221026 2021-01-27 00:44:03 -0800 Use SFTranscription instead of SFTranscriptionSegment for SpeechRecognitionAlternative 2021-01-27 09:40:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu webkit-bug-importer youennf oldest_to_newest 1722851 0 sihui_liu 2021-01-27 00:44:03 -0800 ... 1722856 1 418512 sihui_liu 2021-01-27 00:56:52 -0800 Created attachment 418512 Patch 1722864 2 418512 youennf 2021-01-27 01:10:55 -0800 Comment on attachment 418512 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418512&action=review > Source/WebCore/ChangeLog:8 > + So SpeechRecognitionAlternative contains a sentence instead of a word, which matches Blink's behavior. Does this work well with websites doing word concatenation with space themselves? 1723002 3 sihui_liu 2021-01-27 08:45:46 -0800 (In reply to youenn fablet from comment #2) > Comment on attachment 418512 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418512&action=review > > > Source/WebCore/ChangeLog:8 > > + So SpeechRecognitionAlternative contains a sentence instead of a word, which matches Blink's behavior. > > Does this work well with websites doing word concatenation with space > themselves? Yes, because in this case they just insert spaces between sentences while concatenating them. 1723019 4 ews-feeder 2021-01-27 09:39:28 -0800 Committed r271958: <https://trac.webkit.org/changeset/271958> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418512. 1723021 5 webkit-bug-importer 2021-01-27 09:40:15 -0800 <rdar://problem/73665700> 418512 2021-01-27 00:56:52 -0800 2021-01-27 09:39:29 -0800 Patch bug-221026-20210127005651.patch text/plain 5149 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxOTM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI3NDQ5MjUwYmEwZTEx MWE5MmZjZTNjMmViYTA0MWEyOTlmMDEzMC4uYTU2MGI2NzYzYmZlMjAyNjQ3ZGRlOWExMjNkYTFk MDE2NjBkMjBlMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAxLTI3ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwZS5jb20+CisKKyAgICAgICAgVXNlIFNGVHJhbnNjcmlwdGlv biBpbnN0ZWFkIG9mIFNGVHJhbnNjcmlwdGlvblNlZ21lbnQgZm9yIFNwZWVjaFJlY29nbml0aW9u QWx0ZXJuYXRpdmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyMTAyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNvIFNwZWVjaFJlY29nbml0aW9uQWx0ZXJuYXRpdmUgY29udGFpbnMgYSBzZW50ZW5jZSBp bnN0ZWFkIG9mIGEgd29yZCwgd2hpY2ggbWF0Y2hlcyBCbGluaydzIGJlaGF2aW9yLgorCisgICAg ICAgIE1hbnVhbGx5IHRlc3RlZCBpbiBNaW5pQnJvd3Nlci4KKworICAgICAgICAqIE1vZHVsZXMv c3BlZWNoL2NvY29hL1dlYlNwZWVjaFJlY29nbml6ZXJUYXNrLm1tOgorICAgICAgICAoLVtXZWJT cGVlY2hSZWNvZ25pemVyVGFza0ltcGwgY2FsbGJhY2tXaXRoVHJhbnNjcmlwdGlvbnM6aXNGaW5h bDpdKToKKyAgICAgICAgKC1bV2ViU3BlZWNoUmVjb2duaXplclRhc2tJbXBsIHNwZWVjaFJlY29n bml0aW9uVGFzazpkaWRIeXBvdGhlc2l6ZVRyYW5zY3JpcHRpb246XSk6CisgICAgICAgICgtW1dl YlNwZWVjaFJlY29nbml6ZXJUYXNrSW1wbCBzcGVlY2hSZWNvZ25pdGlvblRhc2s6ZGlkRmluaXNo UmVjb2duaXRpb246XSk6CisgICAgICAgICgtW1dlYlNwZWVjaFJlY29nbml6ZXJUYXNrSW1wbCBj YWxsYmFja1dpdGhSZXN1bHQ6aXNGaW5hbDpdKTogRGVsZXRlZC4KKwogMjAyMS0wMS0yNiAgU2lo dWkgTGl1ICA8c2lodWlfbGl1QGFwcGUuY29tPgogCiAgICAgICAgIE11dGUgYXVkaW8gY2FwdHVy ZSBmb3Igc3BlZWNoIHJlY29nbml0aW9uIGJhc2VkIG9uIHNob3VsZEludGVycnVwdEF1ZGlvT25Q YWdlVmlzaWJpbGl0eUNoYW5nZSB3aGVuIHBhZ2UgaXMgaW52aXNpYmxlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3NwZWVjaC9jb2NvYS9XZWJTcGVlY2hSZWNvZ25pemVyVGFz ay5tbSBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL2NvY29hL1dlYlNwZWVjaFJlY29n bml6ZXJUYXNrLm1tCmluZGV4IDUwMjUwNzc3YmI1MDRiZTIxZTJkOTMxMTBmYjM5MWMxMzNiMDg0 NjMuLmYxYjk2OTU4MDU3ZDJmZTYwNDRkMmM3YjI1OWRiNmM1Y2ViNDRlZmUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL2NvY29hL1dlYlNwZWVjaFJlY29nbml6ZXJU YXNrLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvc3BlZWNoL2NvY29hL1dlYlNwZWVj aFJlY29nbml6ZXJUYXNrLm1tCkBAIC01Niw3ICs1Niw3IEBAIE5TX0FTU1VNRV9OT05OVUxMX0JF R0lOCiB9CiAKIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aElkZW50aWZpZXI6KFNwZWVjaFJlY29n bml0aW9uQ29ubmVjdGlvbkNsaWVudElkZW50aWZpZXIpaWRlbnRpZmllciBsb2NhbGU6KE5TU3Ry aW5nKilsb2NhbGVJZGVudGlmaWVyIGRvTXVsdGlwbGVSZWNvZ25pdGlvbnM6KEJPT0wpY29udGlu dW91cyByZXBvcnRJbnRlcmltUmVzdWx0czooQk9PTClpbnRlcmltUmVzdWx0cyBtYXhBbHRlcm5h dGl2ZXM6KHVuc2lnbmVkIGxvbmcpYWx0ZXJuYXRpdmVzIGRlbGVnYXRlQ2FsbGJhY2s6KHZvaWQo XikoY29uc3QgU3BlZWNoUmVjb2duaXRpb25VcGRhdGUmKSljYWxsYmFjazsKLS0gKHZvaWQpY2Fs bGJhY2tXaXRoUmVzdWx0OihTRlRyYW5zY3JpcHRpb24gKil0cmFuc2NyaXB0aW9uIGlzRmluYWw6 KEJPT0wpaXNGaW5hbDsKKy0gKHZvaWQpY2FsbGJhY2tXaXRoVHJhbnNjcmlwdGlvbnM6KE5TQXJy YXk8U0ZUcmFuc2NyaXB0aW9uICo+ICopdHJhbnNjcmlwdGlvbnMgaXNGaW5hbDooQk9PTClpc0Zp bmFsOwogLSAodm9pZClhdWRpb1NhbXBsZXNBdmFpbGFibGU6KENNU2FtcGxlQnVmZmVyUmVmKXNh bXBsZUJ1ZmZlcjsKIC0gKHZvaWQpYWJvcnQ7CiAtICh2b2lkKXN0b3A7CkBAIC0xMTMsMjQgKzEx MywyMyBAQCBOU19BU1NVTUVfTk9OTlVMTF9CRUdJTgogICAgIHJldHVybiBzZWxmOwogfQogCi0t ICh2b2lkKWNhbGxiYWNrV2l0aFJlc3VsdDooU0ZUcmFuc2NyaXB0aW9uICopdHJhbnNjcmlwdGlv biBpc0ZpbmFsOihCT09MKWlzRmluYWwKKy0gKHZvaWQpY2FsbGJhY2tXaXRoVHJhbnNjcmlwdGlv bnM6KE5TQXJyYXk8U0ZUcmFuc2NyaXB0aW9uICo+ICopdHJhbnNjcmlwdGlvbnMgaXNGaW5hbDoo Qk9PTClpc0ZpbmFsCiB7Ci0gICAgYXV0byBzZWdtZW50cyA9IFt0cmFuc2NyaXB0aW9uIHNlZ21l bnRzXTsKLSAgICBWZWN0b3I8U3BlZWNoUmVjb2duaXRpb25SZXN1bHREYXRhPiBkYXRhczsKLSAg ICBkYXRhcy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KHNlZ21lbnRzLmNvdW50KTsKLSAgICBmb3Ig KFNGVHJhbnNjcmlwdGlvblNlZ21lbnQqIHNlZ21lbnQgaW4gc2VnbWVudHMpIHsKLSAgICAgICAg Ly8gTm90ZSBzZWdtZW50IGNvbmZpZGVuY2UgaXMgcmVwb3J0ZWQgMCB3aGVuIHJlc3VsdCBpcyBu b3QgZmluYWwuCi0gICAgICAgIFZlY3RvcjxTcGVlY2hSZWNvZ25pdGlvbkFsdGVybmF0aXZlRGF0 YT4gYWx0ZXJuYXRpdmVzOwotICAgICAgICBhbHRlcm5hdGl2ZXMucmVzZXJ2ZUluaXRpYWxDYXBh Y2l0eShfbWF4QWx0ZXJuYXRpdmVzKTsKLSAgICAgICAgYWx0ZXJuYXRpdmVzLnVuY2hlY2tlZEFw cGVuZChTcGVlY2hSZWNvZ25pdGlvbkFsdGVybmF0aXZlRGF0YSB7IFtzZWdtZW50IHN1YnN0cmlu Z10sIFtzZWdtZW50IGNvbmZpZGVuY2VdIH0pOwotICAgICAgICBmb3IgKE5TU3RyaW5nKiBzZWdt ZW50QWx0ZXJuYXRpdmUgOiBbc2VnbWVudCBhbHRlcm5hdGl2ZVN1YnN0cmluZ3NdKSB7Ci0gICAg ICAgICAgICBpZiAoYWx0ZXJuYXRpdmVzLnNpemUoKSA9PSBfbWF4QWx0ZXJuYXRpdmVzKQotICAg ICAgICAgICAgICAgIGJyZWFrOwotICAgICAgICAgICAgLy8gRklYTUU6IGNhbGN1bGF0ZSBvciBn ZXQgYWx0ZXJuYXRpdmUgY29uZmlkZW5jZSBpZiBwb3NzaWJsZS4KLSAgICAgICAgICAgIGFsdGVy bmF0aXZlcy51bmNoZWNrZWRBcHBlbmQoU3BlZWNoUmVjb2duaXRpb25BbHRlcm5hdGl2ZURhdGEg eyBzZWdtZW50QWx0ZXJuYXRpdmUsIDAuMCB9KTsKKyAgICBWZWN0b3I8U3BlZWNoUmVjb2duaXRp b25BbHRlcm5hdGl2ZURhdGE+IGFsdGVybmF0aXZlczsKKyAgICBhbHRlcm5hdGl2ZXMucmVzZXJ2 ZUluaXRpYWxDYXBhY2l0eShfbWF4QWx0ZXJuYXRpdmVzKTsKKyAgICBmb3IgKFNGVHJhbnNjcmlw dGlvbiogdHJhbnNjcmlwdGlvbiBpbiB0cmFuc2NyaXB0aW9ucykgeworICAgICAgICAvLyBGSVhN RTogPHJkYXI6Ly83MzYyOTU3Mz4gZ2V0IGNvbmZpZGVuY2Ugb2YgU0ZUcmFuc2NyaXB0aW9uIHdo ZW4gcG9zc2libGUuCisgICAgICAgIGRvdWJsZSBtYXhDb25maWRlbmNlID0gMC4wOworICAgICAg ICBmb3IgKFNGVHJhbnNjcmlwdGlvblNlZ21lbnQqIHNlZ21lbnQgaW4gW3RyYW5zY3JpcHRpb24g c2VnbWVudHNdKSB7CisgICAgICAgICAgICBkb3VibGUgY29uZmlkZW5jZSA9IFtzZWdtZW50IGNv bmZpZGVuY2VdOworICAgICAgICAgICAgbWF4Q29uZmlkZW5jZSA9IG1heENvbmZpZGVuY2UgPCBj b25maWRlbmNlID8gY29uZmlkZW5jZSA6IG1heENvbmZpZGVuY2U7CiAgICAgICAgIH0KLSAgICAg ICAgZGF0YXMudW5jaGVja2VkQXBwZW5kKFNwZWVjaFJlY29nbml0aW9uUmVzdWx0RGF0YSB7IFdU Rk1vdmUoYWx0ZXJuYXRpdmVzKSwgYm9vbChpc0ZpbmFsKSB9KTsKKyAgICAgICAgYWx0ZXJuYXRp dmVzLnVuY2hlY2tlZEFwcGVuZChTcGVlY2hSZWNvZ25pdGlvbkFsdGVybmF0aXZlRGF0YSB7IFt0 cmFuc2NyaXB0aW9uIGZvcm1hdHRlZFN0cmluZ10sIG1heENvbmZpZGVuY2UgfSk7CisgICAgICAg IGlmIChhbHRlcm5hdGl2ZXMuc2l6ZSgpID09IF9tYXhBbHRlcm5hdGl2ZXMpCisgICAgICAgICAg ICBicmVhazsKICAgICB9CisgICAgVmVjdG9yPFNwZWVjaFJlY29nbml0aW9uUmVzdWx0RGF0YT4g ZGF0YXM7CisgICAgZGF0YXMuYXBwZW5kKFNwZWVjaFJlY29nbml0aW9uUmVzdWx0RGF0YSB7IFdU Rk1vdmUoYWx0ZXJuYXRpdmVzKSwgYm9vbChpc0ZpbmFsKSB9KTsKICAgICBfZGVsZWdhdGVDYWxs YmFjayhTcGVlY2hSZWNvZ25pdGlvblVwZGF0ZTo6Y3JlYXRlUmVzdWx0KF9pZGVudGlmaWVyLCBX VEZNb3ZlKGRhdGFzKSkpOwogfQogCkBAIC0yMTksMTQgKzIxOCwxMyBAQCBOU19BU1NVTUVfTk9O TlVMTF9CRUdJTgogICAgIEFTU0VSVChpc01haW5UaHJlYWQoKSk7CiAKICAgICBbc2VsZiBzZW5k U3BlZWNoU3RhcnRJZk5lZWRlZF07Ci0gICAgW3NlbGYgY2FsbGJhY2tXaXRoUmVzdWx0OnRyYW5z Y3JpcHRpb24gaXNGaW5hbDpOT107CisgICAgW3NlbGYgY2FsbGJhY2tXaXRoVHJhbnNjcmlwdGlv bnM6W05TQXJyYXkgYXJyYXlXaXRoT2JqZWN0czp0cmFuc2NyaXB0aW9uLCBuaWxdIGlzRmluYWw6 Tk9dOwogfQogCiAtICh2b2lkKXNwZWVjaFJlY29nbml0aW9uVGFzazooU0ZTcGVlY2hSZWNvZ25p dGlvblRhc2sgKil0YXNrIGRpZEZpbmlzaFJlY29nbml0aW9uOihTRlNwZWVjaFJlY29nbml0aW9u UmVzdWx0ICopcmVjb2duaXRpb25SZXN1bHQKIHsKICAgICBBU1NFUlQoaXNNYWluVGhyZWFkKCkp OwotCi0gICAgW3NlbGYgY2FsbGJhY2tXaXRoUmVzdWx0OnJlY29nbml0aW9uUmVzdWx0LmJlc3RU cmFuc2NyaXB0aW9uIGlzRmluYWw6WUVTXTsKKyAgICBbc2VsZiBjYWxsYmFja1dpdGhUcmFuc2Ny aXB0aW9uczpyZWNvZ25pdGlvblJlc3VsdC50cmFuc2NyaXB0aW9ucyBpc0ZpbmFsOllFU107CiAK ICAgICBpZiAoIV9kb011bHRpcGxlUmVjb2duaXRpb25zKSB7CiAgICAgICAgIFtzZWxmIHNlbmRT cGVlY2hFbmRJZk5lZWRlZF07Cg==