220994 2021-01-26 10:58:04 -0800 [LFC][IFC] Do not create empty runs for empty lines 2021-01-26 18:43:15 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1722600 0 zalan 2021-01-26 10:58:04 -0800 e.g. <div><span></span><span></span></div> we should not create 2 empty inline box runs for the empty <span>s 1722612 1 418452 zalan 2021-01-26 11:28:01 -0800 Created attachment 418452 Patch 1722804 2 ews-feeder 2021-01-26 18:42:25 -0800 Committed r271931: <https://trac.webkit.org/changeset/271931> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418452. 1722805 3 webkit-bug-importer 2021-01-26 18:43:15 -0800 <rdar://problem/73643174> 418452 2021-01-26 11:28:01 -0800 2021-01-26 18:42:25 -0800 Patch bug-220994-20210126112800.patch text/plain 6361 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxODgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODRiZjRkYWE2NWYwN2E5 NDcyOTgzZDEzODBjMjcxZTU1MDlhNGQ5OS4uZjA1MTQzYWU3NTRiZjIzZTA1MjEwZTZlNGUzZjg0 OTEyYTE4NjE3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIxLTAxLTI2ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBEbyBub3Qg Y3JlYXRlIGVtcHR5IHJ1bnMgZm9yIGVtcHR5IGxpbmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA5OTQKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgYSBmYXN0IHBhdGggZm9yIGNhc2VzIHdoZW4g dGhlIGxpbmUgaGFzIHNvbWUgaW5saW5lIGxldmVsIGJveGVzIGJ1dCB3ZSBkb24ndCBjb25zaWRl ciB0aGVtICJjb250ZW50ZnVsIi4KKyAgICAgICAgZS5nLiA8ZGl2PjxzcGFuPjwvc3Bhbj48c3Bh bj48L3NwYW4+PC9kaXY+CisgICAgICAgIEl0IGlzIGEgcmVsYXRpdmVseSBjb21tb24gd2hlbiBi bG9jayBsZXZlbCBib3hlcyBhcmUgd3JhcHBlZCBpbnNpZGUgaW5saW5lIGxldmVsIGJveGVzIGFu ZAorICAgICAgICB3ZSBlbmQgdXAgY29uc3RydWN0aW5nICJlbXB0eSIgcHJlL3Bvc3QgYmxvY2tz IChzZWUgY29udGludWF0aW9uKSBlLmcuIDxzcGFuPjxkaXY+Y29udGVudDwvZGl2Pjwvc3Bhbj4u CisgICAgICAgIFN1Y2ggY29udGVudCBnZW5lcmF0ZXMgImVtcHR5IiBsaW5lcyBhbmQgd2hpbGUg dGhpcyBpcyBjbGVhcmx5IGEgcGVyZm9ybWFuY2UgaW1wcm92ZW1lbnQsIGl0IGlzCisgICAgICAg IGFsc28gYSBjb3JyZWN0bmVzcyBmaXggYXMgUmVuZGVyQmxvY2tGbG93IGNoZWNrcyBmb3IgdGhl IG51bWJlciBvZiBsaW5lcyB0byBzZWUgaWYgdGhlIGJsb2NrIGlzIGVtcHR5IGFuZAorICAgICAg ICB0aGUgaW50ZWdyYXRpb24gbGF5ZXIgY2hlY2tzIHRoZSBudW1iZXIgb2YgcnVucyBvbiB0aGUg bGluZSB0byBkZWNpZGUgaWYgdGhlIGxpbmUgaXMgImVtcHR5IiAoc2VlIExpbmVMYXlvdXQ6Omxp bmVDb3VudCkuCisgICAgICAgIChJbiBMRkMgd2UgY2hlY2sgaWYgdGhlIGxpbmVzIGFyZSBlbXB0 eSBhbmQgbm90IGlmIHRoZSBsaW5lIGNvdW50IGlzIDAgc2luY2UgYWNjb3JkaW5nIHRvIHRoZSBz cGVjIGV2ZW4gImVtcHR5IiBjb250ZW50IGdlbmVyYXRlcyAoZW1wdHkpbGluZXMpCisKKyAgICAg ICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0Ojpjb21w dXRlR2VvbWV0cnlGb3JMaW5lQ29udGVudCk6CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1h dHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpMYXlvdXQ6OkxpbmVCb3hCdWlsZGVyOjpjb25zdHJ1Y3RJbmxpbmVMZXZlbEJveGVzKToK KyAgICAgICAgKiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94Lmg6CisgICAg ICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3g6Omhhc0NvbnRlbnQgY29uc3QpOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQm94OjpzZXRIYXNDb250ZW50KToKKwogMjAyMS0wMS0y NiAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0lGQ10g SW5jb3JyZWN0IGlubGluZSBib3ggd2lkdGggd2l0aCBob3Jpem9udGFsIGFsaWdubWVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ0NvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRp bmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHQuY3BwCmluZGV4IDllZmU5MmIyN2ZiOGRkZTM0NWQy NDJlMjBiM2JhY2I1YTYyMTMyNmUuLjFmZGQ2ZTc4NDJmMjgxNjBlN2IxMzFhY2IxN2ZmYzQ5OTcy NTRhYzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5n L0lubGluZUZvcm1hdHRpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQv aW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dC5jcHAKQEAgLTQ0OCw2ICs0 NDgsMjggQEAgSW5saW5lUmVjdCBJbmxpbmVGb3JtYXR0aW5nQ29udGV4dDo6Y29tcHV0ZUdlb21l dHJ5Rm9yTGluZUNvbnRlbnQoY29uc3QgTGluZUJ1aWwKICAgICBjb25zdCBhdXRvJiBsaW5lQm94 ID0gZm9ybWF0dGluZ1N0YXRlLmxpbmVCb3hlcygpLmxhc3QoKTsKICAgICBhdXRvIGxpbmVJbmRl eCA9IGZvcm1hdHRpbmdTdGF0ZS5saW5lcygpLnNpemUoKTsKICAgICBhdXRvJiBsaW5lQm94TG9n aWNhbFJlY3QgPSBsaW5lQm94LmxvZ2ljYWxSZWN0KCk7CisgICAgaWYgKCFsaW5lQm94Lmhhc0Nv bnRlbnQoKSkgeworICAgICAgICAvLyBGYXN0IHBhdGggZm9yIGxpbmVzIHdpdGggbm8gY29udGVu dCBlLmcuIDxkaXY+PHNwYW4+PC9zcGFuPjxzcGFuPjwvc3Bhbj48L2Rpdj4gb3IgPHNwYW4+PGRp dj48L2Rpdj48L3NwYW4+IHdoZXJlIHdlIGNvbnN0cnVjdCBlbXB0eSBwcmUgYW5kIHBvc3QgYmxv Y2tzLgorICAgICAgICBBU1NFUlQoIWxpbmVDb250ZW50LmNvbnRlbnRMb2dpY2FsV2lkdGgpOwor ICAgICAgICBBU1NFUlQoIWxpbmVCb3hMb2dpY2FsUmVjdC53aWR0aCgpICYmICFsaW5lQm94TG9n aWNhbFJlY3QuaGVpZ2h0KCkpOworICAgICAgICBpZiAobGluZUJveC5oYXNJbmxpbmVCb3goKSkg eworICAgICAgICAgICAgZm9yIChhdXRvJiBpbmxpbmVMZXZlbEJveCA6IGxpbmVCb3gubm9uUm9v dElubGluZUxldmVsQm94ZXMoKSkgeworICAgICAgICAgICAgICAgIGlmICghaW5saW5lTGV2ZWxC b3gtPmlzSW5saW5lQm94KCkpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVlOworICAgICAg ICAgICAgICAgIGF1dG8mIGxheW91dEJveCA9IGlubGluZUxldmVsQm94LT5sYXlvdXRCb3goKTsK KyAgICAgICAgICAgICAgICBhdXRvJiBib3hHZW9tZXRyeSA9IGZvcm1hdHRpbmdTdGF0ZS5ib3hH ZW9tZXRyeShsYXlvdXRCb3gpOworICAgICAgICAgICAgICAgIGF1dG8gaW5saW5lQm94TWFyZ2lu UmVjdCA9IGxpbmVCb3gubG9naWNhbE1hcmdpblJlY3RGb3JJbmxpbmVMZXZlbEJveChsYXlvdXRC b3gsIGJveEdlb21ldHJ5KTsKKyAgICAgICAgICAgICAgICBib3hHZW9tZXRyeS5zZXRDb250ZW50 Qm94SGVpZ2h0KExheW91dFVuaXQ6OmZyb21GbG9hdENlaWwoaW5saW5lQm94TWFyZ2luUmVjdC5o ZWlnaHQoKSkpOworICAgICAgICAgICAgICAgIEFTU0VSVCghaW5saW5lQm94TWFyZ2luUmVjdC53 aWR0aCgpKTsKKyAgICAgICAgICAgICAgICBib3hHZW9tZXRyeS5zZXRDb250ZW50Qm94V2lkdGgo eyB9KTsKKworICAgICAgICAgICAgICAgIGJveEdlb21ldHJ5LnNldExvZ2ljYWxUb3BMZWZ0KHsg fSk7CisgICAgICAgICAgICB9CisgICAgICAgIH0KKyAgICAgICAgZm9ybWF0dGluZ1N0YXRlLmFk ZExpbmUoeyBsaW5lQm94TG9naWNhbFJlY3QsIHsgeyB9LCB7IH0gfSwgeyB9LCB7IH0sIHsgfSB9 KTsKKyAgICAgICAgcmV0dXJuIGxpbmVCb3hMb2dpY2FsUmVjdDsKKyAgICB9CisKICAgICBhdXRv IHJvb3RJbmxpbmVCb3hMb2dpY2FsUmVjdCA9IGxpbmVCb3gubG9naWNhbFJlY3RGb3JSb290SW5s aW5lQm94KCk7CiAgICAgYXV0byBlbmNsb3NpbmdUb3BBbmRCb3R0b20gPSBJbmxpbmVMaW5lR2Vv bWV0cnk6OkVuY2xvc2luZ1RvcEFuZEJvdHRvbSB7IGxpbmVCb3hMb2dpY2FsUmVjdC50b3AoKSAr IHJvb3RJbmxpbmVCb3hMb2dpY2FsUmVjdC50b3AoKSwgbGluZUJveExvZ2ljYWxSZWN0LnRvcCgp ICsgcm9vdElubGluZUJveExvZ2ljYWxSZWN0LmJvdHRvbSgpIH07CiAgICAgSGFzaFNldDxjb25z dCBCb3gqPiBpbmxpbmVCb3hTdGFydFNldDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xh eW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3Bw IGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGlu Z0NvbnRleHRHZW9tZXRyeS5jcHAKaW5kZXggYmNmNDE5ZWUxZGUxOTUzN2E4MTVhZjI3Y2I1ODQ0 NmMzZTJmYjcxYi4uMTg2MmU5YWRmZWRhMmRmZjU4ZDkyM2FhNmMyZTIxYjM0MTE3NzhhMSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9y bWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAKQEAgLTM2 OSw2ICszNjksNyBAQCB2b2lkIExpbmVCb3hCdWlsZGVyOjpjb25zdHJ1Y3RJbmxpbmVMZXZlbEJv eGVzKExpbmVCb3gmIGxpbmVCb3gsIGNvbnN0IExpbmU6OlJ1bgogICAgICAgICBBU1NFUlRfTk9U X1JFQUNIRUQoKTsKICAgICB9CiAKKyAgICBsaW5lQm94LnNldEhhc0NvbnRlbnQobGluZUhhc0Nv bnRlbnQpOwogICAgIGlmICghbV9pbmxpbmVMZXZlbEJveGVzTmVlZFZlcnRpY2FsQWxpZ25tZW50 KSB7CiAgICAgICAgIGlmICghbGluZUhhc0NvbnRlbnQpIHsKICAgICAgICAgICAgIHNpbXBsaWZp ZWRWZXJ0aWNhbEFsaWdubWVudC5yb290SW5saW5lQm94VG9wID0gLXJvb3RJbmxpbmVCb3guYmFz ZWxpbmUoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUxpbmVCb3guaCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUxpbmVCb3guaAppbmRleCAxNTZiOTZjMjRmYjE0MWNhZTI1ZTQ2N2JkMjE2M2I3 NjJiMzZkOTYyLi41MmQ3YTMzZWFkN2Y4OTg1ZTgyNmNmMDgxMjA2MDE2Mjg0NzgwMGNkIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5l Qm94LmgKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5l TGluZUJveC5oCkBAIC0xMzksNiArMTM5LDkgQEAgcHVibGljOgogICAgIElubGluZUxheW91dFNp emUgbG9naWNhbFNpemUoKSBjb25zdCB7IHJldHVybiBsb2dpY2FsUmVjdCgpLnNpemUoKTsgfQog CiAgICAgT3B0aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4gaG9yaXpvbnRhbEFsaWdubWVudE9mZnNl dCgpIGNvbnN0IHsgcmV0dXJuIG1faG9yaXpvbnRhbEFsaWdubWVudE9mZnNldDsgfQorCisgICAg Ly8gTm90ZSB0aGF0IHRoZSBsaW5lIGNhbiBoYXZlIG1hbnkgaW5saW5lIGJveGVzIGFuZCBiZSAi ZW1wdHkiIHRoZSBzYW1lIHRpbWUgZS5nLiA8ZGl2PjxzcGFuPjwvc3Bhbj48c3Bhbj48L3NwYW4+ PC9kaXY+CisgICAgYm9vbCBoYXNDb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV9oYXNDb250ZW50 OyB9CiAgICAgYm9vbCBoYXNJbmxpbmVCb3goKSBjb25zdCB7IHJldHVybiBtX2JveFR5cGVzLmNv bnRhaW5zKElubGluZUxldmVsQm94OjpUeXBlOjpJbmxpbmVCb3gpOyB9CiAgICAgYm9vbCBoYXNO b25JbmxpbmVCb3goKSBjb25zdCB7IHJldHVybiBtX2JveFR5cGVzLmNvbnRhaW5zQW55KHsgSW5s aW5lTGV2ZWxCb3g6OlR5cGU6OkF0b21pY0lubGluZUxldmVsQm94LCBJbmxpbmVMZXZlbEJveDo6 VHlwZTo6TGluZUJyZWFrQm94LCBJbmxpbmVMZXZlbEJveDo6VHlwZTo6R2VuZXJpY0lubGluZUxl dmVsQm94IH0pOyB9CiAKQEAgLTE2Nyw4ICsxNzAsMTEgQEAgcHJpdmF0ZToKIAogICAgIElubGlu ZUxldmVsQm94JiBpbmxpbmVMZXZlbEJveEZvckxheW91dEJveChjb25zdCBCb3gmIGxheW91dEJv eCkgeyByZXR1cm4gKm1faW5saW5lTGV2ZWxCb3hSZWN0TWFwLmdldCgmbGF5b3V0Qm94KTsgfQog CisgICAgdm9pZCBzZXRIYXNDb250ZW50KGJvb2wgaGFzQ29udGVudCkgeyBtX2hhc0NvbnRlbnQg PSBoYXNDb250ZW50OyB9CisKIHByaXZhdGU6CiAgICAgSW5saW5lUmVjdCBtX2xvZ2ljYWxSZWN0 OworICAgIGJvb2wgbV9oYXNDb250ZW50IHsgZmFsc2UgfTsKICAgICBPcHRpb25hbDxJbmxpbmVM YXlvdXRVbml0PiBtX2hvcml6b250YWxBbGlnbm1lbnRPZmZzZXQ7CiAgICAgT3B0aW9uU2V0PElu bGluZUxldmVsQm94OjpUeXBlPiBtX2JveFR5cGVzOwogCg==