220993 2021-01-26 10:57:19 -0800 REGRESSION(r270637) Filtering does not work in Styles sidebar panel 2021-01-26 17:12:07 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rcaliman webkit-unassigned bburg ews-watchlist hi inspector-bugzilla-changes nvasilyev webkit-bug-importer oldest_to_newest 1722598 0 rcaliman 2021-01-26 10:57:19 -0800 Regressed by https://bugs.webkit.org/show_bug.cgi?id=218964 Steps to reproduce: - Go to https://webkit.org - Open WebInspector and select an element - Switch to Styles sidebar panel - Type a CSS property value into the Filter input at the bottom of the styles Expected: - The styles list is filtered by the term Actual: - No change in the styles list 1722599 1 webkit-bug-importer 2021-01-26 10:57:28 -0800 <rdar://problem/73623818> 1722602 2 nvasilyev 2021-01-26 11:03:51 -0800 [Error] TypeError: super.filterDidChange is not a function. (In 'super.filterDidChange(filterBar)', 'super.filterDidChange' is undefined) filterDidChange (SpreadsheetRulesStyleDetailsPanel.js:323) _filterDidChange (GeneralStyleDetailsSidebarPanel.js:431) dispatch (Object.js:130) dispatchEventToListeners (Object.js:138) _handleFilterChanged (FilterBar.js:198) _handleFilterChanged 1722603 3 418448 rcaliman 2021-01-26 11:12:38 -0800 Created attachment 418448 Patch 1722606 4 418448 hi 2021-01-26 11:18:54 -0800 Comment on attachment 418448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review r=me with a recommended alternative > Source/WebInspectorUI/ChangeLog:9 > + Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel. I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`. `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it. 1722628 5 418454 rcaliman 2021-01-26 11:46:24 -0800 Created attachment 418454 Patch 1722629 6 418448 rcaliman 2021-01-26 11:46:54 -0800 Comment on attachment 418448 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review >> Source/WebInspectorUI/ChangeLog:9 >> + Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel. > > I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`. `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it. Sounds good. Done! 1722639 7 418454 hi 2021-01-26 11:50:52 -0800 Comment on attachment 418454 Patch r=me 1722781 8 bburg 2021-01-26 16:55:51 -0800 Setting cq+ 1722784 9 ews-feeder 2021-01-26 17:12:06 -0800 Committed r271927: <https://trac.webkit.org/changeset/271927> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418454. 418448 2021-01-26 11:12:38 -0800 2021-01-26 11:46:19 -0800 Patch bug-220993-20210126201237.patch text/plain 1561 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU2NDQ5OTA0M2E2OTk2OTdmMjY1NjRiYTk1OWRk NmJjOTg1YmU4N2MuLmI0Mjg0NDg4NjQ4YTJmODkzMTcxMmU0NWMyMmNmMDZlM2JiMTU4MzggMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAxLTI2ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy NzA2MzcpIEZpbHRlcmluZyBkb2VzIG5vdCB3b3JrIGluIFN0eWxlcyBzaWRlYmFyIHBhbmVsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA5OTMKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzczNjIzODE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJldmVydGluZyByZW1vdmFsIG9mIGFic3RyYWN0IG1l dGhvZCB1c2VkIGJ5IFNwcmVhZHNoZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbC4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU3R5bGVEZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChX SS5TdHlsZURldGFpbHNQYW5lbC5wcm90b3R5cGUuZmlsdGVyRGlkQ2hhbmdlKToKKwogMjAyMS0w MS0yNSAgTmlraXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiBBZGQgZXhwZXJpbWVudGFsIHNldHRpbmcgdG8gc2hvdyBMYXlvdXQgcGFu ZWwgaW4gRWxlbWVudHMgdGFiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9TdHlsZURldGFpbHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWlsc1BhbmVsLmpzCmluZGV4IDRmZjdm ZmQ3MDQ2OTA2OGMxOWMwZjlhNjI1OGEzYjA1YWEwMWM5YTUuLjkyZDA3NmYzNWNlNTFlN2RlNDE2 NTM4ZDVlNmQyN2YxZWM1MTQ2NDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWlsc1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC0x MTIsNiArMTEyLDExIEBAIFdJLlN0eWxlRGV0YWlsc1BhbmVsID0gY2xhc3MgU3R5bGVEZXRhaWxz UGFuZWwgZXh0ZW5kcyBXSS5WaWV3CiAgICAgICAgICAgICB0aGlzLl9yZWZyZXNoUHJlc2Vydmlu Z1Njcm9sbFBvc2l0aW9uKGV2ZW50LmRhdGEuc2lnbmlmaWNhbnRDaGFuZ2UpOwogICAgIH0KIAor ICAgIGZpbHRlckRpZENoYW5nZShmaWx0ZXJCYXIpCisgICAgeworICAgICAgICAvLyBJbXBsZW1l bnRlZCBieSBzdWJjbGFzc2VzLgorICAgIH0KKwogICAgIC8vIFByaXZhdGUKIAogICAgIGdldCBf aW5pdGlhbFNjcm9sbE9mZnNldCgpCg== 418454 2021-01-26 11:46:24 -0800 2021-01-26 17:12:07 -0800 Patch bug-220993-20210126204623.patch text/plain 2440 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU2NDQ5OTA0M2E2OTk2OTdmMjY1NjRiYTk1OWRk NmJjOTg1YmU4N2MuLjBmNWQ3NWUzYjU0NzYyMThiNjIwZjNhMzljMjI0MTliOTZmZDkwZGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTI2ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIy NzA2MzcpIEZpbHRlcmluZyBkb2VzIG5vdCB3b3JrIGluIFN0eWxlcyBzaWRlYmFyIHBhbmVsCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA5OTMKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzczNjIzODE4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFN0b3AgZXhwZWN0aW5nIFN0eWxlRGV0YWlsc1BhbmVs IHRvIGRlZmluZSBhbiBhYnN0cmFjdCBmaWx0ZXJEaWRDaGFuZ2UoKSBtZXRob2QuCisgICAgICAg IFN1YmNsYXNzZXMgaW1wbGVtZW50IHRoZWlyIG93biBvbiBhIHBlci11c2UgY2FzZSBiYXNpcy4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURldGFpbHNQYW5l bC5qczoKKyAgICAgICAgKFdJLkNvbXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwucHJvdG90eXBlLmZp bHRlckRpZENoYW5nZSk6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVl dFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChXSS5TcHJlYWRzaGVldFJ1bGVz U3R5bGVEZXRhaWxzUGFuZWwucHJvdG90eXBlLmZpbHRlckRpZENoYW5nZSk6CisKIDIwMjEtMDEt MjUgIE5pa2l0YSBWYXNpbHlldiAgPG52YXNpbHlldkBhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogQWRkIGV4cGVyaW1lbnRhbCBzZXR0aW5nIHRvIHNob3cgTGF5b3V0IHBhbmVs IGluIEVsZW1lbnRzIHRhYgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURldGFpbHNQYW5lbC5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvbXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwu anMKaW5kZXggYTQyZjRmNmQxZGY2MTkzNmRmN2Q1M2Y0ODIzZjgwN2Q2MzFkNjEwZS4uOTQ4ODAz ZDM0OTU2ODBiNTdkYjU3NmUzNmQ4YmNjMWIwMWQ0MWFjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29tcHV0ZWRTdHlsZURldGFpbHNQYW5l bC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db21w dXRlZFN0eWxlRGV0YWlsc1BhbmVsLmpzCkBAIC0xNDksOCArMTQ5LDYgQEAgV0kuQ29tcHV0ZWRT dHlsZURldGFpbHNQYW5lbCA9IGNsYXNzIENvbXB1dGVkU3R5bGVEZXRhaWxzUGFuZWwgZXh0ZW5k cyBXSS5TdHlsZUQKIAogICAgIGZpbHRlckRpZENoYW5nZShmaWx0ZXJCYXIpCiAgICAgewotICAg ICAgICBzdXBlci5maWx0ZXJEaWRDaGFuZ2UoZmlsdGVyQmFyKTsKLQogICAgICAgICB0aGlzLmFw cGx5RmlsdGVyKGZpbHRlckJhci5maWx0ZXJzLnRleHQpOwogICAgIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3ByZWFkc2hlZXRSdWxl c1N0eWxlRGV0YWlsc1BhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU3ByZWFkc2hlZXRSdWxlc1N0eWxlRGV0YWlsc1BhbmVsLmpzCmluZGV4IDJlNDA3 ODIxODM3YTE4NmY4ZjkzMmM5NzYxZjYzYzgxMjBkNTg3MWIuLjc5OTU0OTdiMjc5NWU2ZjEwZmVl NTE4MWJjYzE0ZmJjZTJjOTY4OTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NwcmVhZHNoZWV0UnVsZXNTdHlsZURldGFpbHNQYW5lbC5qcwor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TcHJlYWRzaGVl dFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwuanMKQEAgLTMyMCw4ICszMjAsNiBAQCBXSS5TcHJlYWRz aGVldFJ1bGVzU3R5bGVEZXRhaWxzUGFuZWwgPSBjbGFzcyBTcHJlYWRzaGVldFJ1bGVzU3R5bGVE ZXRhaWxzUGFuZWwgZQogCiAgICAgZmlsdGVyRGlkQ2hhbmdlKGZpbHRlckJhcikKICAgICB7Ci0g ICAgICAgIHN1cGVyLmZpbHRlckRpZENoYW5nZShmaWx0ZXJCYXIpOwotCiAgICAgICAgIHRoaXMu YXBwbHlGaWx0ZXIoZmlsdGVyQmFyLmZpbHRlcnMudGV4dCk7CiAgICAgfQogCg==