22099 2008-11-06 05:10:07 -0800 Make the Qt port build the JSC shell in the correct place 2008-11-06 10:43:46 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 galpeter webkit-unassigned oldest_to_newest 97796 0 galpeter 2008-11-06 05:10:07 -0800 After moving the jsc.pro file in rev 38155 not all includes was modified to follow the changes. Part of it was fixed in rev 38163, but for example: the jsc binary ended up in the 'WebKitBuild/Release/' directory instead of the 'WebKitBuild/Release/JavaScriptCore/'. I think this will break JavaScriptCore tests, because jsc binary is not in the correct folder. 97797 1 24940 galpeter 2008-11-06 05:10:50 -0800 Created attachment 24940 proposed patch for fixing jsc.pro includes 97801 2 24941 galpeter 2008-11-06 05:33:47 -0800 Created attachment 24941 fixed proposed patch Previous patch had a little typo. Sorry for that. 97815 3 24941 zwarich 2008-11-06 09:25:01 -0800 Comment on attachment 24941 fixed proposed patch This looks good to me, but doublecheck that it builds 'jsc' and runs tests correctly in a clean build. The bot is still running the tests fine, presumedly because it is using the old executable. 97825 4 galpeter 2008-11-06 09:43:57 -0800 After a clean build I started the tests and the sunspider, both was good. 97834 5 zwarich 2008-11-06 10:34:07 -0800 Okay, I'll land it. 97838 6 zwarich 2008-11-06 10:43:46 -0800 Landed in r38185. 24940 2008-11-06 05:10:50 -0800 2008-11-06 05:33:47 -0800 proposed patch for fixing jsc.pro includes build-include.patch text/plain 1494 galpeter SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4MTY1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMTEtMDYgIFBldGVyIEdh bCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGp1c3QgaW5jbHVkZSBwYXRocyBhbmQgYnVpbGQgZGVz dGluYXRpb24gZGlyLgorCisgICAgICAgICoganNjLnBybzoKKwogMjAwOC0xMS0wNiAgU2ltb24g SGF1c21hbm4gIDxoYXVzbWFubkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0aGUgUXQgYnVp bGQsIGFkanVzdCBpbmNsdWRlIHBhdGhzIGFmdGVyIG1vdmUgb2YganNjLnByby4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL2pzYy5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvanNjLnBy bwkocmV2aXNpb24gMzgxNjUpCisrKyBKYXZhU2NyaXB0Q29yZS9qc2MucHJvCSh3b3JraW5nIGNv cHkpCkBAIC0xLDE0ICsxLDE0IEBACiBURU1QTEFURSA9IGFwcAogVEFSR0VUID0ganNjCi1ERVNU RElSID0gLi4KK0RFU1RESVIgPSAuCiBTT1VSQ0VTID0ganNjLmNwcAogUVQgLT0gZ3VpCi1JTkNM VURFUEFUSCArPSAkJFBXRC8uLiBcCi0gICAgJCRQV0QgXAotICAgICQkUFdELy4uL2JpbmRpbmdz IFwKLSAgICAkJFBXRC8uLi9iaW5kaW5ncy9jIFwKLSAgICAkJFBXRC8uLi93dGYgXAotICAgICQk UFdELy4uL1ZNCitJTkNMVURFUEFUSCArPSAkJFBXRCBcCisgICAgJCRQV0Qva2pzIFwKKyAgICAk JFBXRC9iaW5kaW5ncyBcCisgICAgJCRQV0QvYmluZGluZ3MvYyBcCisgICAgJCRQV0Qvd3RmIFwK KyAgICAkJFBXRC9WTQogQ09ORklHIC09IGFwcF9idW5kbGUKIERFRklORVMgKz0gQlVJTERJTkdf UVRfXwogQ09ORklHICs9IGJ1aWxkaW5nLWxpYnMKQEAgLTE3LDEzICsxNywxMyBAQCBDT05GSUco cmVsZWFzZSkgewogICAgIERFRklORVMgKz0gTkRFQlVHIFVTRV9TWVNURU1fTUFMTE9DCiB9CiAK LWluY2x1ZGUoJCRQV0QvLi4vV2ViS2l0LnByaSkKK2luY2x1ZGUoJCRQV0QvV2ViS2l0LnByaSkK IAogQ09ORklHICs9IGxpbmtfcGtnY29uZmlnCiAKIFFNQUtFX1JQQVRIRElSICs9ICQkT1VUUFVU X0RJUi9saWIKIAotaXNFbXB0eShPVVRQVVRfRElSKTpPVVRQVVRfRElSPSQkUFdELy4uLy4uCitp c0VtcHR5KE9VVFBVVF9ESVIpOk9VVFBVVF9ESVI9JCRQV0QvLi4KIGluY2x1ZGUoJCRPVVRQVVRf RElSL2NvbmZpZy5wcmkpCiBPQkpFQ1RTX0RJUiA9IHRtcAogT0JKRUNUU19ESVJfV1RSID0gJCRP QkpFQ1RTX0RJUi8K 24941 2008-11-06 05:33:47 -0800 2008-11-06 09:25:01 -0800 fixed proposed patch build-include-2.patch text/plain 1368 galpeter SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4MTY1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDgtMTEtMDYgIFBldGVyIEdh bCAgPGdhbHBldGVyQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGp1c3QgaW5jbHVkZSBwYXRocyBhbmQgYnVpbGQgZGVz dGluYXRpb24gZGlyLgorCisgICAgICAgICoganNjLnBybzoKKwogMjAwOC0xMS0wNiAgU2ltb24g SGF1c21hbm4gIDxoYXVzbWFubkB3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCB0aGUgUXQgYnVp bGQsIGFkanVzdCBpbmNsdWRlIHBhdGhzIGFmdGVyIG1vdmUgb2YganNjLnByby4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL2pzYy5wcm8KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvanNjLnBy bwkocmV2aXNpb24gMzgxNjUpCisrKyBKYXZhU2NyaXB0Q29yZS9qc2MucHJvCSh3b3JraW5nIGNv cHkpCkBAIC0xLDE0ICsxLDE0IEBACiBURU1QTEFURSA9IGFwcAogVEFSR0VUID0ganNjCi1ERVNU RElSID0gLi4KK0RFU1RESVIgPSAuCiBTT1VSQ0VTID0ganNjLmNwcAogUVQgLT0gZ3VpCi1JTkNM VURFUEFUSCArPSAkJFBXRC8uLiBcCi0gICAgJCRQV0QgXAotICAgICQkUFdELy4uL2JpbmRpbmdz IFwKLSAgICAkJFBXRC8uLi9iaW5kaW5ncy9jIFwKLSAgICAkJFBXRC8uLi93dGYgXAotICAgICQk UFdELy4uL1ZNCitJTkNMVURFUEFUSCArPSAkJFBXRCBcCisgICAgJCRQV0Qva2pzIFwKKyAgICAk JFBXRC9iaW5kaW5ncyBcCisgICAgJCRQV0QvYmluZGluZ3MvYyBcCisgICAgJCRQV0Qvd3RmIFwK KyAgICAkJFBXRC9WTQogQ09ORklHIC09IGFwcF9idW5kbGUKIERFRklORVMgKz0gQlVJTERJTkdf UVRfXwogQ09ORklHICs9IGJ1aWxkaW5nLWxpYnMKQEAgLTIzLDcgKzIzLDcgQEAgQ09ORklHICs9 IGxpbmtfcGtnY29uZmlnCiAKIFFNQUtFX1JQQVRIRElSICs9ICQkT1VUUFVUX0RJUi9saWIKIAot aXNFbXB0eShPVVRQVVRfRElSKTpPVVRQVVRfRElSPSQkUFdELy4uLy4uCitpc0VtcHR5KE9VVFBV VF9ESVIpOk9VVFBVVF9ESVI9JCRQV0QvLi4KIGluY2x1ZGUoJCRPVVRQVVRfRElSL2NvbmZpZy5w cmkpCiBPQkpFQ1RTX0RJUiA9IHRtcAogT0JKRUNUU19ESVJfV1RSID0gJCRPQkpFQ1RTX0RJUi8K