220982 2021-01-26 07:34:51 -0800 Set ruby-indent-level to 4 2021-01-27 04:13:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos webkit-unassigned fujii mark.lam webkit-bug-importer xan.lopez yoshiaki.jitsukawa ysuzuki oldest_to_newest 1722503 0 angelos 2021-01-26 07:34:51 -0800 Set ruby-indent-level to 4 1722504 1 418417 angelos 2021-01-26 07:36:30 -0800 Created attachment 418417 Patch 1722516 2 418422 angelos 2021-01-26 08:15:56 -0800 Created attachment 418422 Patch 1722626 3 fujii 2021-01-26 11:45:20 -0800 What about other languages? Perl and Python? What about an idea adding the following? [*] indent_style = space indent_size = 4 1722870 4 angelos 2021-01-27 01:50:32 -0800 (In reply to Fujii Hironori from comment #3) > What about other languages? Perl and Python? > What about an idea adding the following? > > [*] > indent_style = space > indent_size = 4 Adding a wildcard would make a coding style decision for future languages as well, something I'm not terribly comfortable with. I know the webkit code style guidelines dictate that "The indent size is 4 spaces" but they also have a python section that simply says "For Python use PEP8 style". So I can't assume an indent size of 4 is mandated for every language used in WebKit (as it might reasonably come in conflict with much more established norms in a language community). Also, I'm not aware of the coding style conventions for all the languages as they are currently used in WebKit. If someone who has touched a lot of perl/python files in WebKit feels that's appropriate, we could add them explicitly alongside C++, C and ruby? 1722907 5 ews-feeder 2021-01-27 04:12:34 -0800 Committed r271945: <https://trac.webkit.org/changeset/271945> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418422. 1722908 6 webkit-bug-importer 2021-01-27 04:13:16 -0800 <rdar://problem/73657473> 418417 2021-01-26 07:36:30 -0800 2021-01-26 08:15:03 -0800 Patch bug-220982-20210126153628.patch text/plain 883 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzg4CmRpZmYgLS1naXQgYS8uZGlyLWxvY2Fscy5lbCBi Ly5kaXItbG9jYWxzLmVsCmluZGV4IDNmZTIzNDBjOTYxNGU4OTNmMGRmZWI3MjBmMjM3NzNiYmYx ZWEwNzYuLjg4N2YwNjM3OWFkZjYyYzU5YTdiOWZhNzA2OTg5NmE3MzBjZjdlZGUgMTAwNjQ0Ci0t LSBhLy5kaXItbG9jYWxzLmVsCisrKyBiLy5kaXItbG9jYWxzLmVsCkBAIC0xMSw1ICsxMSw3IEBA CiAgKGphdmEtbW9kZQogICAoaW5kZW50LXRhYnMtbW9kZSAuIG5pbCkKICAgKGMtYmFzaWMtb2Zm c2V0IC4gNCkpCisgKHJ1YnktbW9kZQorICAocnVieS1pbmRlbnQtbGV2ZWwgLiA0KSkKICAoY2hh bmdlLWxvZy1tb2RlCiAgIChpbmRlbnQtdGFicy1tb2RlIC4gbmlsKSkpCmRpZmYgLS1naXQgYS9D aGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggYzc5MjE1YWNkZjI3Yzg3NTQ0Yjc1Njk5NTFjZjY1 ZTY3ZDA3MjVlMy4uZTZmYzE4ZDY4ODc3YTU4NWNkNzliZTQ4YjgzZDEzMjE0MTAwNzMyZiAxMDA2 NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIx LTAxLTI2ICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEuY29tPgorCisg ICAgICAgIFNldCBydWJ5LWluZGVudC1sZXZlbCB0byA0CisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA5ODIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIC5kaXItbG9jYWxzLmVsOgorCiAyMDIxLTAxLTIz ICBYYW4gTG9wZXogIDx4YW5AaWdhbGlhLmNvbT4KIAogICAgICAgICBbSlNDXSBBbGxvdyB0byBi dWlsZCBXZWJBc3NlbWJseSB3aXRob3V0IEIzCg== 418422 2021-01-26 08:15:56 -0800 2021-01-27 04:12:35 -0800 Patch bug-220982-20210126161555.patch text/plain 1352 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzg4CmRpZmYgLS1naXQgYS8uZGlyLWxvY2Fscy5lbCBi Ly5kaXItbG9jYWxzLmVsCmluZGV4IDNmZTIzNDBjOTYxNGU4OTNmMGRmZWI3MjBmMjM3NzNiYmYx ZWEwNzYuLjg4N2YwNjM3OWFkZjYyYzU5YTdiOWZhNzA2OTg5NmE3MzBjZjdlZGUgMTAwNjQ0Ci0t LSBhLy5kaXItbG9jYWxzLmVsCisrKyBiLy5kaXItbG9jYWxzLmVsCkBAIC0xMSw1ICsxMSw3IEBA CiAgKGphdmEtbW9kZQogICAoaW5kZW50LXRhYnMtbW9kZSAuIG5pbCkKICAgKGMtYmFzaWMtb2Zm c2V0IC4gNCkpCisgKHJ1YnktbW9kZQorICAocnVieS1pbmRlbnQtbGV2ZWwgLiA0KSkKICAoY2hh bmdlLWxvZy1tb2RlCiAgIChpbmRlbnQtdGFicy1tb2RlIC4gbmlsKSkpCmRpZmYgLS1naXQgYS8u ZWRpdG9yY29uZmlnIGIvLmVkaXRvcmNvbmZpZwppbmRleCA2MThkM2YxYzQzYjlkNmMxNzU2NDE0 ZTJiYTMzMDI1NmIwNjZiZmNjLi43N2Y1ZGNlZWJkZTE5ZDQ3MjhlN2ZlNDVmYzdhZWFlMzg3ZDll ZjI5IDEwMDY0NAotLS0gYS8uZWRpdG9yY29uZmlnCisrKyBiLy5lZGl0b3Jjb25maWcKQEAgLTEs NiArMSw2IEBACiAjIEVkaXRvciBjb25maWd1cmF0aW9uLCBzZWUgaHR0cDovL2VkaXRvcmNvbmZp Zy5vcmcKIAotWyoue2MsY3BwLGh9XQorWyoue2MsY3BwLGgscmJ9XQogaW5kZW50X3N0eWxlID0g c3BhY2UKIGluZGVudF9zaXplID0gNAogdGFiX3dpZHRoID0gNApkaWZmIC0tZ2l0IGEvQ2hhbmdl TG9nIGIvQ2hhbmdlTG9nCmluZGV4IGM3OTIxNWFjZGYyN2M4NzU0NGI3NTY5OTUxY2Y2NWU2N2Qw NzI1ZTMuLmYwMDVkMDczN2QyY2ExOGU3MDU2N2Q0ZjgyM2FlNjMyNDg5ZDg0ZWUgMTAwNjQ0Ci0t LSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0wMS0y NiAgQW5nZWxvcyBPaWtvbm9tb3BvdWxvcyAgPGFuZ2Vsb3NAaWdhbGlhLmNvbT4KKworICAgICAg ICBTZXQgcnVieS1pbmRlbnQtbGV2ZWwgdG8gNAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWxsIHRoZSBydWJ5IHNvdXJjZSBmaWxlcyBzZWVtIHRvIGRl ZmF1bHQgdG8gNCBhcyB0aGUgaW5kZW50CisgICAgICAgIGxldmVsOyBtYWtlIGl0IG9mZmljaWFs LgorCisgICAgICAgICogLmRpci1sb2NhbHMuZWw6CisgICAgICAgICogLmVkaXRvcmNvbmZpZzoK KwogMjAyMS0wMS0yMyAgWGFuIExvcGV6ICA8eGFuQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pT Q10gQWxsb3cgdG8gYnVpbGQgV2ViQXNzZW1ibHkgd2l0aG91dCBCMwo=