22097 2008-11-05 23:48:09 -0800 Expose MessageEvent constructor on WorkerContext 2008-11-06 21:55:06 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ap ap darin oldest_to_newest 97782 0 ap 2008-11-05 23:48:09 -0800 Since MessageEvent is used in workers, we should expose its constructor. 97783 1 24936 ap 2008-11-05 23:49:37 -0800 Created attachment 24936 proposed patch 97817 2 24936 darin 2008-11-06 09:29:01 -0800 Comment on attachment 24936 proposed patch > +void setJSWorkerContextMessageEvent(ExecState*, JSObject*, JSValue*) > +{ > + ASSERT_NOT_REACHED(); > +} Why this instead of ReadOnly? r=me 97824 3 ap 2008-11-06 09:41:07 -0800 (In reply to comment #2) > > + ASSERT_NOT_REACHED(); > Why this instead of ReadOnly? I don't know - like other setters, I modeled this after what JSDOMWindowBase does - it doesn't make the constructors read-only, but overrides put() to have special behavior for those. I only have a FIXME for this in setJSWorkerContextMessageChannel now: // FIXME: Do we need to override put for global constructors, like JSDOMWindowBase does? 97917 4 ap 2008-11-06 21:55:06 -0800 Committed revision 38212. 24936 2008-11-05 23:49:37 -0800 2008-11-06 09:29:01 -0800 proposed patch MessageEventConstructor.txt text/plain 3210 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODE1MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA5NworICAgICAgICBF eHBvc2UgTWVzc2FnZUV2ZW50IGNvbnN0cnVjdG9yIG9uIFdvcmtlckNvbnRleHQKKworICAgICAg ICAqIGJpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpq c1dvcmtlckNvbnRleHRNZXNzYWdlRXZlbnQpOgorICAgICAgICAoV2ViQ29yZTo6c2V0SlNXb3Jr ZXJDb250ZXh0TWVzc2FnZUV2ZW50KToKKwogMjAwOC0xMS0wNSAgQWxleGV5IFByb3NrdXJ5YWtv diAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dp YWsuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL2pzL0pTV29ya2VyQ29udGV4dC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9qcy9KU1dvcmtlckNvbnRleHQuY3BwCShyZXZpc2lv biAzODE1MCkKKysrIFdlYkNvcmUvYmluZGluZ3MvanMvSlNXb3JrZXJDb250ZXh0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMzIsNiArMzIsNyBAQAogCiAjaW5jbHVkZSAiSlNET01CaW5kaW5nLmgi CiAjaW5jbHVkZSAiSlNNZXNzYWdlQ2hhbm5lbENvbnN0cnVjdG9yLmgiCisjaW5jbHVkZSAiSlNN ZXNzYWdlRXZlbnQuaCIKICNpbmNsdWRlICJKU01lc3NhZ2VQb3J0LmgiCiAjaW5jbHVkZSAiSlNX b3JrZXJMb2NhdGlvbi5oIgogI2luY2x1ZGUgIldvcmtlckNvbnRleHQuaCIKQEAgLTQ1LDYgKzQ2 LDggQEAgSlNWYWx1ZSoganNXb3JrZXJDb250ZXh0TG9jYXRpb24oRXhlY1N0YQogSlNWYWx1ZSog anNXb3JrZXJDb250ZXh0TWVzc2FnZUNoYW5uZWwoRXhlY1N0YXRlKiwgY29uc3QgSWRlbnRpZmll ciYsIGNvbnN0IFByb3BlcnR5U2xvdCYpOwogdm9pZCBzZXRKU1dvcmtlckNvbnRleHRNZXNzYWdl Q2hhbm5lbChFeGVjU3RhdGUqLCBKU09iamVjdCosIEpTVmFsdWUqKTsKIEpTVmFsdWUqIGpzV29y a2VyQ29udGV4dE1lc3NhZ2VQb3J0KEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBjb25z dCBQcm9wZXJ0eVNsb3QmKTsKK3ZvaWQgc2V0SlNXb3JrZXJDb250ZXh0TWVzc2FnZUV2ZW50KEV4 ZWNTdGF0ZSosIEpTT2JqZWN0KiwgSlNWYWx1ZSopOworSlNWYWx1ZSoganNXb3JrZXJDb250ZXh0 TWVzc2FnZUV2ZW50KEV4ZWNTdGF0ZSosIGNvbnN0IElkZW50aWZpZXImLCBjb25zdCBQcm9wZXJ0 eVNsb3QmKTsKIHZvaWQgc2V0SlNXb3JrZXJDb250ZXh0TWVzc2FnZVBvcnQoRXhlY1N0YXRlKiwg SlNPYmplY3QqLCBKU1ZhbHVlKik7CiBKU1ZhbHVlKiBqc1dvcmtlckNvbnRleHRXb3JrZXJMb2Nh dGlvbihFeGVjU3RhdGUqLCBjb25zdCBJZGVudGlmaWVyJiwgY29uc3QgUHJvcGVydHlTbG90Jik7 CiB2b2lkIHNldEpTV29ya2VyQ29udGV4dFdvcmtlckxvY2F0aW9uKEV4ZWNTdGF0ZSosIEpTT2Jq ZWN0KiwgSlNWYWx1ZSopOwpAQCAtNjUsNiArNjgsNyBAQCB2b2lkIHNldEpTV29ya2VyQ29udGV4 dFdvcmtlckxvY2F0aW9uKEV4CiAjICBvbmNvbm5lY3QgICAgICAgICAgICAgICAgICAgICBqc1dv cmtlckNvbnRleHRPbmNvbm5lY3QgICAgICAgICAgIERvbnREZWxldGUKICMgIG9ubWVzc2FnZSBh bmQgb3RoZXIgTWVzc2FnZVBvcnQgYXR0cmlidXRlcz8KICAgTWVzc2FnZUNoYW5uZWwgICAgICAg ICAgICAgICAganNXb3JrZXJDb250ZXh0TWVzc2FnZUNoYW5uZWwgICAgICAgICAgICAgICAgRG9u dERlbGV0ZQorICBNZXNzYWdlRXZlbnQgICAgICAgICAgICAgICAgICBqc1dvcmtlckNvbnRleHRN ZXNzYWdlRXZlbnQgICAgICAgICAgICAgICAgICBEb250RGVsZXRlCiAgIE1lc3NhZ2VQb3J0ICAg ICAgICAgICAgICAgICAgIGpzV29ya2VyQ29udGV4dE1lc3NhZ2VQb3J0ICAgICAgICAgICAgICAg ICAgIERvbnREZWxldGUKICAgV29ya2VyTG9jYXRpb24gICAgICAgICAgICAgICAganNXb3JrZXJD b250ZXh0V29ya2VyTG9jYXRpb24gICAgICAgICAgICAgICAgRG9udERlbGV0ZQogIyAgWE1MSHR0 cFJlcXVlc3QgICAgICAgICAgICAgICAganNXb3JrZXJDb250ZXh0WE1MSHR0cFJlcXVlc3QgICAg ICAgICAgICAgICAgRG9udERlbGV0ZQpAQCAtMTM5LDYgKzE0MywxMSBAQCBKU1ZhbHVlKiBqc1dv cmtlckNvbnRleHRNZXNzYWdlQ2hhbm5lbChFCiAgICAgcmV0dXJuIGdldERPTUNvbnN0cnVjdG9y PEpTTWVzc2FnZUNoYW5uZWxDb25zdHJ1Y3Rvcj4oZXhlYywgc3RhdGljX2Nhc3Q8SlNXb3JrZXJD b250ZXh0Kj4oYXNPYmplY3Qoc2xvdC5zbG90QmFzZSgpKSkpOwogfQogCitKU1ZhbHVlKiBqc1dv cmtlckNvbnRleHRNZXNzYWdlRXZlbnQoRXhlY1N0YXRlKiBleGVjLCBjb25zdCBJZGVudGlmaWVy JiwgY29uc3QgUHJvcGVydHlTbG90JiBzbG90KQoreworICAgIHJldHVybiBKU01lc3NhZ2VFdmVu dDo6Z2V0Q29uc3RydWN0b3IoZXhlYyk7Cit9CisKIEpTVmFsdWUqIGpzV29ya2VyQ29udGV4dE1l c3NhZ2VQb3J0KEV4ZWNTdGF0ZSogZXhlYywgY29uc3QgSWRlbnRpZmllciYsIGNvbnN0IFByb3Bl cnR5U2xvdCYpCiB7CiAgICAgcmV0dXJuIEpTTWVzc2FnZVBvcnQ6OmdldENvbnN0cnVjdG9yKGV4 ZWMpOwpAQCAtMTcyLDYgKzE4MSwxMSBAQCB2b2lkIHNldEpTV29ya2VyQ29udGV4dE1lc3NhZ2VD aGFubmVsKEV4CiAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CiB9CiAKK3ZvaWQgc2V0SlNXb3Jr ZXJDb250ZXh0TWVzc2FnZUV2ZW50KEV4ZWNTdGF0ZSosIEpTT2JqZWN0KiwgSlNWYWx1ZSopCit7 CisgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7Cit9CisKIHZvaWQgc2V0SlNXb3JrZXJDb250ZXh0 TWVzc2FnZVBvcnQoRXhlY1N0YXRlKiwgSlNPYmplY3QqLCBKU1ZhbHVlKikKIHsKICAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsK