220955 2021-01-25 15:22:18 -0800 Crash from CompositeEditCommand::moveParagraphs() using Position instead of VisiblePosition 2021-01-28 02:58:30 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 julian_a_gonzalez webkit-unassigned ews-watchlist mifenton rniwa wenson_hsieh oldest_to_newest 1722315 0 julian_a_gonzalez 2021-01-25 15:22:18 -0800 frame #0: WebCore`WebCore::makeBoundaryPoint(WebCore::VisiblePosition const&)+81 frame #1: WebCore`decltype(makeSimpleRangeHelper(makeBoundaryPointHelper(std::forward<WebCore::VisiblePosition const&>(fp)), makeBoundaryPointHelper(std::forward<WebCore::VisiblePosition&>(fp)))) WebCore::makeSimpleRange<WebCore::VisiblePosition const&, WebCore::VisiblePosition&>(WebCore::VisiblePosition const&, WebCore::VisiblePosition&)+26 frame #2: WebCore`WebCore::CompositeEditCommand::moveParagraphs(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, bool, bool)+403 frame #3: WebCore`WebCore::InsertListCommand::doApplyForSingleParagraph(bool, WebCore::HTMLQualifiedName const&, WebCore::SimpleRange&)+7504 frame #4: WebCore`WebCore::InsertListCommand::doApply()+7534 frame #5: WebCore`WebCore::CompositeEditCommand::applyCommandToComposite(WTF::Ref<WebCore::EditCommand, WTF::DumbPtrTraits<WebCore::EditCommand> >&&)+79 frame #6: WebCore`WebCore::IndentOutdentCommand::outdentParagraph()+690 frame #7: WebCore`WebCore::IndentOutdentCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)+220 frame #8: WebCore`WebCore::ApplyBlockElementCommand::doApply()+1256 frame #9: WebCore`WebCore::CompositeEditCommand::apply()+500 frame #10: WebCore`WebCore::executeOutdent(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)+229 frame #11: WebCore`WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)+77 The call to makeSimpleRange(start, end) requires non-null VisiblePositions - not non-null Positions. Similar to bug 220630 <rdar://problem/70880426> 1722321 1 418346 julian_a_gonzalez 2021-01-25 15:30:02 -0800 Created attachment 418346 Patch 1722360 2 julian_a_gonzalez 2021-01-25 17:48:51 -0800 Test failures here look legitimate (though I can't reproduce them locally). I'll keep working on this. 1722362 3 418346 rniwa 2021-01-25 17:58:25 -0800 Comment on attachment 418346 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418346&action=review > LayoutTests/editing/inserting/paragraph-outdent-animationframe-crash.html:20 > + document.execCommand("selectAll", false); > + window.requestAnimationFrame(dooutdent); I think the test failure comes from this code running after this test had finished running. You need to add testRunner.waitUntilDone where you call dumpAsText, and call testRunner.notifyDone when the test is done running perhaps at the end of dooutdent? Be sure to verify that the crash still reproduces without the fix if you made those changes to the test. 1723222 4 julian_a_gonzalez 2021-01-27 17:13:28 -0800 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 418346 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418346&action=review > > > LayoutTests/editing/inserting/paragraph-outdent-animationframe-crash.html:20 > > + document.execCommand("selectAll", false); > > + window.requestAnimationFrame(dooutdent); > > I think the test failure comes from this code running after this test had > finished running. > You need to add testRunner.waitUntilDone where you call dumpAsText, > and call testRunner.notifyDone when the test is done running perhaps at the > end of dooutdent? > Be sure to verify that the crash still reproduces without the fix if you > made those changes to the test. This ended up being a little more complicated, but Ryosuke figured it out. Thanks to him for cleaning the test up! 1723224 5 418602 julian_a_gonzalez 2021-01-27 17:19:02 -0800 Created attachment 418602 Patch 1723332 6 418602 rniwa 2021-01-28 02:55:21 -0800 Comment on attachment 418602 Patch Looks good. 1723333 7 ews-feeder 2021-01-28 02:58:29 -0800 Committed r272008: <https://trac.webkit.org/changeset/272008> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418602. 418346 2021-01-25 15:30:02 -0800 2021-01-27 17:18:59 -0800 Patch bug-220955-20210125153001.patch text/plain 4904 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc2M2I1OGVjZjk4NjMx NTc5ZWU2MjAxMzMzOTRjMjVkNjcxMWE3Mi4uMDViNWYzYWUzNTFjMmM5ZTZmY2RlYTYxNjQ2MzYw MjYwYjgyMDNiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTI1ICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggZnJvbSBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMoKSB1c2luZyBQb3Np dGlvbiBpbnN0ZWFkIG9mIFZpc2libGVQb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIHN0YXJ0IG9yIGVuZCBWaXNpYmxlUG9zaXRp b25zIGluc2lkZSBJbnNlcnRMaXN0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMoKQorICAgICAgICBh cmUgbnVsbCwgdGhlbiBtYWtlU2ltcGxlUmFuZ2Uoc3RhcnQsIGVuZCkgd2lsbCBub3QgcmV0dXJu IGEgdXNhYmxlIFNpbXBsZVJhbmdlLgorICAgICAgICBCYWlsIG91dCBlYXJseSBpbiB0aGlzIGNh c2UsIHNpbWlsYXIgdG8gYnVnIDIyMDYzMC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2luc2Vy dGluZy9wYXJhZ3JhcGgtb3V0ZGVudC1hbmltYXRpb25mcmFtZS1jcmFzaC5odG1sCisKKyAgICAg ICAgKiBlZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBocyk6CisKIDIwMjEtMDEtMjIgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBGRlRG cmFtZTo6ZmZ0U2V0dXBGb3JTaXplKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21w b3NpdGVFZGl0Q29tbWFuZC5jcHAKaW5kZXggYmU4MjhiMGY4MzcyOWM1OWE1MmNmZTU1YWU4MWE2 YWNjYWI0MzgyNi4uMTUwZjBhOTcwMDQ0ZGUzYjJjNDQxODRiMzNhNjIzMDE5YTFhMmI2NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAg LTE0MTEsOCArMTQxMSwxMSBAQCB2b2lkIENvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdy YXBocyhjb25zdCBWaXNpYmxlUG9zaXRpb24mIHN0YXJ0T2ZQYXJhZ3JhcAogCiAgICAgLy8gV2Ug dXBzdHJlYW0oKSB0aGUgZW5kIGFuZCBkb3duc3RyZWFtKCkgdGhlIHN0YXJ0IHNvIHRoYXQgd2Ug ZG9uJ3QgaW5jbHVkZSBjb2xsYXBzZWQgd2hpdGVzcGFjZSBpbiB0aGUgbW92ZS4KICAgICAvLyBX aGVuIHdlIHBhc3RlIGEgZnJhZ21lbnQsIHNwYWNlcyBhZnRlciB0aGUgZW5kIGFuZCBiZWZvcmUg dGhlIHN0YXJ0IGFyZSB0cmVhdGVkIGFzIHRob3VnaCB0aGV5IHdlcmUgcmVuZGVyZWQuCi0gICAg YXV0byBzdGFydCA9IHN0YXJ0T2ZQYXJhZ3JhcGhUb01vdmUuZGVlcEVxdWl2YWxlbnQoKS5kb3du c3RyZWFtKCk7Ci0gICAgYXV0byBlbmQgPSBlbmRPZlBhcmFncmFwaFRvTW92ZS5kZWVwRXF1aXZh bGVudCgpLnVwc3RyZWFtKCk7CisgICAgVmlzaWJsZVBvc2l0aW9uIHN0YXJ0ID0gc3RhcnRPZlBh cmFncmFwaFRvTW92ZS5kZWVwRXF1aXZhbGVudCgpLmRvd25zdHJlYW0oKTsKKyAgICBWaXNpYmxl UG9zaXRpb24gZW5kID0gZW5kT2ZQYXJhZ3JhcGhUb01vdmUuZGVlcEVxdWl2YWxlbnQoKS51cHN0 cmVhbSgpOworCisgICAgaWYgKHN0YXJ0LmlzTnVsbCgpIHx8IGVuZC5pc051bGwoKSkKKyAgICAg ICAgcmV0dXJuOwogCiAgICAgLy8gRklYTUU6IFNlcmlhbGl6aW5nIGFuZCByZS1wYXJzaW5nIGlz IGFuIGluZWZmaWNpZW50IHdheSB0byBwcmVzZXJ2ZSBzdHlsZS4KICAgICBSZWZQdHI8RG9jdW1l bnRGcmFnbWVudD4gZnJhZ21lbnQ7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGY5MWY2ZTEyNjFmZWZhOTllOGUyYTRmMDNk ZWRmMjJlNzg3ZjI0Yy4uYzdjMjk3Y2E0ZGQyYWVmMzViYmJiYTdmNmRjYmJjYjc4ZDZlNWU5NCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAxLTI1ICBKdWxpYW4gR29uemFsZXogIDxqdWxp YW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggZnJvbSBDb21wb3NpdGVF ZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMoKSB1c2luZyBQb3NpdGlvbiBpbnN0ZWFkIG9mIFZp c2libGVQb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIwOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgdGVzdCB0byB2ZXJpZnkgdGhhdCB0aGUgY3Jhc2ggaGVyZSBpcyByZXNvbHZl ZAorICAgICAgICB1c2luZyByZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKS4KKworICAgICAgICAqIGVk aXRpbmcvaW5zZXJ0aW5nL3BhcmFncmFwaC1vdXRkZW50LWFuaW1hdGlvbmZyYW1lLWNyYXNoLWV4 cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvcGFyYWdyYXBo LW91dGRlbnQtYW5pbWF0aW9uZnJhbWUtY3Jhc2guaHRtbDogQWRkZWQuCisKIDIwMjEtMDEtMjIg IERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IGZpeCBjcmFzaGluZyB0ZXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9wYXJhZ3JhcGgtb3V0ZGVudC1hbmltYXRpb25mcmFtZS1jcmFzaC1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9wYXJhZ3JhcGgtb3V0ZGVudC1hbmltYXRp b25mcmFtZS1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uZDJiMGVhZDlmM2NlYTE4OGJi ODYwODQ0MWRiNTAyMmNjY2ViMzE3YwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Vk aXRpbmcvaW5zZXJ0aW5nL3BhcmFncmFwaC1vdXRkZW50LWFuaW1hdGlvbmZyYW1lLWNyYXNoLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDQgQEAKK1RoaXMgdGVzdHMgdGhhdCB3ZSBkbyBub3QgY3Jh c2ggd2hpbGUgb3V0ZGVudGluZyBwYXJhZ3JhcGhzLiBQQVNTCisKKworCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9wYXJhZ3JhcGgtb3V0ZGVudC1hbmltYXRpb25m cmFtZS1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcGFyYWdyYXBo LW91dGRlbnQtYW5pbWF0aW9uZnJhbWUtY3Jhc2guaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43ZWEwYjQ1ZWM2 MDcwZmNhNzFiYjM3MzQ0ZjJlNzlhOWY4NGQ5MzY5Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcGFyYWdyYXBoLW91dGRlbnQtYW5pbWF0aW9uZnJhbWUt Y3Jhc2guaHRtbApAQCAtMCwwICsxLDM4IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1 bmN0aW9uIHRlc3RvbmxvYWQoKSB7CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJp bmRlbnQiLCBmYWxzZSk7CisgICAgZG9jdW1lbnQuYm9keS5zZXRBdHRyaWJ1dGUoImNvbnRlbnRl ZGl0YWJsZSIsICJ0cnVlIik7CisgICAgaWZyYW1lLmNvbnRlbnRXaW5kb3cub25wYWdlaGlkZSA9 IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImZyYW1lc2V0Iikub25sb2FkOworCisgICAgb2wuYWRk RXZlbnRMaXN0ZW5lcigiRE9NTm9kZUluc2VydGVkIiwgYW5pbWF0aW9uZnJhbWUpOworICAgIHNl bGVjdC5hZGQob3B0Z3JvdXApOworfQorZnVuY3Rpb24gZG9vdXRkZW50KCkgeworICAgIGRvY3Vt ZW50LmV4ZWNDb21tYW5kKCJvdXRkZW50IiwgZmFsc2UpOworfQorZnVuY3Rpb24gYW5pbWF0aW9u ZnJhbWUoKSB7CisgICAgZG9jdW1lbnQuZXhlY0NvbW1hbmQoInNlbGVjdEFsbCIsIGZhbHNlKTsK KyAgICB3aW5kb3cucmVxdWVzdEFuaW1hdGlvbkZyYW1lKGRvb3V0ZGVudCk7Cit9Cis8L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5IG9ubG9hZD10ZXN0b25sb2FkKCk+CisgICAgVGhpcyB0ZXN0cyB0 aGF0IHdlIGRvIG5vdCBjcmFzaCB3aGlsZSBvdXRkZW50aW5nIHBhcmFncmFwaHMuCisgICAgUEFT UworICAgIDxvbCBpZD0ib2wiPgorICAgICAgICA8bGkgcm9sZT0iZ3JvdXAiPgorICAgICAgICAg ICAgPGlmcmFtZSBpZD0iaWZyYW1lIj48L2lmcmFtZT4KKyAgICAgICAgPC9saT4KKyAgICAgICAg PGRhdGEgaWQ9ImRhdGEiPgorICAgICAgICAgICAgPHNlbGVjdCBpZD0ic2VsZWN0Ij4KKyAgICAg ICAgICAgICAgICA8b3B0Z3JvdXAgaWQ9Im9wdGdyb3VwIj48L29wdGdyb3VwPgorICAgICAgICAg ICAgPC9zZWxlY3Q+CisgICAgICAgIDwvZGF0YT4KKyAgICA8L29sPgorPC9ib2R5PgorPC9odG1s Pgo= 418602 2021-01-27 17:19:02 -0800 2021-01-28 02:58:30 -0800 Patch bug-220955-20210127171901.patch text/plain 4633 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTc2M2I1OGVjZjk4NjMx NTc5ZWU2MjAxMzMzOTRjMjVkNjcxMWE3Mi4uYzJlYTYzNDRhODgzOWYzOTc3MjM3MDJkM2YxMmQx Y2MwM2NiNzYyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTI3ICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jh c2ggZnJvbSBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMoKSB1c2luZyBQb3Np dGlvbiBpbnN0ZWFkIG9mIFZpc2libGVQb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgSWYgdGhlIHN0YXJ0IG9yIGVuZCBWaXNpYmxlUG9zaXRp b25zIGluc2lkZSBJbnNlcnRMaXN0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMoKQorICAgICAgICBh cmUgbnVsbCwgdGhlbiBtYWtlU2ltcGxlUmFuZ2Uoc3RhcnQsIGVuZCkgd2lsbCBub3QgcmV0dXJu IGEgdXNhYmxlIFNpbXBsZVJhbmdlLgorICAgICAgICBCYWlsIG91dCBlYXJseSBpbiB0aGlzIGNh c2UsIHNpbWlsYXIgdG8gYnVnIDIyMDYzMC4KKworICAgICAgICBUZXN0OiBlZGl0aW5nL2luc2Vy dGluZy9wYXJhZ3JhcGgtb3V0ZGVudC1hbmltYXRpb25mcmFtZS1jcmFzaC5odG1sCisKKyAgICAg ICAgKiBlZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkNvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdyYXBocyk6CisKIDIwMjEtMDEtMjIgIENo cmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDcmFzaCB1bmRlciBGRlRG cmFtZTo6ZmZ0U2V0dXBGb3JTaXplKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2VkaXRp bmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21w b3NpdGVFZGl0Q29tbWFuZC5jcHAKaW5kZXggYmU4MjhiMGY4MzcyOWM1OWE1MmNmZTU1YWU4MWE2 YWNjYWI0MzgyNi4uMTUwZjBhOTcwMDQ0ZGUzYjJjNDQxODRiMzNhNjIzMDE5YTFhMmI2NiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAKQEAg LTE0MTEsOCArMTQxMSwxMSBAQCB2b2lkIENvbXBvc2l0ZUVkaXRDb21tYW5kOjptb3ZlUGFyYWdy YXBocyhjb25zdCBWaXNpYmxlUG9zaXRpb24mIHN0YXJ0T2ZQYXJhZ3JhcAogCiAgICAgLy8gV2Ug dXBzdHJlYW0oKSB0aGUgZW5kIGFuZCBkb3duc3RyZWFtKCkgdGhlIHN0YXJ0IHNvIHRoYXQgd2Ug ZG9uJ3QgaW5jbHVkZSBjb2xsYXBzZWQgd2hpdGVzcGFjZSBpbiB0aGUgbW92ZS4KICAgICAvLyBX aGVuIHdlIHBhc3RlIGEgZnJhZ21lbnQsIHNwYWNlcyBhZnRlciB0aGUgZW5kIGFuZCBiZWZvcmUg dGhlIHN0YXJ0IGFyZSB0cmVhdGVkIGFzIHRob3VnaCB0aGV5IHdlcmUgcmVuZGVyZWQuCi0gICAg YXV0byBzdGFydCA9IHN0YXJ0T2ZQYXJhZ3JhcGhUb01vdmUuZGVlcEVxdWl2YWxlbnQoKS5kb3du c3RyZWFtKCk7Ci0gICAgYXV0byBlbmQgPSBlbmRPZlBhcmFncmFwaFRvTW92ZS5kZWVwRXF1aXZh bGVudCgpLnVwc3RyZWFtKCk7CisgICAgVmlzaWJsZVBvc2l0aW9uIHN0YXJ0ID0gc3RhcnRPZlBh cmFncmFwaFRvTW92ZS5kZWVwRXF1aXZhbGVudCgpLmRvd25zdHJlYW0oKTsKKyAgICBWaXNpYmxl UG9zaXRpb24gZW5kID0gZW5kT2ZQYXJhZ3JhcGhUb01vdmUuZGVlcEVxdWl2YWxlbnQoKS51cHN0 cmVhbSgpOworCisgICAgaWYgKHN0YXJ0LmlzTnVsbCgpIHx8IGVuZC5pc051bGwoKSkKKyAgICAg ICAgcmV0dXJuOwogCiAgICAgLy8gRklYTUU6IFNlcmlhbGl6aW5nIGFuZCByZS1wYXJzaW5nIGlz IGFuIGluZWZmaWNpZW50IHdheSB0byBwcmVzZXJ2ZSBzdHlsZS4KICAgICBSZWZQdHI8RG9jdW1l bnRGcmFnbWVudD4gZnJhZ21lbnQ7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZGY5MWY2ZTEyNjFmZWZhOTllOGUyYTRmMDNk ZWRmMjJlNzg3ZjI0Yy4uNGY4YzdjODcyNTQ5MzBiNTg1ODc3MjBmNDMxNGI0YTZjMTI4ZmI3MCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTI3ICBKdWxpYW4gR29uemFsZXogIDxqdWxp YW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgQ3Jhc2ggZnJvbSBDb21wb3NpdGVF ZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMoKSB1c2luZyBQb3NpdGlvbiBpbnN0ZWFkIG9mIFZp c2libGVQb3NpdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIwOTU1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkIGEgdGVzdCB0byB2ZXJpZnkgdGhhdCB0aGUgY3Jhc2ggaGVyZSBpcyByZXNvbHZl ZAorICAgICAgICB1c2luZyByZXF1ZXN0QW5pbWF0aW9uRnJhbWUoKS4gVGhhbmtzIHRvIFJ5b3N1 a2UgTml3YQorICAgICAgICBmb3IgY2xlYW5pbmcgdGhpcyB1cCBhbmQgbWFraW5nIGl0IHJlbGlh YmxlLgorCisgICAgICAgICogZWRpdGluZy9pbnNlcnRpbmcvcGFyYWdyYXBoLW91dGRlbnQtYW5p bWF0aW9uZnJhbWUtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5n L2luc2VydGluZy9wYXJhZ3JhcGgtb3V0ZGVudC1hbmltYXRpb25mcmFtZS1jcmFzaC5odG1sOiBB ZGRlZC4KKwogMjAyMS0wMS0yMiAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBsZS5jb20+CiAK ICAgICAgICAgVW5yZXZpZXdlZCwgZml4IGNyYXNoaW5nIHRlc3QKZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3BhcmFncmFwaC1vdXRkZW50LWFuaW1hdGlvbmZyYW1l LWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL3BhcmFn cmFwaC1vdXRkZW50LWFuaW1hdGlvbmZyYW1lLWNyYXNoLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li4wOTRjOTNjZTM5ZGFhOTJkODRmZmRmOGQwMTBjZDNkNDQ1ZDQwZTkxCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcGFyYWdyYXBoLW91dGRlbnQtYW5p bWF0aW9uZnJhbWUtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMyBAQAorVGhpcyB0ZXN0 cyB0aGF0IHdlIGRvIG5vdCBjcmFzaCB3aGlsZSBvdXRkZW50aW5nIHBhcmFncmFwaHMuIFBBU1MK KworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2VydGluZy9wYXJhZ3JhcGgt b3V0ZGVudC1hbmltYXRpb25mcmFtZS1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9p bnNlcnRpbmcvcGFyYWdyYXBoLW91dGRlbnQtYW5pbWF0aW9uZnJhbWUtY3Jhc2guaHRtbApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi44MWY1N2MwZWZmYjAxOGJkZDdjOTI3MjkxOGIxYzJhNTU1ZmZiMWVkCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvcGFyYWdyYXBoLW91dGRl bnQtYW5pbWF0aW9uZnJhbWUtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI2IEBACis8IURPQ1RZUEUg aHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0PgorZnVuY3Rpb24gcnVuVGVzdCgpIHsKKyAg ICBpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgp OworICAgIGlmcmFtZS5jb250ZW50V2luZG93Lm9ucGFnZWhpZGUgPSAoKSA9PiB7CisgICAgICAg IGRvY3VtZW50LmV4ZWNDb21tYW5kKCJpbmRlbnQiLCBmYWxzZSk7CisgICAgICAgIGRvY3VtZW50 LmV4ZWNDb21tYW5kKCJzZWxlY3RBbGwiLCBmYWxzZSk7CisgICAgfTsKKyAgICBkb2N1bWVudC5l eGVjQ29tbWFuZCgic2VsZWN0QWxsIiwgZmFsc2UpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5k KCJvdXRkZW50IiwgZmFsc2UpOworfQorPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9 InJ1blRlc3QoKSIgY29udGVudGVkaXRhYmxlPgorICAgIFRoaXMgdGVzdHMgdGhhdCB3ZSBkbyBu b3QgY3Jhc2ggd2hpbGUgb3V0ZGVudGluZyBwYXJhZ3JhcGhzLgorICAgIFBBU1MKKyAgICA8b2w+ CisgICAgICAgIDxsaT4KKyAgICAgICAgICAgIDxpZnJhbWUgaWQ9ImlmcmFtZSI+PC9pZnJhbWU+ CisgICAgICAgIDwvbGk+CisgICAgPC9vbD4KKzwvYm9keT4KKzwvaHRtbD4KXCBObyBuZXdsaW5l IGF0IGVuZCBvZiBmaWxlCg==