220953 2021-01-25 15:20:26 -0800 Changes to commit-log-editor should trigger webkitpy EWS tests 2021-01-25 16:51:00 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220950 InRadar P2 Normal --- 1 ryanhaddad ryanhaddad aakash_jain darin jbedard webkit-bug-importer oldest_to_newest 1722309 0 ryanhaddad 2021-01-25 15:20:26 -0800 Since checkout_unittest.py includes tests that rely on commit-log-editor, we should ensure that changes to that commit-log-editor trigger webkitpy test runs in EWS. 1722317 1 webkit-bug-importer 2021-01-25 15:23:54 -0800 <rdar://problem/73590954> 1722323 2 418348 ryanhaddad 2021-01-25 15:31:13 -0800 Created attachment 418348 Patch 1722330 3 418352 aakash_jain 2021-01-25 15:34:26 -0800 Created attachment 418352 Patch 1722334 4 418352 darin 2021-01-25 15:38:42 -0800 Comment on attachment 418352 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418352&action=review > Tools/CISupport/ews-build/steps_unittest.py:2423 > + file_names = ['Tools/Scripts/webkitpy', 'Tools/Scripts/libraries', 'Tools/Script/commit-log-editor'] This won’t work because it says "Script" instead of "Scripts". 1722338 5 418353 aakash_jain 2021-01-25 15:41:34 -0800 Created attachment 418353 Patch 1722339 6 aakash_jain 2021-01-25 15:42:01 -0800 (In reply to Darin Adler from comment #4) > This won’t work because it says "Script" instead of "Scripts". Good catch. Fixed in updated patch. 1722349 7 ews-feeder 2021-01-25 16:50:59 -0800 Committed r271869: <https://trac.webkit.org/changeset/271869> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418353. 418348 2021-01-25 15:31:13 -0800 2021-01-25 15:34:23 -0800 Patch bug-220953-20210125153112.patch text/plain 1306 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxODY1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjAwYTYxNzdiZDQ5ZjM2YzgzNjZjNjk1MTE1NTMyYzVi ZjViNGFmNC4uNTI4YzI0ZDk0YzlkNzJlMTVkYTIyZmM5MjZhMjUzOTc1ZjJjMGRkZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTAxLTI1ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisg ICAgICAgIENoYW5nZXMgdG8gY29tbWl0LWxvZy1lZGl0b3Igc2hvdWxkIHRyaWdnZXIgd2Via2l0 cHkgRVdTIHRlc3RzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjA5NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBTaW5jZSBjaGVja291dF91bml0dGVzdC5weSBpbmNsdWRlcyB0ZXN0cyB0aGF0IHJlbHkg b24gY29tbWl0LWxvZy1lZGl0b3IsIHdlIHNob3VsZCBlbnN1cmUgdGhhdAorICAgICAgICBjaGFu Z2VzIHRvIHRoYXQgY29tbWl0LWxvZy1lZGl0b3IgdHJpZ2dlciB3ZWJraXRweSB0ZXN0IHJ1bnMg aW4gRVdTLgorCisgICAgICAgICogQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weToKKyAgICAg ICAgKENoZWNrUGF0Y2hSZWxldmFuY2UpOiAKKwogMjAyMS0wMS0yNSAgUnlhbiBIYWRkYWQgIDxy eWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3 MTgwNS4KZGlmZiAtLWdpdCBhL1Rvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkgYi9U b29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CmluZGV4IGQwYWYwZTRiZGEwZWYzNjg3 NWUxMDU3NmI2ZmRjNzFhYzczNmM3NDguLjg5YWJmYjZlZDhjNDYxNjMwZmMyMjAzMjhiMGYzZjc2 NzhkNzNhZDQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkK KysrIGIvVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQpAQCAtMzcyLDYgKzM3Miw3 IEBAIGNsYXNzIENoZWNrUGF0Y2hSZWxldmFuY2UoYnVpbGRzdGVwLkJ1aWxkU3RlcCk6CiAgICAg ICAgICdUb29scy8nLAogICAgIF0KICAgICB3ZWJraXRweV9wYXRocyA9IFsKKyAgICAgICAgJ1Rv b2xzL1NjcmlwdHMvY29tbWl0LWxvZy1lZGl0b3InCiAgICAgICAgICdUb29scy9TY3JpcHRzL3dl YmtpdHB5JywKICAgICAgICAgJ1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzJywKICAgICBdCg== 418352 2021-01-25 15:34:26 -0800 2021-01-25 15:41:30 -0800 Patch bug-220953-20210125183424.patch text/plain 2932 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MTg2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAxLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBDaGFuZ2VzIHRvIGNvbW1pdC1sb2ctZWRpdG9yIHNob3VsZCB0cmlnZ2Vy IHdlYmtpdHB5IEVXUyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIwOTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ2hl Y2tQYXRjaFJlbGV2YW5jZSk6IEFkZGVkIGNvbW1pdC1sb2ctZWRpdG9yIHRvIGxpc3Qgb2YgcmVs ZXZhbnQgZmlsZXMgZm9yIHdlYmtpdHB5IGV3cy4KKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBJbXByb3ZlZCB1bml0LXRlc3QgdG8gY2hlY2sgZm9yIHZh cmlvdXMgZmlsZS1uYW1lcy4KKwogMjAyMS0wMS0yNSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFk QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3MTgwNS4KSW5k ZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjcxODY2KQorKysgVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMzc0LDYg KzM3NCw3IEBAIGNsYXNzIENoZWNrUGF0Y2hSZWxldmFuY2UoYnVpbGRzdGVwLkJ1aWwKICAgICB3 ZWJraXRweV9wYXRocyA9IFsKICAgICAgICAgJ1Rvb2xzL1NjcmlwdHMvd2Via2l0cHknLAogICAg ICAgICAnVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMnLAorICAgICAgICAnVG9vbHMvU2NyaXB0L2Nv bW1pdC1sb2ctZWRpdG9yJywKICAgICBdCiAKICAgICBncm91cF90b19wYXRoc19tYXBwaW5nID0g ewpJbmRleDogVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CShy ZXZpc2lvbiAyNzE4NjYpCisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0 ZXN0LnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yNDIwLDE4ICsyNDIwLDE0IEBAIGNsYXNzIFRlc3RD aGVja1BhdGNoUmVsZXZhbmNlKEJ1aWxkU3RlcE0KICAgICAgICAgcmV0dXJuIHNlbGYucnVuU3Rl cCgpCiAKICAgICBkZWYgdGVzdF9yZWxldmFudF93ZWJraXRweV9wYXRjaChzZWxmKToKLSAgICAg ICAgQ2hlY2tQYXRjaFJlbGV2YW5jZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6ICdTYW1wbGUgcGF0 Y2g7IGZpbGU6IFRvb2xzL1NjcmlwdHMvd2Via2l0cHknCi0gICAgICAgIHNlbGYuc2V0dXBTdGVw KENoZWNrUGF0Y2hSZWxldmFuY2UoKSkKLSAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnYnVpbGRl cm5hbWUnLCAnV2ViS2l0UHktVGVzdHMtRVdTJykKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21l KHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRhaW5zIHJlbGV2YW50IGNo YW5nZXMnKQotICAgICAgICByZXR1cm4gc2VsZi5ydW5TdGVwKCkKLQotICAgIGRlZiB0ZXN0X3Jl bGV2YW50X2xpYnJhcmllc19wYXRjaChzZWxmKToKLSAgICAgICAgQ2hlY2tQYXRjaFJlbGV2YW5j ZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6ICdTYW1wbGUgcGF0Y2g7IGZpbGU6IFRvb2xzL1Njcmlw dHMvbGlicmFyaWVzJwotICAgICAgICBzZWxmLnNldHVwU3RlcChDaGVja1BhdGNoUmVsZXZhbmNl KCkpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxkZXJuYW1lJywgJ1dlYktpdFB5LVRl c3RzLUVXUycpCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3Rh dGVfc3RyaW5nPSdQYXRjaCBjb250YWlucyByZWxldmFudCBjaGFuZ2VzJykKLSAgICAgICAgcmV0 dXJuIHNlbGYucnVuU3RlcCgpCisgICAgICAgIGZpbGVfbmFtZXMgPSBbJ1Rvb2xzL1NjcmlwdHMv d2Via2l0cHknLCAnVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMnLCAnVG9vbHMvU2NyaXB0L2NvbW1p dC1sb2ctZWRpdG9yJ10KKyAgICAgICAgZm9yIGZpbGVfbmFtZSBpbiBmaWxlX25hbWVzOgorICAg ICAgICAgICAgQ2hlY2tQYXRjaFJlbGV2YW5jZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6ICdTYW1w bGUgcGF0Y2g7IGZpbGU6IHt9Jy5mb3JtYXQoZmlsZV9uYW1lKQorICAgICAgICAgICAgc2VsZi5z ZXR1cFN0ZXAoQ2hlY2tQYXRjaFJlbGV2YW5jZSgpKQorICAgICAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgnYnVpbGRlcm5hbWUnLCAnV2ViS2l0UHktVGVzdHMtRVdTJykKKyAgICAgICAgICAgIHNl bGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBjb250 YWlucyByZWxldmFudCBjaGFuZ2VzJykKKyAgICAgICAgICAgIHJjID0gc2VsZi5ydW5TdGVwKCkK KyAgICAgICAgcmV0dXJuIHJjCiAKICAgICBkZWYgdGVzdF9xdWV1ZXNfd2l0aG91dF9yZWxldmFu Y2VfaW5mbyhzZWxmKToKICAgICAgICAgQ2hlY2tQYXRjaFJlbGV2YW5jZS5fZ2V0X3BhdGNoID0g bGFtYmRhIHg6ICdTYW1wbGUgcGF0Y2gnCg== 418353 2021-01-25 15:41:34 -0800 2021-01-25 16:50:59 -0800 Patch bug-220953-20210125184133.patch text/plain 2934 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MTg2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAxLTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBDaGFuZ2VzIHRvIGNvbW1pdC1sb2ctZWRpdG9yIHNob3VsZCB0cmlnZ2Vy IHdlYmtpdHB5IEVXUyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIwOTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ2hl Y2tQYXRjaFJlbGV2YW5jZSk6IEFkZGVkIGNvbW1pdC1sb2ctZWRpdG9yIHRvIGxpc3Qgb2YgcmVs ZXZhbnQgZmlsZXMgZm9yIHdlYmtpdHB5IGV3cy4KKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1 aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OiBJbXByb3ZlZCB1bml0LXRlc3QgdG8gY2hlY2sgZm9yIHZh cmlvdXMgZmlsZS1uYW1lcy4KKwogMjAyMS0wMS0yNSAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFk QGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByZXZlcnRpbmcgcjI3MTgwNS4KSW5k ZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjcxODY2KQorKysgVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtMzc0LDYg KzM3NCw3IEBAIGNsYXNzIENoZWNrUGF0Y2hSZWxldmFuY2UoYnVpbGRzdGVwLkJ1aWwKICAgICB3 ZWJraXRweV9wYXRocyA9IFsKICAgICAgICAgJ1Rvb2xzL1NjcmlwdHMvd2Via2l0cHknLAogICAg ICAgICAnVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMnLAorICAgICAgICAnVG9vbHMvU2NyaXB0cy9j b21taXQtbG9nLWVkaXRvcicsCiAgICAgXQogCiAgICAgZ3JvdXBfdG9fcGF0aHNfbWFwcGluZyA9 IHsKSW5kZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQko cmV2aXNpb24gMjcxODY2KQorKysgVG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0 dGVzdC5weQkod29ya2luZyBjb3B5KQpAQCAtMjQyMCwxOCArMjQyMCwxNCBAQCBjbGFzcyBUZXN0 Q2hlY2tQYXRjaFJlbGV2YW5jZShCdWlsZFN0ZXBNCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0 ZXAoKQogCiAgICAgZGVmIHRlc3RfcmVsZXZhbnRfd2Via2l0cHlfcGF0Y2goc2VsZik6Ci0gICAg ICAgIENoZWNrUGF0Y2hSZWxldmFuY2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBh dGNoOyBmaWxlOiBUb29scy9TY3JpcHRzL3dlYmtpdHB5JwotICAgICAgICBzZWxmLnNldHVwU3Rl cChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCi0gICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1aWxk ZXJuYW1lJywgJ1dlYktpdFB5LVRlc3RzLUVXUycpCi0gICAgICAgIHNlbGYuZXhwZWN0T3V0Y29t ZShyZXN1bHQ9U1VDQ0VTUywgc3RhdGVfc3RyaW5nPSdQYXRjaCBjb250YWlucyByZWxldmFudCBj aGFuZ2VzJykKLSAgICAgICAgcmV0dXJuIHNlbGYucnVuU3RlcCgpCi0KLSAgICBkZWYgdGVzdF9y ZWxldmFudF9saWJyYXJpZXNfcGF0Y2goc2VsZik6Ci0gICAgICAgIENoZWNrUGF0Y2hSZWxldmFu Y2UuX2dldF9wYXRjaCA9IGxhbWJkYSB4OiAnU2FtcGxlIHBhdGNoOyBmaWxlOiBUb29scy9TY3Jp cHRzL2xpYnJhcmllcycKLSAgICAgICAgc2VsZi5zZXR1cFN0ZXAoQ2hlY2tQYXRjaFJlbGV2YW5j ZSgpKQotICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdidWlsZGVybmFtZScsICdXZWJLaXRQeS1U ZXN0cy1FV1MnKQotICAgICAgICBzZWxmLmV4cGVjdE91dGNvbWUocmVzdWx0PVNVQ0NFU1MsIHN0 YXRlX3N0cmluZz0nUGF0Y2ggY29udGFpbnMgcmVsZXZhbnQgY2hhbmdlcycpCi0gICAgICAgIHJl dHVybiBzZWxmLnJ1blN0ZXAoKQorICAgICAgICBmaWxlX25hbWVzID0gWydUb29scy9TY3JpcHRz L3dlYmtpdHB5JywgJ1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzJywgJ1Rvb2xzL1NjcmlwdHMvY29t bWl0LWxvZy1lZGl0b3InXQorICAgICAgICBmb3IgZmlsZV9uYW1lIGluIGZpbGVfbmFtZXM6Cisg ICAgICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0Y2ggPSBsYW1iZGEgeDogJ1Nh bXBsZSBwYXRjaDsgZmlsZToge30nLmZvcm1hdChmaWxlX25hbWUpCisgICAgICAgICAgICBzZWxm LnNldHVwU3RlcChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCisgICAgICAgICAgICBzZWxmLnNldFBy b3BlcnR5KCdidWlsZGVybmFtZScsICdXZWJLaXRQeS1UZXN0cy1FV1MnKQorICAgICAgICAgICAg c2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNv bnRhaW5zIHJlbGV2YW50IGNoYW5nZXMnKQorICAgICAgICAgICAgcmMgPSBzZWxmLnJ1blN0ZXAo KQorICAgICAgICByZXR1cm4gcmMKIAogICAgIGRlZiB0ZXN0X3F1ZXVlc193aXRob3V0X3JlbGV2 YW5jZV9pbmZvKHNlbGYpOgogICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0Y2gg PSBsYW1iZGEgeDogJ1NhbXBsZSBwYXRjaCcK