220950 2021-01-25 14:40:35 -0800 REGRESSION (r271805): 3 webkitpy.common.checkout.checkout_unittest.CommitMessageForThisCommitTest tests failing 2021-01-25 18:52:39 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED CONFIGURATION CHANGED https://bugs.webkit.org/show_bug.cgi?id=220822 https://bugs.webkit.org/show_bug.cgi?id=220953 InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned darin fujii webkit-bug-importer oldest_to_newest 1722292 0 ryanhaddad 2021-01-25 14:40:35 -0800 The following three tests started failing after https://trac.webkit.org/changeset/271805/webkit landed: [170/1960] webkitpy.common.checkout.checkout_unittest.CommitMessageForThisCommitTest.test_commit_message_for_changelogs_with_different_messages failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py", line 281, in test_commit_message_for_changelogs_with_different_messages self.assertMultiLineEqual(commit_message.message(), expected_commit_message) AssertionError: u"SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig [truncated]... != u"SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig [truncated]... SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig <http://webkit.org/b/135006> Patch by David Kilzer <ddkilzer@apple.com> on 2014-07-17 Reviewed by Darin Adler. + Source/WebKitLegacy: - Source/WebKitLegacy: * WebKit.xcodeproj/project.pbxproj: Remove references to unused WebKit.xcconfig file. LayoutTests: + Filler change. * Path/To/Complicated/File: Added. [232/1960] webkitpy.common.checkout.checkout_unittest.CommitMessageForThisCommitTest.test_commit_message_for_changelogs_with_same_messages failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py", line 253, in test_commit_message_for_changelogs_with_same_messages self.assertMultiLineEqual(commit_message.message(), expected_commit_message) AssertionError: u"SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig [truncated]... != u"SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig [truncated]... SECTORDER_FLAGS should be defined in target's xcconfig file, not Base.xcconfig <http://webkit.org/b/135006> Patch by David Kilzer <ddkilzer@apple.com> on 2014-07-17 Reviewed by Darin Adler. + Source/WebKitLegacy: - Source/WebKitLegacy: * WebKit.xcodeproj/project.pbxproj: Remove references to unused WebKit.xcconfig file. LayoutTests: + * Path/To/Complicated/File: Added. [281/1960] webkitpy.common.checkout.checkout_unittest.CommitMessageForThisCommitTest.test_commit_message_for_unreviewed_changelogs_with_different_messages failed: Traceback (most recent call last): File "/Volumes/Data/slave/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/common/checkout/checkout_unittest.py", line 207, in test_commit_message_for_unreviewed_changelogs_with_different_messages self.assertMultiLineEqual(commit_message.message(), expected_commit_message) AssertionError: u'Unreviewed build fix to un-break webkit-patch land.\n\n\nTools:\nMove commit_m [truncated]... != u'Unreviewed build fix to un-break webkit-patch land.\n\nTools:\n\nMove commit_m [truncated]... Unreviewed build fix to un-break webkit-patch land. + Tools: - Tools: Move commit_message_for_this_commit from scm to checkout https://bugs.webkit.org/show_bug.cgi?id=36629 * Scripts/webkitpy/common/checkout/api.py: import scm.CommitMessage LayoutTests: + Second part of this complicated change by me, Fr\xe9d\xe9ric Wang! * Path/To/Complicated/File: Added. 1722294 1 darin 2021-01-25 14:50:24 -0800 Sounds like we should roll out the change and re-land it with test fixes. Why didn’t hose failures show up in EWS? 1722305 2 ryanhaddad 2021-01-25 15:15:43 -0800 Reverted r271805 with https://trac.webkit.org/changeset/271865. 1722306 3 webkit-bug-importer 2021-01-25 15:16:15 -0800 <rdar://problem/73590660> 1722312 4 ryanhaddad 2021-01-25 15:21:03 -0800 (In reply to Darin Adler from comment #1) > Sounds like we should roll out the change and re-land it with test fixes. > Why didn’t hose failures show up in EWS? webkitpy EWS tests only get triggered for changes in specific directories, apparently commit-log-editor is not included. Filed https://bugs.webkit.org/show_bug.cgi?id=220953 1722374 5 fujii 2021-01-25 18:52:39 -0800 I'm sorry for breaking the tests. Thank you very much.