220941 2021-01-25 12:26:16 -0800 [Curl] Enable FTP protocol only when ENABLE_FTPDIR is on 2021-02-01 13:19:06 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 don.olmstead webkit-unassigned annulen ews-watchlist fujii galpeter gyuyoung.kim ryuan.choi sergio webkit-bug-importer oldest_to_newest 1722199 0 don.olmstead 2021-01-25 12:26:16 -0800 ... 1722203 1 418322 don.olmstead 2021-01-25 12:33:49 -0800 Created attachment 418322 Patch 1722667 2 418322 fujii 2021-01-26 12:41:07 -0800 Comment on attachment 418322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review > Source/cmake/OptionsWin.cmake:90 > + WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FTPDIR PRIVATE OFF) Nice. However, this is a breaking change. But, I think no WinCairo users are affected. 1722669 3 418322 fujii 2021-01-26 12:43:39 -0800 Comment on attachment 418322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418322&action=review > Source/WebCore/platform/network/curl/CurlContext.cpp:534 > +#if ENABLE(FTPDIR) All upstream curl ports disable FTDIR now. You can remove this unused code if you want. 1724362 4 webkit-bug-importer 2021-02-01 12:27:14 -0800 <rdar://problem/73840873> 1724384 5 ews-feeder 2021-02-01 13:19:02 -0800 Committed r272171: <https://trac.webkit.org/changeset/272171> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418322. 418322 2021-01-25 12:33:49 -0800 2021-02-01 13:19:04 -0800 Patch bug-220941.diff text/plain 2923 don.olmstead ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjNzkyMTVhY2RmMjcuLjlh OGFlZTlmM2I2MCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTAxLTI1ICBEb24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5j b20+CisKKyAgICAgICAgW0N1cmxdIEVuYWJsZSBGVFAgcHJvdG9jb2wgb25seSB3aGVuIEVOQUJM RV9GVFBESVIgaXMgb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIyMDk0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFR1cm4gb2ZmIEVOQUJMRV9GVFBESVIgZm9yIFdpbkNhaXJvLiBUaGUgdmVyc2lvbiBv ZiBjVVJMIHVzZWQgaGFzIEZUUCBzdXBwb3J0IGV4cGxpY2l0bHkKKyAgICAgICAgZGlzYWJsZWQu CisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZToKKwogMjAyMS0wMS0y MyAgWGFuIExvcGV6ICA8eGFuQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0pTQ10gQWxsb3cgdG8g YnVpbGQgV2ViQXNzZW1ibHkgd2l0aG91dCBCMwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQxNWQ4NGEyYzVjNy4u YTlhNGI1NTA1MDM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDEtMjUgIERv biBPbG1zdGVhZCAgPGRvbi5vbG1zdGVhZEBzb255LmNvbT4KKworICAgICAgICBbQ3VybF0gRW5h YmxlIEZUUCBwcm90b2NvbCBvbmx5IHdoZW4gRU5BQkxFX0ZUUERJUiBpcyBvbgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwOTQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgY1VSTCBzdXBwb3J0cyBhIGxh cmdlIG51bWJlciBvZiBwcm90b2NvbHMgYnV0IG9ubHkgSFRUUChTKSBhbmQgRklMRSBzaG91bGQg YmUgZW5hYmxlZCBieQorICAgICAgICBkZWZhdWx0LiBNYWtlIHRoZSBGVFAoUykgcHJvdG9jb2xz IGRlcGVuZGVudCBvbiB3aGV0aGVyIEVOQUJMRShGVFBESVIpIGlzIGVuYWJsZWQgb3Igbm90Lgor CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkN1cmxIYW5kbGU6OmVuYWJsZUFsbG93ZWRQcm90b2NvbHMpOgorCiAyMDIx LTAxLTI1ICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFBD TTogVXNlIGRpZmZlcmVudCB3ZWxsLWtub3duIGxvY2F0aW9ucyBmb3IgdHJpZ2dlcmluZyBhbmQg cmVwb3J0aW5nIGF0dHJpYnV0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2N1cmwvQ3VybENvbnRleHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL0N1cmxDb250ZXh0LmNwcAppbmRleCA4MjBiN2U3MTk5YWMuLjJmNjU1NmVl MDViMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0N1 cmxDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwv Q3VybENvbnRleHQuY3BwCkBAIC01MzAsNyArNTMwLDExIEBAIHZvaWQgQ3VybEhhbmRsZTo6ZW5h YmxlQWNjZXB0RW5jb2RpbmcoKQogCiB2b2lkIEN1cmxIYW5kbGU6OmVuYWJsZUFsbG93ZWRQcm90 b2NvbHMoKQogewotICAgIHN0YXRpYyBjb25zdCBsb25nIGFsbG93ZWRQcm90b2NvbHMgPSBDVVJM UFJPVE9fRklMRSB8IENVUkxQUk9UT19GVFAgfCBDVVJMUFJPVE9fRlRQUyB8IENVUkxQUk9UT19I VFRQIHwgQ1VSTFBST1RPX0hUVFBTOworICAgIHN0YXRpYyBjb25zdCBsb25nIGFsbG93ZWRQcm90 b2NvbHMgPSBDVVJMUFJPVE9fRklMRSB8CisjaWYgRU5BQkxFKEZUUERJUikKKyAgICAgICAgQ1VS TFBST1RPX0ZUUCB8IENVUkxQUk9UT19GVFBTIHwKKyNlbmRpZgorICAgICAgICBDVVJMUFJPVE9f SFRUUCB8IENVUkxQUk9UT19IVFRQUzsKIAogICAgIGN1cmxfZWFzeV9zZXRvcHQobV9oYW5kbGUs IENVUkxPUFRfUFJPVE9DT0xTLCBhbGxvd2VkUHJvdG9jb2xzKTsKIH0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21h a2UKaW5kZXggOWMwMmRjOWJjZWU2Li5jNGFiNDkzYmIxYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9j bWFrZS9PcHRpb25zV2luLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtl CkBAIC04Niw2ICs4Niw5IEBAIGlmICgke1dURl9QTEFURk9STV9XSU5fQ0FJUk99KQogICAgIFdF QktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJEUklWRVIgUFJJVkFURSAk e0VOQUJMRV9FWFBFUklNRU5UQUxfRkVBVFVSRVN9KQogICAgIFdFQktJVF9PUFRJT05fREVGQVVM VF9QT1JUX1ZBTFVFKEVOQUJMRV9XRUJfQ1JZUFRPIFBSSVZBVEUgJHtFTkFCTEVfRVhQRVJJTUVO VEFMX0ZFQVRVUkVTfSkKIAorICAgICMgTm8gc3VwcG9ydCBwbGFubmVkCisgICAgV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX0ZUUERJUiBQUklWQVRFIE9GRikKKwogICAg ICMgRklYTUU6IEltcGxlbWVudCBwbHVnaW4gcHJvY2VzcyBvbiBNb2Rlcm4gV2ViS2l0LiBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg1MzEzCiAgICAgV0VCS0lUX09Q VElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX05FVFNDQVBFX1BMVUdJTl9BUEkgUFJJVkFU RSBPRkYpCiBlbHNlICgpCg==