220927 2021-01-25 08:44:39 -0800 [macOS] Restrict access to dtracehelper 2022-09-17 17:31:20 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221501 InRadar P2 Normal --- 1 pvollan pvollan bfulgham iseenoface webkit-bug-importer oldest_to_newest 1722082 0 pvollan 2021-01-25 08:44:39 -0800 Only allow access to dtracehelper for internal installs. 1722083 1 pvollan 2021-01-25 08:47:39 -0800 <rdar://70350947> 1722085 2 418297 pvollan 2021-01-25 08:50:24 -0800 Created attachment 418297 Patch 1722166 3 418297 bfulgham 2021-01-25 11:35:04 -0800 Comment on attachment 418297 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418297&action=review r=me > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:89 > (with telemetry-backtrace) Should we remove this, given that telemetry-backtrace is a finite resource and we know this is needed for internal builds? 1722214 4 418324 pvollan 2021-01-25 12:55:03 -0800 Created attachment 418324 Patch 1722215 5 pvollan 2021-01-25 12:55:37 -0800 (In reply to Brent Fulgham from comment #3) > Comment on attachment 418297 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418297&action=review > > r=me > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:89 > > (with telemetry-backtrace) > > Should we remove this, given that telemetry-backtrace is a finite resource > and we know this is needed for internal builds? Fixed, thanks for reviewing! 1722226 6 418328 pvollan 2021-01-25 13:10:28 -0800 Created attachment 418328 Patch 1722268 7 ews-feeder 2021-01-25 14:09:58 -0800 Committed r271815: <https://trac.webkit.org/changeset/271815> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418328. 418297 2021-01-25 08:50:24 -0800 2021-01-25 11:35:04 -0800 Patch bug-220927-20210125085023.patch text/plain 2481 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzE3OTUpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTI1ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gUmVzdHJpY3QgYWNjZXNzIHRv IGR0cmFjZWhlbHBlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIwOTI3CisgICAgICAgIDxyZGFyOi8vNzAzNTA5NDc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBhbGxvdyBhY2Nlc3MgdG8gZHRy YWNlaGVscGVyIGZvciBpbnRlcm5hbCBpbnN0YWxscy4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv Y29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjpp bml0aWFsaXplU2FuZGJveCk6CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJv Y2Vzcy5zYi5pbjoKKwogMjAyMS0wMS0yNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBbaU9TIFdLMl0gdGhldmVyZ2UuY29tIC0gcnViYmVyIGJhbmQg c2Nyb2xsaW5nIGF0IHRoZSB0b3Agb2YgdGhlIHBhZ2UgY2F1c2VzIGFuIGFicnVwdCBqdW1wCklu ZGV4OiBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4K PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9j ZXNzLnNiLmluCShyZXZpc2lvbiAyNzE3OTMpCisrKyBTb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv Y29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4JKHdvcmtpbmcgY29weSkKQEAgLTgxLDEzICs4MSwx NSBAQAogICAgIChsaXRlcmFsICIvZGV2L251bGwiKQogICAgIChsaXRlcmFsICIvZGV2L3plcm8i KSkKIAotKGFsbG93IGZpbGUtcmVhZCoKLSAgICAgICBmaWxlLXdyaXRlLWRhdGEKLSAgICAgICBm aWxlLWlvY3RsCisod2hlbiAoZXF1YWw/IChwYXJhbSAiSU5URVJOQUxfSU5TVEFMTCIpICJZRVMi KQorICAgIChhbGxvdyBmaWxlLXJlYWQqCisgICAgICAgICAgIGZpbGUtd3JpdGUtZGF0YQorICAg ICAgICAgICBmaWxlLWlvY3RsCiAjaWYgX19NQUNfT1NfWF9WRVJTSU9OX01JTl9SRVFVSVJFRCA+ PSAxMTAwMDAKICAgICAod2l0aCB0ZWxlbWV0cnktYmFja3RyYWNlKQogI2VuZGlmCi0gICAgKGxp dGVyYWwgIi9kZXYvZHRyYWNlaGVscGVyIikpCisgICAgICAgIChsaXRlcmFsICIvZGV2L2R0cmFj ZWhlbHBlciIpKQorKQogCiA7OzsgQWxsb3cgY3JlYXRpb24gb2YgY29yZSBkdW1wcy4KIChhbGxv dyBmaWxlLXdyaXRlLWNyZWF0ZQpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29h L1dlYlByb2Nlc3NDb2NvYS5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCShyZXZpc2lvbiAyNzE3OTMpCisrKyBTb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tCSh3b3JraW5nIGNvcHkp CkBAIC0xMzUsNiArMTM1LDcgQEAKICNpbXBvcnQgPFdlYkNvcmUvU2Nyb2xsYmFyVGhlbWVNYWMu aD4KICNpbXBvcnQgPHBhbC9zcGkvbWFjL0hJU2VydmljZXNTUEkuaD4KICNpbXBvcnQgPHBhbC9z cGkvbWFjL05TU2Nyb2xsZXJJbXBTUEkuaD4KKyNpbXBvcnQgPHd0Zi9zcGkvZGFyd2luL09TVmFy aWFudFNQSS5oPgogI2VuZGlmCiAKICNpZiBVU0UoT1NfU1RBVEUpCkBAIC02OTIsNiArNjkzLDkg QEAgdm9pZCBXZWJQcm9jZXNzOjppbml0aWFsaXplU2FuZGJveChjb25zdAogI2VuZGlmCiAgICAg c2FuZGJveFBhcmFtZXRlcnMuYWRkUGFyYW1ldGVyKCJFTkFCTEVfU0FOREJPWF9NRVNTQUdFX0ZJ TFRFUiIsIGVuYWJsZU1lc3NhZ2VGaWx0ZXIgPyAiWUVTIiA6ICJOTyIpOwogCisgICAgYm9vbCBp bnRlcm5hbEluc3RhbGwgPSBvc192YXJpYW50X2FsbG93c19pbnRlcm5hbF9zZWN1cml0eV9wb2xp Y2llcygiY29tLmFwcGxlLldlYktpdCIpOworICAgIHNhbmRib3hQYXJhbWV0ZXJzLmFkZFBhcmFt ZXRlcigiSU5URVJOQUxfSU5TVEFMTCIsIGludGVybmFsSW5zdGFsbCA/ICJZRVMiIDogIk5PIik7 CisKICAgICBBdXhpbGlhcnlQcm9jZXNzOjppbml0aWFsaXplU2FuZGJveChwYXJhbWV0ZXJzLCBz YW5kYm94UGFyYW1ldGVycyk7CiAjZW5kaWYKIH0K 418324 2021-01-25 12:55:03 -0800 2021-01-25 13:12:24 -0800 Patch bug-220927-20210125125504.patch text/plain 2455 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzE4MDcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTI1ICBQZXIgQXJuZSAg PHB2b2xsYW5AYXBwbGUuY29tPgorCisgICAgICAgIFttYWNPU10gUmVzdHJpY3QgYWNjZXNzIHRv IGR0cmFjZWhlbHBlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIwOTI3CisgICAgICAgIDxyZGFyOi8vNzAzNTA5NDc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgQnJlbnQgRnVsZ2hhbS4KKworICAgICAgICBPbmx5IGFsbG93IGFjY2VzcyB0byBkdHJh Y2VoZWxwZXIgZm9yIGludGVybmFsIGluc3RhbGxzLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9j b2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisgICAgICAgIChXZWJLaXQ6OldlYlByb2Nlc3M6Omlu aXRpYWxpemVTYW5kYm94KToKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9j ZXNzLnNiLmluOgorCiAyMDIxLTAxLTI1ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgU3VwcG9ydCBBYm9ydFNpZ25hbCBpbiBhZGRFdmVudExpc3RlbmVyT3B0aW9u cyB0byB1bnN1YnNjcmliZSBmcm9tIGV2ZW50cwpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24gMjcxODA3 KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmlu CSh3b3JraW5nIGNvcHkpCkBAIC04MSwxMyArODEsMTIgQEAKICAgICAobGl0ZXJhbCAiL2Rldi9u dWxsIikKICAgICAobGl0ZXJhbCAiL2Rldi96ZXJvIikpCiAKLShhbGxvdyBmaWxlLXJlYWQqCi0g ICAgICAgZmlsZS13cml0ZS1kYXRhCi0gICAgICAgZmlsZS1pb2N0bAotI2lmIF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTEwMDAwCi0gICAgKHdpdGggdGVsZW1ldHJ5LWJhY2t0 cmFjZSkKLSNlbmRpZgotICAgIChsaXRlcmFsICIvZGV2L2R0cmFjZWhlbHBlciIpKQorKHdoZW4g KGVxdWFsPyAocGFyYW0gIklOVEVSTkFMX0lOU1RBTEwiKSAiWUVTIikKKyAgICAoYWxsb3cgZmls ZS1yZWFkKgorICAgICAgICAgICBmaWxlLXdyaXRlLWRhdGEKKyAgICAgICAgICAgZmlsZS1pb2N0 bAorICAgICAgICAobGl0ZXJhbCAiL2Rldi9kdHJhY2VoZWxwZXIiKSkKKykKIAogOzs7IEFsbG93 IGNyZWF0aW9uIG9mIGNvcmUgZHVtcHMuCiAoYWxsb3cgZmlsZS13cml0ZS1jcmVhdGUKSW5kZXg6 IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5t bQkocmV2aXNpb24gMjcxODA3KQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMTM1LDYgKzEzNSw3IEBACiAjaW1w b3J0IDxXZWJDb3JlL1Njcm9sbGJhclRoZW1lTWFjLmg+CiAjaW1wb3J0IDxwYWwvc3BpL21hYy9I SVNlcnZpY2VzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL21hYy9OU1Njcm9sbGVySW1wU1BJLmg+ CisjaW1wb3J0IDx3dGYvc3BpL2Rhcndpbi9PU1ZhcmlhbnRTUEkuaD4KICNlbmRpZgogCiAjaWYg VVNFKE9TX1NUQVRFKQpAQCAtNjkyLDYgKzY5Myw5IEBAIHZvaWQgV2ViUHJvY2Vzczo6aW5pdGlh bGl6ZVNhbmRib3goY29uc3QKICNlbmRpZgogICAgIHNhbmRib3hQYXJhbWV0ZXJzLmFkZFBhcmFt ZXRlcigiRU5BQkxFX1NBTkRCT1hfTUVTU0FHRV9GSUxURVIiLCBlbmFibGVNZXNzYWdlRmlsdGVy ID8gIllFUyIgOiAiTk8iKTsKIAorICAgIGJvb2wgaW50ZXJuYWxJbnN0YWxsID0gb3NfdmFyaWFu dF9hbGxvd3NfaW50ZXJuYWxfc2VjdXJpdHlfcG9saWNpZXMoImNvbS5hcHBsZS5XZWJLaXQiKTsK KyAgICBzYW5kYm94UGFyYW1ldGVycy5hZGRQYXJhbWV0ZXIoIklOVEVSTkFMX0lOU1RBTEwiLCBp bnRlcm5hbEluc3RhbGwgPyAiWUVTIiA6ICJOTyIpOworCiAgICAgQXV4aWxpYXJ5UHJvY2Vzczo6 aW5pdGlhbGl6ZVNhbmRib3gocGFyYW1ldGVycywgc2FuZGJveFBhcmFtZXRlcnMpOwogI2VuZGlm CiB9Cg== 418328 2021-01-25 13:10:28 -0800 2021-01-25 14:09:58 -0800 Patch bug-220927-20210125131029.patch text/plain 2255 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzE4MDgpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAxLTI1ICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIFJlc3RyaWN0IGFj Y2VzcyB0byBkdHJhY2VoZWxwZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyMDkyNworICAgICAgICA8cmRhcjovLzcwMzUwOTQ3PgorCisgICAgICAg IFJldmlld2VkIGJ5IEJyZW50IEZ1bGdoYW0uCisKKyAgICAgICAgT25seSBhbGxvdyBhY2Nlc3Mg dG8gZHRyYWNlaGVscGVyIGZvciBpbnRlcm5hbCBpbnN0YWxscy4KKworICAgICAgICAqIFJlc291 cmNlcy9TYW5kYm94UHJvZmlsZXMvaW9zL2NvbS5hcHBsZS5XZWJLaXQuV2ViQ29udGVudC5zYjoK KyAgICAgICAgKiBXZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluOgorCiAyMDIx LTAxLTI1ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2NvYV0g QWRqdXN0IGxvZ2ljIGZvciBjcmVhdGluZyBzYW5kYm94IGV4dGVuc2lvbnMgYmFzZWQgb24gR1BV UCBmbGFncwpJbmRleDogU291cmNlL1dlYktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lv cy9jb20uYXBwbGUuV2ViS2l0LldlYkNvbnRlbnQuc2IKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdC9SZXNvdXJjZXMvU2FuZGJveFByb2ZpbGVzL2lvcy9jb20uYXBwbGUuV2ViS2l0LldlYkNv bnRlbnQuc2IJKHJldmlzaW9uIDI3MTgwNykKKysrIFNvdXJjZS9XZWJLaXQvUmVzb3VyY2VzL1Nh bmRib3hQcm9maWxlcy9pb3MvY29tLmFwcGxlLldlYktpdC5XZWJDb250ZW50LnNiCSh3b3JraW5n IGNvcHkpCkBAIC0zMTQsOCArMzE0LDEwIEBACiAgICAgICAgICAgIChsaXRlcmFsICIvZGV2L251 bGwiKQogICAgICAgICAgICAobGl0ZXJhbCAiL2Rldi96ZXJvIikpCiAKLSAgICAoYWxsb3cgZmls ZS1yZWFkKiBmaWxlLXdyaXRlLWRhdGEgZmlsZS1pb2N0bAotICAgICAgICAgICAobGl0ZXJhbCAi L2Rldi9kdHJhY2VoZWxwZXIiKSkKKyAgICAod2l0aC1maWx0ZXIgKHN5c3RlbS1hdHRyaWJ1dGUg YXBwbGUtaW50ZXJuYWwpCisgICAgICAgIChhbGxvdyBmaWxlLXJlYWQqIGZpbGUtd3JpdGUtZGF0 YSBmaWxlLWlvY3RsCisgICAgICAgICAgICAobGl0ZXJhbCAiL2Rldi9kdHJhY2VoZWxwZXIiKSkK KyAgICApCiAKICAgICAoYWxsb3cgZmlsZS1yZWFkKgogICAgICAgICAgICAobGl0ZXJhbCAiL2Rl di9yYW5kb20iKQpJbmRleDogU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQ cm9jZXNzLnNiLmluCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20u YXBwbGUuV2ViUHJvY2Vzcy5zYi5pbgkocmV2aXNpb24gMjcxODA3KQorKysgU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9jZXNzLnNiLmluCSh3b3JraW5nIGNvcHkpCkBA IC04MSwxMyArODEsMTIgQEAKICAgICAobGl0ZXJhbCAiL2Rldi9udWxsIikKICAgICAobGl0ZXJh bCAiL2Rldi96ZXJvIikpCiAKLShhbGxvdyBmaWxlLXJlYWQqCi0gICAgICAgZmlsZS13cml0ZS1k YXRhCi0gICAgICAgZmlsZS1pb2N0bAotI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlS RUQgPj0gMTEwMDAwCi0gICAgKHdpdGggdGVsZW1ldHJ5LWJhY2t0cmFjZSkKLSNlbmRpZgotICAg IChsaXRlcmFsICIvZGV2L2R0cmFjZWhlbHBlciIpKQorKHdpdGgtZmlsdGVyIChzeXN0ZW0tYXR0 cmlidXRlIGFwcGxlLWludGVybmFsKQorICAgIChhbGxvdyBmaWxlLXJlYWQqCisgICAgICAgICAg IGZpbGUtd3JpdGUtZGF0YQorICAgICAgICAgICBmaWxlLWlvY3RsCisgICAgICAgIChsaXRlcmFs ICIvZGV2L2R0cmFjZWhlbHBlciIpKQorKQogCiA7OzsgQWxsb3cgY3JlYXRpb24gb2YgY29yZSBk dW1wcy4KIChhbGxvdyBmaWxlLXdyaXRlLWNyZWF0ZQo=