220926 2021-01-25 08:26:14 -0800 [GPU Process] Web process should be terminated if DisplayListReaderHandle advances past 0 2021-01-25 10:36:45 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh ggaren simon.fraser thorton webkit-bug-importer oldest_to_newest 1722076 0 wenson_hsieh 2021-01-25 08:26:14 -0800 Address the last message-check-related FIXME in the GPU Process. 1722079 1 418296 wenson_hsieh 2021-01-25 08:37:08 -0800 Created attachment 418296 Patch 1722115 2 418296 wenson_hsieh 2021-01-25 10:19:30 -0800 Comment on attachment 418296 Patch Thanks for the review! 1722124 3 ews-feeder 2021-01-25 10:33:26 -0800 Committed r271800: <https://trac.webkit.org/changeset/271800> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418296. 1722128 4 webkit-bug-importer 2021-01-25 10:36:45 -0800 <rdar://problem/73577385> 418296 2021-01-25 08:37:08 -0800 2021-01-25 10:33:27 -0800 Patch bug-220926-20210125083707.patch text/plain 6143 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk2ZTQwYmQyNjIzYWNmYjQ3 YmJjODI0MzkwZTlmYTZiN2M5MDk0YzQuLjRiNmVkZjYzZTVjNDQ2MTNlMzcwNDNkN2NiN2VjODhm MmI4NjU0ZWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAgQEAKKzIwMjEtMDEtMjUgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVSBQcm9jZXNzXSBX ZWIgcHJvY2VzcyBzaG91bGQgYmUgdGVybWluYXRlZCBpZiBEaXNwbGF5TGlzdFJlYWRlckhhbmRs ZSBhZHZhbmNlcyBwYXN0IDAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIyMDkyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZHJlc3MgYW5vdGhlciBGSVhNRSBpbiB0aGUgR1BVIFByb2Nlc3MgYnkgcmVw bGFjaW5nIGEgcmVsZWFzZSBhc3NlcnRpb24gd2l0aCBhIE1FU1NBR0VfQ0hFQ0suIFNlZSBiZWxv dyBmb3IKKyAgICAgICAgbW9yZSBkZXRhaWxzLgorCisgICAgICAgICogR1BVUHJvY2Vzcy9ncmFw aGljcy9EaXNwbGF5TGlzdFJlYWRlckhhbmRsZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OkRpc3Bs YXlMaXN0UmVhZGVySGFuZGxlOjphZHZhbmNlKToKKworICAgICAgICBSZXR1cm4gYFdURjo6bnVs bG9wdGAgaW5zdGVhZCBvZiBqdXN0IGNyYXNoaW5nIGluIHRoZSBjYXNlIHdoZXJlIHRoZSBudW1i ZXIgb2YgYnl0ZXMgdG8gYWR2YW5jZSBleGNlZWRzIHRoZQorICAgICAgICBudW1iZXIgb2YgdW5y ZWFkIGJ5dGVzLiBUaGlzIGNhbiAoYW5kIHNob3VsZCkgb25seSBoYXBwZW4gaW4gdGhlIGNhc2Ug d2hlcmUgYSBjb21wcm9taXNlZCB3ZWIgY29udGVudCBwcm9jZXNzCisgICAgICAgIGF0dGVtcHRz IHRvIG92ZXJ3cml0ZSB0aGUgbnVtYmVyIG9mIHVucmVhZCBieXRlcyBpbiB0aGUgc2hhcmVkIGRp c3BsYXkgbGlzdCBoZWFkZXIuCisKKyAgICAgICAgKiBHUFVQcm9jZXNzL2dyYXBoaWNzL0Rpc3Bs YXlMaXN0UmVhZGVySGFuZGxlLmg6CisgICAgICAgICogR1BVUHJvY2Vzcy9ncmFwaGljcy9SZW1v dGVSZW5kZXJpbmdCYWNrZW5kLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlUmVuZGVyaW5n QmFja2VuZDo6bmV4dERlc3RpbmF0aW9uSW1hZ2VCdWZmZXJBZnRlckFwcGx5aW5nRGlzcGxheUxp c3RzKToKKyAgICAgICAgKiBTaGFyZWQvU2hhcmVkRGlzcGxheUxpc3RIYW5kbGUuaDoKKworICAg ICAgICBSZW1vdmUgdGhpcyB2aXJ0dWFsIG1ldGhvZCBmcm9tIHRoZSBiYXNlIGNsYXNzLCBzaW5j ZSB0aGUgcmVhZGVyIGhhbmRsZSBub3cgcmV0dXJucyBhbiBgT3B0aW9uYWw8c2l6ZV90PmAKKyAg ICAgICAgaW5zdGVhZCBvZiBqdXN0IGEgYHNpemVfdGAuCisKKyAgICAgICAgKiBXZWJQcm9jZXNz L0dQVS9ncmFwaGljcy9EaXNwbGF5TGlzdFdyaXRlckhhbmRsZS5oOgorCiAyMDIxLTAxLTIzICBQ ZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWFjT1NdIERl bnkgbWFjaCBsb29rdXAgYWNjZXNzIHRvICJjb20uYXBwbGUuaWNvbnNlcnZpY2VzLnN0b3JlIiBp biB0aGUgV2ViQ29udGVudCBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVBy b2Nlc3MvZ3JhcGhpY3MvRGlzcGxheUxpc3RSZWFkZXJIYW5kbGUuY3BwIGIvU291cmNlL1dlYktp dC9HUFVQcm9jZXNzL2dyYXBoaWNzL0Rpc3BsYXlMaXN0UmVhZGVySGFuZGxlLmNwcAppbmRleCBh ZDExMzZlM2U4Y2UyNmEwOGNlMmI3MTkyN2UyY2JkMDQyODUyYTdjLi42ZDAwZDQzMzY4YmJjMmI2 YWY1MGQ0MDdkYzNhZjljZmNhNmZjMWY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0dQVVBy b2Nlc3MvZ3JhcGhpY3MvRGlzcGxheUxpc3RSZWFkZXJIYW5kbGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9EaXNwbGF5TGlzdFJlYWRlckhhbmRsZS5jcHAKQEAg LTI5LDE0ICsyOSwxMSBAQAogbmFtZXNwYWNlIFdlYktpdCB7CiB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKIAotc2l6ZV90IERpc3BsYXlMaXN0UmVhZGVySGFuZGxlOjphZHZhbmNlKHNpemVfdCBh bW91bnQpCitPcHRpb25hbDxzaXplX3Q+IERpc3BsYXlMaXN0UmVhZGVySGFuZGxlOjphZHZhbmNl KHNpemVfdCBhbW91bnQpCiB7CiAgICAgYXV0byBwcmV2aW91c1VucmVhZEJ5dGVzID0gaGVhZGVy KCkudW5yZWFkQnl0ZXMuZXhjaGFuZ2VTdWIoYW1vdW50KTsKLSAgICBpZiAoVU5MSUtFTFkocHJl dmlvdXNVbnJlYWRCeXRlcyA8IGFtb3VudCkpIHsKLSAgICAgICAgLy8gRklYTUU6IFRoaXMgc2hv dWxkIHJlc3VsdCBpbiB0ZXJtaW5hdGluZyB0aGUgd2ViIHByb2Nlc3MuCi0gICAgICAgIFJFTEVB U0VfQVNTRVJUX05PVF9SRUFDSEVEKCk7Ci0gICAgICAgIHJldHVybiAwOwotICAgIH0KKyAgICBp ZiAoVU5MSUtFTFkocHJldmlvdXNVbnJlYWRCeXRlcyA8IGFtb3VudCkpCisgICAgICAgIHJldHVy biBXVEY6Om51bGxvcHQ7CiAgICAgcmV0dXJuIHByZXZpb3VzVW5yZWFkQnl0ZXMgLSBhbW91bnQ7 CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGljcy9EaXNw bGF5TGlzdFJlYWRlckhhbmRsZS5oIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNz L0Rpc3BsYXlMaXN0UmVhZGVySGFuZGxlLmgKaW5kZXggYmU4YzU1Zjg4YzVkYjRjYzViY2FjNDI0 NmEyYTYxNTNjZjJkNTY3Yi4uMWExOWZkYzNmYzhlOGQ2YzdjNzE4MWIyNDZhMzFmMGRiYWM3YzU5 NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL0Rpc3BsYXlM aXN0UmVhZGVySGFuZGxlLmgKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNz L0Rpc3BsYXlMaXN0UmVhZGVySGFuZGxlLmgKQEAgLTI3LDYgKzI3LDcgQEAKIAogI2luY2x1ZGUg IlNoYXJlZERpc3BsYXlMaXN0SGFuZGxlLmgiCiAjaW5jbHVkZSA8d3RmL0Zhc3RNYWxsb2MuaD4K KyNpbmNsdWRlIDx3dGYvT3B0aW9uYWwuaD4KIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKQEAgLTM4 LDcgKzM5LDcgQEAgcHVibGljOgogICAgICAgICByZXR1cm4gYWRvcHRSZWYoKm5ldyBEaXNwbGF5 TGlzdFJlYWRlckhhbmRsZShpZGVudGlmaWVyLCBXVEZNb3ZlKHNoYXJlZE1lbW9yeSkpKTsKICAg ICB9CiAKLSAgICBzaXplX3QgYWR2YW5jZShzaXplX3QgYW1vdW50KSBvdmVycmlkZTsKKyAgICBP cHRpb25hbDxzaXplX3Q+IGFkdmFuY2Uoc2l6ZV90IGFtb3VudCk7CiAgICAgc3RkOjp1bmlxdWVf cHRyPFdlYkNvcmU6OkRpc3BsYXlMaXN0OjpEaXNwbGF5TGlzdD4gZGlzcGxheUxpc3RGb3JSZWFk aW5nKHNpemVfdCBvZmZzZXQsIHNpemVfdCBjYXBhY2l0eSwgV2ViQ29yZTo6RGlzcGxheUxpc3Q6 Okl0ZW1CdWZmZXJSZWFkaW5nQ2xpZW50JikgY29uc3Q7CiAKICAgICB2b2lkIHN0YXJ0V2FpdGlu ZygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3MvUmVtb3Rl UmVuZGVyaW5nQmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvZ3JhcGhpY3Mv UmVtb3RlUmVuZGVyaW5nQmFja2VuZC5jcHAKaW5kZXggMzcyMDdkN2ZjNzgwYmZiM2E0YmQ3YzFi NGRjYzBlNjQ4NTVkNTVlNi4uMzJhZmQzMTBiZTVjMzAzMDY0N2Q3MjU4YzIzZmRhMDEwMmIyZDc3 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL2dyYXBoaWNzL1JlbW90ZVJl bmRlcmluZ0JhY2tlbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy9ncmFwaGlj cy9SZW1vdGVSZW5kZXJpbmdCYWNrZW5kLmNwcApAQCAtMTk0LDkgKzE5NCwxMiBAQCBSZWZQdHI8 SW1hZ2VCdWZmZXI+IFJlbW90ZVJlbmRlcmluZ0JhY2tlbmQ6Om5leHREZXN0aW5hdGlvbkltYWdl QnVmZmVyQWZ0ZXJBcHBseQogICAgICAgICBNRVNTQUdFX0NIRUNLX1dJVEhfUkVUVVJOX1ZBTFVF KGRpc3BsYXlMaXN0LCBudWxscHRyLCAiRmFpbGVkIHRvIG1hcCBkaXNwbGF5IGxpc3QgZnJvbSBz aGFyZWQgbWVtb3J5Iik7CiAKICAgICAgICAgYXV0byByZXN1bHQgPSBzdWJtaXQoKmRpc3BsYXlM aXN0LCAqZGVzdGluYXRpb24pOwotICAgICAgICBzaXplVG9SZWFkID0gaGFuZGxlLmFkdmFuY2Uo cmVzdWx0Lm51bWJlck9mQnl0ZXNSZWFkKTsKICAgICAgICAgTUVTU0FHRV9DSEVDS19XSVRIX1JF VFVSTl9WQUxVRShyZXN1bHQucmVhc29uRm9yU3RvcHBpbmcgIT0gRGlzcGxheUxpc3Q6OlN0b3BS ZXBsYXlSZWFzb246OkludmFsaWRJdGVtLCBudWxscHRyLCAiRGV0ZWN0ZWQgaW52YWxpZCBkaXNw bGF5IGxpc3QgaXRlbSIpOwogCisgICAgICAgIGF1dG8gYWR2YW5jZVJlc3VsdCA9IGhhbmRsZS5h ZHZhbmNlKHJlc3VsdC5udW1iZXJPZkJ5dGVzUmVhZCk7CisgICAgICAgIE1FU1NBR0VfQ0hFQ0tf V0lUSF9SRVRVUk5fVkFMVUUoYWR2YW5jZVJlc3VsdCwgbnVsbHB0ciwgIkZhaWxlZCB0byBhZHZh bmNlIGRpc3BsYXkgbGlzdCByZWFkZXIgaGFuZGxlIik7CisgICAgICAgIHNpemVUb1JlYWQgPSAq YWR2YW5jZVJlc3VsdDsKKwogICAgICAgICBDaGVja2VkU2l6ZSBjaGVja2VkT2Zmc2V0ID0gb2Zm c2V0OwogICAgICAgICBjaGVja2VkT2Zmc2V0ICs9IHJlc3VsdC5udW1iZXJPZkJ5dGVzUmVhZDsK ICAgICAgICAgTUVTU0FHRV9DSEVDS19XSVRIX1JFVFVSTl9WQUxVRSghY2hlY2tlZE9mZnNldC5o YXNPdmVyZmxvd2VkKCksIG51bGxwdHIsICJPdmVyZmxvd2VkIHdoZW4gYWR2YW5jaW5nIHNoYXJl ZCBkaXNwbGF5IGxpc3QgaGFuZGxlIG9mZnNldCIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9TaGFyZWQvU2hhcmVkRGlzcGxheUxpc3RIYW5kbGUuaCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVk L1NoYXJlZERpc3BsYXlMaXN0SGFuZGxlLmgKaW5kZXggMGEyYTdlMDllZDQ5ODBlMTUwMDE3NWIw ZTkzZWVhN2UzYWRjYmMwNy4uOTU4NzZiMzRkNWUzN2IzZjk5NTQ5M2RmZjQyY2MzOTNjZWUwODE4 MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvU2hhcmVkRGlzcGxheUxpc3RIYW5k bGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9TaGFyZWREaXNwbGF5TGlzdEhhbmRsZS5o CkBAIC01Myw4ICs1Myw2IEBAIHB1YmxpYzoKICAgICAgICAgcmV0dXJuIGhlYWRlcigpLnVucmVh ZEJ5dGVzLmxvYWQoKTsKICAgICB9CiAKLSAgICB2aXJ0dWFsIHNpemVfdCBhZHZhbmNlKHNpemVf dCBhbW91bnQpID0gMDsKLQogICAgIGVudW0gY2xhc3MgV2FpdGluZ1N0YXR1cyA6IHVpbnQ4X3Qg ewogICAgICAgICBOb3RXYWl0aW5nLAogICAgICAgICBXYWl0aW5nLApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9EaXNwbGF5TGlzdFdyaXRlckhhbmRs ZS5oIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9EaXNwbGF5TGlzdFdy aXRlckhhbmRsZS5oCmluZGV4IGY5ZjQ0ZTQyODhjOTA2YWY4N2EyMGM3YzA5NzVlOTk0NWYwZjll MzIuLjgyMzVmZjk0Nzc0OGNmZWQzNzZhZWZkMDZmYzNjZTk3NWQ3ZmI2OWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvRGlzcGxheUxpc3RXcml0ZXJI YW5kbGUuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL0Rpc3Bs YXlMaXN0V3JpdGVySGFuZGxlLmgKQEAgLTQzLDcgKzQzLDcgQEAgcHVibGljOgogCiAgICAgYm9v bCBtb3ZlV3JpdGFibGVPZmZzZXRUb1N0YXJ0SWZQb3NzaWJsZSgpOwogCi0gICAgc2l6ZV90IGFk dmFuY2Uoc2l6ZV90IGFtb3VudCkgb3ZlcnJpZGU7CisgICAgc2l6ZV90IGFkdmFuY2Uoc2l6ZV90 IGFtb3VudCk7CiAgICAgV2ViQ29yZTo6RGlzcGxheUxpc3Q6Okl0ZW1CdWZmZXJIYW5kbGUgY3Jl YXRlSGFuZGxlKCkgY29uc3Q7CiAKICAgICBib29sIHRyeVRvUmVzdW1lKFNoYXJlZERpc3BsYXlM aXN0SGFuZGxlOjpSZXN1bWVSZWFkaW5nSW5mb3JtYXRpb24mJiBpbmZvKQo=