220885 2021-01-22 19:22:09 -0800 WebKit doesn't automatically right-align Adlam 2022-02-03 04:28:28 -0800 1 1 1 Unclassified WebKit Text WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xfq.free mmaxfield achristensen benjamin cdumez cmarcelo darin ews-watchlist ishida mmaxfield smoley webkit-bug-importer zalan oldest_to_newest 1721806 0 xfq.free 2021-01-22 19:22:09 -0800 Adlam text displayed in a block element with 'dir' set to 'auto' should be automatically right-aligned, unless the base direction is set to LTR. See https://github.com/w3c/afrlreq/issues/13 for more info. 1723235 1 smoley 2021-01-27 17:47:48 -0800 Can you please attach a test html file as well? Thanks 1723236 2 webkit-bug-importer 2021-01-27 17:47:57 -0800 <rdar://problem/73688496> 1723237 3 smoley 2021-01-27 17:51:34 -0800 Actually it looks like this page may work: http://adlamtesting.appspot.com 1723238 4 smoley 2021-01-27 17:54:09 -0800 On second thought that page is showing it in a <textarea> but at least it provides some test text. 1723595 5 418695 xfq.free 2021-01-28 19:09:25 -0800 Created attachment 418695 WebKit doesn't automatically right-align Adlam Here's a test HTML file. 1723901 6 mmaxfield 2021-01-29 15:20:36 -0800 The content has dir="auto" 1723902 7 mmaxfield 2021-01-29 15:22:14 -0800 If the text is moved out from the intermediate <p> element, it becomes right aligned. Somehow the <p> element is causing the problem. 1723904 8 mmaxfield 2021-01-29 15:23:32 -0800 (In reply to Myles C. Maxfield from comment #7) > If the text is moved out from the intermediate <p> element, it becomes right > aligned. Somehow the <p> element is causing the problem. Whoops, this is only true if you insert some RTL text like Arabic at the beginning of the string. 1723908 9 mmaxfield 2021-01-29 15:25:24 -0800 (In reply to Myles C. Maxfield from comment #8) > (In reply to Myles C. Maxfield from comment #7) > > If the text is moved out from the intermediate <p> element, it becomes right > > aligned. Somehow the <p> element is causing the problem. > > Whoops, this is only true if you insert some RTL text like Arabic at the > beginning of the string. Yeah, ignore what I said about the <p> element. The <p> element has nothing to do with this. 1723912 10 mmaxfield 2021-01-29 15:32:10 -0800 The first place to check would be StringImpl::defaultWritingDirection() 1723917 11 mmaxfield 2021-01-29 15:33:48 -0800 oh hahahaha we're terrible auto charDirection = u_charDirection(is8Bit() ? m_data8[i] : m_data16[i]); super broken 1723919 12 418778 mmaxfield 2021-01-29 15:48:48 -0800 Created attachment 418778 Patch 1723937 13 ews-feeder 2021-01-29 16:18:32 -0800 Committed r272084: <https://trac.webkit.org/changeset/272084> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418778. 1723961 14 418778 darin 2021-01-29 17:04:30 -0800 Comment on attachment 418778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418778&action=review > Source/WTF/wtf/text/StringImpl.cpp:1672 > UCharDirection StringImpl::defaultWritingDirection(bool* hasStrongDirectionality) Some day to clean up: Feels to me like we should move this function to StringView or make it a non-member function that takes a StringView, in some place where we have code about writing direction and bidirectional algorithms. And give it a better interface with return values instead of an out argument. And add a fast path so we aren’t calling u_charDirection in common cases. 1723962 15 418778 darin 2021-01-29 17:04:30 -0800 Comment on attachment 418778 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418778&action=review > Source/WTF/wtf/text/StringImpl.cpp:1672 > UCharDirection StringImpl::defaultWritingDirection(bool* hasStrongDirectionality) Some day to clean up: Feels to me like we should move this function to StringView or make it a non-member function that takes a StringView, in some place where we have code about writing direction and bidirectional algorithms. And give it a better interface with return values instead of an out argument. And add a fast path so we aren’t calling u_charDirection in common cases. 1723976 16 mmaxfield 2021-01-29 17:50:00 -0800 (In reply to Darin Adler from comment #15) > Comment on attachment 418778 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=418778&action=review > > > Source/WTF/wtf/text/StringImpl.cpp:1672 > > UCharDirection StringImpl::defaultWritingDirection(bool* hasStrongDirectionality) > > Some day to clean up: Feels to me like we should move this function to > StringView or make it a non-member function that takes a StringView, in some > place where we have code about writing direction and bidirectional > algorithms. And give it a better interface with return values instead of an > out argument. And add a fast path so we aren’t calling u_charDirection in > common cases. Yeah, Alex and I had a conversation about the direction to move this class. Sounds like we all agree :) 1836866 17 ishida 2022-02-03 04:28:28 -0800 Thanks for fixing this. 418695 2021-01-28 19:09:25 -0800 2021-01-28 19:09:25 -0800 WebKit doesn't automatically right-align Adlam index.html text/html 2403 xfq.free PCFET0NUWVBFIGh0bWw+CjxodG1sIGxhbmc9ImVuIj4KPGhlYWQ+CiAgPG1ldGEgY2hhcnNldD0i dXRmLTgiPgogIDx0aXRsZT5NeSB0ZXN0IHBhZ2U8L3RpdGxlPgo8L2hlYWQ+Cjxib2R5PgoKICA8 ZGl2IGRpcj0iYXV0byIgbGFuZz0iZnVmIj4KICAgIDxwIHRpdGxlPSJVREhSLCBhcnRpY2xlIDEi PvCepJHwnqS18J6lhfCepKTwnqSi8J6kpCDwnqS68J6kovCepKPwnqSi8J6ksvCepKLwnqSkCiAg IAogICDwnqSL8J6ksvCepYbwnqSi8J6kpfCepKIg8J6kovCepYTwnqSj8J6kq/CepYXwnqS28J6k rSDwnqSs8J6krvCepKwg8J6kqPCepK7wnqS88J6kreK5gSDwnqSyJ/CepKPwnqSt8J6kpfCepK/w nqSt8J6ko/CepK0g8J6kqyDwnqS28J6krfCepKbwnqSt8J6ksvCepKLwnqSy8J6lhvCepKPwnqSr IPCepLzwnqSuIPCepKbwnqSi8J6ksvCepYbwnqS68J6kqyDwnqS48J6kovCepLPwnqWG8J6kq/Ce pYXwnqS28J6krS4g8J6kifCepKnwnqSrIPCepLIn8J6kuvCepK7wnqWF8J6ko/CepK0g8J6kpfCe pK3wnqWF8J6ktvCepK4g8J6kqyDwnqS48J6kovCepLPwnqWG8J6krfCepKTwnqSi8J6ksvCepLzw nqSi8J6lhPCepLrwnqSi8J6kpCDwnqSr8J6kvPCepKsg8J6kq/CepKnwnqSrIPCepKjwnqSu8J6k vPCepK0g8J6kuPCepLXwnqWF8J6krPCepK4g8J6ksifwnqSj8J6krfCepKrwnqSj8J6kqyDwnqSr IPCepLIn8J6ko/CepKvwnqSqIPCepKkg8J6krfCepLTwnqSy8J6kuvCepLXwnqS08J6ktfCepKXw nqWG8J6kovCepYTwnqS68J6ktS48L3A+CiAgIDxwIHRpdGxlPSJVREhSLCBhcnRpY2xlIDIiPvCe pJHwnqS18J6lhfCepKTwnqSi8J6kpCDwnqWSCiAgIAogICDwnqSY8J6krvCepYXwnqS88J6kriDw nqSz8J6kovCepKTwnqSiIPCepK3wnqSy8J6koiDwnqSx8J6kovCepYTwnqSx8J6krSDwnqS48J6k rvCepLPwnqWG8J6ktfCepLLwnqSj8J6kqyDwnqS48J6krvCepYXwnqSq8J6kqyDwnqSl8J6ktfCe pKUg8J6kuPCepKLwnqSz8J6lhvCepKvwnqWF8J6ktvCepK0g8J6kqyDwnqSyJ/CepKPwnqSt8J6k pfCepKIg8J6kuvCepLXwnqWF8J6ktvCepK0g8J6ks/CepKLwnqWE8J6kpPCepKLwnqWE8J6kr/Ce pK0g8J6kqyDwnqSy8J6kovCepLLwnqSu8J6ksvCepKPwnqSt8J6kqvCepKLwnqSk8J6ksvCepLrw nqSi8J6kpCDwnqS88J6kovCepLHwnqSiIPCepKLwnqSk8J6kovCepYQg8J6kqPCepKLwnqSk8J6k vPCepKLwnqS68J6krvCepKQg8J6ksifwnqS68J6ktfCepKrwnqS14rmB8J6kkCfwnqSm8J6kovCe pLTwnqSj8J6kreK5gSDwnqSk8J6kq/CepLvwnqSu8J6kpOK5gSDwnqSv8J6kq/CepKXwnqSy8J6k uvCepKLwnqSk4rmBIPCepKPwnqSt8J6lhfCepLLwnqSr4rmBIPCepK3wnqSx8J6ko/CepK0g8J6k pPCepKvwnqS08J6ko/CepK0g8J6ksfCepKLwnqSk8J6lhvCepKIg8J6kqvCepKvwnqSy8J6lhvCe pKPwnqSu4rmBIPCepKPwnqSi8J6ku/CepKLwnqSk4rmBIPCepLbwnqSt8J6kpvCepK3wnqSy8J6k ovCepLLwnqSj8J6kqyDwnqSx8J6kovCepKTwnqWG8J6koiDwnqSz8J6kovCepKTwnqSiIPCepLIn 8J6kuvCepK7wnqSy8J6ks/CepKIuIPCepIkg8J6ks/CepK4g8J6krPCepKLwnqSx8J6kvPCepK3w nqWFIPCepLjwnqSr8J6lhfCepLIg8J6kuPCepKLwnqS0IPCepKjwnqSi8J6kpPCepLzwnqSu8J6l hfCepKog8J6kuvCepK7wnqWF8J6kvPCepK4g8J6ksfCepK7wnqWF8J6ko/CepKLwnqS88J6kovCe pYQg8J6kqyDwnqSj8J6krvCepLEg8J6ktPCepK7wnqSx8J6krfCepLzwnqSi8J6lhPCepKPwnqSr IPCepKsg8J6ko/CepKLwnqSx8J6kqvCepLXwnqS68J6krvCepKTiuYEg8J6ku/CepKLwnqWE8J6k sfCepK7wnqWF8J6kqvCepKsg8J6kuPCepKLwnqSz8J6lhvCepLXwnqSy8J6ko/CepKsg8J6kpPCe pKvwnqS08J6kr/CepKvwnqWF8J6kpPCepKsg8J6krPCepKLwnqSx8J6kovCepYTwnqSj8J6kqyDw nqSrIPCepLLwnqSr8J6kr/CepYbwnqSuIPCepLXwnqSl8J6lhvCepK3wnqWF8J6kr/CepK4g8J6k pPCepKvwnqS08J6ko/CepK0g8J6ksfCepKLwnqSk8J6lhvCepKIg8J6ksvCepKvwnqSv8J6lhvCe pK4g8J6kpfCepK4g8J6ktPCepK7wnqSx8J6krfCepLzwnqSi8J6lhPCepLPwnqStIPCepKXwnqSi 8J6lhCDwnqSx8J6krvCepLLwnqStIPCepKjwnqSi8J6ksfCepK3wnqSv8J6kriDwnqS08J6kovCe pKXwnqSt8J6kqvCepK7wnqWF8J6kqvCepKsg8J6kpPCepKLwnqWE8J6ksfCepK/wnqSt8J6ksvCe pKLwnqWE8J6ksvCepKPwnqSrIPCepLHwnqSi8J6lhPCepLHwnqSy8J6ko/CepKsg8J6ksfCepK7w nqSy8J6ko/CepKsg8J6krPCepK7wnqSsLjwvcD4KICAgPCEtLSBTb3VyY2U6IGh0dHBzOi8vdW5p Y29kZS5vcmcvdWRoci9kL3VkaHJfZnVmX2FkbG0uaHRtbCAtLT4KICAgPC9kaXY+Cgo8L2JvZHk+ CjwvaHRtbD4K 418778 2021-01-29 15:48:48 -0800 2021-01-29 16:18:33 -0800 Patch bug-220885-20210129154847.patch text/plain 3740 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyMDczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE1Y2RiMmEyYWZkMGRlNDFkM2RlNzk2 MWU5MzVkODk5NDhlYWJjMjUuLjhlYjI2ODRlOWMwMzVjZTEwODI0M2YyNThmN2FhN2ViNDQ2ZGIw MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMjEtMDEtMjkgIE15bGVzIEMuIE1heGZpZWxkICA8 bW1heGZpZWxkQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXQgZG9lc24ndCBhdXRvbWF0aWNh bGx5IHJpZ2h0LWFsaWduIEFkbGFtCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjA4ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJZiB3ZSB3YW50IHRvIGl0ZXJhdGUgYWNyb3NzIGNvZGUgcG9pbnRzLCB3 ZSBoYXZlIHRvIGFjdHVhbGx5CisgICAgICAgIGl0ZXJhdGUgYWNyb3NzIGNvZGUgcG9pbnRzIGlu c3RlYWQgb2YgaXRlcmF0aW5nIGFjcm9zcyBjb2RlIHVuaXRzLgorCisgICAgICAgIFRlc3Q6IGZh c3QvdGV4dC9hZGxhbS1kaXItYXV0by5odG1sCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdJ bXBsLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nSW1wbDo6ZGVmYXVsdFdyaXRpbmdEaXJlY3Rp b24pOgorCiAyMDIxLTAxLTI5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5j b20+CiAKICAgICAgICAgZm9udC1zdHJldGNoIGlzIG5vdCBhcHBsaWVkIHRvIHN5c3RlbS11aQpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcCBiL1NvdXJjZS9X VEYvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAKaW5kZXggMjcwZTFjY2U0ODg1NTQwOTI1ODQzNDAz ODM1N2E1YTIzZWZhMDFiMS4uODdjOTYzYTM1MTdmOTNlMTFlZWVhY2VhMDA4OGY2YmMxYjM5NmI0 NSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAorKysgYi9T b3VyY2UvV1RGL3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCkBAIC0xNjcxLDggKzE2NzEsOCBAQCBi b29sIGVxdWFsSWdub3JpbmdBU0NJSUNhc2VOb25OdWxsKGNvbnN0IFN0cmluZ0ltcGwqIGEsIGNv bnN0IFN0cmluZ0ltcGwqIGIpCiAKIFVDaGFyRGlyZWN0aW9uIFN0cmluZ0ltcGw6OmRlZmF1bHRX cml0aW5nRGlyZWN0aW9uKGJvb2wqIGhhc1N0cm9uZ0RpcmVjdGlvbmFsaXR5KQogewotICAgIGZv ciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX2xlbmd0aDsgKytpKSB7Ci0gICAgICAgIGF1dG8gY2hh ckRpcmVjdGlvbiA9IHVfY2hhckRpcmVjdGlvbihpczhCaXQoKSA/IG1fZGF0YThbaV0gOiBtX2Rh dGExNltpXSk7CisgICAgZm9yIChhdXRvIGNvZGVQb2ludCA6IFN0cmluZ1ZpZXcodGhpcykuY29k ZVBvaW50cygpKSB7CisgICAgICAgIGF1dG8gY2hhckRpcmVjdGlvbiA9IHVfY2hhckRpcmVjdGlv bihjb2RlUG9pbnQpOwogICAgICAgICBpZiAoY2hhckRpcmVjdGlvbiA9PSBVX0xFRlRfVE9fUklH SFQpIHsKICAgICAgICAgICAgIGlmIChoYXNTdHJvbmdEaXJlY3Rpb25hbGl0eSkKICAgICAgICAg ICAgICAgICAqaGFzU3Ryb25nRGlyZWN0aW9uYWxpdHkgPSB0cnVlOwpAQCAtMTY4NCw2ICsxNjg0 LDcgQEAgVUNoYXJEaXJlY3Rpb24gU3RyaW5nSW1wbDo6ZGVmYXVsdFdyaXRpbmdEaXJlY3Rpb24o Ym9vbCogaGFzU3Ryb25nRGlyZWN0aW9uYWxpdHkKICAgICAgICAgICAgIHJldHVybiBVX1JJR0hU X1RPX0xFRlQ7CiAgICAgICAgIH0KICAgICB9CisKICAgICBpZiAoaGFzU3Ryb25nRGlyZWN0aW9u YWxpdHkpCiAgICAgICAgICpoYXNTdHJvbmdEaXJlY3Rpb25hbGl0eSA9IGZhbHNlOwogICAgIHJl dHVybiBVX0xFRlRfVE9fUklHSFQ7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOTM1ODk3ZGM2ODJkNmExODk2ZGFiODk4MDg1 M2RjMDJkNGM1NjRlNS4uYTRjZTJkMDgxOTZiYzk2YTg3ZDlmZDRmNjBjNTQ1YTc1NTY1NDUyYyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAxLTI5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1t YXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViS2l0IGRvZXNuJ3QgYXV0b21hdGljYWxs eSByaWdodC1hbGlnbiBBZGxhbQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIwODg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBmYXN0L3RleHQvYWRsYW0tZGlyLWF1dG8tZXhwZWN0ZWQuaHRtbDogQWRk ZWQuCisgICAgICAgICogZmFzdC90ZXh0L2FkbGFtLWRpci1hdXRvLmh0bWw6IEFkZGVkLgorCiAy MDIxLTAxLTI5ICBNeWxlcyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAg ICAgICAgZm9udC1zdHJldGNoIGlzIG5vdCBhcHBsaWVkIHRvIHN5c3RlbS11aQpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2FkbGFtLWRpci1hdXRvLWV4cGVjdGVkLmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L3RleHQvYWRsYW0tZGlyLWF1dG8tZXhwZWN0ZWQuaHRtbApuZXcgZmls ZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwLi5kOGQwN2RhZGM1OGU1YmM4NmY4MTc1ZjdjMWZmZTNmYmVlYjJhMmE0Ci0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2FkbGFtLWRpci1hdXRvLWV4cGVjdGVkLmh0 bWwKQEAgLTAsMCArMSw5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGhlYWQ+Cis8L2hl YWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRoYXQgQWRsYW0gdGV4dCBpcyByaWdo dC1hbGlnbmVkIHdoZW4gZGlyPWF1dG8uIFRoZSB0ZXN0IHBhc3NlcyBpZiB0aGUgQWRsYW0gdGV4 dCBpcyBvbiB0aGUgcmlnaHQgc2lkZSBvZiB0aGUgcGFnZS4KKzxkaXYgZGlyPSJydGwiIHN0eWxl PSJmb250LXNpemU6IDQ4cHg7Ij4mI3gxRTkzNTs8L2Rpdj4KKzwvYm9keT4KKzwvaHRtbD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9hZGxhbS1kaXItYXV0by5odG1sIGIvTGF5 b3V0VGVzdHMvZmFzdC90ZXh0L2FkbGFtLWRpci1hdXRvLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMWVmYTFh YTE5NGIxMjM5NzdiNjllYzNmYmIxNmZjYzQ5YTVmNzUwNAotLS0gL2Rldi9udWxsCisrKyBiL0xh eW91dFRlc3RzL2Zhc3QvdGV4dC9hZGxhbS1kaXItYXV0by5odG1sCkBAIC0wLDAgKzEsOSBAQAor PCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxoZWFkPgorPC9oZWFkPgorPGJvZHk+CitUaGlzIHRl c3QgbWFrZXMgc3VyZSB0aGF0IEFkbGFtIHRleHQgaXMgcmlnaHQtYWxpZ25lZCB3aGVuIGRpcj1h dXRvLiBUaGUgdGVzdCBwYXNzZXMgaWYgdGhlIEFkbGFtIHRleHQgaXMgb24gdGhlIHJpZ2h0IHNp ZGUgb2YgdGhlIHBhZ2UuCis8ZGl2IGRpcj0iYXV0byIgc3R5bGU9ImZvbnQtc2l6ZTogNDhweDsi PiYjeDFFOTM1OzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgo=