220870 2021-01-22 11:11:13 -0800 [webkitpy][GTK] Xvfb driver fails to start with python3 2021-01-22 16:00:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura bugs-noreply ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1721633 0 lmoura 2021-01-22 11:11:13 -0800 Sample command: python3 Tools/Scripts/run-webdriver-tests --verbose --gtk --release --display-server=xvfb Running inside flatpak gives the trace below. Hangs silently running from the desktop at the same point, regardless of inside Flatpak or outside it. Traceback (most recent call last): File "Tools/Scripts/run-webdriver-tests", line 84, in <module> runner = WebDriverTestRunner(port) File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py", line 63, in __init__ env = self._display_driver._setup_environ_for_test() File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 99, in _setup_environ_for_test display_id = self._xvfb_run(port_server_environment) File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 87, in _xvfb_run display_id = self._xvfb_read_display_id(read_fd) File "/home/lauro/dev/WebKit/Tools/Scripts/webkitpy/port/xvfbdriver.py", line 63, in _xvfb_read_display_id fd_list = select.select(fd_set, [], [])[0] KeyboardInterrupt 1721634 1 lmoura 2021-01-22 11:12:13 -0800 Oops. There was bug210698 with the same issue. Closing this one. *** This bug has been marked as a duplicate of bug 210698 *** 1721637 2 lmoura 2021-01-22 11:13:26 -0800 Actually, reopening to track in this one, as the description is more precise. (Sorry for the noise) 1721703 3 418177 lmoura 2021-01-22 13:41:04 -0800 Created attachment 418177 Patch 1721704 4 lmoura 2021-01-22 13:43:58 -0800 The style checker failed due to set_inheritable missing from the `os` module, but it's guarded by a check for py3. 1721757 5 ews-feeder 2021-01-22 15:59:53 -0800 Committed r271764: <https://trac.webkit.org/changeset/271764> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418177. 1721758 6 webkit-bug-importer 2021-01-22 16:00:15 -0800 <rdar://problem/73519495> 418177 2021-01-22 13:41:04 -0800 2021-01-22 15:59:54 -0800 Patch bug-220870-20210122184103.patch text/plain 3470 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOWU1NTM5YTQzZWI0MjhlOGIzZTgxMjg0YWQ0YWZjNmFi YWMyY2IxNS4uZTFmZGYyNTNmMjA2M2UxZGJiYmFmMjM2MTBlMmQyYjQ3NTA3NjBhNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5 IEBACisyMDIxLTAxLTIyICBMYXVybyBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAg ICAgIFt3ZWJraXRweV1bR1RLXSBYdmZiIGRyaXZlciBmYWlscyB0byBzdGFydCB3aXRoIHB5dGhv bjMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDg3 MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFB5dGhv bjIgYW5kIFB5dGhvbjMgZGlmZmVyIGluIGhvdyB0aGV5IGhhbmRsZSBmaWxlIGRlc2NyaXB0b3Ig aW5oZXJpdGFuY2UKKyAgICAgICAgYW5kIFBvcGVuJ3MgY2xvc2VfZmRzIGRlZmF1bHQgdmFsdWUu CisKKyAgICAgICAgSW4gUHl0aG9uMiwgb3MucGlwZSBjcmVhdGVzIHRoZSBmZHMgd2l0aCB0aGUg aW5oZXJpdGFibGUgZmxhZyBzZXQsIGFuZAorICAgICAgICBQb3BlbidzIGNsb3NlX2ZkcyBkZWZh dWx0cyB0byBUcnVlLgorCisgICAgICAgIEluIFB5dGhvbjMsIG9zLnBpcGUgY3JlYXRlcyB0aGUg ZmRzIG5vbi1pbmhlcml0YWJsZSwgcmVxdWlyaW5nIGEgY2FsbAorICAgICAgICB0byBvcy5zZXRf aW5oZXJpdGFibGUgdG8gZW5hYmxlIGl0LiBBbHNvLCBQb3BlbidzIGNsb3NlX2ZkcyBkZWZhdWx0 cworICAgICAgICB0byBGYWxzZSwgY2xvc2luZyBhbGwgZmlsZSBkZXNjcmlwdG9ycyBleGNlcHQg c3RkaW4sIHN0ZG91dCBhbmQgc3RkZXJyLgorCisgICAgICAgIFdpdGggdGhpcyBjb21taXQsIFB5 dGhvbjMgaXMgYWJsZSB0byBsYXVuY2ggdGhlIFh2ZmIgZHJpdmVyIGZvcgorICAgICAgICBydW4t d2ViZHJpdmVyLXRlc3RzLCBidXQgaXMgc3RpbGwgZmFpbGluZyBsYXRlciB3aXRoIHNvbWUgcHl0 ZXN0IGlzc3VlCisgICAgICAgIHRvIGJlIHRyYWNrZWQgaW4gYW5vdGhlciBidWcuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQveHZmYmRyaXZlci5weToKKyAgICAgICAgKFh2ZmJE cml2ZXIuX3h2ZmJfcGlwZSk6IE1ha2UgdGhlIHdyaXRlX2ZkIGluaGVyaXRhYmxlIGlmIGluIHB5 My4KKyAgICAgICAgKFh2ZmJEcml2ZXIuX3h2ZmJfcmVhZF9kaXNwbGF5X2lkKTogRW5jb2RlIGZv ciBweTMgYnl0ZXMgY29tcGF0aWJpbGl0eS4KKyAgICAgICAgKFh2ZmJEcml2ZXIuX3h2ZmJfcnVu KTogVGVsbCBwb3BlbiB0byBrZWVwIHRoZSBmaWxlIGRlc2NyaXB0b3JzIG9wZW4uCisKIDIwMjEt MDEtMjIgIExhdXJvIE1vdXJhICA8bG1vdXJhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW1dlYkRy aXZlcl0gQWRkIGluZm8gYWJvdXQgaW1wb3J0aW5nIHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3dlYmtpdHB5L3BvcnQveHZmYmRyaXZlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvcG9ydC94dmZiZHJpdmVyLnB5CmluZGV4IDVhNmZhMWNkNDUyMjMwMmM4ZjI2NjE0YmViMDUx NTE3ZWRjYTBhN2EuLmNiZDA4NjAxMmY5NDI4MDUxZjdmMWU4MjVlMGE1ODI0OTU2NWJlNzkgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC94dmZiZHJpdmVyLnB5CisrKyBi L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC94dmZiZHJpdmVyLnB5CkBAIC0yOSw5ICsyOSwx MSBAQAogCiBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9zCitpbXBvcnQgc3lzCiBpbXBvcnQgcmUK IGltcG9ydCB0aW1lCiAKK2Zyb20gd2Via2l0Y29yZXB5IGltcG9ydCBzdHJpbmdfdXRpbHMKIGZy b20gd2Via2l0cHkucG9ydC5zZXJ2ZXJfcHJvY2VzcyBpbXBvcnQgU2VydmVyUHJvY2VzcwogZnJv bSB3ZWJraXRweS5wb3J0LmRyaXZlciBpbXBvcnQgRHJpdmVyCiAKQEAgLTUwLDcgKzUyLDEzIEBA IGNsYXNzIFh2ZmJEcml2ZXIoRHJpdmVyKToKICAgICAgICAgcmV0dXJuIHh2ZmJfZm91bmQKIAog ICAgIGRlZiBfeHZmYl9waXBlKHNlbGYpOgotICAgICAgICByZXR1cm4gb3MucGlwZSgpCisgICAg ICAgIHJlYWRfZmQsIHdyaXRlX2ZkID0gb3MucGlwZSgpCisKKyAgICAgICAgIyBCeSBkZWZhdWx0 LCBweXRob24zIGNyZWF0ZXMgZmlsZSBkZXNjcmlwdG9ycyBhcyBub24taW5oZXJpdGFibGUKKyAg ICAgICAgaWYgc3lzLnZlcnNpb25faW5mby5tYWpvciA9PSAzOgorICAgICAgICAgICAgb3Muc2V0 X2luaGVyaXRhYmxlKHdyaXRlX2ZkLCBUcnVlKQorCisgICAgICAgIHJldHVybiAocmVhZF9mZCwg d3JpdGVfZmQpCiAKICAgICBkZWYgX3h2ZmJfcmVhZF9kaXNwbGF5X2lkKHNlbGYsIHJlYWRfZmQp OgogICAgICAgICBpbXBvcnQgZXJybm8KQEAgLTY3LDcgKzc1LDcgQEAgY2xhc3MgWHZmYkRyaXZl cihEcml2ZXIpOgogCiAgICAgICAgICAgICBpZiByZWFkX2ZkIGluIGZkX2xpc3Q6CiAgICAgICAg ICAgICAgICAgIyBXZSBvbmx5IGV4cGVjdCBhIG51bWJlciwgc28gZmlyc3QgcmVhZCBzaG91bGQg YmUgZW5vdWdoLgotICAgICAgICAgICAgICAgIGRpc3BsYXlfaWQgPSBvcy5yZWFkKHJlYWRfZmQs IDI1Nikuc3RyaXAoJ1xuJykKKyAgICAgICAgICAgICAgICBkaXNwbGF5X2lkID0gb3MucmVhZChy ZWFkX2ZkLCAyNTYpLnN0cmlwKHN0cmluZ191dGlscy5lbmNvZGUoJ1xuJykpCiAgICAgICAgICAg ICAgICAgZmRfc2V0ID0gW10KIAogICAgICAgICByZXR1cm4gaW50KGRpc3BsYXlfaWQpCkBAIC04 Miw3ICs5MCw4IEBAIGNsYXNzIFh2ZmJEcml2ZXIoRHJpdmVyKToKICAgICAgICAgaWYgc2VsZi5f cG9ydC5fc2hvdWxkX3VzZV9qaGJ1aWxkKCk6CiAgICAgICAgICAgICBydW5feHZmYiA9IHNlbGYu X3BvcnQuX2poYnVpbGRfd3JhcHBlciArIHJ1bl94dmZiCiAgICAgICAgIHdpdGggb3Blbihvcy5k ZXZudWxsLCAndycpIGFzIGRldm51bGw6Ci0gICAgICAgICAgICBzZWxmLl94dmZiX3Byb2Nlc3Mg PSBzZWxmLl9wb3J0Lmhvc3QuZXhlY3V0aXZlLnBvcGVuKHJ1bl94dmZiLCBzdGRlcnI9ZGV2bnVs bCwgZW52PWVudmlyb25tZW50KQorICAgICAgICAgICAgIyBweXRob24zIHdpbGwgdHJ5IHRvIGNs b3NlIHRoZSBmaWxlIGRlc2NyaXB0b3JzIGJ5IGRlZmF1bHQKKyAgICAgICAgICAgIHNlbGYuX3h2 ZmJfcHJvY2VzcyA9IHNlbGYuX3BvcnQuaG9zdC5leGVjdXRpdmUucG9wZW4ocnVuX3h2ZmIsIHN0 ZGVycj1kZXZudWxsLCBlbnY9ZW52aXJvbm1lbnQsIGNsb3NlX2Zkcz1GYWxzZSkKICAgICAgICAg ICAgIGRpc3BsYXlfaWQgPSBzZWxmLl94dmZiX3JlYWRfZGlzcGxheV9pZChyZWFkX2ZkKQogCiAg ICAgICAgIHNlbGYuX3h2ZmJfY2xvc2VfcGlwZSgocmVhZF9mZCwgd3JpdGVfZmQpKQo=