<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22087</bug_id>
          
          <creation_ts>2008-11-05 13:25:23 -0800</creation_ts>
          <short_desc>Need correct platform defines for Mac Chromium.</short_desc>
          <delta_ts>2008-11-13 10:10:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Mike Pinkerton">pinkerton</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>97728</commentid>
    <comment_count>0</comment_count>
    <who name="Mike Pinkerton">pinkerton</who>
    <bug_when>2008-11-05 13:25:23 -0800</bug_when>
    <thetext>Sets the appropriate platform defines for Mac Chromium, which behaves a lot like platform(mac), ie CG/CF/ATSUI/etc but won&apos;t be defining PLATFORM(MAC) because, well, it&apos;s not. :-)

patch upcoming...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>97729</commentid>
    <comment_count>1</comment_count>
      <attachid>24916</attachid>
    <who name="Mike Pinkerton">pinkerton</who>
    <bug_when>2008-11-05 13:25:58 -0800</bug_when>
    <thetext>Created attachment 24916
patch file</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>97730</commentid>
    <comment_count>2</comment_count>
      <attachid>24916</attachid>
    <who name="Sam Weinig">sam</who>
    <bug_when>2008-11-05 13:34:17 -0800</bug_when>
    <thetext>Comment on attachment 24916
patch file

You have some tabs in the ChangeLog, but otherwise, r=me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>98281</commentid>
    <comment_count>3</comment_count>
    <who name="Mike Pinkerton">pinkerton</who>
    <bug_when>2008-11-11 06:34:43 -0800</bug_when>
    <thetext>this patch has been sitting with review+ for about a week, can someone land it? thanks ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>98617</commentid>
    <comment_count>4</comment_count>
    <who name="Sam Weinig">sam</who>
    <bug_when>2008-11-13 10:10:14 -0800</bug_when>
    <thetext>Landed in r38372.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>24916</attachid>
            <date>2008-11-05 13:25:58 -0800</date>
            <delta_ts>2008-11-05 13:34:17 -0800</delta_ts>
            <desc>patch file</desc>
            <filename>platform.patch</filename>
            <type>text/plain</type>
            <size>1350</size>
            <attacher name="Mike Pinkerton">pinkerton</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDM4MTMyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDgtMTEtMDUgIE1pa2UgUGlu
a2VydG9uICA8cGlua2VydG9uQGNocm9taXVtLm9yZz4KKworCVNldCB0aGUgYXBwcm9wcmlhdGUg
cGxhdGZvcm0gZGVmaW5lcyBmb3IgTWFjIENocm9taXVtLCB3aGljaCBpcworCXNpbWlsYXIgdG8g
UExBVEZPUk0oTUFDKSwgYnV0IGlzbid0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisKIDIwMDgtMTEtMDUgIEFuZGVy
cyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggU25vdyBMZW9w
YXJkIGJ1aWxkLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDM4MTIyKQorKysg
SmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyNiwxMCAr
MTI2LDE2IEBACiAjZGVmaW5lIFdURl9QTEFURk9STV9DSSAxCiAjZW5kaWYKIAotLyogUExBVEZP
Uk0oU0tJQSkgKi8KKy8qIFBMQVRGT1JNKFNLSUEpIGZvciBXaW4vTGludXgsIENHL0NJIGZvciBN
YWMgKi8KICNpZiBQTEFURk9STShDSFJPTUlVTSkKKyNpZiBQTEFURk9STShEQVJXSU4pCisjZGVm
aW5lIFdURl9QTEFURk9STV9DRyAxCisjZGVmaW5lIFdURl9QTEFURk9STV9DSSAxCisjZGVmaW5l
IFdURl9VU0VfQVRTVUkgMQorI2Vsc2UKICNkZWZpbmUgV1RGX1BMQVRGT1JNX1NLSUEgMQogI2Vu
ZGlmCisjZW5kaWYKIAogLyogTWFrZXMgUExBVEZPUk0oV0lOKSBkZWZhdWx0IHRvIFBMQVRGT1JN
KENBSVJPKSAqLwogI2lmICFQTEFURk9STShNQUMpICYmICFQTEFURk9STShRVCkgJiYgIVBMQVRG
T1JNKFdYKQpAQCAtMjY0LDYgKzI3MCwxMSBAQAogI2VuZGlmCiAjZW5kaWYKIAorI2lmIFBMQVRG
T1JNKENIUk9NSVVNKSAmJiBQTEFURk9STShEQVJXSU4pCisjZGVmaW5lIFdURl9QTEFURk9STV9D
RiAxCisjZGVmaW5lIFdURl9VU0VfUFRIUkVBRFMgMQorI2VuZGlmCisKICNpZiBQTEFURk9STShX
SU4pCiAjZGVmaW5lIFdURl9VU0VfV0lOSU5FVCAxCiAjZW5kaWYK
</data>
<flag name="review"
          id="11429"
          type_id="1"
          status="+"
          setter="sam"
    />
          </attachment>
      

    </bug>

</bugzilla>