220860 2021-01-22 06:55:28 -0800 [GTK] run-gtk-tests: Use sys.exit(1) instead of return 1 2021-01-25 02:24:13 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aboya aboya pnormand webkit-bug-importer oldest_to_newest 1721578 0 aboya 2021-01-22 06:55:28 -0800 Several parts of the code in api_test_runner.py returned 1 on failure. While common for main() functions, this is bad in functions that are expected to return something else than an exit code, and lets the program run after the error. sys.exit(1) should be used in those cases instead. 1721579 1 418146 aboya 2021-01-22 07:04:01 -0800 Created attachment 418146 Patch 1721997 2 ews-feeder 2021-01-25 02:23:12 -0800 Committed r271789: <https://trac.webkit.org/changeset/271789> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418146. 1721998 3 webkit-bug-importer 2021-01-25 02:24:13 -0800 <rdar://problem/73564098> 418146 2021-01-22 07:04:01 -0800 2021-01-25 02:23:13 -0800 Patch bug-220860-20210122160405.patch text/plain 1902 aboya U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzU2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZmY1NThhMjUyNDc3YmE0ODllMDY0OGZiOWQ4NjQ0YmVl ZTI1MThlNy4uZWY1NGJhZWQwODg0MjNmNjllODAxNmY3NmEyMzEyOTBmNjNjYmE4MiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDIxLTAxLTIyICBBbGljaWEgQm95YSBHYXJjw61hICA8YWJveWFAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBydW4tZ3RrLXRlc3RzOiBVc2Ugc3lzLmV4aXQoMSkgaW5zdGVhZCBv ZiByZXR1cm4gMQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIwODYwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgU2V2ZXJhbCBwYXJ0cyBvZiB0aGUgY29kZSBpbiBhcGlfdGVzdF9ydW5uZXIucHkgcmV0dXJu ZWQgMSBvbiBmYWlsdXJlLgorICAgICAgICBXaGlsZSBjb21tb24gZm9yIG1haW4oKSBmdW5jdGlv bnMsIHRoaXMgaXMgYmFkIGluIGZ1bmN0aW9ucyB0aGF0IGFyZQorICAgICAgICBleHBlY3RlZCB0 byByZXR1cm4gc29tZXRoaW5nIGVsc2UgdGhhbiBhbiBleGl0IGNvZGUsIGFuZCBsZXRzIHRoZQor ICAgICAgICBwcm9ncmFtIHJ1biBhZnRlciB0aGUgZXJyb3IuIHN5cy5leGl0KDEpIHNob3VsZCBi ZSB1c2VkIGluIHRob3NlIGNhc2VzCisgICAgICAgIGluc3RlYWQuCisKKyAgICAgICAgKiBnbGli L2FwaV90ZXN0X3J1bm5lci5weToKKyAgICAgICAgKFRlc3RSdW5uZXIuX2dldF90ZXN0c19mcm9t X2dvb2dsZV90ZXN0X3N1aXRlKToKKyAgICAgICAgKFRlc3RSdW5uZXIucnVuX3Rlc3RzKToKKwog MjAyMS0wMS0wOSAgTGF1cm8gTW91cmEgIDxsbW91cmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBb R1N0cmVhbWVyXSBCdWlsZCBmYWlsdXJlIHdpdGggZ3N0LWJ1aWxkOiBNaXNzaW5nIGdzdC9hdWRp by9hdWRpby5oCmRpZmYgLS1naXQgYS9Ub29scy9nbGliL2FwaV90ZXN0X3J1bm5lci5weSBiL1Rv b2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CmluZGV4IGYzZGE4ZjgwNGIyNTI0OWExODJiMTNm OWI2MjAzNmYwMWQ4OTQxYTYuLmE1OTRkZmE4NzZmNTFhZjAxNjYxYmM2MWM2YzE5MzNmZjQwMWI4 MGQgMTAwNzU1Ci0tLSBhL1Rvb2xzL2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CisrKyBiL1Rvb2xz L2dsaWIvYXBpX3Rlc3RfcnVubmVyLnB5CkBAIC0yMDMsNyArMjAzLDcgQEAgY2xhc3MgVGVzdFJ1 bm5lcihvYmplY3QpOgogICAgICAgICBleGNlcHQgc3VicHJvY2Vzcy5DYWxsZWRQcm9jZXNzRXJy b3I6CiAgICAgICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCJFUlJPUjogY291bGQgbm90IGxpc3Qg YXZhaWxhYmxlIHRlc3RzIGZvciBiaW5hcnkgJXMuXG4iICUgKHRlc3RfcHJvZ3JhbSkpCiAgICAg ICAgICAgICBzeXMuc3RkZXJyLmZsdXNoKCkKLSAgICAgICAgICAgIHJldHVybiAxCisgICAgICAg ICAgICBzeXMuZXhpdCgxKQogCiAgICAgICAgIHRlc3RzID0gW10KICAgICAgICAgcHJlZml4ID0g Tm9uZQpAQCAtMjgyLDcgKzI4Miw3IEBAIGNsYXNzIFRlc3RSdW5uZXIob2JqZWN0KToKICAgICAg ICAgaWYgbm90IHNlbGYuX3Rlc3RzOgogICAgICAgICAgICAgc3lzLnN0ZGVyci53cml0ZSgiRVJS T1I6IHRlc3RzIG5vdCBmb3VuZCBpbiAlcy5cbiIgJSAoc2VsZi5fdGVzdF9wcm9ncmFtc19iYXNl X2RpcigpKSkKICAgICAgICAgICAgIHN5cy5zdGRlcnIuZmx1c2goKQotICAgICAgICAgICAgcmV0 dXJuIDEKKyAgICAgICAgICAgIHN5cy5leGl0KDEpCiAKICAgICAgICAgc2VsZi5fc2V0dXBfdGVz dGluZ19lbnZpcm9ubWVudCgpCiAK