220846 2021-01-22 00:16:23 -0800 WebGL powerPreference is not tested 2022-10-25 13:32:10 -0700 1 1 1 Unclassified WebKit WebGL Other Unspecified Unspecified NEW InRadar P2 Normal --- 220843 1 kkinnunen kkinnunen ahmad.saleem792 ap dino kbr webkit-bug-importer oldest_to_newest 1721501 0 kkinnunen 2021-01-22 00:16:23 -0800 Needs - tests - interface to check if integrated GPU is on - interface to check if has discrete GPU - interface to flush the shutdown timer of discrete GPU 1721503 1 418113 kkinnunen 2021-01-22 00:23:21 -0800 Created attachment 418113 Patch 1721832 2 418113 kbr 2021-01-23 00:25:02 -0800 Comment on attachment 418113 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418113&action=review Looks good to me. r+ > LayoutTests/fast/canvas/webgl/high-performance-context.html:14 > +description("Tests that a high-performance contexts do not fail."); "contexts do not" -> "context does not" > LayoutTests/fast/canvas/webgl/high-performance-context.html:19 > +var wtu = WebGLTestUtils; Nowadays, prefer "let" (or "const") over "var". 1722789 3 kbr 2021-01-26 17:26:15 -0800 In case they're useful, here are some related tests run against Chromium: https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/gpu_process_integration_test.py;l=112?q=gpu_process_integration_test https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/pixel_test_pages.py;l=642 the latter of which reference helper functions in this file: https://source.chromium.org/chromium/chromium/src/+/master:content/test/gpu/gpu_tests/pixel_integration_test.py;l=221 1723641 4 webkit-bug-importer 2021-01-29 00:17:17 -0800 <rdar://problem/73744012> 1908209 5 ahmad.saleem792 2022-10-25 13:32:10 -0700 Looks like this r+ patch didn't landed and I checked via BugID on Webkit GitHub. Just wanted to update. Thanks! 418113 2021-01-22 00:23:21 -0800 2021-01-23 00:25:02 -0800 Patch bug-220846-20210122102317.patch text/plain 3181 kkinnunen U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNTM3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMzNhY2FjYjc4OTA5MjEyYWRmOGNm ZWM3OGE1YzUxNjc0ZGNlZWJiOS4uZjkzZjhhNGRmYzZiNGU0M2JiYTcwMTYyN2ZiZWZhYTgyMmY2 MDZmOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAxLTIyICBLaW1tbyBLaW5udW5lbiAg PGtraW5udW5lbkBhcHBsZS5jb20+CisKKyAgICAgICAgV2ViR0wgcG93ZXJQcmVmZXJlbmNlIGlz IG5vdCB0ZXN0ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTIyMDg0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdJUDogcGxhY2Vob2xkZXIKKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2hpZ2gt cGVyZm9ybWFuY2UtY29udGV4dC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3Qv Y2FudmFzL3dlYmdsL2hpZ2gtcGVyZm9ybWFuY2UtY29udGV4dC5odG1sOiBBZGRlZC4KKwogMjAy MS0wMS0xNSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAg IEFYOiBpbmNyZW1lbnQvZGVjcmVtZW50IHN5bnRoZXRpYyBhcnJvdyBldmVudHMgZG9uJ3Qgd29y ayBpbiBBUklBIHNsaWRlciBleGFtcGxlcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvaGlnaC1wZXJmb3JtYW5jZS1jb250ZXh0LWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2hpZ2gtcGVyZm9ybWFuY2UtY29udGV4dC1leHBlY3Rl ZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uY2JiNDBmOTIxYjk3MzMwMzBjYmMzNmFjNzY5ZDE0YzE1YTJjOWFh YgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2hpZ2gt cGVyZm9ybWFuY2UtY29udGV4dC1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGVzdHMg dGhhdCBhIGhpZ2gtcGVyZm9ybWFuY2UgY29udGV4dHMgZG8gbm90IGZhaWwuCisKK09uIHN1Y2Nl c3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5 ICJURVNUIENPTVBMRVRFIi4KKworUEFTUyBnbC5nZXRDb250ZXh0QXR0cmlidXRlcygpLnBvd2Vy UHJlZmVyZW5jZSBpcyAiaGlnaC1wZXJmb3JtYW5jZSIKK1BBU1MgcHJvZ3JhbSAhPSBudWxsIGlz IHRydWUKK1BBU1MgZ2V0RXJyb3Igd2FzIGV4cGVjdGVkIHZhbHVlOiBOT19FUlJPUiA6IFNob3Vs ZCBiZSBubyBlcnJvcnMgZnJvbSBzZXR1cC4KK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy93ZWJnbC9oaWdoLXBlcmZvcm1hbmNlLWNvbnRleHQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL3dlYmdsL2hpZ2gtcGVyZm9ybWFuY2UtY29udGV4dC5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmYx MTEyZmVhOTJjMTMwZGFjNTEwMzA5ZmRlZjYwYjM4OWU2YTdhYjQKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9oaWdoLXBlcmZvcm1hbmNlLWNvbnRleHQu aHRtbApAQCAtMCwwICsxLDQxIEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICA8aGVhZD4K KyAgPG1ldGEgY2hhcnNldD0idXRmLTgiPgorICAgIDx0aXRsZT5IaWdoIHBlcmZvcm1hbmNlIFdl YkdMIGNvbnRleHQgdGVzdDwvdGl0bGU+CisgICAgPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291 cmNlcy9qcy10ZXN0LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3dl YmdsLXRlc3QuanMiPiA8L3NjcmlwdD4KKyAgICA8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3dlYmds LXRlc3QtdXRpbHMuanMiPiA8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGRpdiBpZD0iZGVz Y3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Cis8c2NyaXB0PgorZGVz Y3JpcHRpb24oIlRlc3RzIHRoYXQgYSBoaWdoLXBlcmZvcm1hbmNlIGNvbnRleHRzIGRvIG5vdCBm YWlsLiIpOworaWYgKHdpbmRvdy50ZXN0UnVubmVyKSB7CisgICAgdGVzdFJ1bm5lci5kdW1wQXNU ZXh0KCk7CisgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7Cit9Cit2YXIgd3R1ID0gV2Vi R0xUZXN0VXRpbHM7Cit2YXIgY2FudmFzID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnY2FudmFz Jyk7CitjYW52YXMuYWRkRXZlbnRMaXN0ZW5lcigid2ViZ2xjb250ZXh0Y2hhbmdlZCIsICgpID0+ IHsKKyAgICB0ZXN0UnVubmVyLm5vdGlmeURvbmUoKTsKK30sIGZhbHNlKTsKK3ZhciBnbCA9IHd0 dS5jcmVhdGUzRENvbnRleHQoY2FudmFzLCB7IHBvd2VyUHJlZmVyZW5jZTogImhpZ2gtcGVyZm9y bWFuY2UiIH0pOworc2hvdWxkQmUoImdsLmdldENvbnRleHRBdHRyaWJ1dGVzKCkucG93ZXJQcmVm ZXJlbmNlIiwgJyJoaWdoLXBlcmZvcm1hbmNlIicpOworY2FudmFzLndpZHRoID0gMjAwOworY2Fu dmFzLmhlaWdodCA9IDIwMDsKK2dsLnZpZXdwb3J0KDAsIDAsIDAsIDApOwordmFyIHByb2dyYW0g PSB3dHUuc2V0dXBUZXh0dXJlZFF1YWQoZ2wpOworc2hvdWxkQmVUcnVlKCJwcm9ncmFtICE9IG51 bGwiKTsKK3ZhciB0ZXggPSBnbC5jcmVhdGVUZXh0dXJlKCk7CitnbC5iaW5kVGV4dHVyZShnbC5U RVhUVVJFXzJELCB0ZXgpOwordmFyIHBpeGVsID0gbmV3IFVpbnQ4QXJyYXkoWzAsIDI1NSwgMCwg MjU1XSk7CitnbC50ZXhJbWFnZTJEKAorICBnbC5URVhUVVJFXzJELCAwLCBnbC5SR0JBLCAxLCAx LCAwLCBnbC5SR0JBLCBnbC5VTlNJR05FRF9CWVRFLCBwaXhlbCk7Cit3dHUuZHJhd1F1YWQoZ2wp OworCitnbEVycm9yU2hvdWxkQmUoZ2wsIGdsLk5PX0VSUk9SLCAiU2hvdWxkIGJlIG5vIGVycm9y cyBmcm9tIHNldHVwLiIpOworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+Cg==