220836 2021-01-21 17:04:48 -0800 [ews] Commit Queue should retry the build when update-working-directory step fails 2021-01-30 12:23:46 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap bburg jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1721420 0 aakash_jain 2021-01-21 17:04:48 -0800 Commit Queue should retry the build when update-working-directory step fails. This would make Commit-Queue more robust against temporary flaky issues. e.g.: https://ews-build.webkit.org/#/builders/28/builds/8103 failed but passed in retry in https://ews-build.webkit.org/#/builders/28/builds/8109 1721423 1 418101 aakash_jain 2021-01-21 17:07:41 -0800 Created attachment 418101 Patch 1722228 2 aakash_jain 2021-01-25 13:17:44 -0800 Tested in https://ews-build.webkit-uat.org/#/builders/9/builds/779 (style-queue also uses same build step) 1722235 3 ews-feeder 2021-01-25 13:29:10 -0800 Committed r271812: <https://trac.webkit.org/changeset/271812> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418101. 1722237 4 webkit-bug-importer 2021-01-25 13:30:15 -0800 <rdar://problem/73586025> 1724057 5 aakash_jain 2021-01-30 12:23:46 -0800 This helped, e.g.: https://ews-build.webkit.org/#/builders/28/builds/8276, https://ews-build.webkit.org/#/builders/28/builds/8278 418101 2021-01-21 17:07:41 -0800 2021-01-25 13:29:10 -0800 Patch bug-220836-20210121200741.patch text/plain 2762 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MTcyMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAxLTIxICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBDb21taXQgUXVldWUgc2hvdWxkIHJldHJ5IHRoZSBidWlsZCB3 aGVuIHVwZGF0ZS13b3JraW5nLWRpcmVjdG9yeSBzdGVwIGZhaWxzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4MzYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3Rl cHMucHk6CisgICAgICAgIChVcGRhdGVXb3JraW5nRGlyZWN0b3J5KToKKyAgICAgICAgKFVwZGF0 ZVdvcmtpbmdEaXJlY3RvcnkuZ2V0UmVzdWx0U3VtbWFyeSk6IFByb3ZpZGUgYmV0dGVyIGZhaWx1 cmUgbWVzc2FnZS4KKyAgICAgICAgKFVwZGF0ZVdvcmtpbmdEaXJlY3RvcnkuZXZhbHVhdGVDb21t YW5kKTogUmV0cnkgdGhlIGJ1aWxkIHdoZW4gdGhpcyBzdGVwIGZhaWxzLgorICAgICAgICAqIENJ U3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisKIDIwMjEtMDEtMjEgIEFha2Fz aCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBzZXR1cC1j b21taXQtcXVldWUuc2ggZm9yIGdpdGh1YiByZXBvCkluZGV4OiBUb29scy9DSVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkJKHJldmlzaW9uIDI3MTcyMykKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQv c3RlcHMucHkJKHdvcmtpbmcgY29weSkKQEAgLTI0Myw3ICsyNDMsNiBAQCBjbGFzcyBDbGVhbldv cmtpbmdEaXJlY3Rvcnkoc2hlbGwuU2hlbGxDCiBjbGFzcyBVcGRhdGVXb3JraW5nRGlyZWN0b3J5 KHNoZWxsLlNoZWxsQ29tbWFuZCk6CiAgICAgbmFtZSA9ICd1cGRhdGUtd29ya2luZy1kaXJlY3Rv cnknCiAgICAgZGVzY3JpcHRpb24gPSBbJ3VwZGF0ZS13b3JrcmluZy1kaXJlY3RvcnkgcnVubmlu ZyddCi0gICAgZGVzY3JpcHRpb25Eb25lID0gWydVcGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5J10K ICAgICBmbHVua09uRmFpbHVyZSA9IFRydWUKICAgICBoYWx0T25GYWlsdXJlID0gVHJ1ZQogICAg IGNvbW1hbmQgPSBbJ3BlcmwnLCAnVG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0J10KQEAgLTI1 MSw2ICsyNTAsMTggQEAgY2xhc3MgVXBkYXRlV29ya2luZ0RpcmVjdG9yeShzaGVsbC5TaGVsbAog ICAgIGRlZiBfX2luaXRfXyhzZWxmLCAqKmt3YXJncyk6CiAgICAgICAgIHN1cGVyKFVwZGF0ZVdv cmtpbmdEaXJlY3RvcnksIHNlbGYpLl9faW5pdF9fKGxvZ0Vudmlyb249RmFsc2UsICoqa3dhcmdz KQogCisgICAgZGVmIGdldFJlc3VsdFN1bW1hcnkoc2VsZik6CisgICAgICAgIGlmIHNlbGYucmVz dWx0cyAhPSBTVUNDRVNTOgorICAgICAgICAgICAgcmV0dXJuIHt1J3N0ZXAnOiB1J0ZhaWxlZCB0 byB1cGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5J30KKyAgICAgICAgZWxzZToKKyAgICAgICAgICAg IHJldHVybiB7dSdzdGVwJzogdSdVcGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5J30KKworICAgIGRl ZiBldmFsdWF0ZUNvbW1hbmQoc2VsZiwgY21kKToKKyAgICAgICAgcmMgPSBzaGVsbC5TaGVsbENv bW1hbmQuZXZhbHVhdGVDb21tYW5kKHNlbGYsIGNtZCkKKyAgICAgICAgaWYgcmMgPT0gRkFJTFVS RToKKyAgICAgICAgICAgIHNlbGYuYnVpbGQuYnVpbGRGaW5pc2hlZChbJ0dpdCBpc3N1ZSwgcmV0 cnlpbmcgYnVpbGQnXSwgUkVUUlkpCisgICAgICAgIHJldHVybiByYworCiAKIGNsYXNzIEFwcGx5 UGF0Y2goc2hlbGwuU2hlbGxDb21tYW5kLCBDb21wb3NpdGVTdGVwTWl4aW4pOgogICAgIG5hbWUg PSAnYXBwbHktcGF0Y2gnCkluZGV4OiBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3Vu aXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNf dW5pdHRlc3QucHkJKHJldmlzaW9uIDI3MTcyMykKKysrIFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVp bGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAgLTIyNjgsNyArMjI2OCw3IEBA IGNsYXNzIFRlc3RVcGRhdGVXb3JraW5nRGlyZWN0b3J5KEJ1aWxkU3QKICAgICAgICAgICAgICsg RXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nVW5leHBlY3RlZCBmYWlsdXJlLicpCiAg ICAgICAgICAgICArIDIsCiAgICAgICAgICkKLSAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJl c3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J1VwZGF0ZWQgd29ya2luZyBkaXJlY3RvcnkgKGZh aWx1cmUpJykKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJlc3VsdD1GQUlMVVJFLCBzdGF0 ZV9zdHJpbmc9J0ZhaWxlZCB0byB1cGRhdGVkIHdvcmtpbmcgZGlyZWN0b3J5JykKICAgICAgICAg cmV0dXJuIHNlbGYucnVuU3RlcCgpCiAKIAo=