22083 2008-11-05 07:36:00 -0800 MessageEvents cannot be used across threads 2008-11-05 23:07:49 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 97677 0 ap 2008-11-05 07:36:00 -0800 Patch forthcoming for a couple of issues: 1) MessageEvent bindings should not use static tables, as these events are used in workers. 2) MessagePort shouldn't store MessageEvents in its queue, as Event has an AtomicString member, and AtomicStrings cannot be moved across threads. 97678 1 24908 ap 2008-11-05 07:42:48 -0800 Created attachment 24908 proposed patch 97681 2 24908 mjs 2008-11-05 07:58:01 -0800 Comment on attachment 24908 proposed patch r=me 97781 3 ap 2008-11-05 23:07:49 -0800 Committed revision 38151. 24908 2008-11-05 07:42:48 -0800 2008-11-05 08:23:39 -0800 proposed patch MessageEvent.txt text/plain 6591 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODEyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjYgQEAKKzIwMDgtMTEtMDUgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4MworICAgICAgICBN ZXNzYWdlRXZlbnRzIGNhbm5vdCBiZSB1c2VkIGFjcm9zcyB0aHJlYWRzCisKKyAgICAgICAgKiBk b20vRXZlbnQuaWRsOgorICAgICAgICAqIGRvbS9NZXNzYWdlRXZlbnQuaWRsOgorICAgICAgICBB ZGQgYSBOb1N0YXRpY1RhYmxlcyBhdHRyaWJ1dGUgLSBNZXNzYWdlRXZlbnQgaXMgdXNlZCBpbiB3 b3JrZXIgdGhyZWFkcywgc28gc3RhdGljIHRhYmxlcworICAgICAgICB3b24ndCB3b3JrLgorCisg ICAgICAgICogZG9tL01lc3NhZ2VQb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lc3NhZ2VQ b3J0OjpFdmVudERhdGE6OkV2ZW50RGF0YSk6CisgICAgICAgIChXZWJDb3JlOjpNZXNzYWdlUG9y dDo6RXZlbnREYXRhOjp+RXZlbnREYXRhKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lc3NhZ2VQb3J0 OjpjbG9uZSk6CisgICAgICAgIChXZWJDb3JlOjpNZXNzYWdlUG9ydDo6cG9zdE1lc3NhZ2UpOgor ICAgICAgICAoV2ViQ29yZTo6TWVzc2FnZVBvcnQ6OnN0YXJ0Q29udmVyc2F0aW9uKToKKyAgICAg ICAgKFdlYkNvcmU6Ok1lc3NhZ2VQb3J0OjpkaXNwYXRjaE1lc3NhZ2VzKToKKyAgICAgICAgKiBk b20vTWVzc2FnZVBvcnQuaDoKKyAgICAgICAgRG9uJ3QgY3JlYXRlIGEgTWVzc2FnZUV2ZW50IHVu dGlsIGRpc3BhdGNoIHRpbWUgLSBtZXNzYWdlcyBjYW4gYmUgcG9zdGVkIGFjcm9zcyB0aHJlYWRz LAorICAgICAgICBidXQgTWVzc2FnZUV2ZW50cyBhcmUgdGllZCB0byB0aGUgdGhyZWFkIHRoYXQg dGhleSB3ZXJlIGNyZWF0ZWQgaW4uCisKIDIwMDgtMTEtMDUgIEplZmYgQ29vayAgPGNvb2tpZWNh cGVyQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubiBhbmQg VG9yIEFybmUuCkluZGV4OiBXZWJDb3JlL2RvbS9FdmVudC5pZGwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9kb20vRXZlbnQuaWRsCShyZXZpc2lvbiAzODExOSkKKysrIFdlYkNvcmUvZG9tL0V2ZW50 LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjMsNiArMjMsNyBAQCBtb2R1bGUgZXZlbnRzIHsKICAg ICAvLyBJbnRyb2R1Y2VkIGluIERPTSBMZXZlbCAyOgogICAgIGludGVyZmFjZSBbCiAgICAgICAg IEdlbmVyYXRlQ29uc3RydWN0b3IsCisgICAgICAgIE5vU3RhdGljVGFibGVzLAogICAgICAgICBP YmpDQ3VzdG9tSW50ZXJuYWxJbXBsLAogICAgICAgICBJbnRlcmZhY2VVVUlEPUQxNzQ5NUZBLUFD QUQtNGQyNy05MzYyLUUxOUUwNTdCMTg5RCwKICAgICAgICAgSW1wbGVtZW50YXRpb25VVUlEPUNG RENEREIyLTVCM0YtNDEyZC1CREE0LTgwQjIzQzcyMTU0OQpJbmRleDogV2ViQ29yZS9kb20vTWVz c2FnZUV2ZW50LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9NZXNzYWdlRXZlbnQuaWRs CShyZXZpc2lvbiAzODExOSkKKysrIFdlYkNvcmUvZG9tL01lc3NhZ2VFdmVudC5pZGwJKHdvcmtp bmcgY29weSkKQEAgLTI3LDcgKzI3LDggQEAKIG1vZHVsZSBldmVudHMgewogCiAgICAgaW50ZXJm YWNlIFsKLSAgICAgICAgR2VuZXJhdGVDb25zdHJ1Y3RvcgorICAgICAgICBHZW5lcmF0ZUNvbnN0 cnVjdG9yLAorICAgICAgICBOb1N0YXRpY1RhYmxlcwogICAgIF0gTWVzc2FnZUV2ZW50IDogRXZl bnQgewogCiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBET01TdHJpbmcgZGF0YTsKSW5kZXg6 IFdlYkNvcmUvZG9tL01lc3NhZ2VQb3J0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9N ZXNzYWdlUG9ydC5jcHAJKHJldmlzaW9uIDM4MTE5KQorKysgV2ViQ29yZS9kb20vTWVzc2FnZVBv cnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02Miw2ICs2MiwyMiBAQCBwcml2YXRlOgogICAgIFJl ZlB0cjxNZXNzYWdlUG9ydD4gbV9wb3J0OwogfTsKIAorTWVzc2FnZVBvcnQ6OkV2ZW50RGF0YTo6 RXZlbnREYXRhKCkKK3sKK30KKworTWVzc2FnZVBvcnQ6OkV2ZW50RGF0YTo6RXZlbnREYXRhKGNv bnN0IFN0cmluZyYgbWVzc2FnZSwgUGFzc1JlZlB0cjxET01XaW5kb3c+IHdpbmRvdywgUGFzc1Jl ZlB0cjxNZXNzYWdlUG9ydD4gbWVzc2FnZVBvcnQpCisgICAgOiBtZXNzYWdlKG1lc3NhZ2UuY29w eSgpKQorICAgICwgd2luZG93KHdpbmRvdykKKyAgICAsIG1lc3NhZ2VQb3J0KG1lc3NhZ2VQb3J0 KQoreworICAgIEFTU0VSVCghdGhpcy0+d2luZG93IHx8IGlzTWFpblRocmVhZCgpKTsKK30KKwor TWVzc2FnZVBvcnQ6OkV2ZW50RGF0YTo6fkV2ZW50RGF0YSgpCit7Cit9CisKIE1lc3NhZ2VQb3J0 OjpNZXNzYWdlUG9ydChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBzY3JpcHRFeGVjdXRpb25Db250 ZXh0KQogICAgIDogbV9lbnRhbmdsZWRQb3J0KDApCiAgICAgLCBtX3F1ZXVlSXNPcGVuKGZhbHNl KQpAQCAtOTMsOSArMTA5LDkgQEAgUGFzc1JlZlB0cjxNZXNzYWdlUG9ydD4gTWVzc2FnZVBvcnQ6 OmNsbwogCiAgICAgLy8gTW92ZSBhbGwgdGhlIGV2ZW50cyBpbiB0aGUgcG9ydCBtZXNzYWdlIHF1 ZXVlIG9mIG9yaWdpbmFsIHBvcnQgdG8gdGhlIHBvcnQgbWVzc2FnZSBxdWV1ZSBvZiBuZXcgcG9y dCwgaWYgYW55LCBsZWF2aW5nIHRoZSBuZXcgcG9ydCdzIHBvcnQgbWVzc2FnZSBxdWV1ZSBpbiBp dHMgaW5pdGlhbCBjbG9zZWQgc3RhdGUuCiAgICAgLy8gSWYgZXZlbnRzIGFyZSBwb3N0ZWQgKGUu Zy4gZnJvbSBhIHdvcmtlciB0aHJlYWQpIHdoaWxlIHRoaXMgY29kZSBpcyBleGVjdXRpbmcsIHRo ZXJlIGlzIG5vIGd1YXJhbnRlZSB3aGV0aGVyIHRoZXkgZW5kIHVwIGluIHRoZSBvcmlnaW5hbCBv ciBuZXcgcG9ydCdzIG1lc3NhZ2UgcXVldWUuCi0gICAgUmVmUHRyPEV2ZW50PiBldmVudDsKLSAg ICB3aGlsZSAobV9tZXNzYWdlUXVldWUudHJ5R2V0TWVzc2FnZShldmVudCkpCi0gICAgICAgIG5l d1BvcnQtPm1fbWVzc2FnZVF1ZXVlLmFwcGVuZChldmVudCk7CisgICAgRXZlbnREYXRhIGV2ZW50 RGF0YTsKKyAgICB3aGlsZSAobV9tZXNzYWdlUXVldWUudHJ5R2V0TWVzc2FnZShldmVudERhdGEp KQorICAgICAgICBuZXdQb3J0LT5tX21lc3NhZ2VRdWV1ZS5hcHBlbmQoZXZlbnREYXRhKTsKIAog ICAgIGVudGFuZ2xlKHJlbW90ZVBvcnQuZ2V0KCksIG5ld1BvcnQuZ2V0KCkpOyAvLyBUaGUgcG9y dCBvYmplY3Qgd2lsbCBiZSB1bmVudGFuZ2xlZC4KICAgICByZXR1cm4gbmV3UG9ydDsKQEAgLTEy NCw3ICsxNDAsNyBAQCB2b2lkIE1lc3NhZ2VQb3J0Ojpwb3N0TWVzc2FnZShjb25zdCBTdHJpCiAK ICAgICBET01XaW5kb3cqIHdpbmRvdyA9IChtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPmlzRG9j dW1lbnQoKSAmJiBtX2VudGFuZ2xlZFBvcnQtPm1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNE b2N1bWVudCgpKSA/CiAgICAgICAgIHN0YXRpY19jYXN0PERvY3VtZW50Kj4obV9zY3JpcHRFeGVj dXRpb25Db250ZXh0KS0+ZG9tV2luZG93KCkgOiAwOwotICAgIG1fZW50YW5nbGVkUG9ydC0+bV9t ZXNzYWdlUXVldWUuYXBwZW5kKE1lc3NhZ2VFdmVudDo6Y3JlYXRlKG1lc3NhZ2UsICIiLCAiIiwg d2luZG93LCBuZXdNZXNzYWdlUG9ydC5nZXQoKSkpOworICAgIG1fZW50YW5nbGVkUG9ydC0+bV9t ZXNzYWdlUXVldWUuYXBwZW5kKEV2ZW50RGF0YShtZXNzYWdlLCB3aW5kb3csIG5ld01lc3NhZ2VQ b3J0KSk7CiAgICAgaWYgKG1fZW50YW5nbGVkUG9ydC0+bV9xdWV1ZUlzT3BlbikKICAgICAgICAg bV9lbnRhbmdsZWRQb3J0LT5tX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQtPnByb2Nlc3NNZXNzYWdl UG9ydE1lc3NhZ2VzU29vbigpOwogfQpAQCAtMTQwLDcgKzE1Niw3IEBAIFBhc3NSZWZQdHI8TWVz c2FnZVBvcnQ+IE1lc3NhZ2VQb3J0OjpzdGEKIAogICAgIERPTVdpbmRvdyogd2luZG93ID0gKG1f c2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+aXNEb2N1bWVudCgpICYmIG1fZW50YW5nbGVkUG9ydC0+ bV9zY3JpcHRFeGVjdXRpb25Db250ZXh0LT5pc0RvY3VtZW50KCkpID8KICAgICAgICAgc3RhdGlj X2Nhc3Q8RG9jdW1lbnQqPihtX3NjcmlwdEV4ZWN1dGlvbkNvbnRleHQpLT5kb21XaW5kb3coKSA6 IDA7Ci0gICAgbV9lbnRhbmdsZWRQb3J0LT5tX21lc3NhZ2VRdWV1ZS5hcHBlbmQoTWVzc2FnZUV2 ZW50OjpjcmVhdGUobWVzc2FnZSwgIiIsICIiLCB3aW5kb3csIHBvcnQyLmdldCgpKSk7CisgICAg bV9lbnRhbmdsZWRQb3J0LT5tX21lc3NhZ2VRdWV1ZS5hcHBlbmQoRXZlbnREYXRhKG1lc3NhZ2Us IHdpbmRvdywgcG9ydDIpKTsKICAgICBpZiAobV9lbnRhbmdsZWRQb3J0LT5tX3F1ZXVlSXNPcGVu KQogICAgICAgICBtX2VudGFuZ2xlZFBvcnQtPm1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dC0+cHJv Y2Vzc01lc3NhZ2VQb3J0TWVzc2FnZXNTb29uKCk7CiAgICAgcmV0dXJuIHBvcnQxOwpAQCAtMjA3 LDEwICsyMjMsMTIgQEAgdm9pZCBNZXNzYWdlUG9ydDo6ZGlzcGF0Y2hNZXNzYWdlcygpCiAgICAg Ly8gTWVzc2FnZXMgZm9yIGNvbnRleHRzIHRoYXQgYXJlIG5vdCBmdWxseSBhY3RpdmUgZ2V0IGRp c3BhdGNoZWQgdG9vLCBidXQgSlNBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KCkg ZG9lc24ndCBjYWxsIGhhbmRsZXJzIGZvciB0aGVzZS4KICAgICBBU1NFUlQocXVldWVJc09wZW4o KSk7CiAKLSAgICBSZWZQdHI8RXZlbnQ+IGV2dDsKLSAgICB3aGlsZSAobV9tZXNzYWdlUXVldWUu dHJ5R2V0TWVzc2FnZShldnQpKSB7CisgICAgRXZlbnREYXRhIGV2ZW50RGF0YTsKKyAgICB3aGls ZSAobV9tZXNzYWdlUXVldWUudHJ5R2V0TWVzc2FnZShldmVudERhdGEpKSB7CisgICAgICAgIEFT U0VSVCghZXZlbnREYXRhLndpbmRvdyB8fCBpc01haW5UaHJlYWQoKSk7CisgICAgICAgIEFTU0VS VCghZXZlbnREYXRhLndpbmRvdyB8fCBzY3JpcHRFeGVjdXRpb25Db250ZXh0KCktPmlzRG9jdW1l bnQoKSk7CiAKLSAgICAgICAgQVNTRVJUKGV2dC0+dHlwZSgpID09IGV2ZW50TmFtZXMoKS5tZXNz YWdlRXZlbnQpOworICAgICAgICBSZWZQdHI8RXZlbnQ+IGV2dCA9IE1lc3NhZ2VFdmVudDo6Y3Jl YXRlKGV2ZW50RGF0YS5tZXNzYWdlLCAiIiwgIiIsIGV2ZW50RGF0YS53aW5kb3csIGV2ZW50RGF0 YS5tZXNzYWdlUG9ydCk7CiAKICAgICAgICAgaWYgKG1fb25NZXNzYWdlTGlzdGVuZXIpIHsKICAg ICAgICAgICAgIGV2dC0+c2V0VGFyZ2V0KHRoaXMpOwpJbmRleDogV2ViQ29yZS9kb20vTWVzc2Fn ZVBvcnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9NZXNzYWdlUG9ydC5oCShyZXZpc2lv biAzODExOSkKKysrIFdlYkNvcmUvZG9tL01lc3NhZ2VQb3J0LmgJKHdvcmtpbmcgY29weSkKQEAg LTQxLDYgKzQxLDcgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEF0b21pY1N0 cmluZ0ltcGw7CisgICAgY2xhc3MgRE9NV2luZG93OwogICAgIGNsYXNzIEV2ZW50OwogICAgIGNs YXNzIEZyYW1lOwogICAgIGNsYXNzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ7CkBAIC0xMDgsNyAr MTA5LDE3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgdm9pZCBkaXNwYXRjaENsb3Nl RXZlbnQoKTsKIAogICAgICAgICBNZXNzYWdlUG9ydCogbV9lbnRhbmdsZWRQb3J0OwotICAgICAg ICBNZXNzYWdlUXVldWU8UmVmUHRyPEV2ZW50PiA+IG1fbWVzc2FnZVF1ZXVlOworICAgICAgICAK KyAgICAgICAgc3RydWN0IEV2ZW50RGF0YSB7CisgICAgICAgICAgICBFdmVudERhdGEoKTsKKyAg ICAgICAgICAgIEV2ZW50RGF0YShjb25zdCBTdHJpbmcmLCBQYXNzUmVmUHRyPERPTVdpbmRvdz4s IFBhc3NSZWZQdHI8TWVzc2FnZVBvcnQ+KTsKKyAgICAgICAgICAgIH5FdmVudERhdGEoKTsKKwor ICAgICAgICAgICAgU3RyaW5nIG1lc3NhZ2U7CisgICAgICAgICAgICBSZWZQdHI8RE9NV2luZG93 PiB3aW5kb3c7CisgICAgICAgICAgICBSZWZQdHI8TWVzc2FnZVBvcnQ+IG1lc3NhZ2VQb3J0Owor ICAgICAgICB9OworICAgICAgICBNZXNzYWdlUXVldWU8RXZlbnREYXRhPiBtX21lc3NhZ2VRdWV1 ZTsKICAgICAgICAgYm9vbCBtX3F1ZXVlSXNPcGVuOwogCiAgICAgICAgIFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIG1fc2NyaXB0RXhlY3V0aW9uQ29udGV4dDsK