220813 2021-01-21 12:31:07 -0800 Null dereference in CompositeEditCommand::cloneParagraphUnderNewElement(): needs to check lastNode parent 2021-01-21 15:43:30 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 julian_a_gonzalez webkit-unassigned ews-watchlist mifenton rniwa wenson_hsieh oldest_to_newest 1721281 0 julian_a_gonzalez 2021-01-21 12:31:07 -0800 e.g. frame #0: WebCore`WebCore::Node::parentNode() const+0 frame #1: WebCore`WebCore::CompositeEditCommand::cloneParagraphUnderNewElement(WebCore::Position const&, WebCore::Position const&, WebCore::Node*, WebCore::Element*)+0 frame #2: WebCore`WebCore::CompositeEditCommand::moveParagraphWithClones(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&, WebCore::Element*, WebCore::Node*)+0 frame #3: WebCore`WebCore::IndentOutdentCommand::indentIntoBlockquote(WebCore::Position const&, WebCore::Position const&, WTF::RefPtr<WebCore::Element, WTF::DumbPtrTraits<WebCore::Element> >&)+0 frame #4: WebCore`WebCore::ApplyBlockElementCommand::formatSelection(WebCore::VisiblePosition const&, WebCore::VisiblePosition const&)+0 frame #5: WebCore`WebCore::ApplyBlockElementCommand::doApply()+0 frame #6: WebCore`WebCore::CompositeEditCommand::apply()+0 frame #7: WebCore`WebCore::executeIndent(WebCore::Frame&, WebCore::Event*, WebCore::EditorCommandSource, WTF::String const&)+0 frame #8: WebCore`WebCore::Document::execCommand(WTF::String const&, bool, WTF::String const&)+0 <rdar://problem/66894117> 1721284 1 418070 julian_a_gonzalez 2021-01-21 12:42:26 -0800 Created attachment 418070 Patch 1721384 2 julian_a_gonzalez 2021-01-21 15:42:58 -0800 Real radar: <rdar://problem/72194329> 1721385 3 ews-feeder 2021-01-21 15:43:28 -0800 Committed r271720: <https://trac.webkit.org/changeset/271720> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418070. 418070 2021-01-21 12:42:26 -0800 2021-01-21 15:43:29 -0800 Patch bug-220813-20210121124225.patch text/plain 4547 julian_a_gonzalez U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMjU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODA3ZmUyOTg1YTk2YjBl ODVlNjNlNTQwN2I0ZjdiMjU1NjZiMzRmZS4uM2M3YjhiZjkyNzA2MmE2MzhlNjY3MjQxZDY0ZTg3 Y2QxNjQ1YzM2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAxLTIxICBKdWxp YW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CisKKyAgICAgICAgTnVs bCBkZXJlZmVyZW5jZSBpbiBDb21wb3NpdGVFZGl0Q29tbWFuZDo6Y2xvbmVQYXJhZ3JhcGhVbmRl ck5ld0VsZW1lbnQoKTogbmVlZHMgdG8gY2hlY2sgbGFzdE5vZGUgcGFyZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA4MTMKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGl0ZXJhdGluZyB0aHJv dWdoIHBhcmVudCBub2RlcywgY2xvbmVQYXJhZ3JhcGhVbmRlck5ld0VsZW1lbnQoKQorICAgICAg ICBoYXMgdG8gYmUgY2FyZWZ1bCB0byBjaGVjayBmb3IgdGhlIHRvcCBvZiB0aGUgRE9NIHRyZWUg Zm9yICpib3RoKgorICAgICAgICBzdGFydE5vZGUgYW5kIGxhc3ROb2RlLgorICAgICAgICBTaW5j ZSB3ZSdyZSBleHBsaWNpdGx5IGNoZWNraW5nIGZvciB0aGlzIG5vdywgcmVtb3ZlIHRoZSBhc3Nl cnRpb24KKyAgICAgICAgdGhhdCBsYXN0Tm9kZSdzIHBhcmVudCBpcyBuZXZlciBudWxscHRyLgor CisgICAgICAgIFRlc3Q6IGVkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC11bC1zZWxlY3QtYWxsLmh0 bWwKKworICAgICAgICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q29tcG9zaXRlRWRpdENvbW1hbmQ6OmNsb25lUGFyYWdyYXBoVW5kZXJOZXdF bGVtZW50KToKKwogMjAyMS0wMS0wNyAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KIAogICAgICAgICBbV2luQ2Fpcm9dIFdlYkdMIGlzbid0IHNob3duIGluIG5vbi1B QyBtb2RlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRD b21tYW5kLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQu Y3BwCmluZGV4IGJjNjhkMTk5M2EyZTRmYzNmOTVkMjA2ODY4YTljMjJmNWNjODhmYTIuLmJlODI4 YjBmODM3MjljNTlhNTJjZmU1NWFlODFhNmFjY2FiNDM4MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCkBAIC0xMjYyLDEwICsxMjYyLDkg QEAgdm9pZCBDb21wb3NpdGVFZGl0Q29tbWFuZDo6Y2xvbmVQYXJhZ3JhcGhVbmRlck5ld0VsZW1l bnQoY29uc3QgUG9zaXRpb24mIHN0YXJ0LAogICAgICAgICAgICAgLy8gTW92ZSBsYXN0Tm9kZSB1 cCBpbiB0aGUgdHJlZSBhcyBtdWNoIGFzIG5vZGUgd2FzIG1vdmVkIHVwIGluIHRoZQogICAgICAg ICAgICAgLy8gdHJlZSBieSBOb2RlVHJhdmVyc2FsOjpuZXh0U2tpcHBpbmdDaGlsZHJlbiwgc28g dGhhdCB0aGUgcmVsYXRpdmUgZGVwdGggYmV0d2VlbgogICAgICAgICAgICAgLy8gbm9kZSBhbmQg dGhlIG9yaWdpbmFsIHN0YXJ0IG5vZGUgaXMgbWFpbnRhaW5lZCBpbiB0aGUgY2xvbmUuCi0gICAg ICAgICAgICB3aGlsZSAoc3RhcnROb2RlLT5wYXJlbnROb2RlKCkgJiYgc3RhcnROb2RlLT5wYXJl bnROb2RlKCkgIT0gbm9kZS0+cGFyZW50Tm9kZSgpKSB7CisgICAgICAgICAgICB3aGlsZSAoc3Rh cnROb2RlLT5wYXJlbnROb2RlKCkgJiYgbGFzdE5vZGUtPnBhcmVudE5vZGUoKSAmJiBzdGFydE5v ZGUtPnBhcmVudE5vZGUoKSAhPSBub2RlLT5wYXJlbnROb2RlKCkpIHsKICAgICAgICAgICAgICAg ICBzdGFydE5vZGUgPSBzdGFydE5vZGUtPnBhcmVudE5vZGUoKTsKICAgICAgICAgICAgICAgICBs YXN0Tm9kZSA9IGxhc3ROb2RlLT5wYXJlbnROb2RlKCk7Ci0gICAgICAgICAgICAgICAgQVNTRVJU KGxhc3ROb2RlKTsKICAgICAgICAgICAgIH0KIAogICAgICAgICAgICAgYXV0byBjbG9uZWROb2Rl ID0gbm9kZS0+Y2xvbmVOb2RlKHRydWUpOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdl TG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDE2YjU1YzFlODIyODM3MjAyNzEwY2Ew N2U0NTNiNzhmMmVjNjc5OGMuLjk1NDhjODM1N2Q4NmRjODFlNThlYjUzOTJmYzQ4ODVmZmVmMmVl NDQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0wMS0yMSAgSnVsaWFuIEdvbnphbGV6ICA8 anVsaWFuX2FfZ29uemFsZXpAYXBwbGUuY29tPgorCisgICAgICAgIE51bGwgZGVyZWZlcmVuY2Ug aW4gQ29tcG9zaXRlRWRpdENvbW1hbmQ6OmNsb25lUGFyYWdyYXBoVW5kZXJOZXdFbGVtZW50KCk6 IG5lZWRzIHRvIGNoZWNrIGxhc3ROb2RlIHBhcmVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwODEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCB0byB2ZXJpZnkgdGhhdCB3ZSBkb24n dCBpdGVyYXRlIG91dHNpZGUgdGhlIERPTSB0cmVlIHdoZW4KKyAgICAgICAgaW5zZXJ0aW5nIGFu IHVub3JkZXJlZCBsaXN0IG9uIHRvcCBvZiBleGlzdGluZyBjb250ZW50LgorCisgICAgICAgICog ZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LXVsLXNlbGVjdC1hbGwtZXhwZWN0ZWQudHh0OiBBZGRl ZC4KKyAgICAgICAgKiBlZGl0aW5nL2luc2VydGluZy9pbnNlcnQtdWwtc2VsZWN0LWFsbC5odG1s OiBBZGRlZC4KKwogMjAyMS0wMS0wNyAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3 ZWJraXQub3JnPgogCiAgICAgICAgIE51bGwgY2hlY2sgZ2xvYmFsIG9iamVjdCBpbiBCbG9iOjpz dHJlYW0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5nL2luc2VydC11 bC1zZWxlY3QtYWxsLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2VkaXRpbmcvaW5zZXJ0aW5n L2luc2VydC11bC1zZWxlY3QtYWxsLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iNzFlNTM4YmU0 Mzc4NmRjMDZmYmI5ODY1MTBjM2UxZmU1YmY2NGEzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LXVsLXNlbGVjdC1hbGwtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMiBAQAorVGhpcyB0ZXN0cyB0aGF0IHdlIGRvIG5vdCBjcmFzaCB3aGlsZSBp bnNlcnRpbmcgdGhlIHVsCisuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL2luc2Vy dGluZy9pbnNlcnQtdWwtc2VsZWN0LWFsbC5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9pbnNl cnRpbmcvaW5zZXJ0LXVsLXNlbGVjdC1hbGwuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45Njg4NDVmYWIzNTA5 NTMyZjU5OWJkOWY2MGI2YzkzYTg3OTg1MTZmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVz dHMvZWRpdGluZy9pbnNlcnRpbmcvaW5zZXJ0LXVsLXNlbGVjdC1hbGwuaHRtbApAQCAtMCwwICsx LDI1IEBACis8aHRtbD4KKzxoZWFkPgorPHNjcmlwdD4KK2Z1bmN0aW9uIHRlc3RvbmxvYWQoKSB7 CisgICAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQorICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1Rl eHQoKTsKKworICAgIGRvY3VtZW50LmRlc2lnbk1vZGUgPSAib24iOworICAgIGZvbnQuYXBwZW5k Q2hpbGQobGkpOworICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJzZWxlY3RBbGwiKTsKKyAgICBk b2N1bWVudC5leGVjQ29tbWFuZCgiaW5zZXJ0VW5vcmRlcmVkTGlzdCIsIGZhbHNlKTsKK30KKzwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPXRlc3RvbmxvYWQoKT4KKyAgICA8bWFycXVl ZT4KKyAgICAgICAgPGZvbnQgaWQ9ImZvbnQiPjwvZm9udD4KKyAgICA8L21hcnF1ZWU+CisgICAg PG9sPgorICAgICAgICA8bGkgY29udGVudGVkaXRhYmxlPSJmYWxzZSI+PC9saT4KKyAgICA8bGkg aWQ9ImxpIj5UaGlzIHRlc3RzIHRoYXQgd2UgZG8gbm90IGNyYXNoIHdoaWxlIGluc2VydGluZyB0 aGUgdWwuPC9saT4KKyAgICA8bGk+VGhpcyB3aWxsIGJlIHJlcGxhY2VkIHdpdGggdGhlIGZpbmFs IGNoYXJhY3RlciBvZiB0aGUgcHJldmlvdXMgbGkgZWxlbWVudC48L2xpPgorICAgIDwvb2w+Cis8 L2JvZHk+Cis8L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQo=