<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220811</bug_id>
          
          <creation_ts>2021-01-21 11:20:05 -0800</creation_ts>
          <short_desc>Add WebXR to features.json</short_desc>
          <delta_ts>2021-01-21 16:13:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Myles C. Maxfield">mmaxfield</reporter>
          <assigned_to name="Myles C. Maxfield">mmaxfield</assigned_to>
          <cc>dino</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>joepeck</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1721251</commentid>
    <comment_count>0</comment_count>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-01-21 11:20:05 -0800</bug_when>
    <thetext>Add WebXR to features.json</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721253</commentid>
    <comment_count>1</comment_count>
      <attachid>418065</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-01-21 11:22:01 -0800</bug_when>
    <thetext>Created attachment 418065
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721257</commentid>
    <comment_count>2</comment_count>
      <attachid>418065</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2021-01-21 11:29:29 -0800</bug_when>
    <thetext>Comment on attachment 418065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418065&amp;action=review

&gt; Source/WebCore/features.json:822
&gt; +            &quot;enabled-by-default&quot;: true

Let&apos;s remove this.

&gt; Source/WebCore/features.json:826
&gt; +        &quot;keywords&quot;: [&quot;webxr&quot;, &quot;webgl&quot;, &quot;webgpu&quot;],

are webgl and webgpu relevant?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721258</commentid>
    <comment_count>3</comment_count>
      <attachid>418065</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-01-21 11:33:05 -0800</bug_when>
    <thetext>Comment on attachment 418065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418065&amp;action=review

&gt;&gt; Source/WebCore/features.json:826
&gt;&gt; +        &quot;keywords&quot;: [&quot;webxr&quot;, &quot;webgl&quot;, &quot;webgpu&quot;],
&gt; 
&gt; are webgl and webgpu relevant?

yes! XR without webgl/webgpu is hardly an XR at all!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721263</commentid>
    <comment_count>4</comment_count>
      <attachid>418066</attachid>
    <who name="Myles C. Maxfield">mmaxfield</who>
    <bug_when>2021-01-21 11:49:12 -0800</bug_when>
    <thetext>Created attachment 418066
Patch for committing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721276</commentid>
    <comment_count>5</comment_count>
      <attachid>418065</attachid>
    <who name="Dean Jackson">dino</who>
    <bug_when>2021-01-21 12:09:22 -0800</bug_when>
    <thetext>Comment on attachment 418065
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418065&amp;action=review

&gt;&gt; Source/WebCore/features.json:822
&gt;&gt; +            &quot;enabled-by-default&quot;: true
&gt; 
&gt; Let&apos;s remove this.

it&apos;s definitely not on by default</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721395</commentid>
    <comment_count>6</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-01-21 16:12:52 -0800</bug_when>
    <thetext>Committed r271721: &lt;https://trac.webkit.org/changeset/271721&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 418066.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1721397</commentid>
    <comment_count>7</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-01-21 16:13:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/73473944&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>418065</attachid>
            <date>2021-01-21 11:22:01 -0800</date>
            <delta_ts>2021-01-21 11:29:29 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-220811-20210121112200.patch</filename>
            <type>text/plain</type>
            <size>1858</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTcwNDFiYjMwOTQ0NDZl
Yjc3N2JiZGZkNTkxNGRjNjlkOWU5ZDBlZC4uYmIwNTQ4Y2M2OWZjYWI2MTc2ZTQyYWZhZTg5MzY1
MTczY2E2YjQ4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAxLTIxICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIFdlYlhS
IHRvIGZlYXR1cmVzLmpzb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIyMDgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgIFdlIGFyZSBjbGVhcmx5IHdvcmtpbmcgb24gV2ViWFIuIFNlZToKKyAgICAgICAg
LSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE2OTI1CisgICAgICAg
IC0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODk4OAorICAgICAg
ICAtIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjAxMDcKKyAgICAg
ICAgLSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjE5MTcxCisKKyAg
ICAgICAgTm8gbmV3IHRlc3RzIGJlY2F1c2UgdGhlcmUgaXMgbm8gYmVoYXZpb3IgY2hhbmdlLgor
CisgICAgICAgICogZmVhdHVyZXMuanNvbjoKKwogMjAyMS0wMS0yMCAgS2VubmV0aCBSdXNzZWxs
ICA8a2JyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBTdXBwb3J0IFdFQkdMX211bHRpX2RyYXcg
ZXh0ZW5zaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uIGIvU291
cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgppbmRleCA1NDkzNjQ1ZDc4NTllYzEwZTU0NWRlZjY0
OGM2N2RjOTNmOTVlNTM3Li4zNjMzOGE5YzMyNmQ4NzAzNDBkYmU2OTA4OTMyMjE0NGIwZjAwNTJj
IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9mZWF0dXJlcy5qc29uCisrKyBiL1NvdXJjZS9X
ZWJDb3JlL2ZlYXR1cmVzLmpzb24KQEAgLTgxNSw2ICs4MTUsMTggQEAKICAgICAgICAgICAgICJl
bWFpbCI6ICJ3ZWItZXZhbmdlbGlzdEBhcHBsZS5jb20iCiAgICAgICAgIH0KICAgICB9LAorICAg
IHsKKyAgICAgICAgIm5hbWUiOiAiV2ViWFIiLAorICAgICAgICAic3RhdHVzIjogeworICAgICAg
ICAgICAgInN0YXR1cyI6ICJJbiBEZXZlbG9wbWVudCIsCisgICAgICAgICAgICAiZW5hYmxlZC1i
eS1kZWZhdWx0IjogdHJ1ZQorICAgICAgICB9LAorICAgICAgICAidXJsIjogImh0dHBzOi8vaW1t
ZXJzaXZlLXdlYi5naXRodWIuaW8vd2VieHIvIiwKKyAgICAgICAgIndlYmtpdC11cmwiOiAiaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIwODk4OCIsCisgICAgICAgICJr
ZXl3b3JkcyI6IFsid2VieHIiLCAid2ViZ2wiLCAid2ViZ3B1Il0sCisgICAgICAgICJjYXRlZ29y
eSI6ICJodG1sIiwKKyAgICAgICAgImRlc2NyaXB0aW9uIjogIlRoZSBXZWJYUiBkZXZpY2UgQVBJ
IGlzIGZvciBhY2Nlc3NpbmcgdmlydHVhbCByZWFsaXR5IChWUikgYW5kIGF1Z21lbnRlZCByZWFs
aXR5IChBUikgZGV2aWNlcywgaW5jbHVkaW5nIHNlbnNvcnMgYW5kIGhlYWQtbW91bnRlZCBkaXNw
bGF5cyBvbiB0aGUgV2ViLiIKKyAgICB9LAogICAgIHsKICAgICAgICAgIm5hbWUiOiAiV29ya2xl
dHMgTGV2ZWwgMSIsCiAgICAgICAgICJzdGF0dXMiOiB7Cg==
</data>
<flag name="review"
          id="435912"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>418066</attachid>
            <date>2021-01-21 11:49:12 -0800</date>
            <delta_ts>2021-01-21 16:12:53 -0800</delta_ts>
            <desc>Patch for committing</desc>
            <filename>bug-220811-20210121114912.patch</filename>
            <type>text/plain</type>
            <size>1815</size>
            <attacher name="Myles C. Maxfield">mmaxfield</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTcwNDFiYjMwOTQ0NDZl
Yjc3N2JiZGZkNTkxNGRjNjlkOWU5ZDBlZC4uNWYyN2YyYjJmNDc5N2E1NGNiMDBhNWZkZmYzZTA2
OTdkMWQzMmU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAxLTIxICBNeWxl
cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIFdlYlhS
IHRvIGZlYXR1cmVzLmpzb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTIyMDgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKwor
ICAgICAgICBXZSBhcmUgY2xlYXJseSB3b3JraW5nIG9uIFdlYlhSLiBTZWU6CisgICAgICAgIC0g
aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxNjkyNQorICAgICAgICAt
IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMDg5ODgKKyAgICAgICAg
LSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwMTA3CisgICAgICAg
IC0gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIxOTE3MQorCisgICAg
ICAgIE5vIG5ldyB0ZXN0cyBiZWNhdXNlIHRoZXJlIGlzIG5vIGJlaGF2aW9yIGNoYW5nZS4KKwor
ICAgICAgICAqIGZlYXR1cmVzLmpzb246CisKIDIwMjEtMDEtMjAgIEtlbm5ldGggUnVzc2VsbCAg
PGtickBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgU3VwcG9ydCBXRUJHTF9tdWx0aV9kcmF3IGV4
dGVuc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbiBiL1NvdXJj
ZS9XZWJDb3JlL2ZlYXR1cmVzLmpzb24KaW5kZXggNTQ5MzY0NWQ3ODU5ZWMxMGU1NDVkZWY2NDhj
NjdkYzkzZjk1ZTUzNy4uMWQ3MjE0ZTBlYjdkMzNiZTgyZWMyMGM4ZTM3YWRiYzE2YmMyYTczMiAx
MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZmVhdHVyZXMuanNvbgorKysgYi9Tb3VyY2UvV2Vi
Q29yZS9mZWF0dXJlcy5qc29uCkBAIC04MTUsNiArODE1LDE3IEBACiAgICAgICAgICAgICAiZW1h
aWwiOiAid2ViLWV2YW5nZWxpc3RAYXBwbGUuY29tIgogICAgICAgICB9CiAgICAgfSwKKyAgICB7
CisgICAgICAgICJuYW1lIjogIldlYlhSIiwKKyAgICAgICAgInN0YXR1cyI6IHsKKyAgICAgICAg
ICAgICJzdGF0dXMiOiAiSW4gRGV2ZWxvcG1lbnQiCisgICAgICAgIH0sCisgICAgICAgICJ1cmwi
OiAiaHR0cHM6Ly9pbW1lcnNpdmUtd2ViLmdpdGh1Yi5pby93ZWJ4ci8iLAorICAgICAgICAid2Vi
a2l0LXVybCI6ICJodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjA4OTg4
IiwKKyAgICAgICAgImtleXdvcmRzIjogWyJ3ZWJ4ciIsICJ3ZWJnbCIsICJ3ZWJncHUiXSwKKyAg
ICAgICAgImNhdGVnb3J5IjogImh0bWwiLAorICAgICAgICAiZGVzY3JpcHRpb24iOiAiVGhlIFdl
YlhSIGRldmljZSBBUEkgaXMgZm9yIGFjY2Vzc2luZyB2aXJ0dWFsIHJlYWxpdHkgKFZSKSBhbmQg
YXVnbWVudGVkIHJlYWxpdHkgKEFSKSBkZXZpY2VzLCBpbmNsdWRpbmcgc2Vuc29ycyBhbmQgaGVh
ZC1tb3VudGVkIGRpc3BsYXlzIG9uIHRoZSBXZWIuIgorICAgIH0sCiAgICAgewogICAgICAgICAi
bmFtZSI6ICJXb3JrbGV0cyBMZXZlbCAxIiwKICAgICAgICAgInN0YXR1cyI6IHsK
</data>

          </attachment>
      

    </bug>

</bugzilla>