220800 2021-01-21 09:05:43 -0800 [webkitscmpy] Handle machines that cannot import keyring 2021-01-21 09:55:00 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer oldest_to_newest 1721182 0 jbedard 2021-01-21 09:05:43 -0800 Although keyring is certainly useful so a contributor does not have to constantly input their password, it's not needed for the library the function. We should effectively make it an optional import. 1721183 1 webkit-bug-importer 2021-01-21 09:05:59 -0800 <rdar://problem/73454666> 1721192 2 418047 jbedard 2021-01-21 09:21:45 -0800 Created attachment 418047 Patch 1721216 3 ews-feeder 2021-01-21 09:54:59 -0800 Committed r271697: <https://trac.webkit.org/changeset/271697> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418047. 418047 2021-01-21 09:21:45 -0800 2021-01-21 09:55:00 -0800 Patch bug-220800-20210121092144.patch text/plain 4041 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MTY5MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAxLTIxICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbd2Via2l0c2NtcHldIEhhbmRsZSBtYWNoaW5lcyB0aGF0IGNhbm5vdCBp bXBvcnQga2V5cmluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIwODAwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzQ1NDY2Nj4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvbGlicmFy aWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5OiBCdW1wIHZlcnNpb24uCisgICAgICAgICogU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHk6IERpdHRvLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L3JlbW90 ZS9naXRfaHViLnB5OgorICAgICAgICAoR2l0SHViLmNyZWRlbnRpYWxzKTogTWFrZSBrZXlyaW5n IG9wdGlvbmFsLgorCiAyMDIxLTAxLTIxICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxv c0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFt3ZWJraXRjb3JlcHldIERvbid0IGltcG9ydCBzaXgg YXQgdGhlIHRvcCBsZXZlbApJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2Nt cHkvc2V0dXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0 c2NtcHkvc2V0dXAucHkJKHJldmlzaW9uIDI3MTY5MikKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFy aWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBA IGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0c2NtcHknLAotICAgIHZl cnNpb249JzAuOS4zJywKKyAgICB2ZXJzaW9uPScwLjkuNCcsCiAgICAgZGVzY3JpcHRpb249J0xp YnJhcnkgZGVzaWduZWQgdG8gaW50ZXJhY3Qgd2l0aCBnaXQgYW5kIHN2biByZXBvc2l0b3JpZXMu JywKICAgICBsb25nX2Rlc2NyaXB0aW9uPXJlYWRtZSgpLAogICAgIGNsYXNzaWZpZXJzPVsKSW5k ZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5p dF9fLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L19faW5pdF9fLnB5CShyZXZpc2lvbiAyNzE2OTIpCisrKyBUb29scy9TY3Jp cHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9fX2luaXRfXy5weQkod29ya2lu ZyBjb3B5KQpAQCAtNDYsNyArNDYsNyBAQCBleGNlcHQgSW1wb3J0RXJyb3I6CiAgICAgICAgICJQ bGVhc2UgaW5zdGFsbCB3ZWJraXRjb3JlcHkgd2l0aCBgcGlwIGluc3RhbGwgd2Via2l0Y29yZXB5 IC0tZXh0cmEtaW5kZXgtdXJsIDxwYWNrYWdlIGluZGV4IFVSTD5gIgogICAgICkKIAotdmVyc2lv biA9IFZlcnNpb24oMCwgOSwgMykKK3ZlcnNpb24gPSBWZXJzaW9uKDAsIDksIDQpCiAKIEF1dG9J bnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ2VudHJ5cG9pbnRzJywgVmVyc2lvbigwLCAzLCAwKSkp CiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJzaW9uKDAsIDE1 LCAwKSkpCkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRz Y21weS9yZW1vdGUvZ2l0X2h1Yi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xpYnJh cmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9yZW1vdGUvZ2l0X2h1Yi5weQkocmV2aXNpb24g MjcxNjkyKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2Nt cHkvcmVtb3RlL2dpdF9odWIucHkJKHdvcmtpbmcgY29weSkKQEAgLTMwLDYgKzMwLDcgQEAgaW1w b3J0IHN5cwogCiBmcm9tIGRhdGV0aW1lIGltcG9ydCBkYXRldGltZQogZnJvbSByZXF1ZXN0cy5h dXRoIGltcG9ydCBIVFRQQmFzaWNBdXRoCitmcm9tIHN1YnByb2Nlc3MgaW1wb3J0IENhbGxlZFBy b2Nlc3NFcnJvcgogZnJvbSB3ZWJraXRjb3JlcHkgaW1wb3J0IE91dHB1dENhcHR1cmUsIGRlY29y YXRvcnMKIGZyb20gd2Via2l0c2NtcHkgaW1wb3J0IENvbW1pdCwgQ29udHJpYnV0b3IKIGZyb20g d2Via2l0c2NtcHkucmVtb3RlLnNjbSBpbXBvcnQgU2NtCkBAIC03MSwxMyArNzIsMTcgQEAgY2xh c3MgR2l0SHViKFNjbSk6CiAgICAgICAgICAgICByZXR1cm4gdXNlcm5hbWUsIGFjY2Vzc190b2tl bgogCiAgICAgICAgIHdpdGggT3V0cHV0Q2FwdHVyZSgpOgotICAgICAgICAgICAgaW1wb3J0IGtl eXJpbmcKKyAgICAgICAgICAgIHRyeToKKyAgICAgICAgICAgICAgICBpbXBvcnQga2V5cmluZwor ICAgICAgICAgICAgZXhjZXB0IChDYWxsZWRQcm9jZXNzRXJyb3IsIEltcG9ydEVycm9yKToKKyAg ICAgICAgICAgICAgICBrZXlyaW5nID0gTm9uZQogCiAgICAgICAgIHVzZXJuYW1lX3Byb21wdGVk ID0gRmFsc2UKICAgICAgICAgcGFzc3dvcmRfcHJvbXB0ZWQgPSBGYWxzZQogICAgICAgICBpZiBu b3QgdXNlcm5hbWU6CiAgICAgICAgICAgICB0cnk6Ci0gICAgICAgICAgICAgICAgdXNlcm5hbWUg PSBrZXlyaW5nLmdldF9wYXNzd29yZChzZWxmLmFwaV91cmwsICd1c2VybmFtZScpCisgICAgICAg ICAgICAgICAgaWYga2V5cmluZzoKKyAgICAgICAgICAgICAgICAgICAgdXNlcm5hbWUgPSBrZXly aW5nLmdldF9wYXNzd29yZChzZWxmLmFwaV91cmwsICd1c2VybmFtZScpCiAgICAgICAgICAgICBl eGNlcHQgUnVudGltZUVycm9yOgogICAgICAgICAgICAgICAgIHBhc3MKIApAQCAtOTIsNyArOTcs OCBAQCBjbGFzcyBHaXRIdWIoU2NtKToKIAogICAgICAgICBpZiBub3QgYWNjZXNzX3Rva2VuIGFu ZCByZXF1aXJlZDoKICAgICAgICAgICAgIHRyeToKLSAgICAgICAgICAgICAgICBhY2Nlc3NfdG9r ZW4gPSBrZXlyaW5nLmdldF9wYXNzd29yZChzZWxmLmFwaV91cmwsIHVzZXJuYW1lKQorICAgICAg ICAgICAgICAgIGlmIGtleXJpbmc6CisgICAgICAgICAgICAgICAgICAgIGFjY2Vzc190b2tlbiA9 IGtleXJpbmcuZ2V0X3Bhc3N3b3JkKHNlbGYuYXBpX3VybCwgdXNlcm5hbWUpCiAgICAgICAgICAg ICBleGNlcHQgUnVudGltZUVycm9yOgogICAgICAgICAgICAgICAgIHBhc3MKIApAQCAtMTA1LDcg KzExMSw3IEBAIGNsYXNzIEdpdEh1YihTY20pOgogICAgICAgICBpZiB1c2VybmFtZSBhbmQgYWNj ZXNzX3Rva2VuOgogICAgICAgICAgICAgc2VsZi5fY2FjaGVkX2NyZWRlbnRpYWxzID0gKHVzZXJu YW1lLCBhY2Nlc3NfdG9rZW4pCiAKLSAgICAgICAgaWYgdXNlcm5hbWVfcHJvbXB0ZWQgb3IgcGFz c3dvcmRfcHJvbXB0ZWQ6CisgICAgICAgIGlmIGtleXJpbmcgYW5kICh1c2VybmFtZV9wcm9tcHRl ZCBvciBwYXNzd29yZF9wcm9tcHRlZCk6CiAgICAgICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCdT dG9yZSB1c2VybmFtZSBhbmQgYWNjZXNzIHRva2VuIGluIHN5c3RlbSBrZXlyaW5nIGZvciB7fT8g KFkvTik6ICcuZm9ybWF0KHNlbGYuYXBpX3VybCkpCiAgICAgICAgICAgICByZXNwb25zZSA9IChp bnB1dCBpZiBzeXMudmVyc2lvbl9pbmZvID4gKDMsIDApIGVsc2UgcmF3X2lucHV0KSgpCiAgICAg ICAgICAgICBpZiByZXNwb25zZS5sb3dlcigpIGluIFsneScsICd5ZXMnLCAnb2snXToK