220795 2021-01-21 07:06:10 -0800 [webkitcorepy] Don't import six at the top level 2021-01-21 14:37:23 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 angelos webkit-unassigned aakash_jain dewei_zhu jbedard webkit-bug-importer oldest_to_newest 1721153 0 angelos 2021-01-21 07:06:10 -0800 [webkitcorepy] Don't import six at the top level 1721154 1 418037 angelos 2021-01-21 07:10:47 -0800 Created attachment 418037 Patch 1721167 2 418037 aakash_jain 2021-01-21 08:05:32 -0800 Comment on attachment 418037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review > Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338 > + from six import reraise Do we need to import it again whiling exiting? 1721170 3 418037 jbedard 2021-01-21 08:20:37 -0800 Comment on attachment 418037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=418037&action=review >> Tools/Scripts/libraries/webkitcorepy/webkitcorepy/task_pool.py:338 >> + from six import reraise > > Do we need to import it again whiling exiting? We do, because we use it on line 352 1721176 4 ews-feeder 2021-01-21 08:52:11 -0800 Committed r271692: <https://trac.webkit.org/changeset/271692> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418037. 1721178 5 webkit-bug-importer 2021-01-21 08:54:51 -0800 <rdar://problem/73454252> 1721345 6 aakash_jain 2021-01-21 14:37:23 -0800 *** Bug 220791 has been marked as a duplicate of this bug. *** 418037 2021-01-21 07:10:47 -0800 2021-01-21 08:52:12 -0800 Patch bug-220795-20210121161044.patch text/plain 2045 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjkwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQyYjllNDQ1M2M3NjE4NTdmNGU0YTJjZTFhOWQ2NGY2 NGYzMDAwNy4uYWRmNzkxMzRmMjU4YzRlM2FkMmFhNTI3NmZlYjg4MzY3YjY1NzJjZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTAxLTIxICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFt3ZWJraXRjb3JlcHldIERvbid0IGltcG9ydCBzaXggYXQgdGhlIHRv cCBsZXZlbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIwNzk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg SW5zdGVhZCwgZG8gdGhlIGltcG9ydCBhZnRlciB0aGUgbW9kdWxlIGhhcyBiZWVuIGxvYWRlZCwg d2hlbgorICAgICAgICBBdXRvSW5zdGFsbCBoYXMgYmVlbiBzZXQgdXAgcHJvcGVybHkuIEZpeGVz IGEgcmVncmVzc2lvbiBhZnRlcgorICAgICAgICAxZDM0MmE1MDY3ZTIyYWM4MDY5ZmYzZmYzMzdi MmQ1OGUxZDA2NTE3LCB3aGVyZSB0YXNrX3Bvb2wucHkgdXNlcworICAgICAgICB0aGUgc2l4IG1v ZHVsZSB3aXRob3V0IGl0IGJlaW5nIGluc3RhbGxlZC4KKworICAgICAgICAqIFNjcmlwdHMvbGli cmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvdGFza19wb29sLnB5OgorICAgICAgICAo Q2hpbGRFeGNlcHRpb24uX19jYWxsX18pOgorICAgICAgICAoVGFza1Bvb2wuX19leGl0X18pOgor CiAyMDIxLTAxLTIwICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNvbT4KIAogICAg ICAgICBbd2Via2l0c2NtcHldIEdyYWNlZnVsbHkgaGFuZGxlIG1pc3Npbmcga2V5cmluZyBiYWNr ZW5kCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Vi a2l0Y29yZXB5L3Rhc2tfcG9vbC5weSBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNv cmVweS93ZWJraXRjb3JlcHkvdGFza19wb29sLnB5CmluZGV4IGNhOTM1MmFjMGRlZDJjODNhMzhk MWJlMTRiYzg2ZDJhNDg4ZTRmMWMuLmQ3N2E5ZTk5NmJjNjYyNzczNTUyOTY4NzExZTAzY2ZhYjY2 MmRiNjcgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93 ZWJraXRjb3JlcHkvdGFza19wb29sLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dl YmtpdGNvcmVweS93ZWJraXRjb3JlcHkvdGFza19wb29sLnB5CkBAIC0yNyw3ICsyNyw2IEBAIGlt cG9ydCBtdWx0aXByb2Nlc3NpbmcKIGltcG9ydCBzaWduYWwKIGltcG9ydCBzeXMKIAotZnJvbSBz aXggaW1wb3J0IHJlcmFpc2UKIGZyb20gd2Via2l0Y29yZXB5IGltcG9ydCBPdXRwdXRDYXB0dXJl LCBUaW1lb3V0LCBsb2cKIAogCkBAIC0xMjAsNiArMTE5LDcgQEAgY2xhc3MgQ2hpbGRFeGNlcHRp b24oTWVzc2FnZSk6CiAgICAgICAgIHNlbGYuZXhjX2luZm8gPSBleGNfaW5mbyBvciBzeXMuZXhj X2luZm8oKQogCiAgICAgZGVmIF9fY2FsbF9fKHNlbGYsIGNhbGxlcik6CisgICAgICAgIGZyb20g c2l4IGltcG9ydCByZXJhaXNlCiAgICAgICAgIF8sIGV4Y2VwdGlvbiwgdHJhY2UgPSBzeXMuZXhj X2luZm8oKQogICAgICAgICBpZiBleGNlcHRpb246CiAgICAgICAgICAgICBsb2cuY3JpdGljYWwo IkV4Y2VwdGlvbiBpbiBmbGlnaHQsICd7fScgaWdub3JlZCIuZm9ybWF0KHNlbGYuZXhjX2luZm9b MV0pKQpAQCAtMzM1LDYgKzMzNSw3IEBAIGNsYXNzIFRhc2tQb29sKG9iamVjdCk6CiAgICAgICAg ICAgICBzZWxmLnF1ZXVlLnJlY2VpdmUoKShzZWxmKQogCiAgICAgZGVmIF9fZXhpdF9fKHNlbGYs ICphcmdzLCAqKmt3YXJncyk6CisgICAgICAgIGZyb20gc2l4IGltcG9ydCByZXJhaXNlCiAgICAg ICAgIHRyeToKICAgICAgICAgICAgIGluZmxpZ2h0ID0gc3lzLmV4Y19pbmZvKCkKIAo=