220792 2021-01-21 05:38:03 -0800 [webkitcorepy] Use AutoInstall for webkitcorepy deps as well 2021-01-21 09:04:17 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX https://bugs.webkit.org/show_bug.cgi?id=220791 P2 Normal --- 1 angelos webkit-unassigned aakash_jain clopez ews-watchlist glenn jbedard oldest_to_newest 1721134 0 angelos 2021-01-21 05:38:03 -0800 [webkitcorepy] Use AutoInstall for webkitcorepy deps as well 1721137 1 418033 angelos 2021-01-21 05:51:02 -0800 Created attachment 418033 Patch 1721151 2 418033 jbedard 2021-01-21 06:53:55 -0800 Comment on attachment 418033 Patch In most places, this would be the right approach, but webkitcorepy is a special case because it’s imported before the autoinstaller is configured (and not just in webkitpy, that’s also true in some Apple non-public code) What I should have done is put the six import in task_pool inside the function (or functions) that are actually using it. If no one else posts a patch, I’ll get to it in the next hour or two. 1721152 3 angelos 2021-01-21 07:01:52 -0800 (In reply to Jonathan Bedard from comment #2) > Comment on attachment 418033 [details] > Patch > > In most places, this would be the right approach, but webkitcorepy is a > special case because it’s imported before the autoinstaller is configured > (and not just in webkitpy, that’s also true in some Apple non-public code) Ah, so you need the autoinstaller configuration to be in the consumers of webkitcorepy? That makes sense. > What I should have done is put the six import in task_pool inside the > function (or functions) that are actually using it. If no one else posts a > patch, I’ll get to it in the next hour or two. Sure, I'll file a new bug. 1721155 4 angelos 2021-01-21 07:11:11 -0800 https://bugs.webkit.org/show_bug.cgi?id=220795 1721181 5 jbedard 2021-01-21 09:04:17 -0800 Angelos fixed this in the other bug he linked, closing this one. 418033 2021-01-21 05:51:02 -0800 2021-01-21 06:53:55 -0800 Patch bug-220792-20210121145058.patch text/plain 4678 angelos U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjg4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGQyYjllNDQ1M2M3NjE4NTdmNGU0YTJjZTFhOWQ2NGY2 NGYzMDAwNy4uOTE4YjBjMDU2MjcxN2RkMTk0NmEzMTM3NjczZDY5Nzk2NjQ3NzUzMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIxLTAxLTIxICBBbmdlbG9zIE9pa29ub21vcG91bG9zICA8YW5nZWxvc0BpZ2FsaWEu Y29tPgorCisgICAgICAgIFt3ZWJraXRjb3JlcHldIFVzZSBBdXRvSW5zdGFsbCBmb3Igd2Via2l0 Y29yZXB5IGRlcHMgYXMgd2VsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIwNzkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2FsbCBBdXRvSW5zdGFsbC5zZXRfZGlyZWN0b3J5IGluIHdlYmtpdGNvcmVw eS9fX2luaXRfXy5weSwgc28KKyAgICAgICAgdGhhdCBpdCBjYW4gYWxzbyBiZSB1c2VkIGZvciBk ZXBlbmRlbmNpZXMgYnkgc2libGluZyBmaWxlcyBpbiB0aGUKKyAgICAgICAgc2FtZSBkaXJlY3Rv cnkuICBGaXhlcyBhIHJlZ3Jlc3Npb24gYWZ0ZXIKKyAgICAgICAgMWQzNDJhNTA2N2UyMmFjODA2 OWZmM2ZmMzM3YjJkNThlMWQwNjUxNywgd2hlcmUgdGFza19wb29sLnB5IHVzZXMKKyAgICAgICAg dGhlIHNpeCBtb2R1bGUgd2l0aG91dCBpdCBiZWluZyBpbnN0YWxsZWQuCisKKyAgICAgICAgKiBT Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5L19faW5pdF9fLnB5Ogor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvX19pbml0X18ucHk6CisKIDIwMjEtMDEtMjAgIEpv bmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIFt3ZWJraXRzY21w eV0gR3JhY2VmdWxseSBoYW5kbGUgbWlzc2luZyBrZXlyaW5nIGJhY2tlbmQKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0 X18ucHkgYi9Ub29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvd2Via2l0Y29yZXB5 L19faW5pdF9fLnB5CmluZGV4IDBhZDBjZjRjZGZjOWFkOTE5NDE2ZmQxZGUzYjViMWZkYTI3Mzc4 NmIuLmY5MGE1MDQzYWVmY2UwZTkxZGY0YjgzMzRlM2ExMjY2NWZjOTE4ZmIgMTAwNjQ0Ci0tLSBh L1Rvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0 X18ucHkKKysrIGIvVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNv cmVweS9fX2luaXRfXy5weQpAQCAtMjEsNiArMjEsNyBAQAogIyBTT0ZUV0FSRSwgRVZFTiBJRiBB RFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogaW1wb3J0IGxvZ2dp bmcKK2ltcG9ydCBvcwogaW1wb3J0IHBsYXRmb3JtCiBpbXBvcnQgc3lzCiAKQEAgLTI5LDE2ICsz MCwyMSBAQCBmcm9tIGxvZ2dpbmcgaW1wb3J0IE51bGxIYW5kbGVyCiBsb2cgPSBsb2dnaW5nLmdl dExvZ2dlcignd2Via2l0Y29yZXB5JykKIGxvZy5hZGRIYW5kbGVyKE51bGxIYW5kbGVyKCkpCiAK K2xpYnJhcmllcyA9IG9zLnBhdGguYWJzcGF0aChvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJu YW1lKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXykpKSkKK2lmIHN5cy5wbGF0Zm9ybSA9PSAnZGFy d2luJzoKKyAgICBpc19yb290ID0gbm90IG9zLmdldHVpZCgpCisgICAgZG9lc19vd25fbGlicmFy aWVzID0gb3Muc3RhdChsaWJyYXJpZXMpLnN0X3VpZCA9PSBvcy5nZXR1aWQoKQorICAgIGlmIChp c19yb290IG9yIG5vdCBkb2VzX293bl9saWJyYXJpZXMpOgorICAgICAgICBsaWJyYXJpZXMgPSBv cy5wYXRoLmV4cGFuZHVzZXIoJ34vTGlicmFyeS93ZWJraXRweScpCisKK2Zyb20gd2Via2l0Y29y ZXB5LmF1dG9pbnN0YWxsIGltcG9ydCBQYWNrYWdlLCBBdXRvSW5zdGFsbAogZnJvbSB3ZWJraXRj b3JlcHkudmVyc2lvbiBpbXBvcnQgVmVyc2lvbgotZnJvbSB3ZWJraXRjb3JlcHkuc3RyaW5nX3V0 aWxzIGltcG9ydCBCeXRlc0lPLCBTdHJpbmdJTywgVW5pY29kZUlPLCB1bmljb2RlCi1mcm9tIHdl YmtpdGNvcmVweS50aW1lb3V0IGltcG9ydCBUaW1lb3V0Ci1mcm9tIHdlYmtpdGNvcmVweS5zdWJw cm9jZXNzX3V0aWxzIGltcG9ydCBUaW1lb3V0RXhwaXJlZCwgQ29tcGxldGVkUHJvY2VzcywgcnVu Ci1mcm9tIHdlYmtpdGNvcmVweS5vdXRwdXRfY2FwdHVyZSBpbXBvcnQgTG9nZ2VyQ2FwdHVyZSwg T3V0cHV0Q2FwdHVyZSwgT3V0cHV0RHVwbGljYXRlCi1mcm9tIHdlYmtpdGNvcmVweS50YXNrX3Bv b2wgaW1wb3J0IFRhc2tQb29sCisKK0F1dG9JbnN0YWxsLnNldF9kaXJlY3Rvcnkob3MucGF0aC5q b2luKGxpYnJhcmllcywgJ2F1dG9pbnN0YWxsZWQnLCAncHl0aG9uLXt9Jy5mb3JtYXQoc3lzLnZl cnNpb25faW5mb1swXSkpKQorQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgnc2l4JywgVmVy c2lvbigxLCAxNSwgMCkpKQogCiB2ZXJzaW9uID0gVmVyc2lvbigwLCA1LCAwKQogCi1mcm9tIHdl YmtpdGNvcmVweS5hdXRvaW5zdGFsbCBpbXBvcnQgUGFja2FnZSwgQXV0b0luc3RhbGwKIGlmIHN5 cy52ZXJzaW9uX2luZm8gPiAoMywgMCk6CiAgICAgQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2Fn ZSgnbW9jaycsIFZlcnNpb24oNCkpKQogZWxzZToKQEAgLTU1LDkgKzYxLDE0IEBAIEF1dG9JbnN0 YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3B5cGFyc2luZycsIFZlcnNpb24oMiwgNCwgNykpKQogQXV0 b0luc3RhbGwucmVnaXN0ZXIoUGFja2FnZSgncmVxdWVzdHMnLCBWZXJzaW9uKDIsIDI0KSkpCiBB dXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdzZXR1cHRvb2xzJywgVmVyc2lvbig0NCwgMSwg IDEpKSkKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBhY2thZ2UoJ3NvY2tzJywgVmVyc2lvbigxLCA3 LCAxKSwgcHlwaV9uYW1lPSdQeVNvY2tzJykpCi1BdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdl KCdzaXgnLCBWZXJzaW9uKDEsIDE1LCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdl KCd0YmxpYicsIFZlcnNpb24oMSwgNywgMCkpKQogQXV0b0luc3RhbGwucmVnaXN0ZXIoUGFja2Fn ZSgndXJsbGliMycsIFZlcnNpb24oMSwgMjUsIDEwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQ YWNrYWdlKCd3aGVlbCcsIFZlcnNpb24oMCwgMzUsIDEpKSkKIAorZnJvbSB3ZWJraXRjb3JlcHku c3RyaW5nX3V0aWxzIGltcG9ydCBCeXRlc0lPLCBTdHJpbmdJTywgVW5pY29kZUlPLCB1bmljb2Rl Citmcm9tIHdlYmtpdGNvcmVweS50aW1lb3V0IGltcG9ydCBUaW1lb3V0Citmcm9tIHdlYmtpdGNv cmVweS5zdWJwcm9jZXNzX3V0aWxzIGltcG9ydCBUaW1lb3V0RXhwaXJlZCwgQ29tcGxldGVkUHJv Y2VzcywgcnVuCitmcm9tIHdlYmtpdGNvcmVweS5vdXRwdXRfY2FwdHVyZSBpbXBvcnQgTG9nZ2Vy Q2FwdHVyZSwgT3V0cHV0Q2FwdHVyZSwgT3V0cHV0RHVwbGljYXRlCitmcm9tIHdlYmtpdGNvcmVw eS50YXNrX3Bvb2wgaW1wb3J0IFRhc2tQb29sCisKIG5hbWUgPSAnd2Via2l0Y29yZXB5JwpkaWZm IC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weSBiL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvX19pbml0X18ucHkKaW5kZXggODIwNmQxNTgxYzMyZDYxNTM1M2IwODFiNWFl NzJkODYzY2VkM2IwNS4uNjNhOGRjNDRkMmQyMDQ2MWUzYmQxMWI5NDQ3MzcxZWRkNjlhMjFjMCAx MDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9fX2luaXRfXy5weQorKysgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L19faW5pdF9fLnB5CkBAIC0yMSwxNCArMjEsNyBAQCBvcy5lbnZp cm9uWydTWVNURU1fVkVSU0lPTl9DT01QQVQnXSA9ICcwJwogbGlicmFyaWVzID0gb3MucGF0aC5q b2luKG9zLnBhdGguYWJzcGF0aChvcy5wYXRoLmRpcm5hbWUob3MucGF0aC5kaXJuYW1lKF9fZmls ZV9fKSkpLCAnbGlicmFyaWVzJykKIHN5cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmpvaW4obGli cmFyaWVzLCAnd2Via2l0Y29yZXB5JykpCiAKLWlmIHN5cy5wbGF0Zm9ybSA9PSAnZGFyd2luJzoK LSAgICBpc19yb290ID0gbm90IG9zLmdldHVpZCgpCi0gICAgZG9lc19vd25fbGlicmFyaWVzID0g b3Muc3RhdChsaWJyYXJpZXMpLnN0X3VpZCA9PSBvcy5nZXR1aWQoKQotICAgIGlmIChpc19yb290 IG9yIG5vdCBkb2VzX293bl9saWJyYXJpZXMpOgotICAgICAgICBsaWJyYXJpZXMgPSBvcy5wYXRo LmV4cGFuZHVzZXIoJ34vTGlicmFyeS93ZWJraXRweScpCi0KIGZyb20gd2Via2l0Y29yZXB5IGlt cG9ydCBBdXRvSW5zdGFsbCwgUGFja2FnZSwgVmVyc2lvbgotQXV0b0luc3RhbGwuc2V0X2RpcmVj dG9yeShvcy5wYXRoLmpvaW4obGlicmFyaWVzLCAnYXV0b2luc3RhbGxlZCcsICdweXRob24te30n LmZvcm1hdChzeXMudmVyc2lvbl9pbmZvWzBdKSkpCiAKIEF1dG9JbnN0YWxsLnJlZ2lzdGVyKFBh Y2thZ2UoJ2F0b21pY3dyaXRlcycsIFZlcnNpb24oMSwgMSwgNSkpKQogQXV0b0luc3RhbGwucmVn aXN0ZXIoUGFja2FnZSgnYXR0cicsIFZlcnNpb24oMTgsIDEsIDApLCBweXBpX25hbWU9J2F0dHJz JykpCg==