220759 2021-01-19 18:41:01 -0800 REGRESSION (r271508) Scrolling is no longer smooth 2021-01-19 21:24:14 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220635 InRadar P2 Normal --- 1 simon.fraser simon.fraser cmarcelo darin ews-watchlist fred.wang jamesr luiz sam simon.fraser tonikitoo webkit-bug-importer oldest_to_newest 1720786 0 simon.fraser 2021-01-19 18:41:01 -0800 REGRESSION (r271508) Scrolling is no longer smooth 1720787 1 417936 simon.fraser 2021-01-19 18:41:58 -0800 Created attachment 417936 Patch 1720795 2 417936 darin 2021-01-19 19:08:15 -0800 Comment on attachment 417936 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417936&action=review > Source/WebCore/ChangeLog:9 > + r271508 has a logic error that resulted in no scrolling thread layer commits, which meant that > + scrolling on pages with a busy main thread only updated layers at main thread cadence. Is a regression test possible? 1720806 3 simon.fraser 2021-01-19 21:07:23 -0800 I'd have to write a bunch of infrastructure to test this (count layer commits on the scrolling thread). 1720808 4 ews-feeder 2021-01-19 21:23:12 -0800 Committed r271637: <https://trac.webkit.org/changeset/271637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417936. 1720809 5 webkit-bug-importer 2021-01-19 21:24:14 -0800 <rdar://problem/73388312> 417936 2021-01-19 18:41:58 -0800 2021-01-19 21:23:13 -0800 Patch bug-220759-20210119184157.patch text/plain 1764 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNTU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTU3MzczODg2YjQ2ZDcy ZGE1OTM3M2Q0MmIxMjYxODgwMjhhYzhjNC4uMTQ0NzUwMjYyN2NmMzNlZTFmYjAwYmMxOGIwZDZl MTMyMWRiM2FkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAxLTE5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04g KHIyNzE1MDgpIFNjcm9sbGluZyBpcyBubyBsb25nZXIgc21vb3RoCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA3NTkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICByMjcxNTA4IGhhcyBhIGxvZ2ljIGVycm9y IHRoYXQgcmVzdWx0ZWQgaW4gbm8gc2Nyb2xsaW5nIHRocmVhZCBsYXllciBjb21taXRzLCB3aGlj aCBtZWFudCB0aGF0CisgICAgICAgIHNjcm9sbGluZyBvbiBwYWdlcyB3aXRoIGEgYnVzeSBtYWlu IHRocmVhZCBvbmx5IHVwZGF0ZWQgbGF5ZXJzIGF0IG1haW4gdGhyZWFkIGNhZGVuY2UuCisKKyAg ICAgICAgKiBwYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1RyZWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6VGhyZWFkZWRTY3JvbGxpbmdUcmVlOjpjYW5VcGRhdGVMYXllcnNPblNjcm9s bGluZ1RocmVhZCBjb25zdCk6CisKIDIwMjEtMDEtMTYgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFw cGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIERvIG5vdCB1c2UgTGluZUJveDo6aXNDb25z aWRlcmVkRW1wdHkgd2hlbiBjaGVja2luZyBpZiBpbmxpbmUgYm94IHN0cmV0Y2hlcyB0aGUgbGlu ZSBib3guCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRl ZFNjcm9sbGluZ1RyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGFnZS9zY3JvbGxpbmcvVGhyZWFk ZWRTY3JvbGxpbmdUcmVlLmNwcAppbmRleCA2ZDM5YzU2Nzk2MTlkMzlmNTI1NmUzYjU1NjQzZTUw ODQ0NjMxNGU5Li5kNzhiYTZiZTZhY2Y4ODZiNTc3Zjc2ODc0ZTVhZGU1OThlN2QyMDJlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL3Njcm9sbGluZy9UaHJlYWRlZFNjcm9sbGluZ1Ry ZWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL1RocmVhZGVkU2Nyb2xs aW5nVHJlZS5jcHAKQEAgLTE4Niw3ICsxODYsNyBAQCB2b2lkIFRocmVhZGVkU2Nyb2xsaW5nVHJl ZTo6cHJvcGFnYXRlU3luY2hyb25vdXNTY3JvbGxpbmdSZWFzb25zKGNvbnN0IEhhc2hTZXQ8Uwog CiBib29sIFRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6Y2FuVXBkYXRlTGF5ZXJzT25TY3JvbGxpbmdU aHJlYWQoKSBjb25zdAogewotICAgIHJldHVybiBtX2hhc05vZGVzV2l0aFN5bmNocm9ub3VzU2Ny b2xsaW5nUmVhc29uczsKKyAgICByZXR1cm4gIW1faGFzTm9kZXNXaXRoU3luY2hyb25vdXNTY3Jv bGxpbmdSZWFzb25zOwogfQogCiB2b2lkIFRocmVhZGVkU2Nyb2xsaW5nVHJlZTo6c2Nyb2xsaW5n VHJlZU5vZGVEaWRTY3JvbGwoU2Nyb2xsaW5nVHJlZVNjcm9sbGluZ05vZGUmIG5vZGUsIFNjcm9s bGluZ0xheWVyUG9zaXRpb25BY3Rpb24gc2Nyb2xsaW5nTGF5ZXJQb3NpdGlvbkFjdGlvbikK