220743 2021-01-19 12:52:03 -0800 REGRESSION (r271559): [BigSur] fast/forms/password-scrolled-after-caps-lock-toggled.html is consistently failing 2021-01-21 19:09:36 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=60305 InRadar P2 Normal --- 1 ryanhaddad zimmermann changseok esprehn+autocc ews-watchlist fred.wang glenn kondapallykalyan pdr simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh zimmermann oldest_to_newest 1720632 0 ryanhaddad 2021-01-19 12:52:03 -0800 After https://trac.webkit.org/changeset/271559/webkit landed, fast/forms/password-scrolled-after-caps-lock-toggled.html is consistently failing on Big Sur bots: --- /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/fast/forms/password-scrolled-after-caps-lock-toggled-expected.txt +++ /Volumes/Data/slave/bigsur-release-tests-wk2/build/layout-test-results/fast/forms/password-scrolled-after-caps-lock-toggled-actual.txt @@ -25,7 +25,7 @@ PASS document.getElementById('input').scrollLeft is 0 After caps lock enabled: -PASS document.getElementById('input').scrollLeft is 0 +FAIL document.getElementById('input').scrollLeft should be 0. Was 5. After caps lock disabled: PASS document.getElementById('input').scrollLeft is 0 @@ -39,6 +39,7 @@ After caps lock disabled: PASS document.getElementById('input').scrollLeft is 0 PASS successfullyParsed is true +Some tests failed. TEST COMPLETE https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Fpassword-scrolled-after-caps-lock-toggled.html 1720633 1 webkit-bug-importer 2021-01-19 12:52:15 -0800 <rdar://problem/73368910> 1720990 2 ryanhaddad 2021-01-20 14:05:03 -0800 I'll go ahead and revert this change since we have a confirmed regression point. 1720993 3 ryanhaddad 2021-01-20 14:09:54 -0800 (In reply to Ryan Haddad from comment #2) > I'll go ahead and revert this change since we have a confirmed regression > point. https://trac.webkit.org/changeset/271598/webkit would also need to go, so maybe this needs a look sooner rather than later. 1720996 4 simon.fraser 2021-01-20 14:12:04 -0800 Rollouts will cause a lot of churn with these big patches, and Nikolas will look at this soon, so I'd prefer to hold off on the rollout. 1720999 5 zimmermann 2021-01-20 14:16:07 -0800 Regression confirmed, will look into it right now. 1721126 6 418029 zimmermann 2021-01-21 04:37:28 -0800 Created attachment 418029 Patch 1721130 7 zimmermann 2021-01-21 05:08:58 -0800 While this fixes the regression on the fast/forms/password-...* text, it has side effects for two other test categories, that I'm investigating. I'm on it - stay tuned. 1721245 8 simon.fraser 2021-01-21 10:48:54 -0800 I'm sure it's obvious, but you just need to match the behavior from before the RenderLayer split. 1721381 9 418094 zimmermann 2021-01-21 15:36:42 -0800 Created attachment 418094 Patch 1721457 10 ews-feeder 2021-01-21 19:09:33 -0800 Committed r271732: <https://trac.webkit.org/changeset/271732> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418094. 418029 2021-01-21 04:37:28 -0800 2021-01-21 15:36:38 -0800 Patch bug-220743-20210121133727.patch text/plain 2433 zimmermann U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjczCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTVlMTk3NzBlMWJiNGQz YTEwYjA0YTM0OGQ1ZmI5YjIxMzI4ZDRlMS4uNjJmZTNjMDg0MmI1MTQ4MWVlZmNkN2FjNDI3NzE3 ZDcyNzBjOTE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIxLTAxLTIxICBOaWtv bGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JF U1NJT04gKHIyNzE1NTkpOiBbQmlnU3VyXSBmYXN0L2Zvcm1zL3Bhc3N3b3JkLXNjcm9sbGVkLWFm dGVyLWNhcHMtbG9jay10b2dnbGVkLmh0bWwgaXMgY29uc2lzdGVudGx5IGZhaWxpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDc0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCByZWdyZXNzaW9u IC0tIFJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXQoKSBpcyBub3QKKyAg ICAgICAgcmVzcG9uc2libGUgZm9yIHRyaWdnZXJpbmcgdGhlIGNyZWF0aW9uL2RlbGV0aW9uIG9m IGEKKyAgICAgICAgUmVuZGVyTGF5ZXJTY3JvbGxhYmxlQXJlYS4KKworICAgICAgICBDb3ZlcmVk IGJ5IGZhc3QvZm9ybXMvcGFzc3dvcmQtc2Nyb2xsZWQtYWZ0ZXItY2Fwcy1sb2NrLXRvZ2dsZWQu aHRtbC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJMYXllci5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJMYXllcjo6c2Nyb2xsKTogQXZvaWQgdW5uZWNlc3NhcnkgY3JlYXRpb24g b2YKKyAgICAgICAgUmVuZGVyTGF5ZXJTY3JvbGxhYmxlQXJlYS4gQ2FsbGluZyBzY3JvbGwoKSBz aG91bGQgZWFybHkgcmV0dXJuIGhlcmUKKyAgICAgICAgaW5zdGVhZCBvZiByZXR1cm5pbmcgZmFs c2UgZnJvbSBSZW5kZXJMYXllclNjcm9sbGFibGVBcmVhOjpzY3JvbGwoKS4KKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckxheWVyOjp1cGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXQpOiBTdG9wIGNh bGxpbmcKKyAgICAgICAgdXBkYXRlTGF5ZXJTY3JvbGxhYmxlQXJlYSgpIC0tIFJlbmRlckxheWVy OjpzdHlsZWRDaGFuZ2VkKCkgaXMKKyAgICAgICAgcmVzcG9uc2libGUgZm9yIG1hbmFnaW5nIHRo ZSBSZW5kZXJMYXllclNjcm9sbGFibGVBcmVhIGxpZmV0aW1lLgorCiAyMDIxLTAxLTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVVByb2Nlc3NdIE1hcmsg SU9TdXJmYWNlIGJhY2tpbmcgZm9yIFJlbW90ZUdyYXBoaWNzQ29udGV4dEdMJ3MgZGlzcGxheUJ1 ZmZlciBhcyBvd25lZCBieSB0aGUgV2ViUHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJMYXllci5jcHAKaW5kZXggMjMwZmEyYTFhOGQyMTJhZGE2NzM1OWRhNzNjMDliMTA1MDUx ZTIxZC4uZmU1NzBmOTkxMzIxZTUyMjI3MzE0MGJmYzVmOGFjMjVlNmY2NTQyNCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwCkBAIC01MjQsNyArNTI0LDkgQEAgaW50 IFJlbmRlckxheWVyOjpob3Jpem9udGFsU2Nyb2xsYmFySGVpZ2h0KE92ZXJsYXlTY3JvbGxiYXJT aXplUmVsZXZhbmN5IHJlbGV2YW4KIAogYm9vbCBSZW5kZXJMYXllcjo6c2Nyb2xsKFNjcm9sbERp cmVjdGlvbiBkaXJlY3Rpb24sIFNjcm9sbEdyYW51bGFyaXR5IGdyYW51bGFyaXR5LCBmbG9hdCBt dWx0aXBsaWVyKQogewotICAgIHJldHVybiBlbnN1cmVMYXllclNjcm9sbGFibGVBcmVhKCktPnNj cm9sbChkaXJlY3Rpb24sIGdyYW51bGFyaXR5LCBtdWx0aXBsaWVyKTsKKyAgICBpZiAobV9zY3Jv bGxhYmxlQXJlYSkKKyAgICAgICAgcmV0dXJuIG1fc2Nyb2xsYWJsZUFyZWEtPnNjcm9sbChkaXJl Y3Rpb24sIGdyYW51bGFyaXR5LCBtdWx0aXBsaWVyKTsKKyAgICByZXR1cm4gZmFsc2U7CiB9CiAv LyBFbmQgb2YgdGVtcG9yYXJ5IGdsdWUgY29kZQogCkBAIC0yOTQ2LDcgKzI5NDgsNiBAQCBpbnQg UmVuZGVyTGF5ZXI6OnNjcm9sbEhlaWdodCgpIGNvbnN0CiAKIHZvaWQgUmVuZGVyTGF5ZXI6OnVw ZGF0ZVNjcm9sbEluZm9BZnRlckxheW91dCgpCiB7Ci0gICAgdXBkYXRlTGF5ZXJTY3JvbGxhYmxl QXJlYSgpOwogICAgIGlmIChtX3Njcm9sbGFibGVBcmVhKQogICAgICAgICBtX3Njcm9sbGFibGVB cmVhLT51cGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlvdXQoKTsKIH0K 418094 2021-01-21 15:36:42 -0800 2021-01-21 19:09:35 -0800 Patch bug-220743-20210122003641.patch text/plain 2952 zimmermann U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMxNTlhNWM0M2RjOTA0 MmU0MTM0MWJjNjg5MDJjMzE2MDAzYjI5ZS4uNzI4MGFmMTQ2YWNiOGU1YTM3ZDNkZGFmOGJiZjJh MWQ0ZTlmNGZhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTAxLTIxICBOaWtv bGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JF U1NJT04gKHIyNzE1NTkpOiBbQmlnU3VyXSBmYXN0L2Zvcm1zL3Bhc3N3b3JkLXNjcm9sbGVkLWFm dGVyLWNhcHMtbG9jay10b2dnbGVkLmh0bWwgaXMgY29uc2lzdGVudGx5IGZhaWxpbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDc0MworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENyZWF0ZSBSZW5kZXJM YXllclNjcm9sbGFibGVBcmVhIG9iamVjdHMgZm9yIGxheWVycyB0aGF0IGVzdGFibGlzaAorICAg ICAgICBvdmVyZmxvdyBjbGlwcGluZyAob3ZlcmZsb3c6IGhpZGRlbikuIEl0IGlzIHVuZm9ydHVu YXRlIHRoYXQgdGhpcyBpcworICAgICAgICBuZWNlc3NhcnkgYW5kIGNvdWxkIGJlIG9wdGltaXpl ZCBpbiB0aGUgZnV0dXJlLgorCisgICAgICAgIENvdmVyZWQgYnkgZmFzdC9mb3Jtcy9wYXNzd29y ZC1zY3JvbGxlZC1hZnRlci1jYXBzLWxvY2stdG9nZ2xlZC5odG1sLgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCb3g6OnJlcXVp cmVzTGF5ZXJXaXRoU2Nyb2xsYWJsZUFyZWEgY29uc3QpOiBMYXllcnMKKyAgICAgICAgdGhhdCBl c3RhYmxpc2ggb3ZlcmZsb3cgY2xpcHBpbmcgKG92ZXJmbG93OiBoaWRkZW4pIG5lZWQgdG8gY3Jl YXRlCisgICAgICAgIFJlbmRlckxheWVyU2Nyb2xsYWJsZUFyZWEuCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckxheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyOjpzY3Jv bGwpOiBBdm9pZCB1bm5lY2Vzc2FyeSBjcmVhdGlvbiBvZgorICAgICAgICBSZW5kZXJMYXllclNj cm9sbGFibGVBcmVhLiBDYWxsaW5nIHNjcm9sbCgpIHNob3VsZCBlYXJseSByZXR1cm4gaGVyZQor ICAgICAgICBpbnN0ZWFkIG9mIHJldHVybmluZyBmYWxzZSBmcm9tIFJlbmRlckxheWVyU2Nyb2xs YWJsZUFyZWE6OnNjcm9sbCgpLgorCiAyMDIxLTAxLTIxICBKdWxpYW4gR29uemFsZXogIDxqdWxp YW5fYV9nb256YWxlekBhcHBsZS5jb20+CiAKICAgICAgICAgemVybyBhbmQgcmVuYW1lIGJvdW5k aW5nUmVjdCBwb2ludGVyIGluIEZvbnQ6OnBsYXRmb3JtQm91bmRzRm9yR2x5cGgoKSB0byBDVEZv bnRHZXRCb3VuZGluZ1JlY3RzRm9yR2x5cGhzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveC5jcHAKaW5kZXggODZjODlmM2IwNjA0YWZkY2EzZWQ5N2NmZWNjZTMzMGViNzk4ODk3MS4u ODRkZTZkNjgyODM0Y2U0Njc4Nzc1MWYzMDNmNWYwOWYxYzA5ZDkxNCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckJveC5jcHAKQEAgLTkzNyw3ICs5MzcsNyBAQCBib29sIFJlbmRlckJv eDo6cmVxdWlyZXNMYXllcldpdGhTY3JvbGxhYmxlQXJlYSgpIGNvbnN0CiAgICAgICAgIHJldHVy biB0cnVlOwogCiAgICAgLy8gT3ZlcmZsb3cgaGFuZGxpbmcgbmVlZHMgUmVuZGVyTGF5ZXJTY3Jv bGxhYmxlQXJlYS4KLSAgICBpZiAoc2Nyb2xsc092ZXJmbG93KCkgfHwgaGFzSG9yaXpvbnRhbE92 ZXJmbG93KCkgfHwgaGFzVmVydGljYWxPdmVyZmxvdygpKQorICAgIGlmIChzY3JvbGxzT3ZlcmZs b3coKSB8fCBoYXNPdmVyZmxvd0NsaXAoKSB8fCBoYXNIb3Jpem9udGFsT3ZlcmZsb3coKSB8fCBo YXNWZXJ0aWNhbE92ZXJmbG93KCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgLy8gUmVz aXplIGhhbmRsaW5nIG5lZWRzIFJlbmRlckxheWVyU2Nyb2xsYWJsZUFyZWEuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlckxheWVyLmNwcAppbmRleCAyMzBmYTJhMWE4ZDIxMmFkYTY3MzU5 ZGE3M2MwOWIxMDUwNTFlMjFkLi5lYTg5ZTEzMTMzN2ZkYjdlMWNlZjI1OGFjMzU2NzgxNTM0Yjhi ZDM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllci5jcHAKQEAgLTUyNCw3 ICs1MjQsOSBAQCBpbnQgUmVuZGVyTGF5ZXI6Omhvcml6b250YWxTY3JvbGxiYXJIZWlnaHQoT3Zl cmxheVNjcm9sbGJhclNpemVSZWxldmFuY3kgcmVsZXZhbgogCiBib29sIFJlbmRlckxheWVyOjpz Y3JvbGwoU2Nyb2xsRGlyZWN0aW9uIGRpcmVjdGlvbiwgU2Nyb2xsR3JhbnVsYXJpdHkgZ3JhbnVs YXJpdHksIGZsb2F0IG11bHRpcGxpZXIpCiB7Ci0gICAgcmV0dXJuIGVuc3VyZUxheWVyU2Nyb2xs YWJsZUFyZWEoKS0+c2Nyb2xsKGRpcmVjdGlvbiwgZ3JhbnVsYXJpdHksIG11bHRpcGxpZXIpOwor ICAgIGlmIChtX3Njcm9sbGFibGVBcmVhKQorICAgICAgICByZXR1cm4gbV9zY3JvbGxhYmxlQXJl YS0+c2Nyb2xsKGRpcmVjdGlvbiwgZ3JhbnVsYXJpdHksIG11bHRpcGxpZXIpOworICAgIHJldHVy biBmYWxzZTsKIH0KIC8vIEVuZCBvZiB0ZW1wb3JhcnkgZ2x1ZSBjb2RlCiAK