220731 2021-01-19 08:10:33 -0800 Web Inspector: `Historical Figures` string should be `Alternate Glyphs` 2021-01-19 13:26:47 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 pangle pangle aakash_jain bburg ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1720528 0 pangle 2021-01-19 08:10:33 -0800 `Historical Figures` is very similar to the value `Historical Forms`, which can cause confusion in localization. While Historical forms is the only valid value at this time, it will be more accurate and create less confusion to name this field `Alternate Glyphs`, which is a better analogue to the underlying `font-variant-alternates` property. 1720530 1 417877 pangle 2021-01-19 08:27:12 -0800 Created attachment 417877 Patch v1.0 1720534 2 pangle 2021-01-19 08:41:07 -0800 <rdar://73206500> 1720562 3 417877 bburg 2021-01-19 10:07:28 -0800 Comment on attachment 417877 Patch v1.0 r=me 1720563 4 ews-feeder 2021-01-19 10:10:04 -0800 commit-queue failed to commit attachment 417877 to WebKit repository. 1720575 5 ews-feeder 2021-01-19 10:30:46 -0800 commit-queue failed to commit attachment 417877 to WebKit repository. 1720664 6 ews-feeder 2021-01-19 13:26:46 -0800 Committed r271612: <https://trac.webkit.org/changeset/271612> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417877. 417877 2021-01-19 08:27:12 -0800 2021-01-19 13:26:47 -0800 Patch v1.0 bug-220731-20210119112711.patch text/plain 4820 pangle U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAz NzA4ZjgwM2RhZjgwNGE1NDUwNmUwYzg4MTliOTY1NDQzMDk5ZGM4Li40NWNhZWE1NmI2N2U5ZDVk MTRkZWE3MjUxN2VmNmQ1ODJiNzk2NDc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wMS0xOSAgUGF0cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYEhpc3RvcmljYWwgRmlndXJlc2Agc3RyaW5nIHNo b3VsZCBiZSBgQWx0ZXJuYXRlIEdseXBoc2AKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIyMDczMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIENoYW5nZWQgdGl0bGUgZm9yIENTUyBwcm9wZXJ0eSBgZm9udC12 YXJpYW50LWFsdGVybmF0ZXNgIHRvIGJlIGBBbHRlcm5hdGUgR2x5cGhzYC4KKworICAgICAgICAq IExvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL1ZpZXdzL0ZvbnREZXRhaWxzUGFuZWwuanM6CisgICAgICAgIChXSS5Gb250 RGV0YWlsc1BhbmVsLnByb3RvdHlwZS5pbml0aWFsTGF5b3V0KToKKwogMjAyMS0wMS0xNSAgUGF0 cmljayBBbmdsZSAgPHBhbmdsZUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjog Rm9udCBEZXRhaWxzIHNpZGViYXIgLSBJbXByb3ZlIGxpbmUgd3JhcHBpbmcgb2YgdGFibGUgcm93 IHRpdGxlcyB3aGVuIHNwYWNlIGlzIGF2YWlsYWJsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmlu Z3MuanMKaW5kZXggMTM4YjcwM2JlMzU0NzljOWUwMzgzY2NmY2I4ZjYxMjVlNTgxYzczMy4uNzc0 ODVmMzMxOTc0MzNkZmM4ODZjNmY1MDY5NGJmNGYzY2Q4MTE0MiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2Nh bGl6ZWRTdHJpbmdzLmpzCkBAIC0xNTIsNiArMTUyLDggQEAgbG9jYWxpemVkU3RyaW5nc1siQWxs IGl0ZW1zIGluIFx1MDAyMiVzXHUwMDIyIG11c3QgYmUgZXJyb3Igb2JqZWN0cyJdID0gIkFsbCBp dGUKIGxvY2FsaXplZFN0cmluZ3NbIkFsbCBpdGVtcyBpbiBcdTAwMjIlc1x1MDAyMiBtdXN0IGJl IG5vbi1lbXB0eSBzdHJpbmdzIl0gPSAiQWxsIGl0ZW1zIGluIFx1MDAyMiVzXHUwMDIyIG11c3Qg YmUgbm9uLWVtcHR5IHN0cmluZ3MiOwogbG9jYWxpemVkU3RyaW5nc1siQWxsIGl0ZW1zIGluIFx1 MDAyMiVzXHUwMDIyIG11c3QgYmUgdmFsaWQgRE9NIG5vZGVzIl0gPSAiQWxsIGl0ZW1zIGluIFx1 MDAyMiVzXHUwMDIyIG11c3QgYmUgdmFsaWQgRE9NIG5vZGVzIjsKIGxvY2FsaXplZFN0cmluZ3Nb IkFsbG93IE1lZGlhIENhcHR1cmUgb24gSW5zZWN1cmUgU2l0ZXMiXSA9ICJBbGxvdyBNZWRpYSBD YXB0dXJlIG9uIEluc2VjdXJlIFNpdGVzIjsKKy8qIFByb3BlcnR5IHRpdGxlIGZvciBgZm9udC12 YXJpYW50LWFsdGVybmF0ZXNgLiAqLworbG9jYWxpemVkU3RyaW5nc1siQWx0ZXJuYXRlIEdseXBo cyBAIEZvbnQgRGV0YWlscyBTaWRlYmFyIFByb3BlcnR5Il0gPSAiQWx0ZXJuYXRlIEdseXBocyI7 CiBsb2NhbGl6ZWRTdHJpbmdzWyJBbiBlcnJvciBvY2N1cnJlZCB0cnlpbmcgdG8gbG9hZCB0aGUg cmVzb3VyY2UuIl0gPSAiQW4gZXJyb3Igb2NjdXJyZWQgdHJ5aW5nIHRvIGxvYWQgdGhlIHJlc291 cmNlLiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJBbiBlcnJvciBvY2N1cnJlZCB0cnlpbmcgdG8gcmVh ZCB0aGUgXHUyMDFDJXNcdTIwMUQgdGFibGUuIl0gPSAiQW4gZXJyb3Igb2NjdXJyZWQgdHJ5aW5n IHRvIHJlYWQgdGhlIFx1MjAxQyVzXHUyMDFEIHRhYmxlLiI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJB biB1bmV4cGVjdGVkIGVycm9yICVzIG9jY3VycmVkLiJdID0gIkFuIHVuZXhwZWN0ZWQgZXJyb3Ig JXMgb2NjdXJyZWQuIjsKQEAgLTczNSw4ICs3MzcsNiBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJIaWdo IEAgVGltZWxpbmUgRW5lcmd5IEltcGFjdCJdID0gIkhpZ2giOwogbG9jYWxpemVkU3RyaW5nc1si SGlnaGVzdDogJXMiXSA9ICJIaWdoZXN0OiAlcyI7CiAvKiBQcm9wZXJ0eSB2YWx1ZSBmb3IgYGZv bnQtdmFyaWFudC1saWdhdHVyZXM6IGhpc3RvcmljYWwtbGlnYXR1cmVzYC4gKi8KIGxvY2FsaXpl ZFN0cmluZ3NbIkhpc3RvcmljYWwgQCBGb250IERldGFpbHMgU2lkZWJhciBQcm9wZXJ0eSBWYWx1 ZSJdID0gIkhpc3RvcmljYWwiOwotLyogUHJvcGVydHkgdGl0bGUgZm9yIGBmb250LXZhcmlhbnQt YWx0ZXJuYXRlc2AuICovCi1sb2NhbGl6ZWRTdHJpbmdzWyJIaXN0b3JpY2FsIEZpZ3VyZXMgQCBG b250IERldGFpbHMgU2lkZWJhciBQcm9wZXJ0eSJdID0gIkhpc3RvcmljYWwgRmlndXJlcyI7CiAv KiBQcm9wZXJ0eSB2YWx1ZSBmb3IgYGZvbnQtdmFyaWFudC1hbHRlcm5hdGVzOiBoaXN0b3JpY2Fs LWZvcm1zYC4gKi8KIGxvY2FsaXplZFN0cmluZ3NbIkhpc3RvcmljYWwgRm9ybXMgQCBGb250IERl dGFpbHMgU2lkZWJhciBQcm9wZXJ0eSBWYWx1ZSJdID0gIkhpc3RvcmljYWwgRm9ybXMiOwogbG9j YWxpemVkU3RyaW5nc1siSG9zdCJdID0gIkhvc3QiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9udERldGFpbHNQYW5lbC5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZvbnREZXRhaWxzUGFuZWwuanMK aW5kZXggM2QyOWFjMjNmMjRlYjJkMmNlYTI5YjkzZjZhOWE1ZDVkNTAwMTkzNC4uNjM1MzUxNTI1 OTQ1NmU2ZjU1YWU0NDc4YmIyYWYzZDUwODM0MWIwMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRm9udERldGFpbHNQYW5lbC5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Gb250RGV0YWlsc1BhbmVs LmpzCkBAIC0xMTQsNyArMTE0LDcgQEAgV0kuRm9udERldGFpbHNQYW5lbCA9IGNsYXNzIEZvbnRE ZXRhaWxzUGFuZWwgZXh0ZW5kcyBXSS5TdHlsZURldGFpbHNQYW5lbAogICAgICAgICB0aGlzLl9m b250VmFyaWFudFBvc2l0aW9uUm93ID0gbmV3IFdJLkRldGFpbHNTZWN0aW9uU2ltcGxlUm93KFdJ LlVJU3RyaW5nKCJQb3NpdGlvbiIsICJQb3NpdGlvbiBAIEZvbnQgRGV0YWlscyBTaWRlYmFyIFBy b3BlcnR5IiwgIlByb3BlcnR5IHRpdGxlIGZvciBgZm9udC12YXJpYW50LXBvc2l0aW9uYC4iKSk7 CiAgICAgICAgIHRoaXMuX2ZvbnRWYXJpYW50Q2Fwc1JvdyA9IG5ldyBXSS5EZXRhaWxzU2VjdGlv blNpbXBsZVJvdyhXSS5VSVN0cmluZygiQ2FwaXRhbHMiLCAiQ2FwaXRhbHMgQCBGb250IERldGFp bHMgU2lkZWJhciBQcm9wZXJ0eSIsICJQcm9wZXJ0eSB0aXRsZSBmb3IgYGZvbnQtdmFyaWFudC1j YXBzYC4iKSk7CiAgICAgICAgIHRoaXMuX2ZvbnRWYXJpYW50TnVtZXJpY1JvdyA9IG5ldyBXSS5E ZXRhaWxzU2VjdGlvblNpbXBsZVJvdyhXSS5VSVN0cmluZygiTnVtZXJpYyIsICJOdW1lcmljIEAg Rm9udCBEZXRhaWxzIFNpZGViYXIgUHJvcGVydHkiLCAiUHJvcGVydHkgdGl0bGUgZm9yIGBmb250 LXZhcmlhbnQtbnVtZXJpY2AuIikpOwotICAgICAgICB0aGlzLl9mb250VmFyaWFudEFsdGVybmF0 ZXNSb3cgPSBuZXcgV0kuRGV0YWlsc1NlY3Rpb25TaW1wbGVSb3coV0kuVUlTdHJpbmcoIkhpc3Rv cmljYWwgRmlndXJlcyIsICJIaXN0b3JpY2FsIEZpZ3VyZXMgQCBGb250IERldGFpbHMgU2lkZWJh ciBQcm9wZXJ0eSIsICJQcm9wZXJ0eSB0aXRsZSBmb3IgYGZvbnQtdmFyaWFudC1hbHRlcm5hdGVz YC4iKSk7CisgICAgICAgIHRoaXMuX2ZvbnRWYXJpYW50QWx0ZXJuYXRlc1JvdyA9IG5ldyBXSS5E ZXRhaWxzU2VjdGlvblNpbXBsZVJvdyhXSS5VSVN0cmluZygiQWx0ZXJuYXRlIEdseXBocyIsICJB bHRlcm5hdGUgR2x5cGhzIEAgRm9udCBEZXRhaWxzIFNpZGViYXIgUHJvcGVydHkiLCAiUHJvcGVy dHkgdGl0bGUgZm9yIGBmb250LXZhcmlhbnQtYWx0ZXJuYXRlc2AuIikpOwogICAgICAgICB0aGlz Ll9mb250VmFyaWFudEVhc3RBc2lhblJvdyA9IG5ldyBXSS5EZXRhaWxzU2VjdGlvblNpbXBsZVJv dyhXSS5VSVN0cmluZygiRWFzdCBBc2lhbiIsICJFYXN0IEFzaWFuIEAgRm9udCBEZXRhaWxzIFNp ZGViYXIgUHJvcGVydHkiLCAiUHJvcGVydHkgdGl0bGUgZm9yIGBmb250LXZhcmlhbnQtZWFzdC1h c2lhbmAuIikpOwogICAgICAgICBsZXQgZmVhdHVyZVByb3BlcnRpZXNHcm91cCA9IG5ldyBXSS5E ZXRhaWxzU2VjdGlvbkdyb3VwKFt0aGlzLl9mb250VmFyaWFudExpZ2F0dXJlc1JvdywgdGhpcy5f Zm9udFZhcmlhbnRQb3NpdGlvblJvdywgdGhpcy5fZm9udFZhcmlhbnRDYXBzUm93LCB0aGlzLl9m b250VmFyaWFudE51bWVyaWNSb3csIHRoaXMuX2ZvbnRWYXJpYW50QWx0ZXJuYXRlc1JvdywgdGhp cy5fZm9udFZhcmlhbnRFYXN0QXNpYW5Sb3ddKTsKIAo=