220720 2021-01-18 20:01:15 -0800 REGRESSION(r271444) [WPE] fast/canvas/webgl/oes-vertex-array-object.html is failing 2021-07-23 00:32:16 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220372 https://bugs.webkit.org/show_bug.cgi?id=169917 InRadar P2 Normal --- 1 lmoura webkit-unassigned aperez bugs-noreply dino dpino estea kbr kkinnunen kpiddington webkit-bug-importer oldest_to_newest 1720460 0 lmoura 2021-01-18 20:01:15 -0800 fast/canvas/webgl/oes-vertex-array-object.html Diff: --- /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/oes-vertex-array-object-expected.txt +++ /home/buildbot/worker/wpe-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/oes-vertex-array-object-actual.txt @@ -36,6 +36,9 @@ PASS Draw 1 passed pixel test PASS Draw 2 passed pixel test Testing using deleted buffers referenced by VAOs +FAIL buffer removed too early +FAIL buffer removed too early +FAIL buffer removed too early PASS should be 255,0,0,255 PASS should be 0,255,0,255 PASS should be 0,0,255,255 @@ -46,6 +49,7 @@ PASS getError was expected value: NO_ERROR : there should be no errors PASS successfullyParsed is true +Some tests failed. TEST COMPLETE These "buffer removed too early" also started appearing in GTK results (It already failed there with other assertion errors). 1720627 1 kbr 2021-01-19 12:41:19 -0800 Sorry about this regression which was apparently introduced with the fix for Bug 220372. Can the WPE port switch over to the USE_ANGLE code path? ANGLE runs on Linux, so hopefully this should be a straightforward switch. 1768092 2 dpino 2021-06-09 00:48:53 -0700 We're working on enabling ANGLE on GLIB ports. In the meantime, I'd use this bug the file same regressions for WebKitGTK. Output is slightly different: --- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/oes-vertex-array-object-expected.txt +++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/canvas/webgl/oes-vertex-array-object-actual.txt @@ -1,3 +1,7 @@ +CONSOLE MESSAGE: *** Error loading shader '[object WebGLShader]':INVALID_OPERATION +CONSOLE MESSAGE: Error in compiling shader +CONSOLE MESSAGE: *** Error loading shader '[object WebGLShader]':INVALID_OPERATION +CONSOLE MESSAGE: Error in compiling shader This test verifies the functionality of the OES_vertex_array_object extension, if it is available. On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". @@ -32,20 +36,30 @@ Testing that attribute values are not attached to bindings PASS Vertex attribute values are not attached to bindings Testing draws with various VAO bindings -PASS Draw 0 passed pixel test +FAIL Draw 0 failed pixel test PASS Draw 1 passed pixel test PASS Draw 2 passed pixel test Testing using deleted buffers referenced by VAOs -PASS should be 255,0,0,255 -PASS should be 0,255,0,255 -PASS should be 0,0,255,255 -PASS should be 0,255,255,255 +FAIL buffer removed too early +FAIL buffer removed too early +FAIL buffer removed too early +FAIL should be 255,0,0,255 +at (0, 0) expected: 255,0,0,255 was 255,255,255,255 +FAIL should be 0,255,0,255 +at (0, 0) expected: 0,255,0,255 was 255,255,255,255 +FAIL should be 0,0,255,255 +at (0, 0) expected: 0,0,255,255 was 255,255,255,255 +FAIL should be 0,255,255,255 +at (0, 0) expected: 0,255,255,255 was 255,255,255,255 Testing that VAOs don't effect ARRAY_BUFFER binding. -PASS should be red -PASS should be green -PASS getError was expected value: NO_ERROR : there should be no errors +FAIL should be red +at (0, 0) expected: 255,0,0,255 was 255,255,255,255 +FAIL should be green +at (0, 0) expected: 0,255,0,255 was 255,255,255,255 +FAIL getError expected: NO_ERROR. Was INVALID_OPERATION : there should be no errors PASS successfullyParsed is true +Some tests failed. TEST COMPLETE 1777709 3 433731 estea 2021-07-17 04:24:07 -0700 Created attachment 433731 Patch 1777710 4 estea 2021-07-17 04:30:15 -0700 I think that this test should be removed as it is based in the incorrect assumption that deleted buffer names remain valid until the object they used to refer to is destroyed. According to the WebGL spec (this paragraph is present in 1.0.0 and on): https://www.khronos.org/registry/webgl/specs/1.0.3/ section: 5.14.5 isBuffer "Return false if the buffer's invalidated flag is set", this is not true and names become invalid immediately. So, the correct behavior is that after the user calls deleteBuffer the buffer is invalidated (== marked as deleted), although it is still valid, and isBuffer returns false. If you check the WebGL implementation of isBuffer, we return false when the object is marked as deleted (m_deleted is true) which is the correct behavior, and that's why the incorrect test fails. This patch together with this fix (WIP the MacOSX problem in comments): https://bugs.webkit.org/show_bug.cgi?id=96828 fix make the vertex array OES tests pass. 1778957 5 433731 kbr 2021-07-22 19:15:08 -0700 Comment on attachment 433731 Patch This test is quite out of date with respect to the top-of-tree version of the test. It's OK to remove just this portion, but ideally we'd start running the webgl/1.0.x and webgl/2.0.y versions of the layout tests and remove all of the now-obsolete ones. r+ FYI, the win EWS failures are unrelated to this patch. 1778994 6 ews-feeder 2021-07-23 00:31:03 -0700 Committed r280218 (239905@main): <https://commits.webkit.org/239905@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433731. 1778995 7 webkit-bug-importer 2021-07-23 00:32:16 -0700 <rdar://problem/81006096> 433731 2021-07-17 04:24:07 -0700 2021-07-23 00:31:05 -0700 Patch bug-220720-20210717142253.patch text/plain 1907 estea U3VidmVyc2lvbiBSZXZpc2lvbjogMjgwMDE3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMWVmM2QzOWU0NWU4NjIxYTI0NDE4 N2EzZDQ3OTFlY2MyZTBjYTE3ZC4uODJlYmY2Y2RiZTNiZmVhOGRlMDk5YjUxODUwM2MxOTM2ODVh Mzk2YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTA3LTE3ICBFbGVuaSBNYXJpYSBTdGVh ICA8ZXN0ZWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSZW1vdmVkIGluY29ycmVjdCB0ZXN0IGZy b20gd2ViZ2wgdGVzdHMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjA3MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUaGUgcmVtb3ZlZCB0ZXN0IHdhcyBiYXNlZCBvbiB0aGUgaW5jb3JyZWN0IGFzc3Vt cHRpb24gdGhhdAorICAgICAgICBkZWxldGVkIGJ1ZmZlciBuYW1lcyByZW1haW4gdmFsaWQgdW50 aWwgdGhlIG9iamVjdCB0aGV5IHVzZWQgdG8KKyAgICAgICAgcmVmZXIgdG8gaXMgZGVzdHJveWVk LiBBY2NvcmRpbmcgdG8gdGhlIFdlYkdMIHNwZWM6CisgICAgICAgIGh0dHBzOi8vd3d3Lmtocm9u b3Mub3JnL3JlZ2lzdHJ5L3dlYmdsL3NwZWNzLzEuMC4zLyBzZWN0aW9uOgorICAgICAgICA1LjE0 LjUgaXNCdWZmZXIgIlJldHVybiBmYWxzZSBpZiB0aGUgYnVmZmVyJ3MgaW52YWxpZGF0ZWQgZmxh ZworICAgICAgICBpcyBzZXQiLCB0aGlzIGlzIG5vdCB0cnVlIGFuZCBuYW1lcyBiZWNvbWUgaW52 YWxpZCBpbW1lZGlhdGVseS4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL29lcy12ZXJ0 ZXgtYXJyYXktb2JqZWN0Lmh0bWw6CisKIDIwMjEtMDctMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9u LmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCkgcmV0 dXJucyB0aGUgaW5jb3JyZWN0IHJlY3RhbmdsZSBvbiBlbGVtZW50cyB3aG9zZSBwYXJlbnQgZWxl bWVudCBpcyBzZXQgLXdlYmtpdC1jb2x1bW4tY291bnQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2Zhc3QvY2FudmFzL3dlYmdsL29lcy12ZXJ0ZXgtYXJyYXktb2JqZWN0Lmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9vZXMtdmVydGV4LWFycmF5LW9iamVjdC5odG1sCmluZGV4 IGE1NTNkNTNiYjY4ODQ0YzQwMzkzODE4M2Y4ZmUyN2YyYWRhMTgzNzEuLjg5ZTM2MjM1ZmI3Zjlh M2MzZDk5ZWI4YWIyMzY3YzA4ZDFlYTJiMzEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv Y2FudmFzL3dlYmdsL29lcy12ZXJ0ZXgtYXJyYXktb2JqZWN0Lmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9jYW52YXMvd2ViZ2wvb2VzLXZlcnRleC1hcnJheS1vYmplY3QuaHRtbApAQCAtNDc4 LDEwICs0NzgsNiBAQCBmdW5jdGlvbiBydW5EZWxldGVUZXN0cygpIHsKICAgICBmb3IgKHZhciBp aSA9IDA7IGlpIDwgY29sb3JCdWZmZXJzLmxlbmd0aDsgKytpaSkgewogICAgICAgZ2wuZGVsZXRl QnVmZmVyKGNvbG9yQnVmZmVyc1tpaV0pOwogICAgICAgZ2wuZGVsZXRlQnVmZmVyKGVsZW1lbnRC dWZmZXJzW2lpXSk7Ci0gICAgICAvLyBUaGUgYnVmZmVycyBzaG91bGQgc3RpbGwgYmUgdmFsaWQg YXQgdGhpcyBwb2ludCwgc2luY2UgaXQgd2FzIGF0dGFjaGVkIHRvIHRoZSBWQU8KLSAgICAgIGlm KCFnbC5pc0J1ZmZlcihjb2xvckJ1ZmZlcnNbaWldKSkgewotICAgICAgICB0ZXN0RmFpbGVkKCJi dWZmZXIgcmVtb3ZlZCB0b28gZWFybHkiKTsKLSAgICAgIH0KICAgICB9CiAgICAgZ2wuZGVsZXRl QnVmZmVyKHBvc2l0aW9uQnVmZmVyKTsKIAo=