220712 2021-01-18 09:31:28 -0800 Object.assign should throw for property creation on non-extensible `target` 2021-02-05 06:27:32 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Trivial --- 1 ashvayka ashvayka ews-watchlist keith_miller mark.lam msaboff ross.kirsling saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1720362 0 ashvayka 2021-01-18 09:31:28 -0800 Object.assign should always throw if `target` is non-extensible 1720364 1 417838 ashvayka 2021-01-18 09:34:53 -0800 Created attachment 417838 Patch 1720409 2 417838 ross.kirsling 2021-01-18 13:50:37 -0800 Comment on attachment 417838 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417838&action=review r=me with comments > Source/JavaScriptCore/ChangeLog:3 > + Object.assign should always throw if `target` is non-extensible Seems like "always" is a bit too strong if we don't throw when updating a property, right? > Source/JavaScriptCore/ChangeLog:12 > + Aligns JSC with the spec [1], V8, and SpiderMonkey. Should we add a test262 test too? 1721444 3 webkit-bug-importer 2021-01-21 18:10:29 -0800 <rdar://problem/73478307> 1726037 4 ashvayka 2021-02-05 06:26:48 -0800 Committed r272411: <https://trac.webkit.org/changeset/272411> 1726038 5 ashvayka 2021-02-05 06:27:32 -0800 (In reply to Ross Kirsling from comment #2) Thank you for review, Ross! > Seems like "always" is a bit too strong if we don't throw when updating a > property, right? Absolutely, I've renamed the bug. > Should we add a test262 test too? Extensive tests are coming in https://github.com/tc39/test262/pull/2945. 417838 2021-01-18 09:34:53 -0800 2021-01-18 13:50:37 -0800 Patch bug-220712-20210118193451.patch text/plain 3366 ashvayka SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzE1ODApCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEyIEBACisyMDIxLTAxLTE4ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KKworICAgICAgICBPYmplY3QuYXNzaWduIHNob3VsZCBhbHdheXMgdGhyb3cg aWYgYHRhcmdldGAgaXMgbm9uLWV4dGVuc2libGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDcxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNzL29iamVjdC1hc3NpZ24tZmFzdC1wYXRoLmpz OgorCiAyMDIxLTAxLTE4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CiAKICAg ICAgICAgW0pTQ10gY2FsbGVySXNPTUdDb21waWxlZCBzaG91bGQgYmUgcm9idXN0CkluZGV4OiBK U1Rlc3RzL3N0cmVzcy9vYmplY3QtYXNzaWduLWZhc3QtcGF0aC5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBK U1Rlc3RzL3N0cmVzcy9vYmplY3QtYXNzaWduLWZhc3QtcGF0aC5qcwkocmV2aXNpb24gMjcxNTgw KQorKysgSlNUZXN0cy9zdHJlc3Mvb2JqZWN0LWFzc2lnbi1mYXN0LXBhdGguanMJKHdvcmtpbmcg Y29weSkKQEAgLTE2MywzICsxNjMsMTkgQEAgZnVuY3Rpb24gY2hlY2tQcm9wZXJ0eShvYmplY3Qs IG5hbWUsIHZhbAogICAgIHNob3VsZEJlKHJlc3VsdC5oZWxsbywgMCk7CiAgICAgc2hvdWxkQmUo c2V0dGVyQ2FsbGVkV2l0aFZhbHVlLCAid29ybGQiKTsKIH0KK3sKKyAgICBsZXQgb2JqZWN0ID0g T2JqZWN0LmZyZWV6ZSh7IGZvbzogMSB9KTsKKyAgICBzaG91bGRCZShPYmplY3QuYXNzaWduKG9i amVjdCwge30pLCBvYmplY3QpOworfQoreworICAgIGxldCBvYmplY3QgPSBPYmplY3QucHJldmVu dEV4dGVuc2lvbnMoeyBmb286IDEgfSk7CisgICAgc2hvdWxkQmUoT2JqZWN0LmFzc2lnbihvYmpl Y3QsIHsgZm9vOiAyIH0pLCBvYmplY3QpOworICAgIHNob3VsZEJlKG9iamVjdC5mb28sIDIpOwor fQoreworICAgIGxldCBvYmplY3QgPSBPYmplY3QucHJldmVudEV4dGVuc2lvbnMoeyBmb286IDEg fSk7CisgICAgc2hvdWxkVGhyb3coKCkgPT4geworICAgICAgICBPYmplY3QuYXNzaWduKG9iamVj dCwgeyBiYXI6IDIgfSk7CisgICAgfSwgYFR5cGVFcnJvcjogQXR0ZW1wdGVkIHRvIGFzc2lnbiB0 byByZWFkb25seSBwcm9wZXJ0eS5gKTsKKyAgICBzaG91bGRCZShvYmplY3QuYmFyLCB1bmRlZmlu ZWQpOworfQpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNzE1ODApCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMg KzEsMjEgQEAKKzIwMjEtMDEtMTggIEFsZXhleSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwu Y29tPgorCisgICAgICAgIE9iamVjdC5hc3NpZ24gc2hvdWxkIGFsd2F5cyB0aHJvdyBpZiBgdGFy Z2V0YCBpcyBub24tZXh0ZW5zaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjIwNzEyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBwZXJmb3JtYW5jZS1uZXV0cmFsIGNoYW5nZSBwcmVjbHVkZXMg T2JqZWN0LmFzc2lnbiBmcm9tIHRha2luZyB0aGUKKyAgICAgICAgZmFzdCBwYXRoIGlmIGB0YXJn ZXRgIGlzIGEgbm9uLWV4dGVuc2libGUgSlNGaW5hbE9iamVjdCwgd2hpY2ggZW5zdXJlcworICAg ICAgICBhIFR5cGVFcnJvciBpcyB0aHJvd24gZm9yIHByb3BlcnR5IGNyZWF0aW9uIHZpYSBbW1Nl dF1dLgorCisgICAgICAgIEFsaWducyBKU0Mgd2l0aCB0aGUgc3BlYyBbMV0sIFY4LCBhbmQgU3Bp ZGVyTW9ua2V5LgorCisgICAgICAgIFsxXTogaHR0cHM6Ly90YzM5LmVzL2VjbWEyNjIvI3NlYy12 YWxpZGF0ZWFuZGFwcGx5cHJvcGVydHlkZXNjcmlwdG9yIChzdGVwIDIuYSkKKworICAgICAgICAq IHJ1bnRpbWUvT2JqZWN0Q29uc3RydWN0b3IuY3BwOgorICAgICAgICAoSlNDOjpKU0NfREVGSU5F X0hPU1RfRlVOQ1RJT04pOgorCiAyMDIxLTAxLTE4ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRh bnphcm9AZ25vbWUub3JnPgogCiAgICAgICAgIFtHVEtdIE11bHRpbGliIGNvbmZsaWN0cyBpbiBn aXIgZmlsZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0 cnVjdG9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9P YmplY3RDb25zdHJ1Y3Rvci5jcHAJKHJldmlzaW9uIDI3MTU4MCkKKysrIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09iamVjdENvbnN0cnVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MjczLDcgKzI3Myw3IEBAIEpTQ19ERUZJTkVfSE9TVF9GVU5DVElPTihvYmplY3RDb25zdHJ1Y3QK IAogICAgIC8vIEZJWE1FOiBFeHRlbmQgdGhpcyBmb3Igbm9uIEpTRmluYWxPYmplY3QuIEZvciBl eGFtcGxlLCB3ZSB3b3VsZCBsaWtlIHRvIHVzZSB0aGlzIGZhc3QgcGF0aCBmb3IgZnVuY3Rpb24g b2JqZWN0cyB0b28uCiAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4NTM1OAotICAgIGJvb2wgdGFyZ2V0Q2FuUGVyZm9ybUZhc3RQdXQgPSBqc0R5bmFtaWND YXN0PEpTRmluYWxPYmplY3QqPih2bSwgdGFyZ2V0KSAmJiB0YXJnZXQtPmNhblBlcmZvcm1GYXN0 UHV0SW5saW5lRXhjbHVkaW5nUHJvdG8odm0pOworICAgIGJvb2wgdGFyZ2V0Q2FuUGVyZm9ybUZh c3RQdXQgPSBqc0R5bmFtaWNDYXN0PEpTRmluYWxPYmplY3QqPih2bSwgdGFyZ2V0KSAmJiB0YXJn ZXQtPmNhblBlcmZvcm1GYXN0UHV0SW5saW5lRXhjbHVkaW5nUHJvdG8odm0pICYmIHRhcmdldC0+ aXNTdHJ1Y3R1cmVFeHRlbnNpYmxlKHZtKTsKIAogICAgIFZlY3RvcjxSZWZQdHI8VW5pcXVlZFN0 cmluZ0ltcGw+LCA4PiBwcm9wZXJ0aWVzOwogICAgIE1hcmtlZEFyZ3VtZW50QnVmZmVyIHZhbHVl czsK