22070 2008-11-04 15:25:48 -0800 Add an option to allow scripts to close windows. 2009-01-28 11:19:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 1 zork zork oldest_to_newest 97625 0 zork 2008-11-04 15:25:48 -0800 This is a useful option for automated testing. It allows you to set up test pages that clean up after themselves when they're done. 97626 1 24900 zork 2008-11-04 15:27:10 -0800 Created attachment 24900 Patch to implement this feature 100324 2 24900 eric 2008-11-25 16:12:48 -0800 Comment on attachment 24900 Patch to implement this feature The patch looks fine in general, but the variable names don't follow WebKit's style guidelines: http://webkit.org/coding/coding-style.html 100334 3 25513 zork 2008-11-25 16:44:24 -0800 Created attachment 25513 Patch to implement this feature Fixed the variable names to be CamelCase 100366 4 25513 sam 2008-11-25 19:44:02 -0800 Comment on attachment 25513 Patch to implement this feature > + bool allowScriptsToCloseWindows = > + (settings && settings->allowScriptsToCloseWindows()); No reason to put these on two lines. > @@ -232,6 +235,7 @@ namespace WebCore { > bool m_zoomsTextOnly : 1; > bool m_enforceCSSMIMETypeInStrictMode : 1; > size_t m_maximumDecodedImageSize; > + bool m_allowScriptsToCloseWindows : 1; If you move this bool up one place, it will not cause unnessary bloating of the object. This patch looks fine, but it is not hooked up to anything. Usually when we expose a new setting, we hook it up to the WebPreferences API (or probably SPI in this case) in WebKit. r- since this really won't do anything on its own. 103325 5 25513 sam 2008-12-23 13:45:46 -0800 Comment on attachment 25513 Patch to implement this feature I am reversing my decision here. It is a little odd to add a new setting without adding WebKit SPI to do something with it, and I would rather you did, but it is not strictly necessary. 107351 6 fishd 2009-01-28 11:19:50 -0800 http://trac.webkit.org/changeset/40315 24900 2008-11-04 15:27:10 -0800 2008-11-25 16:44:24 -0800 Patch to implement this feature AllowScriptsToCloseWindows.txt text/plain 3153 zork SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODExMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEtMDQgIFphY2hhcnkgS3V6bmlhICA8em9ya0BjaHJvbWl1 dW0ub3JnPgorCisgICAgICAgIEFkZGluZyBhIHByZWZlcmVuY2UgdG8gYWxsb3cgc2NpcHRzIHRv IGNsb3NlIHdpbmRvd3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZKE9PUFMhKQorCisg ICAgICAgICogcGFnZS9TZXR0aW5ncy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6 U2V0dGluZ3MpOgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnNldEFsbG93U2NyaXB0c1Rv Q2xvc2VXaW5kb3dzKToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAgIChXZWJD b3JlOjpTZXR0aW5nczo6YWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3MpOgorCiAyMDA4LTExLTA0 ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBKb2huIFN1bGxpdmFuCkluZGV4OiBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2aXNpb24gMzgxMTApCisrKyBX ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsNyBA QAogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSAiU2NyZWVuLmgiCiAjaW5j bHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKKyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUg PGFsZ29yaXRobT4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogCkBAIC00MzksNyArNDQw LDEzIEBAIHZvaWQgRE9NV2luZG93OjpjbG9zZSgpCiAgICAgaWYgKCFtX2ZyYW1lKQogICAgICAg ICByZXR1cm47CiAKLSAgICBpZiAobV9mcmFtZS0+bG9hZGVyKCktPm9wZW5lZEJ5RE9NKCkgfHwg bV9mcmFtZS0+bG9hZGVyKCktPmdldEhpc3RvcnlMZW5ndGgoKSA8PSAxKQorICAgIFNldHRpbmdz KiBzZXR0aW5ncyA9IG1fZnJhbWUtPnNldHRpbmdzKCk7CisgICAgYm9vbCBhbGxvd19zY3JpcHRz X3RvX2Nsb3NlX3dpbmRvd3MgPQorICAgICAgICAoc2V0dGluZ3MgJiYgc2V0dGluZ3MtPmFsbG93 U2NyaXB0c1RvQ2xvc2VXaW5kb3dzKCkpOworCisgICAgaWYgKG1fZnJhbWUtPmxvYWRlcigpLT5v cGVuZWRCeURPTSgpCisgICAgICAgIHx8IG1fZnJhbWUtPmxvYWRlcigpLT5nZXRIaXN0b3J5TGVu Z3RoKCkgPD0gMQorICAgICAgICB8fCBhbGxvd19zY3JpcHRzX3RvX2Nsb3NlX3dpbmRvd3MpCiAg ICAgICAgIG1fZnJhbWUtPnNjaGVkdWxlQ2xvc2UoKTsKIH0KIApJbmRleDogV2ViQ29yZS9wYWdl L1NldHRpbmdzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCShy ZXZpc2lvbiAzODExMCkKKysrIFdlYkNvcmUvcGFnZS9TZXR0aW5ncy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTg2LDYgKzg2LDcgQEAgU2V0dGluZ3M6OlNldHRpbmdzKFBhZ2UqIHBhZ2UpCiAgICAg LCBtX3pvb21zVGV4dE9ubHkoZmFsc2UpCiAgICAgLCBtX2VuZm9yY2VDU1NNSU1FVHlwZUluU3Ry aWN0TW9kZSh0cnVlKQogICAgICwgbV9tYXhpbXVtRGVjb2RlZEltYWdlU2l6ZShzdGQ6Om51bWVy aWNfbGltaXRzPHNpemVfdD46Om1heCgpKQorICAgICwgbV9hbGxvd19zY3JpcHRzX3RvX2Nsb3Nl X3dpbmRvd3MoZmFsc2UpCiB7CiAgICAgLy8gQSBGcmFtZSBtYXkgbm90IGhhdmUgYmVlbiBjcmVh dGVkIHlldCwgc28gd2UgaW5pdGlhbGl6ZSB0aGUgQXRvbWljU3RyaW5nIAogICAgIC8vIGhhc2gg YmVmb3JlIHRyeWluZyB0byB1c2UgaXQuCkBAIC0zOTEsNCArMzkyLDkgQEAgdm9pZCBTZXR0aW5n czo6c2V0U2hvdWxkUGFpbnROYXRpdmVDb250cgogfQogI2VuZGlmCiAKK3ZvaWQgU2V0dGluZ3M6 OnNldEFsbG93U2NyaXB0c1RvQ2xvc2VXaW5kb3dzKGJvb2wgYWxsb3dfc2NyaXB0c190b19jbG9z ZV93aW5kb3dzKQoreworICAgIG1fYWxsb3dfc2NyaXB0c190b19jbG9zZV93aW5kb3dzID0gYWxs b3dfc2NyaXB0c190b19jbG9zZV93aW5kb3dzOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CkluZGV4OiBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bh Z2UvU2V0dGluZ3MuaAkocmV2aXNpb24gMzgxMTApCisrKyBXZWJDb3JlL3BhZ2UvU2V0dGluZ3Mu aAkod29ya2luZyBjb3B5KQpAQCAtMTg0LDYgKzE4NCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgc3RhdGljIGJvb2wgc2hvdWxkUGFpbnROYXRpdmVDb250cm9scygpIHsgcmV0dXJu IGdTaG91bGRQYWludE5hdGl2ZUNvbnRyb2xzOyB9CiAjZW5kaWYKIAorICAgICAgICB2b2lkIHNl dEFsbG93U2NyaXB0c1RvQ2xvc2VXaW5kb3dzKGJvb2wpOworICAgICAgICBib29sIGFsbG93U2Ny aXB0c1RvQ2xvc2VXaW5kb3dzKCkgY29uc3QgeyByZXR1cm4gbV9hbGxvd19zY3JpcHRzX3RvX2Ns b3NlX3dpbmRvd3M7IH0KKwogICAgIHByaXZhdGU6CiAgICAgICAgIFBhZ2UqIG1fcGFnZTsKICAg ICAgICAgCkBAIC0yMzIsNiArMjM1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBi b29sIG1fem9vbXNUZXh0T25seSA6IDE7CiAgICAgICAgIGJvb2wgbV9lbmZvcmNlQ1NTTUlNRVR5 cGVJblN0cmljdE1vZGUgOiAxOwogICAgICAgICBzaXplX3QgbV9tYXhpbXVtRGVjb2RlZEltYWdl U2l6ZTsKKyAgICAgICAgYm9vbCBtX2FsbG93X3NjcmlwdHNfdG9fY2xvc2Vfd2luZG93cyA6IDE7 CiAKICNpZiBVU0UoU0FGQVJJX1RIRU1FKQogICAgICAgICBzdGF0aWMgYm9vbCBnU2hvdWxkUGFp bnROYXRpdmVDb250cm9sczsK 25513 2008-11-25 16:44:24 -0800 2008-12-23 13:45:46 -0800 Patch to implement this feature AllowScriptsToCloseWindows.txt text/plain 3121 zork SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODExMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEtMDQgIFphY2hhcnkgS3V6bmlhICA8em9ya0BjaHJvbWl1 dW0ub3JnPgorCisgICAgICAgIEFkZGluZyBhIHByZWZlcmVuY2UgdG8gYWxsb3cgc2NpcHRzIHRv IGNsb3NlIHdpbmRvd3MuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZKE9PUFMhKQorCisg ICAgICAgICogcGFnZS9TZXR0aW5ncy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTZXR0aW5nczo6 U2V0dGluZ3MpOgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnNldEFsbG93U2NyaXB0c1Rv Q2xvc2VXaW5kb3dzKToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdzLmg6CisgICAgICAgIChXZWJD b3JlOjpTZXR0aW5nczo6YWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3MpOgorCiAyMDA4LTExLTA0 ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBKb2huIFN1bGxpdmFuCkluZGV4OiBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2aXNpb24gMzgxMTApCisrKyBX ZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsNiArNTUsNyBA QAogI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSAiU2NyZWVuLmgiCiAjaW5j bHVkZSAiU2VjdXJpdHlPcmlnaW4uaCIKKyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUg PGFsZ29yaXRobT4KICNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogCkBAIC00MzksNyArNDQw LDEzIEBAIHZvaWQgRE9NV2luZG93OjpjbG9zZSgpCiAgICAgaWYgKCFtX2ZyYW1lKQogICAgICAg ICByZXR1cm47CiAKLSAgICBpZiAobV9mcmFtZS0+bG9hZGVyKCktPm9wZW5lZEJ5RE9NKCkgfHwg bV9mcmFtZS0+bG9hZGVyKCktPmdldEhpc3RvcnlMZW5ndGgoKSA8PSAxKQorICAgIFNldHRpbmdz KiBzZXR0aW5ncyA9IG1fZnJhbWUtPnNldHRpbmdzKCk7CisgICAgYm9vbCBhbGxvd1NjcmlwdHNU b0Nsb3NlV2luZG93cyA9CisgICAgICAgIChzZXR0aW5ncyAmJiBzZXR0aW5ncy0+YWxsb3dTY3Jp cHRzVG9DbG9zZVdpbmRvd3MoKSk7CisKKyAgICBpZiAobV9mcmFtZS0+bG9hZGVyKCktPm9wZW5l ZEJ5RE9NKCkKKyAgICAgICAgfHwgbV9mcmFtZS0+bG9hZGVyKCktPmdldEhpc3RvcnlMZW5ndGgo KSA8PSAxCisgICAgICAgIHx8IGFsbG93U2NyaXB0c1RvQ2xvc2VXaW5kb3dzKQogICAgICAgICBt X2ZyYW1lLT5zY2hlZHVsZUNsb3NlKCk7CiB9CiAKSW5kZXg6IFdlYkNvcmUvcGFnZS9TZXR0aW5n cy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcAkocmV2aXNpb24g MzgxMTApCisrKyBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04 Niw2ICs4Niw3IEBAIFNldHRpbmdzOjpTZXR0aW5ncyhQYWdlKiBwYWdlKQogICAgICwgbV96b29t c1RleHRPbmx5KGZhbHNlKQogICAgICwgbV9lbmZvcmNlQ1NTTUlNRVR5cGVJblN0cmljdE1vZGUo dHJ1ZSkKICAgICAsIG1fbWF4aW11bURlY29kZWRJbWFnZVNpemUoc3RkOjpudW1lcmljX2xpbWl0 czxzaXplX3Q+OjptYXgoKSkKKyAgICAsIG1fYWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3MoZmFs c2UpCiB7CiAgICAgLy8gQSBGcmFtZSBtYXkgbm90IGhhdmUgYmVlbiBjcmVhdGVkIHlldCwgc28g d2UgaW5pdGlhbGl6ZSB0aGUgQXRvbWljU3RyaW5nIAogICAgIC8vIGhhc2ggYmVmb3JlIHRyeWlu ZyB0byB1c2UgaXQuCkBAIC0zOTEsNCArMzkyLDkgQEAgdm9pZCBTZXR0aW5nczo6c2V0U2hvdWxk UGFpbnROYXRpdmVDb250cgogfQogI2VuZGlmCiAKK3ZvaWQgU2V0dGluZ3M6OnNldEFsbG93U2Ny aXB0c1RvQ2xvc2VXaW5kb3dzKGJvb2wgYWxsb3dTY3JpcHRzVG9DbG9zZVdpbmRvd3MpCit7Cisg ICAgbV9hbGxvd1NjcmlwdHNUb0Nsb3NlV2luZG93cyA9IGFsbG93U2NyaXB0c1RvQ2xvc2VXaW5k b3dzOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJDb3JlL3BhZ2UvU2V0 dGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAkocmV2aXNpb24g MzgxMTApCisrKyBXZWJDb3JlL3BhZ2UvU2V0dGluZ3MuaAkod29ya2luZyBjb3B5KQpAQCAtMTg0 LDYgKzE4NCw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgc3RhdGljIGJvb2wgc2hv dWxkUGFpbnROYXRpdmVDb250cm9scygpIHsgcmV0dXJuIGdTaG91bGRQYWludE5hdGl2ZUNvbnRy b2xzOyB9CiAjZW5kaWYKIAorICAgICAgICB2b2lkIHNldEFsbG93U2NyaXB0c1RvQ2xvc2VXaW5k b3dzKGJvb2wpOworICAgICAgICBib29sIGFsbG93U2NyaXB0c1RvQ2xvc2VXaW5kb3dzKCkgY29u c3QgeyByZXR1cm4gbV9hbGxvd1NjcmlwdHNUb0Nsb3NlV2luZG93czsgfQorCiAgICAgcHJpdmF0 ZToKICAgICAgICAgUGFnZSogbV9wYWdlOwogICAgICAgICAKQEAgLTIzMiw2ICsyMzUsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgbV96b29tc1RleHRPbmx5IDogMTsKICAg ICAgICAgYm9vbCBtX2VuZm9yY2VDU1NNSU1FVHlwZUluU3RyaWN0TW9kZSA6IDE7CiAgICAgICAg IHNpemVfdCBtX21heGltdW1EZWNvZGVkSW1hZ2VTaXplOworICAgICAgICBib29sIG1fYWxsb3dT Y3JpcHRzVG9DbG9zZVdpbmRvd3MgOiAxOwogCiAjaWYgVVNFKFNBRkFSSV9USEVNRSkKICAgICAg ICAgc3RhdGljIGJvb2wgZ1Nob3VsZFBhaW50TmF0aXZlQ29udHJvbHM7Cg==