220691 2021-01-17 17:10:17 -0800 [JSC] Add some more exception checks in globalFuncCopyDataProperties 2021-01-17 22:03:38 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1720207 0 ysuzuki 2021-01-17 17:10:17 -0800 [JSC] Add some more scope checks in globalFuncCopyDataProperties 1720208 1 417786 ysuzuki 2021-01-17 17:13:47 -0800 Created attachment 417786 Patch 1720209 2 ysuzuki 2021-01-17 17:14:43 -0800 <rdar://problem/73242251> 1720233 3 417786 mark.lam 2021-01-17 21:56:50 -0800 Comment on attachment 417786 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417786&action=review r=me with suggested title change. > Source/JavaScriptCore/ChangeLog:3 > + [JSC] Add some more scope checks in globalFuncCopyDataProperties I think "exception checks" would be more accurate than "scope checks". 1720239 4 417786 ysuzuki 2021-01-17 22:01:17 -0800 Comment on attachment 417786 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417786&action=review >> Source/JavaScriptCore/ChangeLog:3 >> + [JSC] Add some more scope checks in globalFuncCopyDataProperties > > I think "exception checks" would be more accurate than "scope checks". Thanks! Fixed. 1720240 5 ysuzuki 2021-01-17 22:03:38 -0800 Committed r271568: <https://trac.webkit.org/changeset/271568> 417786 2021-01-17 17:13:47 -0800 2021-01-17 21:56:50 -0800 Patch bug-220691-20210117171346.patch text/plain 3172 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NzE0OGUyMWM0NmNlNGFmOTdmODkwM2RiMjYyMmRkOTFiY2Y2Mzk2Li5jMTRhMzU2NzY1NTYyZDIy MTIxMWVhOTdiNzc2NzUzM2I4MGUyNTNmIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAyMS0wMS0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIEFkZCBzb21lIG1vcmUgc2NvcGUgY2hlY2tzIGluIGdsb2JhbEZ1 bmNDb3B5RGF0YVByb3BlcnRpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIyMDY5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFRoaXMgcGF0Y2ggYWRkIHNvbWUgbWlzc2luZyBleGNlcHRpb24gY2hlY2tz IGluIGdsb2JhbEZ1bmNDb3B5RGF0YVByb3BlcnRpZXMgdG8gZml4IHRlc3RzIGF0dGFjaGVkIGlu IHRoaXMgcGF0Y2guCisKKyAgICAgICAgKiBydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25z LmNwcDoKKyAgICAgICAgKEpTQzo6SlNDX0RFRklORV9IT1NUX0ZVTkNUSU9OKToKKwogMjAyMS0w MS0xNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBK U0MgQVBJIGNvbmZpZ3VyaW5nIEdDIHNpZ25hbHMgaW4gTGludXgKZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcCBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsT2JqZWN0RnVuY3Rpb25zLmNwcApp bmRleCBkYzdiMTcyMTA0MmIxOGVmMjNmYTJhOTQ4ZWVlYTYwZDY3YzY0NGNlLi42ZmQ2MTFiZmYy Y2MzZjRiZjA4ODZiMDYyMzhmNTVkZDZkMWU4ZjM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9KU0dsb2JhbE9iamVjdEZ1bmN0aW9ucy5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxPYmplY3RGdW5jdGlvbnMuY3BwCkBAIC05 MzYsNyArOTM2LDcgQEAgSlNDX0RFRklORV9IT1NUX0ZVTkNUSU9OKGdsb2JhbEZ1bmNDb3B5RGF0 YVByb3BlcnRpZXMsIChKU0dsb2JhbE9iamVjdCogZ2xvYmFsT2IKIAogICAgICAgICBmb3IgKGNv bnN0IGF1dG8mIHByb3BlcnR5TmFtZSA6IHByb3BlcnR5TmFtZXMpIHsKICAgICAgICAgICAgIGJv b2wgZXhjbHVkZWQgPSBpc1Byb3BlcnR5TmFtZUV4Y2x1ZGVkKGdsb2JhbE9iamVjdCwgcHJvcGVy dHlOYW1lKTsKLSAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIGZhbHNlKTsK KyAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04oc2NvcGUsIHsgfSk7CiAgICAgICAgICAg ICBpZiAoZXhjbHVkZWQpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKQEAgLTk1Niw2ICs5 NTYsNyBAQCBKU0NfREVGSU5FX0hPU1RfRlVOQ1RJT04oZ2xvYmFsRnVuY0NvcHlEYXRhUHJvcGVy dGllcywgKEpTR2xvYmFsT2JqZWN0KiBnbG9iYWxPYgogICAgICAgICAgICAgUkVUVVJOX0lGX0VY Q0VQVElPTihzY29wZSwgeyB9KTsKIAogICAgICAgICAgICAgdGFyZ2V0LT5wdXREaXJlY3RNYXlC ZUluZGV4KGdsb2JhbE9iamVjdCwgcHJvcGVydHlOYW1lLCB2YWx1ZSk7CisgICAgICAgICAgICBS RVRVUk5fSUZfRVhDRVBUSU9OKHNjb3BlLCB7IH0pOwogICAgICAgICB9CiAgICAgfQogCmRpZmYg LS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDRiZjdk YzIwNjA4NGYyYzM5YzVhZGQ0NDhiM2UxMTRiZmI5MWQ2MmIuLmJkNTI1YjMzYjJmODE0ZjM2NGE0 OTk3ZDJjZTcwMmIxYzlhMDk3ODYgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBi L0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDEtMTcgIFl1c3VrZSBT dXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgc29tZSBtb3Jl IHNjb3BlIGNoZWNrcyBpbiBnbG9iYWxGdW5jQ29weURhdGFQcm9wZXJ0aWVzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA2OTEKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9zcHJlYWQtb2Jq ZWN0LWNoZWNrLmpzOiBBZGRlZC4KKyAgICAgICAgKiBzdHJlc3Mvc3ByZWFkLW9iamVjdC1jaGVj azIuanM6IEFkZGVkLgorCiAyMDIxLTAxLTE0ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGlu Z0Bzb255LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBBZGQgc2tpcHMgZm9yIEJpZyBTdXIt ZGVwZW5kZW50IHRlc3QyNjIgdGVzdHMuCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9zcHJl YWQtb2JqZWN0LWNoZWNrLmpzIGIvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLW9iamVjdC1jaGVjay5q cwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi4yNjljY2Q0MTRmOWRmNzU4NzIxYWE4MTgyNDE2NjY2YTZhMDIzNTUxCi0t LSAvZGV2L251bGwKKysrIGIvSlNUZXN0cy9zdHJlc3Mvc3ByZWFkLW9iamVjdC1jaGVjay5qcwpA QCAtMCwwICsxLDIgQEAKK2xldCB6ID0gbmV3IFVpbnQ4QXJyYXkoNCk7Cisoey4uLnp9KTsKZGlm ZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3NwcmVhZC1vYmplY3QtY2hlY2syLmpzIGIvSlNUZXN0 cy9zdHJlc3Mvc3ByZWFkLW9iamVjdC1jaGVjazIuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uOGJhYzE0ZjM0Yzkz OGVlZmU4NmQ3YjJhZDJjYWUxMWI0MDllNzgwMQotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMv c3RyZXNzL3NwcmVhZC1vYmplY3QtY2hlY2syLmpzCkBAIC0wLDAgKzEsNSBAQAorbGV0IG8gPSB7 CisgIDEyMzQ6IHVuZGVmaW5lZAorfTsKKworKHsuLi5vfSk7Cg==