220676 2021-01-15 16:41:43 -0800 Scroll position is lost when homing out and resuming Safari on iOS 2021-01-19 10:57:02 -0800 1 1 1 Unclassified WebKit Scrolling WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser cdumez cmarcelo ews-watchlist fred.wang ggaren jamesr luiz simon.fraser thorton tonikitoo oldest_to_newest 1720079 0 simon.fraser 2021-01-15 16:41:43 -0800 Scroll position is lost when homing out and resuming Safari on iOS 1720081 1 417749 simon.fraser 2021-01-15 16:45:16 -0800 Created attachment 417749 Patch 1720082 2 simon.fraser 2021-01-15 16:45:45 -0800 <rdar://problem/71534598> 1720108 3 ews-feeder 2021-01-15 19:44:43 -0800 Committed r271551: <https://trac.webkit.org/changeset/271551> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417749. 1720587 4 ggaren 2021-01-19 10:53:24 -0800 I believe we have code that avoids sending certain JS events during snapshotting (resize and orientation). Maybe it would be less risky to run the scrolling code and just avoid sending the JS event that would trigger programmatic scroll? 1720589 5 simon.fraser 2021-01-19 10:57:02 -0800 The programmatic scroll is not from JS. It's from layout (when you layout narrow, and then wide, you may need to adjust your scroll offset because the current one is no longer valid). 417749 2021-01-15 16:45:16 -0800 2021-01-15 19:44:44 -0800 Patch bug-220676-20210115164515.patch text/plain 2820 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWQwNTUwMTNiYzBjMTll MTllMzViNTFhODczMjYwY2VkOThjM2RiOC4uMWI1M2ZiZjRiNWFmMWQ3OGNmNzJiZTVjYmE3ZmYx NTZjNGNlY2M4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTAxLTE1ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFNjcm9sbCBwb3Np dGlvbiBpcyBsb3N0IHdoZW4gaG9taW5nIG91dCBhbmQgcmVzdW1pbmcgU2FmYXJpIG9uIGlPUwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNjc2CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiBob21p bmcgb3V0IG9uIGlPUywgVUlLaXQgc25hcHNob3R0aW5nIGNhdXNlcyBtdWx0aXBsZSB3ZWIgdmll dyByZXNpemVzLCB3aGljaCBydW5zCisgICAgICAgIHRoZSBkeW5hbWljVmlld3BvcnRTaXplVXBk YXRlKCkgbG9naWMuIFRoaXMgY2FuIHRyaWdnZXIgcHJvZ3JhbW1hdGljIHNjcm9sbHMgdmlhCisg ICAgICAgIEZyYW1lVmlldzo6c2V0Q29udGVudHNTaXplKCksIHdoaWNoIGdldCBzdG9yZWQgaW4g dGhlIHNjcm9sbGluZyBzdGF0ZSB0cmVlLiBXaGVuCisgICAgICAgIHRoYXQgdHJlZSBpcyBjb21t aXR0ZWQgb24gcmVzdW1lLCB3ZSB0aGVuIGVycm9uZW91c2x5IGFwcGx5IHRoZSBwcm9ncmFtbWF0 aWMKKyAgICAgICAgc2Nyb2xscy4KKworICAgICAgICBGaXggYnkgaWdub3JpbmcgcmVxdWVzdGVk IHNjcm9sbCBwb3NpdGlvbnMgdXBkYXRlcyB3aGVuIHNuYXBzaG90dGluZywgYXMgd2UgZG8gd2hl bgorICAgICAgICB3ZSdyZSBpbiB0aGUgcGFnZSBjYWNoZS4KKworICAgICAgICAqIHBhZ2Uvc2Ny b2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 QXN5bmNTY3JvbGxpbmdDb29yZGluYXRvcjo6cmVxdWVzdFNjcm9sbFBvc2l0aW9uVXBkYXRlKToK KwogMjAyMS0wMS0xNCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBbQXN5bmMgc2Nyb2xsaW5nXSBTbG93LXNjcm9sbGluZyByZWFzb25zIHNob3VsZCBu b3QgcHJvcGFnYXRlIGFjcm9zcyBmcmFtZSBib3VuZGFyaWVzCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wYWdlL3Njcm9sbGluZy9Bc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3Bw CmluZGV4IDcwZWEwMzZmODNjOWVmMjk0OThkOThkMDFkYWVmMzRmYzM5MGE3OTMuLjZhOWViYjNl MmI2NGY4YzNlNjdmNjcyM2ZlZTQ1OTY5YTk1NDY3Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BhZ2Uvc2Nyb2xsaW5nL0FzeW5jU2Nyb2xsaW5nQ29vcmRpbmF0b3IuY3Bw CkBAIC0yNjgsNiArMjY4LDcgQEAgYm9vbCBBc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yOjpyZXF1 ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUoU2Nyb2xsYWJsZUFyZWEmIHNjcm8KICAgICBzZXRTY3Jv bGxpbmdOb2RlU2Nyb2xsYWJsZUFyZWFHZW9tZXRyeShzY3JvbGxpbmdOb2RlSUQsIHNjcm9sbGFi bGVBcmVhKTsKIAogICAgIGJvb2wgaW5CYWNrRm9yd2FyZENhY2hlID0gZnJhbWVWaWV3LT5mcmFt ZSgpLmRvY3VtZW50KCktPmJhY2tGb3J3YXJkQ2FjaGVTdGF0ZSgpICE9IERvY3VtZW50OjpOb3RJ bkJhY2tGb3J3YXJkQ2FjaGU7CisgICAgYm9vbCBpc1NuYXBzaG90dGluZyA9IG1fcGFnZS0+aXNU YWtpbmdTbmFwc2hvdHNGb3JBcHBsaWNhdGlvblN1c3BlbnNpb24oKTsKICAgICBib29sIGluUHJv Z3JhbW1hdGljU2Nyb2xsID0gc2Nyb2xsYWJsZUFyZWEuY3VycmVudFNjcm9sbFR5cGUoKSA9PSBT Y3JvbGxUeXBlOjpQcm9ncmFtbWF0aWM7CiAgICAgaWYgKGluUHJvZ3JhbW1hdGljU2Nyb2xsIHx8 IGluQmFja0ZvcndhcmRDYWNoZSkKICAgICAgICAgYXBwbHlTY3JvbGxVcGRhdGUoc2Nyb2xsaW5n Tm9kZUlELCBzY3JvbGxQb3NpdGlvbiwgeyB9LCBTY3JvbGxUeXBlOjpQcm9ncmFtbWF0aWMsIFNj cm9sbGluZ0xheWVyUG9zaXRpb25BY3Rpb246OlNldCk7CkBAIC0yNzYsNyArMjc3LDcgQEAgYm9v bCBBc3luY1Njcm9sbGluZ0Nvb3JkaW5hdG9yOjpyZXF1ZXN0U2Nyb2xsUG9zaXRpb25VcGRhdGUo U2Nyb2xsYWJsZUFyZWEmIHNjcm8KIAogICAgIC8vIElmIHRoaXMgZnJhbWUgdmlldydzIGRvY3Vt ZW50IGlzIGJlaW5nIHB1dCBpbnRvIHRoZSBiYWNrL2ZvcndhcmQgY2FjaGUsIHdlIGRvbid0IHdh bnQgdG8gdXBkYXRlIG91cgogICAgIC8vIG1haW4gZnJhbWUgc2Nyb2xsIHBvc2l0aW9uLiBKdXN0 IGxldCB0aGUgRnJhbWVWaWV3IHRoaW5rIHRoYXQgd2UgZGlkLgotICAgIGlmIChpbkJhY2tGb3J3 YXJkQ2FjaGUpCisgICAgaWYgKGluQmFja0ZvcndhcmRDYWNoZSB8fCBpc1NuYXBzaG90dGluZykK ICAgICAgICAgcmV0dXJuIHRydWU7CiAKICAgICBhdXRvKiBzdGF0ZU5vZGUgPSBkb3duY2FzdDxT Y3JvbGxpbmdTdGF0ZVNjcm9sbGluZ05vZGU+KG1fc2Nyb2xsaW5nU3RhdGVUcmVlLT5zdGF0ZU5v ZGVGb3JJRChzY3JvbGxpbmdOb2RlSUQpKTsK