220672 2021-01-15 14:06:26 -0800 Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along. 2021-01-18 16:03:54 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall apinheiro cfleizach darin dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1720008 0 andresg_22 2021-01-15 14:06:26 -0800 Apple Mail AX, VoiceOver: When composing a new email message, moving VO focus to the message body field does not bring keyboard focus along. 1720014 1 andresg_22 2021-01-15 14:12:21 -0800 <rdar://problem/73045466> 1720020 2 417739 andresg_22 2021-01-15 14:23:12 -0800 Created attachment 417739 Patch 1720053 3 417739 darin 2021-01-15 15:11:05 -0800 Comment on attachment 417739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review > Source/WebCore/ChangeLog:10 > + The call to AccessibilityObject::setFocused to set the focus to the > + scroll view needs to happen before the check for canSetFocusAttribute. Normally we require a regression test when we fix a bug. Is there a way to fix this? 1720055 4 417739 darin 2021-01-15 15:26:03 -0800 Comment on attachment 417739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417739&action=review >> Source/WebCore/ChangeLog:10 >> + scroll view needs to happen before the check for canSetFocusAttribute. > > Normally we require a regression test when we fix a bug. Is there a way to fix this? I meant to say, "Is there way to make a regression test for this?" 1720415 5 andresg_22 2021-01-18 14:21:02 -0800 (In reply to Darin Adler from comment #4) > Comment on attachment 417739 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417739&action=review > > >> Source/WebCore/ChangeLog:10 > >> + scroll view needs to happen before the check for canSetFocusAttribute. > > > > Normally we require a regression test when we fix a bug. Is there a way to fix this? > > I meant to say, "Is there way to make a regression test for this?" So far I haven't found any example of a LayoutTest that mimics switching focus to a web view from another view. I don't know if it is possible in the context of LayoutTests. 1720429 6 ews-feeder 2021-01-18 16:03:52 -0800 Committed r271589: <https://trac.webkit.org/changeset/271589> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417739. 417739 2021-01-15 14:23:12 -0800 2021-01-18 16:03:53 -0800 Patch bug-220672-20210115172311.patch text/plain 2207 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNDU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWQ1NzY1ZjMzN2NhNmI1 YTI4MzA0ODgxYTQ3NTZkMjNkZDZmNWQyYi4uZmU2MGU0ZTk5ZGZmNDM3NzM2MTJiZGZhMTRmZGUx NGE3NGQ1YjQ5YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAxLTE1ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBcHBsZSBNYWls IEFYLCBWb2ljZU92ZXI6IFdoZW4gY29tcG9zaW5nIGEgbmV3IGVtYWlsIG1lc3NhZ2UsIG1vdmlu ZyBWTyBmb2N1cyB0byB0aGUgbWVzc2FnZSBib2R5IGZpZWxkIGRvZXMgbm90IGJyaW5nIGtleWJv YXJkIGZvY3VzIGFsb25nLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIwNjcyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzA0NTQ2Nj4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY2FsbCB0byBB Y2Nlc3NpYmlsaXR5T2JqZWN0OjpzZXRGb2N1c2VkIHRvIHNldCB0aGUgZm9jdXMgdG8gdGhlCisg ICAgICAgIHNjcm9sbCB2aWV3IG5lZWRzIHRvIGhhcHBlbiBiZWZvcmUgdGhlIGNoZWNrIGZvciBj YW5TZXRGb2N1c0F0dHJpYnV0ZS4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJp bGl0eVJlbmRlck9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5UmVu ZGVyT2JqZWN0OjpzZXRGb2N1c2VkKToKKwogMjAyMS0wMS0xMyAgRnVqaWkgSGlyb25vcmkgIDxI aXJvbm9yaS5GdWppaUBzb255LmNvbT4KIAogICAgICAgICBSZWltcGxlbWVudCBXZWJDb3JlOjpp c0luV2ViUHJvY2VzcygpIGZhbWlseSBhcyBjcm9zcy1wbGF0Zm9ybSBieSB1c2luZyBBdXhpbGlh cnlQcm9jZXNzSW5pdGlhbGl6YXRpb25QYXJhbWV0ZXJzLnByb2Nlc3NUeXBlCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Qu Y3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2Jq ZWN0LmNwcAppbmRleCAwMjMwMGQ5ODc4NTFhYmEwNGQ3ZDMzZDU2ZDAwYmM2OTAwZmU1YWNjLi5j N2Y5ZmIxOGY4N2Y2ZTUwNjAzYTA1NWI2MWE3ZTBlMTY4ZDI2ZjRhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAKQEAgLTE4NDcsNiArMTg0Nyw5IEBAIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dDo6aXNGb2N1c2VkKCkgY29uc3QKIAogdm9pZCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojpz ZXRGb2N1c2VkKGJvb2wgb24pCiB7CisgICAgLy8gQ2FsbCB0aGUgYmFzZSBjbGFzcyBzZXRGb2N1 c2VkIHRvIGVuc3VyZSB0aGUgdmlldyBpcyBmb2N1c2VkIGFuZCBhY3RpdmUuCisgICAgQWNjZXNz aWJpbGl0eU9iamVjdDo6c2V0Rm9jdXNlZChvbik7CisKICAgICBpZiAoIWNhblNldEZvY3VzQXR0 cmlidXRlKCkpCiAgICAgICAgIHJldHVybjsKIApAQCAtMTg1OCw5ICsxODYxLDYgQEAgdm9pZCBB Y2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0OjpzZXRGb2N1c2VkKGJvb2wgb24pCiAgICAgICAgIHJl dHVybjsKICAgICB9CiAKLSAgICAvLyBDYWxsIHRoZSBiYXNlIGNsYXNzIHNldEZvY3VzZWQgdG8g ZW5zdXJlIHRoZSB2aWV3IGlzIGZvY3VzZWQgYW5kIGFjdGl2ZS4KLSAgICBBY2Nlc3NpYmlsaXR5 T2JqZWN0OjpzZXRGb2N1c2VkKG9uKTsKLQogICAgIC8vIFdoZW4gYSBub2RlIGlzIHRvbGQgdG8g c2V0IGZvY3VzLCB0aGF0IGNhbiBjYXVzZSBpdCB0byBiZSBkZWFsbG9jYXRlZCwgd2hpY2ggbWVh bnMgdGhhdCBkb2luZwogICAgIC8vIGFueXRoaW5nIGVsc2UgaW5zaWRlIHRoaXMgb2JqZWN0IHdp bGwgY3Jhc2guIFRvIGZpeCB0aGlzLCB3ZSBhZGRlZCBhIFJlZlB0ciB0byBwcm90ZWN0IHRoaXMg b2JqZWN0CiAgICAgLy8gbG9uZyBlbm91Z2ggZm9yIGR1cmF0aW9uLgo=