22065 2008-11-04 10:52:04 -0800 General mac plug-in code cleanup 2008-12-02 17:20:27 -0800 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 97580 0 andersca 2008-11-04 10:52:04 -0800 This bug represents some cleanup I want to do in the Mac plug-in code. 97581 1 24888 andersca 2008-11-04 10:53:16 -0800 Created attachment 24888 Remove some unused code 97601 2 24891 andersca 2008-11-04 11:53:54 -0800 Created attachment 24891 Don't create the stream loader until the stream has been started 24888 2008-11-04 10:53:16 -0800 2008-11-04 10:53:56 -0800 Remove some unused code textmate stdin clg807.txt text/plain 3913 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MDk3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDgtMTEt MDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFJlbW92ZSBzb21lIG9s ZCwgdW51c2VkIHBsdWctaW4gY29kZS4KKyAgICAgICAgCisgICAgICAgICogUGx1Z2lucy9XZWJC YXNlTmV0c2NhcGVQbHVnaW5WaWV3Lmg6CisgICAgICAgICogUGx1Z2lucy9XZWJCYXNlTmV0c2Nh cGVQbHVnaW5WaWV3Lm1tOgorICAgICAgICAoLVtXZWJCYXNlTmV0c2NhcGVQbHVnaW5WaWV3IHNh dmVBbmRTZXROZXdQb3J0U3RhdGVGb3JVcGRhdGU6XSk6CisgICAgICAgICgtW1dlYkJhc2VOZXRz Y2FwZVBsdWdpblZpZXcgc3RhcnRdKToKKyAgICAgICAgKC1bV2ViQmFzZU5ldHNjYXBlUGx1Z2lu VmlldyBzZXRWYXJpYWJsZTp2YWx1ZTpdKToKKwogMjAwOC0xMS0wMSAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CkluZGV4OiBQbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBsdWdpblZpZXcuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBQbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBsdWdpblZpZXcuaAkocmV2aXNpb24gMzgwOTcpCisr KyBQbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBsdWdpblZpZXcuaAkod29ya2luZyBjb3B5KQpAQCAt OTksNyArOTksNiBAQCB0eXBlZGVmIHN0cnVjdCBfTlBQbHVnaW5UZXh0SW5wdXRGdW5jcyBOCiAg ICAgQk9PTCBpc1N0YXJ0ZWQ7CiAgICAgQk9PTCBpblNldFdpbmRvdzsKICAgICBCT09MIGhhc0Zv Y3VzOwotICAgIEJPT0wgaXNUcmFuc3BhcmVudDsKICAgICBCT09MIGlzQ29tcGxldGVseU9ic2N1 cmVkOwogICAgIEJPT0wgc2hvdWxkU3RvcFNvb247CiAKSW5kZXg6IFBsdWdpbnMvV2ViQmFzZU5l dHNjYXBlUGx1Z2luVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQbHVnaW5zL1dlYkJhc2VOZXRzY2Fw ZVBsdWdpblZpZXcubW0JKHJldmlzaW9uIDM4MDk3KQorKysgUGx1Z2lucy9XZWJCYXNlTmV0c2Nh cGVQbHVnaW5WaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMzMsNiArMzMzLDcgQEAgc3RhdGlj IGlubGluZSB2b2lkIGdldE5QUmVjdChjb25zdCBOU1JlYwogICAgIH0KICNlbmRpZgogICAgIAor ICAgIHdpbmRvdy50eXBlID0gTlBXaW5kb3dUeXBlV2luZG93OwogICAgIHdpbmRvdy54ID0gKGlu dDMyKWJvdW5kc0luV2luZG93Lm9yaWdpbi54OyAKICAgICB3aW5kb3cueSA9IChpbnQzMilib3Vu ZHNJbldpbmRvdy5vcmlnaW4ueTsKICAgICB3aW5kb3cud2lkdGggPSBzdGF0aWNfY2FzdDx1aW50 MzI+KE5TV2lkdGgoYm91bmRzSW5XaW5kb3cpKTsKQEAgLTY2Miw3ICs2NjMsNyBAQCBzdGF0aWMg aW5saW5lIHZvaWQgZ2V0TlBSZWN0KGNvbnN0IE5TUmVjCiAgICAgLy8gRHJhdyBncmVlbiB0byBo ZWxwIGRlYnVnLgogICAgIC8vIElmIHdlIHNlZSBhbnkgZ3JlZW4gd2Uga25vdyBzb21ldGhpbmcn cyB3cm9uZy4KICAgICAvLyBOb3RlIHRoYXQgUGFpbnRSZWN0KCkgb25seSB3b3JrcyBmb3IgUXVp Y2tEcmF3IHBsdWdpbnM7IG90aGVyd2lzZSB0aGUgY3VycmVudCBRRCBwb3J0IGlzIHVuZGVmaW5l ZC4KLSAgICBpZiAoaXNEcmF3aW5nTW9kZWxRdWlja0RyYXcoZHJhd2luZ01vZGVsKSAmJiAhaXNU cmFuc3BhcmVudCAmJiBldmVudElzRHJhd1JlY3QpIHsKKyAgICBpZiAoaXNEcmF3aW5nTW9kZWxR dWlja0RyYXcoZHJhd2luZ01vZGVsKSAmJiBldmVudElzRHJhd1JlY3QpIHsKICAgICAgICAgRm9y ZUNvbG9yKGdyZWVuQ29sb3IpOwogICAgICAgICBjb25zdCA6OlJlY3QgYmlnUmVjdCA9IHsgLTEw MDAwLCAtMTAwMDAsIDEwMDAwLCAxMDAwMCB9OwogICAgICAgICBQYWludFJlY3QoJmJpZ1JlY3Qp OwpAQCAtMTE4MCwxMCArMTE4MSw2IEBAIHN0YXRpYyBpbmxpbmUgdm9pZCBnZXROUFJlY3QoY29u c3QgTlNSZWMKICAgICAvLyBJbml0aWFsaXplIGV2ZW50TW9kZWwgdG8gYW4gaW52YWxpZCB2YWx1 ZSBzbyB0aGF0IHdlIGNhbiBkZXRlY3Qgd2hlbiB0aGUgcGx1Z2luIGRvZXMgbm90IHNwZWNpZnkg YW4gZXZlbnQgbW9kZWwuCiAgICAgZXZlbnRNb2RlbCA9IChOUEV2ZW50TW9kZWwpLTE7CiAgICAg Ci0gICAgLy8gUGx1Zy1pbnMgYXJlICJ3aW5kb3dlZCIgYnkgZGVmYXVsdC4gIE9uIE1hY09TLCB3 aW5kb3dlZCBwbHVnLWlucyBzaGFyZSB0aGUgc2FtZSB3aW5kb3cgYW5kIGdyYXBoaWNzIHBvcnQg YXMgdGhlIG1haW4KLSAgICAvLyBicm93c2VyIHdpbmRvdy4gIFdpbmRvd2xlc3MgcGx1Zy1pbnMg YXJlIHJlbmRlcmVkIG9mZi1zY3JlZW4sIHRoZW4gY29waWVkIGludG8gdGhlIG1haW4gYnJvd3Nl ciB3aW5kb3cuCi0gICAgd2luZG93LnR5cGUgPSBOUFdpbmRvd1R5cGVXaW5kb3c7Ci0gICAgCiAg ICAgTlBFcnJvciBucEVyciA9IFtzZWxmIF9jcmVhdGVQbHVnaW5dOwogICAgIGlmIChucEVyciAh PSBOUEVSUl9OT19FUlJPUikgewogICAgICAgICBMT0dfRVJST1IoIk5QUF9OZXcgZmFpbGVkIHdp dGggZXJyb3I6ICVkIiwgbnBFcnIpOwpAQCAtMjU2NywzMCArMjU2NCw2IEBAIHN0YXRpYyBOUEJy b3dzZXJUZXh0SW5wdXRGdW5jcyAqYnJvd3NlclQKIC0gKE5QRXJyb3Ipc2V0VmFyaWFibGU6KE5Q UFZhcmlhYmxlKXZhcmlhYmxlIHZhbHVlOih2b2lkICopdmFsdWUKIHsKICAgICBzd2l0Y2ggKHZh cmlhYmxlKSB7Ci0gICAgICAgIGNhc2UgTlBQVnBsdWdpbldpbmRvd0Jvb2w6Ci0gICAgICAgIHsK LSAgICAgICAgICAgIE5QV2luZG93VHlwZSBuZXdXaW5kb3dUeXBlID0gKHZhbHVlID8gTlBXaW5k b3dUeXBlV2luZG93IDogTlBXaW5kb3dUeXBlRHJhd2FibGUpOwotCi0gICAgICAgICAgICAvLyBS ZWRpc3BsYXkgaWYgd2luZG93IHR5cGUgaXMgY2hhbmdpbmcgKHNvbWUgZHJhd2luZyBtb2RlbHMg Y2FuIG9ubHkgaGF2ZSB0aGVpciB3aW5kb3dzIHNldCB3aGlsZSB1cGRhdGluZykuCi0gICAgICAg ICAgICBpZiAobmV3V2luZG93VHlwZSAhPSB3aW5kb3cudHlwZSkKLSAgICAgICAgICAgICAgICBb c2VsZiBzZXROZWVkc0Rpc3BsYXk6WUVTXTsKLSAgICAgICAgICAgIAotICAgICAgICAgICAgd2lu ZG93LnR5cGUgPSBuZXdXaW5kb3dUeXBlOwotICAgICAgICB9Ci0gICAgICAgIAotICAgICAgICBj YXNlIE5QUFZwbHVnaW5UcmFuc3BhcmVudEJvb2w6Ci0gICAgICAgIHsKLSAgICAgICAgICAgIEJP T0wgbmV3VHJhbnNwYXJlbnQgPSAodmFsdWUgIT0gMCk7Ci0gICAgICAgICAgICAKLSAgICAgICAg ICAgIC8vIFJlZGlzcGxheSBpZiB0cmFuc3BhcmVuY3kgaXMgY2hhbmdpbmcKLSAgICAgICAgICAg IGlmIChpc1RyYW5zcGFyZW50ICE9IG5ld1RyYW5zcGFyZW50KQotICAgICAgICAgICAgICAgIFtz ZWxmIHNldE5lZWRzRGlzcGxheTpZRVNdOwotICAgICAgICAgICAgCi0gICAgICAgICAgICBpc1Ry YW5zcGFyZW50ID0gbmV3VHJhbnNwYXJlbnQ7Ci0gICAgICAgICAgICAKLSAgICAgICAgICAgIHJl dHVybiBOUEVSUl9OT19FUlJPUjsKLSAgICAgICAgfQotICAgICAgICAKICAgICAgICAgY2FzZSBO UFBWcGx1Z2luRHJhd2luZ01vZGVsOgogICAgICAgICB7CiAgICAgICAgICAgICAvLyBDYW4gb25s eSBzZXQgZHJhd2luZyBtb2RlbCBpbnNpZGUgTlBQX05ldygpCg== 24891 2008-11-04 11:53:54 -0800 2008-11-04 12:04:35 -0800 Don't create the stream loader until the stream has been started textmate stdin CXbxPK.txt text/plain 1657 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4MTA4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MDQgIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBPbmx5IGNyZWF0ZSB0aGUgcGx1Zy1p biBzdHJlYW0gbG9hZGVyIHdoZW4gdGhlIHN0cmVhbSBpcyBzdGFydGVkLgorICAgICAgICAKKyAg ICAgICAgKiBQbHVnaW5zL1dlYkJhc2VOZXRzY2FwZVBsdWdpblN0cmVhbS5tbToKKyAgICAgICAg KFdlYk5ldHNjYXBlUGx1Z2luU3RyZWFtOjpXZWJOZXRzY2FwZVBsdWdpblN0cmVhbSk6CisgICAg ICAgIChXZWJOZXRzY2FwZVBsdWdpblN0cmVhbTo6c3RhcnQpOgorCiAyMDA4LTExLTA0ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2V2aW4gRGVja2VyLgpJbmRleDogUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5TdHJlYW0u bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5TdHJlYW0ubW0J KHJldmlzaW9uIDM4MTA2KQorKysgUGx1Z2lucy9XZWJCYXNlTmV0c2NhcGVQbHVnaW5TdHJlYW0u bW0JKHdvcmtpbmcgY29weSkKQEAgLTE0OCw5ICsxNDgsNiBAQCBXZWJOZXRzY2FwZVBsdWdpblN0 cmVhbTo6V2ViTmV0c2NhcGVQbHVnCiAgICAgICAgIAogICAgIGlmIChjb3JlKFt2aWV3IHdlYkZy YW1lXSktPmxvYWRlcigpLT5zaG91bGRIaWRlUmVmZXJyZXIoW3JlcXVlc3QgVVJMXSwgY29yZShb dmlldyB3ZWJGcmFtZV0pLT5sb2FkZXIoKS0+b3V0Z29pbmdSZWZlcnJlcigpKSkKICAgICAgICAg W21fcmVxdWVzdC5nZXQoKSBfd2ViX3NldEhUVFBSZWZlcnJlcjpuaWxdOwotICAgIAotICAgIG1f bG9hZGVyID0gTmV0c2NhcGVQbHVnSW5TdHJlYW1Mb2FkZXI6OmNyZWF0ZShjb3JlKFt2aWV3IHdl YkZyYW1lXSksIHRoaXMpOwotICAgIG1fbG9hZGVyLT5zZXRTaG91bGRCdWZmZXJEYXRhKGZhbHNl KTsKIH0KIAogV2ViTmV0c2NhcGVQbHVnaW5TdHJlYW06On5XZWJOZXRzY2FwZVBsdWdpblN0cmVh bSgpCkBAIC0yNTYsNiArMjUzLDEwIEBAIHZvaWQgV2ViTmV0c2NhcGVQbHVnaW5TdHJlYW06OnN0 YXJ0KCkKIHsKICAgICBBU1NFUlQobV9yZXF1ZXN0KTsKICAgICBBU1NFUlQoIW1fZnJhbWVMb2Fk ZXIpOworICAgIEFTU0VSVCghbV9sb2FkZXIpOworICAgIAorICAgIG1fbG9hZGVyID0gTmV0c2Nh cGVQbHVnSW5TdHJlYW1Mb2FkZXI6OmNyZWF0ZShjb3JlKFttX3BsdWdpblZpZXcuZ2V0KCkgd2Vi RnJhbWVdKSwgdGhpcyk7CisgICAgbV9sb2FkZXItPnNldFNob3VsZEJ1ZmZlckRhdGEoZmFsc2Up OwogICAgIAogICAgIG1fbG9hZGVyLT5kb2N1bWVudExvYWRlcigpLT5hZGRQbHVnSW5TdHJlYW1M b2FkZXIobV9sb2FkZXIuZ2V0KCkpOwogICAgIG1fbG9hZGVyLT5sb2FkKG1fcmVxdWVzdC5nZXQo KSk7Cg==