220648 2021-01-14 23:55:50 -0800 When non-integer tabindex is set, the behavior of element should be same as the tabindex is omitted 2021-01-18 18:11:19 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All CLOSED FIXED InRadar P2 Normal --- 1 tomoki.imai tomoki.imai cdumez changseok don.olmstead esprehn+autocc ews-watchlist gyuyoung.kim koivisto tomoki.imai webkit-bug-importer oldest_to_newest 1719797 0 417680 tomoki.imai 2021-01-14 23:55:50 -0800 Created attachment 417680 LayoutTest testcase to overwrite tabindex with non-integer value According to the spec, non-integer and omitted tabindex have the same behavior. https://html.spec.whatwg.org/multipage/interaction.html#attr-tabindex Current WebKit implementation doesn't overwrite the internal tabindex value when new tabindex is non-integer. As a result, its behavior is not changed from the previous tabindex. Attached testcase shows the compatibility problem the other browsers. If it's opened in WinCairo MiniBrowser/Safari TP 118, it shows "FAIL". But on Firefox/Chrome, it shows "PASS". I already created the patch, so we'll post another attachment soon. 1719798 1 417681 tomoki.imai 2021-01-15 00:08:45 -0800 Created attachment 417681 patch Patch 1719877 2 koivisto 2021-01-15 08:16:46 -0800 Seems sensible. 1719888 3 ews-feeder 2021-01-15 08:53:51 -0800 Committed r271523: <https://trac.webkit.org/changeset/271523> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417681. 1719889 4 webkit-bug-importer 2021-01-15 08:54:14 -0800 <rdar://problem/73250245> 1720447 5 tomoki.imai 2021-01-18 18:11:19 -0800 Thanks for your review and merging! 417680 2021-01-14 23:55:50 -0800 2021-01-14 23:55:50 -0800 LayoutTest testcase to overwrite tabindex with non-integer value tabindex-overwrite-with-non-integer.html text/html 621 tomoki.imai PGRpdiBpZD0iYSIgdGFiaW5kZXg9IjEiPlBBU1M8L2Rpdj4KCjxzY3JpcHQ+CiAgICBpZiAod2lu ZG93LnRlc3RSdW5uZXIpIHsKICAgICAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKICAgIH0K ICAgIHZhciBhID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2EnKTsKICAgIGEuYWRkRXZlbnRM aXN0ZW5lcignZm9jdXMnLCBmdW5jdGlvbiAoZSkgewogICAgICAgIGEuaW5uZXJUZXh0ID0gJ0ZB SUwnOwogICAgfSwgZmFsc2UpOwoKICAgIGEuc2V0QXR0cmlidXRlKCd0YWJpbmRleCcsIDEpOwog ICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4JywgbnVsbCk7CiAgICBhLmZvY3VzKCk7CgogICAg YS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4JywgMSk7CiAgICBhLnNldEF0dHJpYnV0ZSgndGFiaW5k ZXgnLCB1bmRlZmluZWQpOwogICAgYS5mb2N1cygpOwoKICAgIGEuc2V0QXR0cmlidXRlKCd0YWJp bmRleCcsIDEpOwogICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4JywgInN0cmluZyIpOwogICAg YS5mb2N1cygpOwoKICAgIGEuc2V0QXR0cmlidXRlKCd0YWJpbmRleCcsIDEpOwogICAgYS5zZXRB dHRyaWJ1dGUoJ3RhYmluZGV4JywgIiIpOwogICAgYS5mb2N1cygpOwo8L3NjcmlwdD4K 417681 2021-01-15 00:08:45 -0800 2021-01-15 08:53:52 -0800 patch 220648.patch text/plain 4059 tomoki.imai ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAzZTZmZWNhZjFkNzQuLmViMjRmMTg0MGJhZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBA CisyMDIxLTAxLTE1ICBUb21va2kgSW1haSAgPFRvbW9raS5JbWFpQHNvbnkuY29tPgorCisgICAg ICAgIFdoZW4gbm9uLWludGVnZXIgdGFiaW5kZXggaXMgc2V0LCB0aGUgYmVoYXZpb3Igb2YgZWxl bWVudCBzaG91bGQgYmUgc2FtZSBhcyB0aGUgdGFiaW5kZXggaXMgb21pdHRlZC4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDY0OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBMYXlvdXRUZXN0IGNh c2UgZm9yIHRhYmluZGV4IHdoaWNoIGlzIG92ZXJ3cml0dGVuIGJ5IG5vbi1pbnRlZ2Vycy4KKyAg ICAgICAgV2hlbiBub24taW50ZWdlciB0YWJpbmRleCBpcyBzcGVjaWZpZWQsIHRoZSBlbGVtZW50 IHNob3VsZCBiZWhhdmUgdGhlIHNhbWUgd2F5IGFzIHRoZSB0YWJpbmRleCBpcyBvbWl0dGVkLgor ICAgICAgICBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9pbnRlcmFjdGlv bi5odG1sI2F0dHItdGFiaW5kZXgKKworICAgICAgICAqIGZhc3QvaHRtbC90YWJpbmRleC1vdmVy d3JpdGUtd2l0aC1ub24taW50ZWdlci1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvaHRtbC90YWJpbmRleC1vdmVyd3JpdGUtd2l0aC1ub24taW50ZWdlci5odG1sOiBBZGRlZC4K KwogMjAyMS0wMS0xMSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAog ICAgICAgICBTYWZhcmkgMTQgb24gMnggZGlzcGxheSByZW5kZXJzIE5ZUyBETVYgcGFnZSBhcyBi bHVycnkKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaHRtbC90YWJpbmRleC1vdmVyd3Jp dGUtd2l0aC1ub24taW50ZWdlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2h0bWwv dGFiaW5kZXgtb3ZlcndyaXRlLXdpdGgtbm9uLWludGVnZXItZXhwZWN0ZWQudHh0Cm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uN2VmMjJlOWE0MzFhCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYmluZGV4LW92ZXJ3cml0ZS13aXRoLW5v bi1pbnRlZ2VyLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitQQVNTCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2h0bWwvdGFiaW5kZXgtb3ZlcndyaXRlLXdpdGgtbm9uLWludGVnZXIu aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaHRtbC90YWJpbmRleC1vdmVyd3JpdGUtd2l0aC1ub24t aW50ZWdlci5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMC4uM2E3 MjNmNjkxNTJlCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9odG1sL3RhYmlu ZGV4LW92ZXJ3cml0ZS13aXRoLW5vbi1pbnRlZ2VyLmh0bWwKQEAgLTAsMCArMSwyNyBAQAorPGRp diBpZD0iYSIgdGFiaW5kZXg9IjEiPlBBU1M8L2Rpdj4KKworPHNjcmlwdD4KKyAgICBpZiAod2lu ZG93LnRlc3RSdW5uZXIpIHsKKyAgICAgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAg fQorICAgIHZhciBhID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2EnKTsKKyAgICBhLmFkZEV2 ZW50TGlzdGVuZXIoJ2ZvY3VzJywgZnVuY3Rpb24gKGUpIHsKKyAgICAgICAgYS5pbm5lclRleHQg PSAnRkFJTCc7CisgICAgfSwgZmFsc2UpOworCisgICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4 JywgMSk7CisgICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4JywgbnVsbCk7CisgICAgYS5mb2N1 cygpOworCisgICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4JywgMSk7CisgICAgYS5zZXRBdHRy aWJ1dGUoJ3RhYmluZGV4JywgdW5kZWZpbmVkKTsKKyAgICBhLmZvY3VzKCk7CisKKyAgICBhLnNl dEF0dHJpYnV0ZSgndGFiaW5kZXgnLCAxKTsKKyAgICBhLnNldEF0dHJpYnV0ZSgndGFiaW5kZXgn LCAic3RyaW5nIik7CisgICAgYS5mb2N1cygpOworCisgICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmlu ZGV4JywgMSk7CisgICAgYS5zZXRBdHRyaWJ1dGUoJ3RhYmluZGV4JywgIiIpOworICAgIGEuZm9j dXMoKTsKKzwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDhiNTBiYTYwNWE2NC4uMGEzZTI5MWY3YmRi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDEtMTUgIFRvbW9raSBJbWFpICA8 VG9tb2tpLkltYWlAc29ueS5jb20+CisKKyAgICAgICAgV2hlbiBub24taW50ZWdlciB0YWJpbmRl eCBpcyBzZXQsIHRoZSBiZWhhdmlvciBvZiBlbGVtZW50IHNob3VsZCBiZSBzYW1lIGFzIHRoZSB0 YWJpbmRleCBpcyBvbWl0dGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIwNjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2hlbiBub24taW50ZWdlciB0YWJpbmRleCBpcyBzcGVjaWZpZWQsIHRoZSBl bGVtZW50IHNob3VsZCBiZWhhdmUgdGhlIHNhbWUgd2F5IGFzIHRoZSB0YWJpbmRleCBpcyBvbWl0 dGVkLgorICAgICAgICBodHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnL211bHRpcGFnZS9pbnRl cmFjdGlvbi5odG1sI2F0dHItdGFiaW5kZXgKKworICAgICAgICBXZWJLaXQgZGlkbid0IG92ZXJ3 cml0ZSB0aGUgaW50ZXJuYWwgdGFiaW5kZXggdmFsdWUgd2hlbiB0aGUgbmV3IHZhbHVlIGlzIG5v bi1pbnRlZ2VyLgorCisgICAgICAgIFRlc3Q6IExheW91dFRlc3RzXGZhc3RcaHRtbFx0YWJpbmRl eC1vdmVyd3JpdGUtd2l0aC1ub24taW50ZWdlci5odG1sCisKKyAgICAgICAgKiBodG1sL0hUTUxF bGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxFbGVtZW50OjpwYXJzZUF0dHJpYnV0 ZSk6IElmIHRoZSBuZXcgdmFsdWUgY2Fubm90IGJlIHBhcnNlZCBhcyB0aGUgaW50ZWdlciwgY2xl YXIgdGhlIGV4aXN0aW5nIHRhYmluZGV4LgorCiAyMDIxLTAxLTExICBTaW1vbiBGcmFzZXIgIDxz aW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFNhZmFyaSAxNCBvbiAyeCBkaXNwbGF5 IHJlbmRlcnMgTllTIERNViBwYWdlIGFzIGJsdXJyeQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxFbGVtZW50 LmNwcAppbmRleCAxMzMzMDU4MDg2MTMuLmFmMmZlNGZiZjNkZCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9I VE1MRWxlbWVudC5jcHAKQEAgLTQ1MiwxMCArNDUyLDEwIEBAIHZvaWQgSFRNTEVsZW1lbnQ6OnBh cnNlQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUsIGNvbnN0IEF0b21TdHJpbmcm IHZhCiAgICAgfQogCiAgICAgaWYgKG5hbWUgPT0gdGFiaW5kZXhBdHRyKSB7Ci0gICAgICAgIGlm ICh2YWx1ZS5pc0VtcHR5KCkpCi0gICAgICAgICAgICBzZXRUYWJJbmRleEV4cGxpY2l0bHkoV1RG OjpudWxsb3B0KTsKLSAgICAgICAgZWxzZSBpZiAoYXV0byBvcHRpb25hbFRhYkluZGV4ID0gcGFy c2VIVE1MSW50ZWdlcih2YWx1ZSkpCisgICAgICAgIGlmIChhdXRvIG9wdGlvbmFsVGFiSW5kZXgg PSBwYXJzZUhUTUxJbnRlZ2VyKHZhbHVlKSkKICAgICAgICAgICAgIHNldFRhYkluZGV4RXhwbGlj aXRseShvcHRpb25hbFRhYkluZGV4LnZhbHVlKCkpOworICAgICAgICBlbHNlCisgICAgICAgICAg ICBzZXRUYWJJbmRleEV4cGxpY2l0bHkoV1RGOjpudWxsb3B0KTsKICAgICAgICAgcmV0dXJuOwog ICAgIH0KICAgICAK