220637 2021-01-14 15:32:34 -0800 REGRESSION (r271472): [ Mac WK2 ] intersection-observer/target-deleted.html is timing out 2021-01-21 22:08:45 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell thorton ajuma cathiechen rniwa sabouhallawa simon.fraser thorton webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1719726 0 tsavell 2021-01-14 15:32:34 -0800 intersection-observer/target-deleted.html This test is timing out constantly sense around r271473 History: https://results.webkit.org/?suite=layout-tests&test=intersection-observer%2Ftarget-deleted.html I can reproduce this with command: run-webkit-tests --iterations 2000 --exit-after-n-failures 1 --exit-after-n-crashes-or-timeouts 1 --debug-rwt-logging --no-retry --force --no-build -f intersection-observer/target-deleted.html 1719727 1 webkit-bug-importer 2021-01-14 15:32:49 -0800 <rdar://problem/73220571> 1719738 2 tsavell 2021-01-14 16:00:30 -0800 I was able to bisect this to r271471 1719739 3 tsavell 2021-01-14 16:01:05 -0800 (In reply to Truitt Savell from comment #2) > I was able to bisect this to r271471 r2714712 fails while r271471 passes actually. misstyped 1719916 4 simon.fraser 2021-01-15 10:12:23 -0800 You mean https://trac.webkit.org/changeset/271472/webkit. Seems pretty unlikely that's the cause. 1720328 5 cathiechen 2021-01-18 04:24:04 -0800 Hmm, I can't reproduce it on Catalina debug wk2. It seems specific to the release versions. I'll try to build release locally. 1720820 6 cathiechen 2021-01-19 23:45:54 -0800 (In reply to cathiechen from comment #5) > Hmm, I can't reproduce it on Catalina debug wk2. > It seems specific to the release versions. > I'll try to build release locally. Tried the release version on macOS Catalina and Big Sur, but can't reproduce it. 1721295 7 thorton 2021-01-21 13:05:00 -0800 I can reproduce with Truitt's command. 1721300 8 thorton 2021-01-21 13:07:56 -0800 Even a single iteration is sufficient (which is consistent with the bots, and will make debugging easier). 1721473 9 thorton 2021-01-21 20:18:02 -0800 The observerShouldBeRemoved interval is firing forever, with 1 outstanding intersection observer live (i.e., the test is catching exactly the failure it was intended to fix...) 1721474 10 thorton 2021-01-21 20:21:29 -0800 Nothing even remotely near the regression point makes any sense, so I'm just going to see if I can debug. 1721476 11 thorton 2021-01-21 20:23:36 -0800 Test was introduced in https://trac.webkit.org/changeset/237880/webkit 1721478 12 thorton 2021-01-21 21:00:01 -0800 I think this is just a test depending on GC and the GC not happening (despite the attempt to force it). If I run the test with --no-timeout, it spins forever, UNTIL the instant I try to remote-web-inspect it, then suddenly the element is collected, the IntersectionObserver goes away, and the test completes... 1721479 13 rniwa 2021-01-21 21:00:45 -0800 Oh, try increasing the number of observers and check if any observer is collected? I suspect the test is buggy. Since we have a conservative GC, we can't guarantee all objects will be collected. 1721480 14 simon.fraser 2021-01-21 21:09:26 -0800 Maybe the test needs to do something non-trivial in the loop to make gc() do something 1721481 15 thorton 2021-01-21 21:09:33 -0800 Wait, also, m_intersectionObservers is a Vector of WeakPtrs, and we're just getting its length... which won't decrease if one of the WeakPtrs gets zeroed, right? This is all a bit questionable. 1721482 16 rniwa 2021-01-21 21:19:29 -0800 (In reply to Simon Fraser (smfr) from comment #14) > Maybe the test needs to do something non-trivial in the loop to make gc() do > something It's never guaranteed that gc() will collect all garbage because we have a conservative GC. Some objects can be kept alive even if they're logically dead. 1721483 17 418108 thorton 2021-01-21 21:21:48 -0800 Created attachment 418108 Patch 1721487 18 ews-feeder 2021-01-21 22:08:25 -0800 Committed r271736: <https://trac.webkit.org/changeset/271736> All reviewed patches have been landed. Closing bug and clearing flags on attachment 418108. 418108 2021-01-21 21:21:48 -0800 2021-01-21 22:08:36 -0800 Patch bug-220637-20210121212147.patch text/plain 2189 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNzIyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzM2Y2FjOTlmZjVmMTk4YjBiZjQ3 MjY3ZmU4N2NlOTA4YzA4MDlhOS4uOTE2YzcwNGJkODc1ZTEwNDQxYmNjMmRkZmM2ZDg1MDE3NGU2 OWRhZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTIxICBUaW0gSG9ydG9uICA8dGlt b3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNzE0NzIpOiBb IE1hYyBXSzIgXSBpbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdGFyZ2V0LWRlbGV0ZWQuaHRtbCBpcyB0 aW1pbmcgb3V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjA2MzcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzczMjIwNTcxPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW50ZXJzZWN0aW9uLW9ic2Vy dmVyL3RhcmdldC1kZWxldGVkLmh0bWw6CisgICAgICAgIEZvciBzb21lIHJlYXNvbiwgb24gc29t ZSBjb25maWd1cmF0aW9ucywgdGhpcyB0ZXN0IHJlY2VudGx5IHN0b3BwZWQgc2VlaW5nIGl0cwor ICAgICAgICBpbnRlcnNlY3Rpb24gb2JzZXJ2ZXIgZ2V0IGdhcmJhZ2UgY29sbGVjdGVkIHdoZW4g aXQgZXhwZWN0cy4gVGhlIHJlZ3Jlc3Npb24KKyAgICAgICAgcG9pbnQgaXMgbGlrZWx5IGlycmVs ZXZhbnQsIHRob3VnaCBtdWx0aXBsZSBib3RzIGFncmVlLgorCisgICAgICAgIERvaW5nIGEgZnVs bCByZW5kZXJpbmcgdXBkYXRlIGJ5IHVzaW5nIHJBRiBpbnN0ZWFkIG9mIGp1c3QgYSBzZXRJbnRl cnZhbAorICAgICAgICBzZWVtcyB0byBiZSBlbm91Z2ggdG8gZ2V0IHRoZSBvYmplY3QgdG8gYWN0 dWFsbHkgYmUgY29sbGVjdGVkIHByb21wdGx5LgorCiAyMDIxLTAxLTIxICBKdWxpYW4gR29uemFs ZXogIDxqdWxpYW5fYV9nb256YWxlekBhcHBsZS5jb20+CiAKICAgICAgICAgTnVsbCBkZXJlZmVy ZW5jZSBpbiBDb21wb3NpdGVFZGl0Q29tbWFuZDo6Y2xvbmVQYXJhZ3JhcGhVbmRlck5ld0VsZW1l bnQoKTogbmVlZHMgdG8gY2hlY2sgbGFzdE5vZGUgcGFyZW50CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9pbnRlcnNlY3Rpb24tb2JzZXJ2ZXIvdGFyZ2V0LWRlbGV0ZWQuaHRtbCBiL0xheW91dFRl c3RzL2ludGVyc2VjdGlvbi1vYnNlcnZlci90YXJnZXQtZGVsZXRlZC5odG1sCmluZGV4IDU1ZTMy M2JkYzFhYmNmNzc3OGYwOGEwZDZmZTVmYmE4NzJiMDg4M2YuLjAxODkyMWFhMDRhZDU3NTE4YjU4 NWE5OWM1ODk3ZGExY2QxODM0NzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ludGVyc2VjdGlv bi1vYnNlcnZlci90YXJnZXQtZGVsZXRlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2ludGVyc2Vj dGlvbi1vYnNlcnZlci90YXJnZXQtZGVsZXRlZC5odG1sCkBAIC0xMSwxMyArMTEsMTUgQEAKICAg ICBmdW5jdGlvbiBvYnNlcnZlclNob3VsZEJlUmVtb3ZlZCgpCiAgICAgewogICAgICAgICByZXR1 cm4gbmV3IFByb21pc2UoZnVuY3Rpb24ocmVzb2x2ZSkgewotICAgICAgICAgICAgaGFuZGxlID0g c2V0SW50ZXJ2YWwoZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBmdW5jdGlvbiB0ZXN0SWZSZW1v dmVkKCkgewogICAgICAgICAgICAgICAgIGdjKCk7Ci0gICAgICAgICAgICAgICAgaWYgKGludGVy bmFscyAmJiBpbnRlcm5hbHMubnVtYmVyT2ZJbnRlcnNlY3Rpb25PYnNlcnZlcnMoZG9jdW1lbnQp ID09IDApIHsKLSAgICAgICAgICAgICAgICAgICAgY2xlYXJJbnRlcnZhbChoYW5kbGUpOworICAg ICAgICAgICAgICAgIGlmIChpbnRlcm5hbHMgJiYgaW50ZXJuYWxzLm51bWJlck9mSW50ZXJzZWN0 aW9uT2JzZXJ2ZXJzKGRvY3VtZW50KSA9PSAwKQogICAgICAgICAgICAgICAgICAgICByZXNvbHZl KCk7Ci0gICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgfSwgMTApOworICAgICAgICAgICAg ICAgIGVsc2UKKyAgICAgICAgICAgICAgICAgICAgcmVxdWVzdEFuaW1hdGlvbkZyYW1lKHRlc3RJ ZlJlbW92ZWQpOworICAgICAgICAgICAgfQorCisgICAgICAgICAgICB0ZXN0SWZSZW1vdmVkKCk7 CiAgICAgICAgIH0pOwogICAgIH0KIAo=