220626 2021-01-14 11:45:47 -0800 AX: increment/decrement synthetic arrow events don't work in ARIA slider examples 2021-01-15 14:54:13 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 jcraig cfleizach aboxhall apinheiro cfleizach dmazzoni ews-watchlist jdiggs samuel_white webkit-bug-importer zalan oldest_to_newest 1719647 0 jcraig 2021-01-14 11:45:47 -0800 Synthetic arrow key events seem to have shipped in bug 213744, but they aren't working on the ARIA slider examples in https://www.w3.org/TR/wai-aria-practices/examples/slider/slider-1.html. 1719775 1 jcraig 2021-01-14 19:09:35 -0800 WebKit increment/decrement is sending event.key but not the legacy event.keyCode. The AX synthesized key events should be identical to the standard key events. 1719776 2 webkit-bug-importer 2021-01-14 19:09:43 -0800 <rdar://problem/73228924> 1719777 3 jcraig 2021-01-14 19:14:48 -0800 FYI this table is listed as optional, but is not really optional for the AX work until WebKit unships those event properties from the non-AX events: https://github.com/WICG/aom/blob/gh-pages/explainer.md#deprecated-keyboardevent-object-properties-optional 1719954 4 417720 cfleizach 2021-01-15 12:37:33 -0800 Created attachment 417720 patch 1720022 5 jcraig 2021-01-15 14:24:27 -0800 The patch should include all the other key event properties listed in that table for two reasons. 1. Someone else is going to write an example that works with the keyboard but doesn't work with VO because it uses another one of the legacy properties. `event.which` for example. It's 0 with this patch, but should be 40 for ArrowDown... 2. Any difference in the event object could be used to differentiate an AT user from a keyboard used. For example: event.code, event.keyLocation and event.metaKey are also different between the AT and non-AT paths using this patch, but should not be. 1720024 6 cfleizach 2021-01-15 14:31:11 -0800 (In reply to James Craig from comment #5) > The patch should include all the other key event properties listed in that > table for two reasons. > > 1. Someone else is going to write an example that works with the keyboard > but doesn't work with VO because it uses another one of the legacy > properties. `event.which` for example. It's 0 with this patch, but should be > 40 for ArrowDown... > > 2. Any difference in the event object could be used to differentiate an AT > user from a keyboard used. For example: event.code, event.keyLocation and > event.metaKey are also different between the AT and non-AT paths using this > patch, but should not be. Can you give us a new bug for these tasks. I'll do a deeper dive on other needed properties 1720027 7 jcraig 2021-01-15 14:35:26 -0800 OK 1720032 8 jcraig 2021-01-15 14:36:57 -0800 At a minimum, you may want to consider event.which in this patch... And event.keyIdentifier is using a different case, too: up vs Up. 1720034 9 cfleizach 2021-01-15 14:38:42 -0800 (In reply to James Craig from comment #8) > At a minimum, you may want to consider event.which in this patch... And > event.keyIdentifier is using a different case, too: up vs Up. better to handle all these things together in a specific patch 1720039 10 jcraig 2021-01-15 14:43:13 -0800 bug 220675 1720043 11 ews-feeder 2021-01-15 14:54:11 -0800 Committed r271536: <https://trac.webkit.org/changeset/271536> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417720. 417720 2021-01-15 12:37:33 -0800 2021-01-15 14:54:12 -0800 patch file_220626.txt text/plain 5619 cfleizach ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv Zw0KaW5kZXggNjEyMjJkMmFiZDMwLi5iYTVlYTYwNWJiOWMgMTAwNjQ0DQotLS0gYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cNCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZw0KQEAgLTEsMyArMSwx NCBAQA0KKzIwMjEtMDEtMTUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4N CisNCisgICAgICAgIEFYOiBpbmNyZW1lbnQvZGVjcmVtZW50IHN5bnRoZXRpYyBhcnJvdyBldmVu dHMgZG9uJ3Qgd29yayBpbiBBUklBIHNsaWRlciBleGFtcGxlcw0KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDYyNg0KKyAgICAgICAgPHJkYXI6Ly9w cm9ibGVtLzczMjI4OTI0Pg0KKw0KKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku DQorDQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkva2V5ZXZlbnRzLXBvc3RlZC1mb3ItaW5jcmVt ZW50LWFjdGlvbnMtZXhwZWN0ZWQudHh0Og0KKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2tleWV2 ZW50cy1wb3N0ZWQtZm9yLWluY3JlbWVudC1hY3Rpb25zLmh0bWw6DQorDQogMjAyMS0wMS0xMyAg UnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4NCiANCiAgICAgICAgIFttYWNPUyBX SzFdIEFTU0VSVElPTiBGQUlMRUQ6ICFuZWVkc0xheW91dCgpIGluIFdlYkNvcmU6OkZyYW1lVmll dzo6cGFpbnRDb250ZW50cw0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkv a2V5ZXZlbnRzLXBvc3RlZC1mb3ItaW5jcmVtZW50LWFjdGlvbnMtZXhwZWN0ZWQudHh0IGIvTGF5 b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9rZXlldmVudHMtcG9zdGVkLWZvci1pbmNyZW1lbnQtYWN0 aW9ucy1leHBlY3RlZC50eHQNCmluZGV4IDY1M2EwZDUwZjMyMC4uZGYyMmM5MjNkMzAwIDEwMDY0 NA0KLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9rZXlldmVudHMtcG9zdGVkLWZvci1p bmNyZW1lbnQtYWN0aW9ucy1leHBlY3RlZC50eHQNCisrKyBiL0xheW91dFRlc3RzL2FjY2Vzc2li aWxpdHkva2V5ZXZlbnRzLXBvc3RlZC1mb3ItaW5jcmVtZW50LWFjdGlvbnMtZXhwZWN0ZWQudHh0 DQpAQCAtNSwxOCArNSwxOCBAQCBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2Yg IlBBU1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURQ0KIA0KIEluY3JlbWVu dC9EZWNyZW1lbnQgLSBMVFINCiBIb3Jpem9udGFsIG9yaWVudGF0aW9uDQotS2V5Y29kZSByZWNl aXZlZDogaWRlbnRpZmllcjogcmlnaHQga2V5IG5hbWU6IEFycm93UmlnaHQNCi1LZXljb2RlIHJl Y2VpdmVkOiBpZGVudGlmaWVyOiBsZWZ0IGtleSBuYW1lOiBBcnJvd0xlZnQNCitLZXljb2RlIHJl Y2VpdmVkOiBpZGVudGlmaWVyOiByaWdodCBrZXkgbmFtZTogQXJyb3dSaWdodCBrZXkgY29kZTog MzkNCitLZXljb2RlIHJlY2VpdmVkOiBpZGVudGlmaWVyOiBsZWZ0IGtleSBuYW1lOiBBcnJvd0xl ZnQga2V5IGNvZGU6IDM3DQogVmVydGljYWwgb3JpZW50YXRpb24NCi1LZXljb2RlIHJlY2VpdmVk OiBpZGVudGlmaWVyOiB1cCBrZXkgbmFtZTogQXJyb3dVcA0KLUtleWNvZGUgcmVjZWl2ZWQ6IGlk ZW50aWZpZXI6IGRvd24ga2V5IG5hbWU6IEFycm93RG93bg0KK0tleWNvZGUgcmVjZWl2ZWQ6IGlk ZW50aWZpZXI6IHVwIGtleSBuYW1lOiBBcnJvd1VwIGtleSBjb2RlOiAzOA0KK0tleWNvZGUgcmVj ZWl2ZWQ6IGlkZW50aWZpZXI6IGRvd24ga2V5IG5hbWU6IEFycm93RG93biBrZXkgY29kZTogNDAN CiBJbmNyZW1lbnQvRGVjcmVtZW50IC0gUlRMDQogSG9yaXpvbnRhbCBvcmllbnRhdGlvbg0KLUtl eWNvZGUgcmVjZWl2ZWQ6IGlkZW50aWZpZXI6IGxlZnQga2V5IG5hbWU6IEFycm93TGVmdA0KLUtl eWNvZGUgcmVjZWl2ZWQ6IGlkZW50aWZpZXI6IHJpZ2h0IGtleSBuYW1lOiBBcnJvd1JpZ2h0DQor S2V5Y29kZSByZWNlaXZlZDogaWRlbnRpZmllcjogbGVmdCBrZXkgbmFtZTogQXJyb3dMZWZ0IGtl eSBjb2RlOiAzNw0KK0tleWNvZGUgcmVjZWl2ZWQ6IGlkZW50aWZpZXI6IHJpZ2h0IGtleSBuYW1l OiBBcnJvd1JpZ2h0IGtleSBjb2RlOiAzOQ0KIFZlcnRpY2FsIG9yaWVudGF0aW9uDQotS2V5Y29k ZSByZWNlaXZlZDogaWRlbnRpZmllcjogdXAga2V5IG5hbWU6IEFycm93VXANCi1LZXljb2RlIHJl Y2VpdmVkOiBpZGVudGlmaWVyOiBkb3duIGtleSBuYW1lOiBBcnJvd0Rvd24NCitLZXljb2RlIHJl Y2VpdmVkOiBpZGVudGlmaWVyOiB1cCBrZXkgbmFtZTogQXJyb3dVcCBrZXkgY29kZTogMzgNCitL ZXljb2RlIHJlY2VpdmVkOiBpZGVudGlmaWVyOiBkb3duIGtleSBuYW1lOiBBcnJvd0Rvd24ga2V5 IGNvZGU6IDQwDQogUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQ0KIA0KIFRFU1QgQ09N UExFVEUNCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2tleWV2ZW50cy1w b3N0ZWQtZm9yLWluY3JlbWVudC1hY3Rpb25zLmh0bWwgYi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L2tleWV2ZW50cy1wb3N0ZWQtZm9yLWluY3JlbWVudC1hY3Rpb25zLmh0bWwNCmluZGV4IGRm YTc4NDc4NjBhZi4uN2FhYWM0ZmU2ZjkwIDEwMDY0NA0KLS0tIGEvTGF5b3V0VGVzdHMvYWNjZXNz aWJpbGl0eS9rZXlldmVudHMtcG9zdGVkLWZvci1pbmNyZW1lbnQtYWN0aW9ucy5odG1sDQorKysg Yi9MYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L2tleWV2ZW50cy1wb3N0ZWQtZm9yLWluY3JlbWVu dC1hY3Rpb25zLmh0bWwNCkBAIC0yMCw3ICsyMCw3IEBADQogDQogICAgIHZhciBrZXlDb3VudCA9 IDA7DQogICAgIGZ1bmN0aW9uIGhhbmRsZUtleURvd24oZXZlbnQpIHsNCi0gICAgICAgIGRlYnVn KCJLZXljb2RlIHJlY2VpdmVkOiBpZGVudGlmaWVyOiAiICsgZXZlbnQua2V5SWRlbnRpZmllciAr ICIga2V5IG5hbWU6ICIgKyBldmVudC5rZXkpOw0KKyAgICAgICAgZGVidWcoIktleWNvZGUgcmVj ZWl2ZWQ6IGlkZW50aWZpZXI6ICIgKyBldmVudC5rZXlJZGVudGlmaWVyICsgIiBrZXkgbmFtZTog IiArIGV2ZW50LmtleSArICIga2V5IGNvZGU6ICIgKyBldmVudC5rZXlDb2RlKTsNCiAgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7DQogICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24o KTsNCiANCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cNCmluZGV4IDkzY2E4MzI3ODE3Mi4uOTY0MjkxOTZkYWVkIDEwMDY0NA0K LS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nDQorKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cNCkBAIC0xLDMgKzEsMTggQEANCisyMDIxLTAxLTE1ICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+DQorDQorICAgICAgICBBWDogaW5jcmVtZW50L2RlY3JlbWVudCBz eW50aGV0aWMgYXJyb3cgZXZlbnRzIGRvbid0IHdvcmsgaW4gQVJJQSBzbGlkZXIgZXhhbXBsZXMN CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA2MjYN CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MzIyODkyND4NCisNCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLg0KKw0KKyAgICAgICAga2V5Q29kZSBpcyBzdGlsbCBleHBlY3Rl ZCB0byBiZSBmaWxsZWQgaW4gd2l0aCBzdGFuZGFyZCBjb2RlcyBmb3IgYXJyb3cga2V5cy4NCisN CisgICAgICAgIFVwZGF0ZWQgdGVzdDogYWNjZXNzaWJpbGl0eS9rZXlldmVudHMtcG9zdGVkLWZv ci1pbmNyZW1lbnQtYWN0aW9ucy5odG1sDQorDQorICAgICAgICAqIGFjY2Vzc2liaWxpdHkvQWNj ZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwOg0KKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlOb2RlT2JqZWN0Ojpwb3N0S2V5Ym9hcmRLZXlzRm9yVmFsdWVDaGFuZ2UpOg0KKw0KIDIwMjEt MDEtMTMgIEplciBOb2JsZSAgPGplci5ub2JsZUBhcHBsZS5jb20+DQogDQogICAgICAgICBGYWNl Ym9vayBwYXVzZXMgdmlkZW8gaW4gUGlQIGR1cmluZyBzY3JvbGwNCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwDQpp bmRleCA0ZWJlMzRmMWUwZjIuLjBmZjBkNDRhOTZmZCAxMDA2NDQNCi0tLSBhL1NvdXJjZS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU5vZGVPYmplY3QuY3BwDQorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlOb2RlT2JqZWN0LmNwcA0KQEAg LTExMzQsOCArMTEzNCwxMCBAQCBib29sIEFjY2Vzc2liaWxpdHlOb2RlT2JqZWN0Ojpwb3N0S2V5 Ym9hcmRLZXlzRm9yVmFsdWVDaGFuZ2UoYm9vbCBpbmNyZWFzZSkNCiAgICAgYm9vbCB2ZXJ0aWNh bCA9IG9yaWVudGF0aW9uKCkgPT0gQWNjZXNzaWJpbGl0eU9yaWVudGF0aW9uOjpWZXJ0aWNhbDsN CiAgICAgYm9vbCBpc0xUUiA9IHBhZ2UoKS0+dXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbigp ID09IFVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb246OkxUUjsNCiAgICAgDQotICAgIGtleUlu aXQua2V5ID0gaW5jcmVhc2UgPyB2ZXJ0aWNhbCA/ICJBcnJvd1VwIl9zIDogaXNMVFIgPyAiQXJy b3dSaWdodCJfcyA6ICJBcnJvd0xlZnQiX3MgOiB2ZXJ0aWNhbCA/ICJBcnJvd0Rvd24iX3MgOiBp c0xUUiA/ICJBcnJvd0xlZnQiX3MgOiAiQXJyb3dSaWdodCJfczsNCi0gICAga2V5SW5pdC5rZXlJ ZGVudGlmaWVyID0gaW5jcmVhc2UgPyB2ZXJ0aWNhbCA/ICJ1cCJfcyA6IGlzTFRSID8gInJpZ2h0 Il9zIDogImxlZnQiX3MgOiB2ZXJ0aWNhbCA/ICJkb3duIl9zIDogaXNMVFIgPyAibGVmdCJfcyA6 ICJyaWdodCJfczsNCisgICAgdHlwZWRlZiBlbnVtIHsgbGVmdCA9IDM3LCB1cCA9IDM4LCByaWdo dCA9IDM5LCBkb3duID0gNDAgfSBrZXlDb2RlOw0KKyAgICBrZXlJbml0LmtleSA9IGluY3JlYXNl ID8gKHZlcnRpY2FsID8gIkFycm93VXAiX3MgOiAoaXNMVFIgPyAiQXJyb3dSaWdodCJfcyA6ICJB cnJvd0xlZnQiX3MpKSA6ICh2ZXJ0aWNhbCA/ICJBcnJvd0Rvd24iX3MgOiAoaXNMVFIgPyAiQXJy b3dMZWZ0Il9zIDogIkFycm93UmlnaHQiX3MpKTsNCisgICAga2V5SW5pdC5rZXlDb2RlID0gaW5j cmVhc2UgPyAodmVydGljYWwgPyBrZXlDb2RlOjp1cCA6IChpc0xUUiA/IGtleUNvZGU6OnJpZ2h0 IDoga2V5Q29kZTo6bGVmdCkpIDogKHZlcnRpY2FsID8ga2V5Q29kZTo6ZG93biA6IChpc0xUUiA/ IGtleUNvZGU6OmxlZnQgOiBrZXlDb2RlOjpyaWdodCkpOw0KKyAgICBrZXlJbml0LmtleUlkZW50 aWZpZXIgPSBpbmNyZWFzZSA/ICh2ZXJ0aWNhbCA/ICJ1cCJfcyA6IChpc0xUUiA/ICJyaWdodCJf cyA6ICJsZWZ0Il9zKSkgOiAodmVydGljYWwgPyAiZG93biJfcyA6IChpc0xUUiA/ICJsZWZ0Il9z IDogInJpZ2h0Il9zKSk7DQogDQogICAgIHJldHVybiBkaXNwYXRjaFNpbXVsYXRlZEtleWJvYXJk VXBEb3duRXZlbnQodGhpcywga2V5SW5pdCk7DQogfQ0K