220608 2021-01-13 16:14:26 -0800 REGRESSION(r266695) Range control with custom track width sized incorrectly 2021-01-19 14:15:20 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=210089 InRadar P2 Normal --- 1 zalan svillar bfulgham esprehn+autocc ews-watchlist glenn graouts gyuyoung.kim hi koivisto macpherson menard simon.fraser wenson_hsieh zalan oldest_to_newest 1719476 0 zalan 2021-01-13 16:14:26 -0800 <rdar://problem/73120825> 1719477 1 417577 zalan 2021-01-13 16:14:40 -0800 Created attachment 417577 test reduction 1719487 2 simon.fraser 2021-01-13 16:44:41 -0800 Do we need to change the styling on range inputs to handle this case? 1719560 3 svillar 2021-01-14 01:40:55 -0800 (In reply to Simon Fraser (smfr) from comment #2) > Do we need to change the styling on range inputs to handle this case? I think so, the issues that appear with "min-size:auto" changes are normally fixed by setting 0 as the min-size (which was the default before and thus a lot of code relies on that). Zalan, will this patch provide the expected results: diff --git a/Source/WebCore/css/html.css b/Source/WebCore/css/html.css index c2ffebcf0716..011939f1e9ca 100644 --- a/Source/WebCore/css/html.css +++ b/Source/WebCore/css/html.css @@ -834,6 +834,7 @@ input[type="range"]::-webkit-slider-container, input[type="range"]::-webkit-medi box-sizing: border-box; display: flex; align-contents: center; + min-width: 0; } input[type="range"]::-webkit-slider-runnable-track { 1719627 4 zalan 2021-01-14 10:09:14 -0800 It does. It's pretty embarrassing that we've got to add such hacks to make things work while the proper solution is as simple as this diff --git a/Source/WebCore/rendering/style/RenderStyle.h b/Source/WebCore/rendering/style/RenderStyle.h index 804454d3e241..50ed6877bf75 100644 --- a/Source/WebCore/rendering/style/RenderStyle.h +++ b/Source/WebCore/rendering/style/RenderStyle.h @@ -1551,7 +1551,7 @@ public: static float initialLetterSpacing() { return 0; } static Length initialWordSpacing() { return Length(Fixed); } static Length initialSize() { return Length(); } - static Length initialMinSize() { return Length(); } + static Length initialMinSize() { return Length(Fixed); } static Length initialMaxSize() { return Length(Undefined); } static Length initialOffset() { return Length(); } static Length initialRadius() { return Length(); } 1719866 5 svillar 2021-01-15 07:12:47 -0800 (In reply to zalan from comment #4) > It does. It's pretty embarrassing that we've got to add such hacks to make > things work while the proper solution is as simple as this > > diff --git a/Source/WebCore/rendering/style/RenderStyle.h > b/Source/WebCore/rendering/style/RenderStyle.h > index 804454d3e241..50ed6877bf75 100644 > --- a/Source/WebCore/rendering/style/RenderStyle.h > +++ b/Source/WebCore/rendering/style/RenderStyle.h > @@ -1551,7 +1551,7 @@ public: > static float initialLetterSpacing() { return 0; } > static Length initialWordSpacing() { return Length(Fixed); } > static Length initialSize() { return Length(); } > - static Length initialMinSize() { return Length(); } > + static Length initialMinSize() { return Length(Fixed); } > static Length initialMaxSize() { return Length(Undefined); } > static Length initialOffset() { return Length(); } > static Length initialRadius() { return Length(); } Well but we cannot do this right? Unless I'm missing something the initial value for min-size properties must be auto. 1719876 6 zalan 2021-01-15 08:12:42 -0800 (In reply to Sergio Villar Senin from comment #5) > (In reply to zalan from comment #4) > > It does. It's pretty embarrassing that we've got to add such hacks to make > > things work while the proper solution is as simple as this > > > > diff --git a/Source/WebCore/rendering/style/RenderStyle.h > > b/Source/WebCore/rendering/style/RenderStyle.h > > index 804454d3e241..50ed6877bf75 100644 > > --- a/Source/WebCore/rendering/style/RenderStyle.h > > +++ b/Source/WebCore/rendering/style/RenderStyle.h > > @@ -1551,7 +1551,7 @@ public: > > static float initialLetterSpacing() { return 0; } > > static Length initialWordSpacing() { return Length(Fixed); } > > static Length initialSize() { return Length(); } > > - static Length initialMinSize() { return Length(); } > > + static Length initialMinSize() { return Length(Fixed); } > > static Length initialMaxSize() { return Length(Undefined); } > > static Length initialOffset() { return Length(); } > > static Length initialRadius() { return Length(); } > > Well but we cannot do this right? Unless I'm missing something the initial > value for min-size properties must be auto. Yeah, I didn't upload this as a patch, did I (j/k) :) 1720280 7 417808 svillar 2021-01-18 00:40:13 -0800 Created attachment 417808 Patch 1720690 8 417808 zalan 2021-01-19 14:09:31 -0800 Comment on attachment 417808 Patch It looks ready to be landed. Let me just cq+-it. Hope you don't mind it. 1720693 9 ews-feeder 2021-01-19 14:15:16 -0800 Committed r271618: <https://trac.webkit.org/changeset/271618> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417808. 417577 2021-01-13 16:14:40 -0800 2021-01-13 16:14:40 -0800 test reduction 73120825.html text/html 147 zalan PHN0eWxlPgppbnB1dFt0eXBlPXJhbmdlXTo6LXdlYmtpdC1zbGlkZXItcnVubmFibGUtdHJhY2sg ewogICAgd2lkdGg6IDgwMHB4Owp9Cjwvc3R5bGU+ClBBU1MgaWYgdGhlIHNsaWRlciBpcyBzaXpl ZCBwcm9wZXJseS4KPGlucHV0IHR5cGU9InJhbmdlIj4K 417808 2021-01-18 00:40:13 -0800 2021-01-19 14:15:18 -0800 Patch bug-220608-20210118094011.patch text/plain 3460 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjQ1NjM1YjA3YmI5YzNh NjY4ZGIxYTkyYjdjMWJhNzhmMDVjZDJlNy4uNTcyZTUwYmQxNjY0MTAzYTMxZWI0MmZkZTgzNmYx ZDU0NDg0YTllZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAxLTE4ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjI2NjY5NSkgUmFuZ2UgY29udHJvbCB3aXRoIGN1c3RvbSB0cmFjayB3aWR0aCBzaXplZCBp bmNvcnJlY3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjIwNjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgVGVzdDogZmFzdC9mb3Jtcy9yYW5nZS9pbnB1dC1yYW5nZS1zaXppbmctZml4ZWQtc2l6ZS5o dG1sCisKKyAgICAgICAgSW4gcjI2NjY5NSB3ZSBtb2RpZmllZCB0aGUgd2F5IG1pbi17d2lkdGh8 aGVpZ2h0fTogYXV0byB3YXMgY29tcHV0ZWQgZm9yIGZsZXhib3ggZWxlbWVudHMuIFRoYXQgYnJv a2UgdGhlIHNpemluZworICAgICAgICBvZiBpbnB1dCByYW5nZSBjb250cm9scyB0aGF0IHdlcmUg d29ya2luZyB1bmRlciB0aGUgYXNzdW1wdGlvbiB0aGF0IG1pbi17d2lkdGh8aGVpZ2h0fSB3YXMg MC4gV2UgaGF2ZSB0byBmb3JjZSBpdAorICAgICAgICBpbiB0aGUgVUEgQ1NTIGluIG9yZGVyIHRv IGtlZXAgdGhlIHNhbWUgYmVoYXZpb3VyLgorCisgICAgICAgICogY3NzL2h0bWwuY3NzOgorICAg ICAgICAoaW5wdXRbdHlwZT0icmFuZ2UiXTo6LXdlYmtpdC1zbGlkZXItY29udGFpbmVyLCBpbnB1 dFt0eXBlPSJyYW5nZSJdOjotd2Via2l0LW1lZGlhLXNsaWRlci1jb250YWluZXIpOiBmb3JjZQor ICAgICAgICBtaW4td2lkdGg6IDAuCisKIDIwMjEtMDEtMTMgIFNlcmdpbyBWaWxsYXIgU2VuaW4g IDxzdmlsbGFyQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMjY4NjY2KSBJbmNv cnJlY3QgdmVydGljYWwgcG9zaXRpb24gaW5zaWRlIGdyaWQgaXRlbXMgd2l0aCBwYWRkaW5nCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9jc3MvaHRtbC5jc3MgYi9Tb3VyY2UvV2ViQ29yZS9j c3MvaHRtbC5jc3MKaW5kZXggYzJmZmViY2YwNzE2NGRkMzkxZWQ3ZmU5OWE5Y2Q4NWNiZmRmNGQy Yy4uMDExOTM5ZjFlOWNhYzcwNzU2ODI0NjQ0NTY2MzQzODBmZWExY2MwZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvY3NzL2h0bWwuY3NzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9odG1s LmNzcwpAQCAtODM0LDYgKzgzNCw3IEBAIGlucHV0W3R5cGU9InJhbmdlIl06Oi13ZWJraXQtc2xp ZGVyLWNvbnRhaW5lciwgaW5wdXRbdHlwZT0icmFuZ2UiXTo6LXdlYmtpdC1tZWRpCiAgICAgYm94 LXNpemluZzogYm9yZGVyLWJveDsKICAgICBkaXNwbGF5OiBmbGV4OwogICAgIGFsaWduLWNvbnRl bnRzOiBjZW50ZXI7CisgICAgbWluLXdpZHRoOiAwOwogfQogCiBpbnB1dFt0eXBlPSJyYW5nZSJd Ojotd2Via2l0LXNsaWRlci1ydW5uYWJsZS10cmFjayB7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNWVmN2FjM2Q0MDcwYWQw ZDQ4ZDk4Njg2MzJmZjlmZWE1YWU1OTJiZC4uNmQ5ZDdkNGYzYjA0NDlhNzg1ZjY5ZGYzNzRjMDM3 N2E0YjI1NDNmMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91 dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAxLTE4ICBTZXJnaW8gVmls bGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjI2 NjY5NSkgUmFuZ2UgY29udHJvbCB3aXRoIGN1c3RvbSB0cmFjayB3aWR0aCBzaXplZCBpbmNvcnJl Y3RseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIw NjA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmV3 IHRlc3QgY2FzZSB0byB2ZXJpZnkgdGhhdCBpbnB1dCByYW5nZSBjb250cm9scyBhcmUgc2l6ZWQg Y29ycmVjdGx5IHdpdGggc3BlY2lmaWVkIHdpZHRocy4KKworICAgICAgICAqIGZhc3QvZm9ybXMv cmFuZ2UvaW5wdXQtcmFuZ2Utc2l6aW5nLWZpeGVkLXNpemUtZXhwZWN0ZWQuaHRtbDogQWRkZWQu CisgICAgICAgICogZmFzdC9mb3Jtcy9yYW5nZS9pbnB1dC1yYW5nZS1zaXppbmctZml4ZWQtc2l6 ZS5odG1sOiBBZGRlZC4KKwogMjAyMS0wMS0xMyAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxs YXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OKHIyNjg2NjYpIEluY29ycmVjdCB2 ZXJ0aWNhbCBwb3NpdGlvbiBpbnNpZGUgZ3JpZCBpdGVtcyB3aXRoIHBhZGRpbmcKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFuZ2UvaW5wdXQtcmFuZ2Utc2l6aW5nLWZpeGVk LXNpemUtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvcmFuZ2UvaW5wdXQt cmFuZ2Utc2l6aW5nLWZpeGVkLXNpemUtZXhwZWN0ZWQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0 NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5hODEwNTkz NzEzNmMxZDE2M2Y0YjEyZGNkODI1OTllOTZkNWMyZDk2Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5 b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYW5nZS9pbnB1dC1yYW5nZS1zaXppbmctZml4ZWQtc2l6ZS1l eHBlY3RlZC5odG1sCkBAIC0wLDAgKzEsMiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aW5wdXQgdHlw ZT0icmFuZ2UiPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9yYW5nZS9pbnB1 dC1yYW5nZS1zaXppbmctZml4ZWQtc2l6ZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9y YW5nZS9pbnB1dC1yYW5nZS1zaXppbmctZml4ZWQtc2l6ZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmE4N2Q0 ZjYwMjU0YWM3MDFhYjFiZmExOTNhYzZlZWM5NjkzMTU3NmQKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3JhbmdlL2lucHV0LXJhbmdlLXNpemluZy1maXhlZC1zaXpl Lmh0bWwKQEAgLTAsMCArMSw3IEBACis8IURPQ1RZUEUgaHRtbD4KKzxzdHlsZT4KK2lucHV0W3R5 cGU9cmFuZ2VdOjotd2Via2l0LXNsaWRlci1ydW5uYWJsZS10cmFjayB7CisgICAgd2lkdGg6IDgw MHB4OworfQorPC9zdHlsZT4KKzxpbnB1dCB0eXBlPSJyYW5nZSI+Cg==