220583 2021-01-13 01:55:18 -0800 [GStreamer][EME][Thunder] Bail out on failed response message for challenges 2021-01-13 04:53:13 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris cgarcia ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1719235 0 calvaris 2021-01-13 01:55:18 -0800 [GStreamer][EME][Thunder] Bail out on failed response message for challenges 1719236 1 417517 calvaris 2021-01-13 02:01:14 -0800 Created attachment 417517 Patch 1719243 2 417517 pnormand 2021-01-13 03:52:42 -0800 Comment on attachment 417517 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417517&action=review > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:365 > + ASSERT_NOT_REACHED(); How is this different from an ASSERT? In debug build you'll still crash here if the framework sent an empty message. 1719257 3 calvaris 2021-01-13 04:36:29 -0800 (In reply to Philippe Normand from comment #2) > Comment on attachment 417517 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417517&action=review > > > Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:365 > > + ASSERT_NOT_REACHED(); > > How is this different from an ASSERT? In debug build you'll still crash here > if the framework sent an empty message. Cause there is a return and it won't crash in line 370. 1719258 4 ews-feeder 2021-01-13 04:52:13 -0800 Committed r271437: <https://trac.webkit.org/changeset/271437> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417517. 1719259 5 webkit-bug-importer 2021-01-13 04:53:13 -0800 <rdar://problem/73147394> 417517 2021-01-13 02:01:14 -0800 2021-01-13 04:52:15 -0800 Patch bug-220583-20210113110113.patch text/plain 1983 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjY2NjJlOWM4NGY0OThk NjkyN2FjYTZhY2FlOGZiNjU0ZmExYzdkMy4uODkxMjE2NWViNzY2YzI1ZWI5ZTJmMjdhOWE5Zjkw NGU4Mjk1ZjllMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTEzICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bRU1FXVtUaHVuZGVyXSBCYWlsIG91dCBvbiBmYWlsZWQgcmVzcG9uc2UgbWVzc2Fn ZSBmb3IgY2hhbGxlbmdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MjIwNTgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2hlbiBwYXJzaW5nIHRoZSBjaGFsbGVuZ2UgbWVzc2FnZSwgc29tZXRpbWVzIHRo ZSBtZXNzYWdlIGxlbmd0aAorICAgICAgICBpcyAwIGFuZCBwYXJzaW5nIGZhaWxzLiBUaGlzIHNo b3VsZCBub3QgaGFwcGVuIGluIHByaW5jaXBsZSBhbmQKKyAgICAgICAgdGhhdCdzIHdoeSB3ZSBq dXN0IGFzc2VydGVkIG9uIHRoYXQgYnV0IGl0IGxvb2tzIGxpa2UgdGhlCisgICAgICAgIGZyYW1l d29yayBpcyBub3QgYXMgY2FyZWZ1bCBhcyBleHBlY3RlZCBoZXJlLiBIZW5jZSB3ZSBuZWVkIHRv CisgICAgICAgIGJhaWwgb3V0IHRvIG5vdCBjcmFzaCBpbiByZWxlYXNlIG1vZGUuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0NETVRodW5kZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6Q0RNSW5zdGFuY2VTZXNzaW9uVGh1bmRlcjo6Y2hhbGxlbmdlR2VuZXJh dGVkQ2FsbGJhY2spOgorCiAyMDIxLTAxLTEyICBYYWJpZXIgUm9kcmlndWV6IENhbHZhciAgPGNh bHZhcmlzQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gU3dpdGNoIGZyb20gRU5B QkxFXyB0byBVU0VfIGluIG5hdGl2ZSBhdWRpby92aWRlbyBhbmQgdGV4dCBzaW5rIG9wdGlvbnMK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9l bWUvQ0RNVGh1bmRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvZW1lL0NETVRodW5kZXIuY3BwCmluZGV4IDgwYWUxMjk0ZWE0OWI5ZGE0MWY4MzI1OTIx ZWFlNTkzMjYwNjFiY2QuLjlmN2UyMDU4NzE3MGI0ZGE2NjU5MzY0MWUwZTg1Y2QxMTJkOWU0OTYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9l bWUvQ0RNVGh1bmRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL2VtZS9DRE1UaHVuZGVyLmNwcApAQCAtMzYwLDcgKzM2MCwxMSBAQCBwcml2YXRl Ogogdm9pZCBDRE1JbnN0YW5jZVNlc3Npb25UaHVuZGVyOjpjaGFsbGVuZ2VHZW5lcmF0ZWRDYWxs YmFjayhSZWZQdHI8U2hhcmVkQnVmZmVyPiYmIGJ1ZmZlcikKIHsKICAgICBQYXJzZWRSZXNwb25z ZU1lc3NhZ2UgcGFyc2VkUmVzcG9uc2VNZXNzYWdlKGJ1ZmZlcik7Ci0gICAgQVNTRVJUKHBhcnNl ZFJlc3BvbnNlTWVzc2FnZSk7CisgICAgaWYgKCFwYXJzZWRSZXNwb25zZU1lc3NhZ2UpIHsKKyAg ICAgICAgR1NUX0VSUk9SKCJyZXNwb25zZSBtZXNzYWdlIHBhcnNpbmcgZmFpbGVkIik7CisgICAg ICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAg aWYgKCFtX2NoYWxsZW5nZUNhbGxiYWNrcy5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9tZXNzYWdl ID0gV1RGTW92ZShwYXJzZWRSZXNwb25zZU1lc3NhZ2UucGF5bG9hZCgpKTsK