220581 2021-01-12 23:51:46 -0800 Facebook pauses video in PiP during scroll 2021-01-13 15:32:30 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble cdumez changseok eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim katherine_cheney peng.liu6 philipj sam sergio webkit-bug-importer oldest_to_newest 1719223 0 jer.noble 2021-01-12 23:51:46 -0800 Facebook pauses video in PiP during scroll 1719225 1 jer.noble 2021-01-12 23:52:04 -0800 <rdar://67273166> 1719226 2 417514 jer.noble 2021-01-12 23:55:07 -0800 Created attachment 417514 Patch 1719298 3 417514 sam 2021-01-13 08:30:54 -0800 Comment on attachment 417514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417514&action=review > Source/WebCore/ChangeLog:12 > + Add a Quirk which blocks Facebook from pausing videos in Picture-in-Picture mode without that > + pause() occurring during a User Gesture. This blocks Facebook from pausing a PiP'd video when > + the <video> element hosting that video scrolls out of the viewport, without blocking Facebook's > + own custom pause control from working correctly. Hey Jer, I've definitely seen this issue on there sites as well (I know this because I don't use Facebook and have seen this, but can't recall where). What are your thoughts on just making this the rule for all sites: pausing PIP requires a user gesture? 1719326 4 jer.noble 2021-01-13 10:01:38 -0800 (In reply to Sam Weinig from comment #3) > Comment on attachment 417514 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417514&action=review > > > Source/WebCore/ChangeLog:12 > > + Add a Quirk which blocks Facebook from pausing videos in Picture-in-Picture mode without that > > + pause() occurring during a User Gesture. This blocks Facebook from pausing a PiP'd video when > > + the <video> element hosting that video scrolls out of the viewport, without blocking Facebook's > > + own custom pause control from working correctly. > > Hey Jer, I've definitely seen this issue on there sites as well (I know this > because I don't use Facebook and have seen this, but can't recall where). > What are your thoughts on just making this the rule for all sites: pausing > PIP requires a user gesture? I'm sympathetic. Since we added an "enter pip" button in the default controls (and similar affordance elsewhere), it's easy for sites to completely miss that the user has put the video into PiP. However, I can also definitely see pitfalls. We've evangelized our autoplay rules which state that once you've "unlocked" a media element with a user gesture, you don't need additional ones to change the play state. Sites with complicated React.js style re-dispatching event handlers might have unexpected behavior. It might still be worth it though. 1719350 5 417514 katherine_cheney 2021-01-13 10:52:41 -0800 Comment on attachment 417514 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417514&action=review > Source/WebCore/page/Quirks.cpp:1269 > + m_requiresUserGestureToPauseInPictureInPicture = equalLettersIgnoringASCIICase(host, "facebook.com") || host.endsWithIgnoringASCIICase(".facebook.com"); If you wanted, I think you could do something like: auto domain = RegistrableDomain(m_document->topDocument().url()); m_requiresUserGestureToPauseInPictureInPicture = domain.string() == "facebook.com"_s; It would make it so you don't need the extra check for the subdomain case .facebook.com (RegistrableDomain will parse the domain for you). 1719370 6 jer.noble 2021-01-13 11:28:42 -0800 (In reply to katherine_cheney from comment #5) > Comment on attachment 417514 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=417514&action=review > > > Source/WebCore/page/Quirks.cpp:1269 > > + m_requiresUserGestureToPauseInPictureInPicture = equalLettersIgnoringASCIICase(host, "facebook.com") || host.endsWithIgnoringASCIICase(".facebook.com"); > > If you wanted, I think you could do something like: > > auto domain = RegistrableDomain(m_document->topDocument().url()); > m_requiresUserGestureToPauseInPictureInPicture = domain.string() == > "facebook.com"_s; > > It would make it so you don't need the extra check for the subdomain case > .facebook.com (RegistrableDomain will parse the domain for you). Oooh, super glad someone finally made this utility class. Will adopt. 1719392 7 417553 jer.noble 2021-01-13 12:56:35 -0800 Created attachment 417553 Patch 1719462 8 ews-feeder 2021-01-13 15:32:27 -0800 Committed r271470: <https://trac.webkit.org/changeset/271470> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417553. 417514 2021-01-12 23:55:07 -0800 2021-01-13 12:56:32 -0800 Patch bug-220581-20210112235506.patch text/plain 4388 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZiMDU2Zjk1MWFhYTcx YTM5NzFkNDZiMDJlMjkyN2UyNWZiNzg4Zi4uMzNkMzA1YWM1N2UzNWFiMDFkOGMxOWU4YWMyZGJl YzJmZGNmMDZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTAxLTEyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEZhY2Vib29rIHBhdXNlcyB2 aWRlbyBpbiBQaVAgZHVyaW5nIHNjcm9sbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNTgxCisgICAgICAgIDxyZGFyOi8vNjcyNzMxNjY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgUXVpcmsg d2hpY2ggYmxvY2tzIEZhY2Vib29rIGZyb20gcGF1c2luZyB2aWRlb3MgaW4gUGljdHVyZS1pbi1Q aWN0dXJlIG1vZGUgd2l0aG91dCB0aGF0CisgICAgICAgIHBhdXNlKCkgb2NjdXJyaW5nIGR1cmlu ZyBhIFVzZXIgR2VzdHVyZS4gVGhpcyBibG9ja3MgRmFjZWJvb2sgZnJvbSBwYXVzaW5nIGEgUGlQ J2QgdmlkZW8gd2hlbgorICAgICAgICB0aGUgPHZpZGVvPiBlbGVtZW50IGhvc3RpbmcgdGhhdCB2 aWRlbyBzY3JvbGxzIG91dCBvZiB0aGUgdmlld3BvcnQsIHdpdGhvdXQgYmxvY2tpbmcgRmFjZWJv b2sncworICAgICAgICBvd24gY3VzdG9tIHBhdXNlIGNvbnRyb2wgZnJvbSB3b3JraW5nIGNvcnJl Y3RseS4KKworICAgICAgICAqIGh0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYUVsZW1lbnRTZXNzaW9uOjpwbGF5YmFja1Blcm1pdHRlZCBjb25zdCk6 CisgICAgICAgICogcGFnZS9RdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjpy ZXF1aXJlc1VzZXJHZXN0dXJlVG9QYXVzZUluUGljdHVyZUluUGljdHVyZSBjb25zdCk6CisgICAg ICAgICogcGFnZS9RdWlya3MuaDoKKwogMjAyMS0wMS0wOCAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBbSEFOR10gNDk2bXMgdG8gMTM2MG1zIGluIFdlYkNvcmU6 OkFWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXI6OnJlZnJlc2hBdWRpb0NhcHR1cmVE ZXZpY2VzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vz c2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCmlu ZGV4IGQzNWY3ZDcxMDBiY2Q2Nzg5ZWE2OWFiNDY0OWFjM2U5YzJhMmRmMzQuLjU4NzgyYmNhMjhi YTI3ZDk1ZjQxZDlhZGRjMzdjOTQ4ZTI1NTdjOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9N ZWRpYUVsZW1lbnRTZXNzaW9uLmNwcApAQCAtMzE1LDYgKzMxNSwxNCBAQCBTdWNjZXNzT3I8TWVk aWFQbGF5YmFja0RlbmlhbFJlYXNvbj4gTWVkaWFFbGVtZW50U2Vzc2lvbjo6cGxheWJhY2tQZXJt aXR0ZWQoKSBjbwogCiAgICAgLy8gRklYTUU6IFdoeSBhcmUgd2UgY2hlY2tpbmcgdG9wLWxldmVs IGRvY3VtZW50IG9ubHkgZm9yIFBlckRvY3VtZW50QXV0b3BsYXlCZWhhdmlvcj8KICAgICBjb25z dCBhdXRvJiB0b3BEb2N1bWVudCA9IGRvY3VtZW50LnRvcERvY3VtZW50KCk7CisgICAgaWYgKHRv cERvY3VtZW50LnF1aXJrcygpLnJlcXVpcmVzVXNlckdlc3R1cmVUb1BhdXNlSW5QaWN0dXJlSW5Q aWN0dXJlKCkKKyAgICAgICAgJiYgbV9lbGVtZW50LmZ1bGxzY3JlZW5Nb2RlKCkgJiBIVE1MTWVk aWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNjcmVlbk1vZGVQaWN0dXJlSW5QaWN0dXJlCisgICAg ICAgICYmICFtX2VsZW1lbnQucGF1c2VkKCkKKyAgICAgICAgJiYgIWRvY3VtZW50LnByb2Nlc3Np bmdVc2VyR2VzdHVyZUZvck1lZGlhKCkpIHsKKyAgICAgICAgQUxXQVlTX0xPRyhMT0dJREVOVElG SUVSLCAiUmV0dXJuaW5nIEZBTFNFIGJlY2F1c2UgYSBxdWlyayByZXF1aXJlcyBhIHVzZXIgZ2Vz dHVyZSB0byBwYXVzZSB3aGlsZSBpbiBQaWN0dXJlLWluLVBpY3R1cmUiKTsKKyAgICAgICAgcmV0 dXJuIE1lZGlhUGxheWJhY2tEZW5pYWxSZWFzb246OlVzZXJHZXN0dXJlUmVxdWlyZWQ7CisgICAg fQorCiAgICAgaWYgKHRvcERvY3VtZW50Lm1lZGlhU3RhdGUoKSAmIE1lZGlhUHJvZHVjZXI6Okhh c1VzZXJJbnRlcmFjdGVkV2l0aE1lZGlhRWxlbWVudCAmJiB0b3BEb2N1bWVudC5xdWlya3MoKS5u ZWVkc1BlckRvY3VtZW50QXV0b3BsYXlCZWhhdmlvcigpKQogICAgICAgICByZXR1cm4geyB9Owog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXggNTU0NDNhMGFjOTY4MWU3YjExOTRjOGZjNjQyYmQw N2Y5YmQwMDQzNC4uNWIyZDQzNGVmOGRjNjk1MDdkNjhkNTAzMGVkNjg3YWM3MDY0MjA5YiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUXVpcmtzLmNwcApAQCAtMTI1OCw0ICsxMjU4LDE4IEBAIGJvb2wgUXVpcmtzOjpu ZWVkc0JsYWNrRnVsbHNjcmVlbkJhY2tncm91bmRRdWlyaygpIGNvbnN0CiAgICAgcmV0dXJuICpt X25lZWRzQmxhY2tGdWxsc2NyZWVuQmFja2dyb3VuZFF1aXJrOwogfQogCitib29sIFF1aXJrczo6 cmVxdWlyZXNVc2VyR2VzdHVyZVRvUGF1c2VJblBpY3R1cmVJblBpY3R1cmUoKSBjb25zdAorewor ICAgIC8vIEZhY2Vib29rIHdpbGwgbmFpdmVseSBwYXVzZSBhIDx2aWRlbz4gZWxlbWVudCB0aGF0 IGhhcyBzY3JvbGxlZCBvdXQgb2YgdGhlIHZpZXdwb3J0LCByZWdhcmRsZXNzIG9mIHdoZXRoZXIg dGhhdCBlbGVtZW50IGlzIGN1cnJlbnRseSBpbiBQaVAgbW9kZS4KKyAgICBpZiAoIW5lZWRzUXVp cmtzKCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIGlmICghbV9yZXF1aXJlc1VzZXJH ZXN0dXJlVG9QYXVzZUluUGljdHVyZUluUGljdHVyZSkgeworICAgICAgICBhdXRvIGhvc3QgPSBt X2RvY3VtZW50LT50b3BEb2N1bWVudCgpLnVybCgpLmhvc3QoKTsKKyAgICAgICAgbV9yZXF1aXJl c1VzZXJHZXN0dXJlVG9QYXVzZUluUGljdHVyZUluUGljdHVyZSA9IGVxdWFsTGV0dGVyc0lnbm9y aW5nQVNDSUlDYXNlKGhvc3QsICJmYWNlYm9vay5jb20iKSB8fCBob3N0LmVuZHNXaXRoSWdub3Jp bmdBU0NJSUNhc2UoIi5mYWNlYm9vay5jb20iKTsKKyAgICB9CisKKyAgICByZXR1cm4gKm1fcmVx dWlyZXNVc2VyR2VzdHVyZVRvUGF1c2VJblBpY3R1cmVJblBpY3R1cmU7Cit9CisKIH0KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmggYi9Tb3VyY2UvV2ViQ29yZS9wYWdl L1F1aXJrcy5oCmluZGV4IGRjNDlkMTVkMzM4MGFiNDVhZjUyM2E3NGE1Mjc1NzhlNmQzMDYyMjku LmUyZGZjNGI4OTQ1MjEyMDRhZGY4ZTdmYWRlZDllMjU0NmQ3NDU5ODYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWly a3MuaApAQCAtMTIzLDYgKzEyMyw4IEBAIHB1YmxpYzoKIAogICAgIGJvb2wgbmVlZHNCbGFja0Z1 bGxzY3JlZW5CYWNrZ3JvdW5kUXVpcmsoKSBjb25zdDsKIAorICAgIGJvb2wgcmVxdWlyZXNVc2Vy R2VzdHVyZVRvUGF1c2VJblBpY3R1cmVJblBpY3R1cmUoKSBjb25zdDsKKwogI2lmIEVOQUJMRShS RVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1MpCiAgICAgc3RhdGljIGJvb2wgaXNNaWNyb3NvZnRUZWFt c1JlZGlyZWN0VVJMKGNvbnN0IFVSTCYpOwogICAgIHN0YXRpYyBib29sIGhhc1N0b3JhZ2VBY2Nl c3NGb3JBbGxMb2dpbkRvbWFpbnMoY29uc3QgSGFzaFNldDxSZWdpc3RyYWJsZURvbWFpbj4mLCBj b25zdCBSZWdpc3RyYWJsZURvbWFpbiYpOwpAQCAtMTYzLDYgKzE2NSw3IEBAIHByaXZhdGU6CiAg ICAgbXV0YWJsZSBPcHRpb25hbDxib29sPiBtX25lZWRzVlA5RnVsbFJhbmdlRmxhZ1F1aXJrOwog ICAgIG11dGFibGUgT3B0aW9uYWw8Ym9vbD4gbV9uZWVkc0hEUlBpeGVsRGVwdGhRdWlyazsKICAg ICBtdXRhYmxlIE9wdGlvbmFsPGJvb2w+IG1fbmVlZHNCbGFja0Z1bGxzY3JlZW5CYWNrZ3JvdW5k UXVpcms7CisgICAgbXV0YWJsZSBPcHRpb25hbDxib29sPiBtX3JlcXVpcmVzVXNlckdlc3R1cmVU b1BhdXNlSW5QaWN0dXJlSW5QaWN0dXJlOwogfTsKIAogfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQo= 417553 2021-01-13 12:56:35 -0800 2021-01-13 15:32:28 -0800 Patch bug-220581-20210113125634.patch text/plain 4582 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2ZiMDU2Zjk1MWFhYTcx YTM5NzFkNDZiMDJlMjkyN2UyNWZiNzg4Zi4uMzNkMzA1YWM1N2UzNWFiMDFkOGMxOWU4YWMyZGJl YzJmZGNmMDZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTAxLTEyICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIEZhY2Vib29rIHBhdXNlcyB2 aWRlbyBpbiBQaVAgZHVyaW5nIHNjcm9sbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNTgxCisgICAgICAgIDxyZGFyOi8vNjcyNzMxNjY+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgUXVpcmsg d2hpY2ggYmxvY2tzIEZhY2Vib29rIGZyb20gcGF1c2luZyB2aWRlb3MgaW4gUGljdHVyZS1pbi1Q aWN0dXJlIG1vZGUgd2l0aG91dCB0aGF0CisgICAgICAgIHBhdXNlKCkgb2NjdXJyaW5nIGR1cmlu ZyBhIFVzZXIgR2VzdHVyZS4gVGhpcyBibG9ja3MgRmFjZWJvb2sgZnJvbSBwYXVzaW5nIGEgUGlQ J2QgdmlkZW8gd2hlbgorICAgICAgICB0aGUgPHZpZGVvPiBlbGVtZW50IGhvc3RpbmcgdGhhdCB2 aWRlbyBzY3JvbGxzIG91dCBvZiB0aGUgdmlld3BvcnQsIHdpdGhvdXQgYmxvY2tpbmcgRmFjZWJv b2sncworICAgICAgICBvd24gY3VzdG9tIHBhdXNlIGNvbnRyb2wgZnJvbSB3b3JraW5nIGNvcnJl Y3RseS4KKworICAgICAgICAqIGh0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHA6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYUVsZW1lbnRTZXNzaW9uOjpwbGF5YmFja1Blcm1pdHRlZCBjb25zdCk6 CisgICAgICAgICogcGFnZS9RdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjpy ZXF1aXJlc1VzZXJHZXN0dXJlVG9QYXVzZUluUGljdHVyZUluUGljdHVyZSBjb25zdCk6CisgICAg ICAgICogcGFnZS9RdWlya3MuaDoKKwogMjAyMS0wMS0wOCAgSmVyIE5vYmxlICA8amVyLm5vYmxl QGFwcGxlLmNvbT4KIAogICAgICAgICBbSEFOR10gNDk2bXMgdG8gMTM2MG1zIGluIFdlYkNvcmU6 OkFWQXVkaW9TZXNzaW9uQ2FwdHVyZURldmljZU1hbmFnZXI6OnJlZnJlc2hBdWRpb0NhcHR1cmVE ZXZpY2VzKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvTWVkaWFFbGVtZW50U2Vz c2lvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL01lZGlhRWxlbWVudFNlc3Npb24uY3BwCmlu ZGV4IGQzNWY3ZDcxMDBiY2Q2Nzg5ZWE2OWFiNDY0OWFjM2U5YzJhMmRmMzQuLjU4NzgyYmNhMjhi YTI3ZDk1ZjQxZDlhZGRjMzdjOTQ4ZTI1NTdjOWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2h0bWwvTWVkaWFFbGVtZW50U2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9N ZWRpYUVsZW1lbnRTZXNzaW9uLmNwcApAQCAtMzE1LDYgKzMxNSwxNCBAQCBTdWNjZXNzT3I8TWVk aWFQbGF5YmFja0RlbmlhbFJlYXNvbj4gTWVkaWFFbGVtZW50U2Vzc2lvbjo6cGxheWJhY2tQZXJt aXR0ZWQoKSBjbwogCiAgICAgLy8gRklYTUU6IFdoeSBhcmUgd2UgY2hlY2tpbmcgdG9wLWxldmVs IGRvY3VtZW50IG9ubHkgZm9yIFBlckRvY3VtZW50QXV0b3BsYXlCZWhhdmlvcj8KICAgICBjb25z dCBhdXRvJiB0b3BEb2N1bWVudCA9IGRvY3VtZW50LnRvcERvY3VtZW50KCk7CisgICAgaWYgKHRv cERvY3VtZW50LnF1aXJrcygpLnJlcXVpcmVzVXNlckdlc3R1cmVUb1BhdXNlSW5QaWN0dXJlSW5Q aWN0dXJlKCkKKyAgICAgICAgJiYgbV9lbGVtZW50LmZ1bGxzY3JlZW5Nb2RlKCkgJiBIVE1MTWVk aWFFbGVtZW50RW51bXM6OlZpZGVvRnVsbHNjcmVlbk1vZGVQaWN0dXJlSW5QaWN0dXJlCisgICAg ICAgICYmICFtX2VsZW1lbnQucGF1c2VkKCkKKyAgICAgICAgJiYgIWRvY3VtZW50LnByb2Nlc3Np bmdVc2VyR2VzdHVyZUZvck1lZGlhKCkpIHsKKyAgICAgICAgQUxXQVlTX0xPRyhMT0dJREVOVElG SUVSLCAiUmV0dXJuaW5nIEZBTFNFIGJlY2F1c2UgYSBxdWlyayByZXF1aXJlcyBhIHVzZXIgZ2Vz dHVyZSB0byBwYXVzZSB3aGlsZSBpbiBQaWN0dXJlLWluLVBpY3R1cmUiKTsKKyAgICAgICAgcmV0 dXJuIE1lZGlhUGxheWJhY2tEZW5pYWxSZWFzb246OlVzZXJHZXN0dXJlUmVxdWlyZWQ7CisgICAg fQorCiAgICAgaWYgKHRvcERvY3VtZW50Lm1lZGlhU3RhdGUoKSAmIE1lZGlhUHJvZHVjZXI6Okhh c1VzZXJJbnRlcmFjdGVkV2l0aE1lZGlhRWxlbWVudCAmJiB0b3BEb2N1bWVudC5xdWlya3MoKS5u ZWVkc1BlckRvY3VtZW50QXV0b3BsYXlCZWhhdmlvcigpKQogICAgICAgICByZXR1cm4geyB9Owog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXggNTU0NDNhMGFjOTY4MWU3YjExOTRjOGZjNjQyYmQw N2Y5YmQwMDQzNC4uMWQyODM0ODNhYWVkMTg5ZDlmZDE0NDM0OGFjYWQ0MmYzN2YyMjdkOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3BhZ2UvUXVpcmtzLmNwcApAQCAtNDUsNiArNDUsNyBAQAogI2luY2x1ZGUgIk5hbWVkTm9k ZU1hcC5oIgogI2luY2x1ZGUgIk5ldHdvcmtTdG9yYWdlU2Vzc2lvbi5oIgogI2luY2x1ZGUgIlBs YXRmb3JtTW91c2VFdmVudC5oIgorI2luY2x1ZGUgIlJlZ2lzdHJhYmxlRG9tYWluLmgiCiAjaW5j bHVkZSAiUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuaCIKICNpbmNsdWRlICJSdW50aW1lRW5hYmxlZEZl YXR1cmVzLmgiCiAjaW5jbHVkZSAiU1ZHUGF0aEVsZW1lbnQuaCIKQEAgLTEyNTgsNCArMTI1OSwx OCBAQCBib29sIFF1aXJrczo6bmVlZHNCbGFja0Z1bGxzY3JlZW5CYWNrZ3JvdW5kUXVpcmsoKSBj b25zdAogICAgIHJldHVybiAqbV9uZWVkc0JsYWNrRnVsbHNjcmVlbkJhY2tncm91bmRRdWlyazsK IH0KIAorYm9vbCBRdWlya3M6OnJlcXVpcmVzVXNlckdlc3R1cmVUb1BhdXNlSW5QaWN0dXJlSW5Q aWN0dXJlKCkgY29uc3QKK3sKKyAgICAvLyBGYWNlYm9vayB3aWxsIG5haXZlbHkgcGF1c2UgYSA8 dmlkZW8+IGVsZW1lbnQgdGhhdCBoYXMgc2Nyb2xsZWQgb3V0IG9mIHRoZSB2aWV3cG9ydCwgcmVn YXJkbGVzcyBvZiB3aGV0aGVyIHRoYXQgZWxlbWVudCBpcyBjdXJyZW50bHkgaW4gUGlQIG1vZGUu CisgICAgaWYgKCFuZWVkc1F1aXJrcygpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBp ZiAoIW1fcmVxdWlyZXNVc2VyR2VzdHVyZVRvUGF1c2VJblBpY3R1cmVJblBpY3R1cmUpIHsKKyAg ICAgICAgYXV0byBkb21haW4gPSBSZWdpc3RyYWJsZURvbWFpbihtX2RvY3VtZW50LT50b3BEb2N1 bWVudCgpLnVybCgpKTsKKyAgICAgICAgbV9yZXF1aXJlc1VzZXJHZXN0dXJlVG9QYXVzZUluUGlj dHVyZUluUGljdHVyZSA9IGRvbWFpbi5zdHJpbmcoKSA9PSAiZmFjZWJvb2suY29tIl9zOworICAg IH0KKworICAgIHJldHVybiAqbV9yZXF1aXJlc1VzZXJHZXN0dXJlVG9QYXVzZUluUGljdHVyZUlu UGljdHVyZTsKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3Mu aCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKaW5kZXggZGM0OWQxNWQzMzgwYWI0NWFm NTIzYTc0YTUyNzU3OGU2ZDMwNjIyOS4uZTJkZmM0Yjg5NDUyMTIwNGFkZjhlN2ZhZGVkOWUyNTQ2 ZDc0NTk4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oCkBAIC0xMjMsNiArMTIzLDggQEAgcHVibGljOgog CiAgICAgYm9vbCBuZWVkc0JsYWNrRnVsbHNjcmVlbkJhY2tncm91bmRRdWlyaygpIGNvbnN0Owog CisgICAgYm9vbCByZXF1aXJlc1VzZXJHZXN0dXJlVG9QYXVzZUluUGljdHVyZUluUGljdHVyZSgp IGNvbnN0OworCiAjaWYgRU5BQkxFKFJFU09VUkNFX0xPQURfU1RBVElTVElDUykKICAgICBzdGF0 aWMgYm9vbCBpc01pY3Jvc29mdFRlYW1zUmVkaXJlY3RVUkwoY29uc3QgVVJMJik7CiAgICAgc3Rh dGljIGJvb2wgaGFzU3RvcmFnZUFjY2Vzc0ZvckFsbExvZ2luRG9tYWlucyhjb25zdCBIYXNoU2V0 PFJlZ2lzdHJhYmxlRG9tYWluPiYsIGNvbnN0IFJlZ2lzdHJhYmxlRG9tYWluJik7CkBAIC0xNjMs NiArMTY1LDcgQEAgcHJpdmF0ZToKICAgICBtdXRhYmxlIE9wdGlvbmFsPGJvb2w+IG1fbmVlZHNW UDlGdWxsUmFuZ2VGbGFnUXVpcms7CiAgICAgbXV0YWJsZSBPcHRpb25hbDxib29sPiBtX25lZWRz SERSUGl4ZWxEZXB0aFF1aXJrOwogICAgIG11dGFibGUgT3B0aW9uYWw8Ym9vbD4gbV9uZWVkc0Js YWNrRnVsbHNjcmVlbkJhY2tncm91bmRRdWlyazsKKyAgICBtdXRhYmxlIE9wdGlvbmFsPGJvb2w+ IG1fcmVxdWlyZXNVc2VyR2VzdHVyZVRvUGF1c2VJblBpY3R1cmVJblBpY3R1cmU7CiB9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg==