220580 2021-01-12 23:04:38 -0800 REGRESSION (r257839): Element cannot be "focus()"ed right after becoming visible from hidden 2021-01-14 01:38:51 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build All All CLOSED DUPLICATE 217240 https://bugs.webkit.org/show_bug.cgi?id=208504 P2 Normal --- 1 tomoki.imai webkit-unassigned koivisto tomoki.imai zalan oldest_to_newest 1719215 0 417510 tomoki.imai 2021-01-12 23:04:38 -0800 Created attachment 417510 Testcase We found a regression from r257839. Here is how to reproduce: 1. Open the attached html with MiniBrowser 2. Push Enter key Expected result: Newly appeared "Menu Item" button should have focus. Actual result: Newly appeared "Menu Item" button doesn't have focus. Reproduced environment: - WinCairo MiniBrowser (r271389) Note: - I confirmed that reverting r257839 solves the issue. - Chrome (87.0.4280.141) and Firefox (84.0.1) on Windows don't have this issue - I didn't test Safari, but because the changed code in r257839 is platform-independent code, I hope it can be reproduced in Safari too. Attached test case description: "Menu Item" button is at first invisible, because the div which contains the button is "display:none". When Enter key is hit, "open" class is added, and it should overwrite "display" with "block". Then we call "focus" on the button. Because button is visible now, it should have focus. // open menu document.querySelector('.menu').classList.add('open'); // focus on menu item document.querySelector('.menu-item').focus(); <div class="menu"> <ul> <li> <button class="menu-item">Menu Item</button> </li> </ul> </div> .menu { display: none; background: #000; } .open { display: block; } 1719265 1 koivisto 2021-01-13 05:30:44 -0800 I can't repro on Safari (the menu opens fine) but I believe this is the same bug as 217240. *** This bug has been marked as a duplicate of bug 217240 *** 1719269 2 tomoki.imai 2021-01-13 06:02:40 -0800 Antti, Thanks for the info, sorry, I'm not sure why I missed that ticket. This bug and bug bug 217240 seems to be same. I confirmed that attachment 417524 in bug 217240 fixes this issue. 1719559 3 koivisto 2021-01-14 01:38:51 -0800 Thanks for confirmation! 417510 2021-01-12 23:04:38 -0800 2021-01-12 23:04:38 -0800 Testcase test.html text/html 1276 tomoki.imai PCFkb2N0eXBlIGh0bWw+DQo8aHRtbCBsYW5nPSJlbiI+DQoNCjxoZWFkPg0KICAgIDxtZXRhIGNo YXJzZXQ9InV0Zi04Ij4NCiAgICA8dGl0bGU+VGVzdDwvdGl0bGU+DQo8L2hlYWQ+DQoNCjxzdHls ZT4NCiAgICBib2R5IHsNCiAgICAgICAgYmFja2dyb3VuZC1jb2xvcjogcmdiKDMzLCAzMywgMzMp Ow0KICAgIH0NCiAgICAubWVudSB7DQogICAgICAgIGRpc3BsYXk6IG5vbmU7DQogICAgICAgIGJh Y2tncm91bmQ6ICMwMDA7DQogICAgfQ0KICAgIC5tZW51IHVsIHsNCiAgICAgICAgbGlzdC1zdHls ZTogbm9uZTsNCiAgICB9DQogICAgLm9wZW4gew0KICAgICAgICBkaXNwbGF5OiBibG9jazsNCiAg ICB9DQo8L3N0eWxlPg0KPHNjcmlwdD4NCiAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcignbG9h ZCcsICgpID0+IHsNCiAgICAgICAgZG9jdW1lbnQucXVlcnlTZWxlY3RvcignLm9wZW4tYnV0dG9u JykuZm9jdXMoKTsNCiAgICB9KTsNCg0KICAgIHdpbmRvdy5hZGRFdmVudExpc3RlbmVyKCdrZXlk b3duJywgKGV2dCkgPT4gew0KICAgICAgICBpZiAoZXZ0LmtleUNvZGUgPT09IDEzKSB7IC8vIEVu dGVyDQogICAgICAgICAgICAvLyBvcGVuIG1lbnUNCiAgICAgICAgICAgIGRvY3VtZW50LnF1ZXJ5 U2VsZWN0b3IoJy5tZW51JykuY2xhc3NMaXN0LmFkZCgnb3BlbicpOw0KICAgICAgICAgICAgLy8g Zm9jdXMgb24gbWVudSBpdGVtDQogICAgICAgICAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCcu bWVudS1pdGVtJykuZm9jdXMoKTsNCiAgICAgICAgfSBlbHNlIGlmIChldnQua2V5Q29kZSA9PT0g MjcpIHsgLy8gRVNDDQogICAgICAgICAgICAvLyBjbG9zZSBtZW51DQogICAgICAgICAgICBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yKCcubWVudScpLmNsYXNzTGlzdC5yZW1vdmUoJ29wZW4nKTsNCiAg ICAgICAgICAgIC8vIGZvY3VzIG9uIGJ1dHRvbg0KICAgICAgICAgICAgZG9jdW1lbnQucXVlcnlT ZWxlY3RvcignLm9wZW4tYnV0dG9uJykuZm9jdXMoKTsNCiAgICAgICAgfQ0KICAgIH0pOw0KPC9z Y3JpcHQ+DQoNCjxib2R5Pg0KICAgIDxidXR0b24gY2xhc3M9Im9wZW4tYnV0dG9uIj5PcGVuIE1l bnU8L2J1dHRvbj4NCiAgICA8ZGl2IGNsYXNzPSJtZW51Ij4NCiAgICAgICAgPHVsPg0KICAgICAg ICAgICAgPGxpPg0KICAgICAgICAgICAgICAgIDxidXR0b24gY2xhc3M9Im1lbnUtaXRlbSI+TWVu dSBJdGVtPC9idXR0b24+DQogICAgICAgICAgICA8L2xpPg0KICAgICAgICA8L3VsPg0KICAgIDwv ZGl2Pg0KPC9ib2R5Pg0KPC9odG1sPg==