220558 2021-01-12 12:28:29 -0800 [ESNext] super accesses broken on arrow functions defined as class field 2021-01-12 16:08:18 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima darin ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1719091 0 ticaiolima 2021-01-12 12:28:29 -0800 The following program is throwing TypeError, but it should run sucessfully: ``` class C { func = () => { super.prop = "foo"; return this.prop; }; } let c = new C; assert(c.func(), "foo"); ``` The result we are getting is: `TypeError: undefined is not an object (evaluating 'super.prop = "foo"')`. We are missing proper `super` binding there. 1719094 1 417480 ticaiolima 2021-01-12 12:32:23 -0800 Created attachment 417480 Patch 1719154 2 417480 ticaiolima 2021-01-12 16:02:43 -0800 Comment on attachment 417480 Patch Thanks for the quick review! 1719157 3 ews-feeder 2021-01-12 16:06:00 -0800 Committed r271420: <https://trac.webkit.org/changeset/271420> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417480. 1719159 4 webkit-bug-importer 2021-01-12 16:08:18 -0800 <rdar://problem/73085036> 417480 2021-01-12 12:32:23 -0800 2021-01-12 16:06:01 -0800 Patch bug-220558-20210112173222.patch text/plain 3418 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NDg5MWRhM2IwNTQxY2UwN2VjNDUyNDI0OWZmZjMxNTllYzg1MGY3Li41NTljY2U1MGVkOGVkNTBk ZGYzNjk2ZWRjN2M5MTk2NjVlOTZiOWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAyMS0wMS0xMiAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0VTTmV4dF0gc3VwZXIgYWNjZXNzZXMgYnJva2VuIG9uIGFycm93IGZ1bmN0 aW9ucyBkZWZpbmVkIGFzIGNsYXNzIGZpZWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA1NTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZSBuZWVkIHRvIHByb3Blcmx5IHNldCBgaXNDbGFzc0NvbnRl eHRgIGZvciBjbGFzcyBmaWVsZHMKKyAgICAgICAgaW5pdGlhbGl6YXRpb24uCisKKyAgICAgICAg KiBieXRlY29kZS9VbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZS5jcHA6CisgICAgICAgIChKU0M6 OmdlbmVyYXRlVW5saW5rZWRGdW5jdGlvbkNvZGVCbG9jayk6CisKIDIwMjEtMDEtMTAgIFl1c3Vr ZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBKSVRDYWdlJ3Mg R2F0ZSBtZWNoYW5pc20gaXMgdXNlZCBpbiBBUk02NEUgZXZlbiBpZiBKSVRDYWdlIGlzIGRpc2Fi bGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZEZ1 bmN0aW9uRXhlY3V0YWJsZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvVW5s aW5rZWRGdW5jdGlvbkV4ZWN1dGFibGUuY3BwCmluZGV4IDAzYmQwNThmMzAxNzhlYzY0MWUyMjNh ZTRmZTJiY2NjZDA0ZDViNGYuLjdlY2I0ZmM3NTlhZDBmMTEzODliNjY2OTQzZjA1N2RmM2IzZGQ3 MWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29kZS9VbmxpbmtlZEZ1 bmN0aW9uRXhlY3V0YWJsZS5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2Rl L1VubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlLmNwcApAQCAtNjgsNyArNjgsNyBAQCBzdGF0aWMg VW5saW5rZWRGdW5jdGlvbkNvZGVCbG9jayogZ2VuZXJhdGVVbmxpbmtlZEZ1bmN0aW9uQ29kZUJs b2NrKAogICAgIGZ1bmN0aW9uLT5maW5pc2hQYXJzaW5nKGV4ZWN1dGFibGUtPm5hbWUoKSwgZXhl Y3V0YWJsZS0+ZnVuY3Rpb25Nb2RlKCkpOwogICAgIGV4ZWN1dGFibGUtPnJlY29yZFBhcnNlKGZ1 bmN0aW9uLT5mZWF0dXJlcygpLCBmdW5jdGlvbi0+aGFzQ2FwdHVyZWRWYXJpYWJsZXMoKSk7CiAK LSAgICBib29sIGlzQ2xhc3NDb250ZXh0ID0gZXhlY3V0YWJsZS0+c3VwZXJCaW5kaW5nKCkgPT0g U3VwZXJCaW5kaW5nOjpOZWVkZWQ7CisgICAgYm9vbCBpc0NsYXNzQ29udGV4dCA9IGV4ZWN1dGFi bGUtPnN1cGVyQmluZGluZygpID09IFN1cGVyQmluZGluZzo6TmVlZGVkIHx8IGV4ZWN1dGFibGUt PnBhcnNlTW9kZSgpID09IFNvdXJjZVBhcnNlTW9kZTo6Q2xhc3NGaWVsZEluaXRpYWxpemVyTW9k ZTsKIAogICAgIFVubGlua2VkRnVuY3Rpb25Db2RlQmxvY2sqIHJlc3VsdCA9IFVubGlua2VkRnVu Y3Rpb25Db2RlQmxvY2s6OmNyZWF0ZSh2bSwgRnVuY3Rpb25Db2RlLCBFeGVjdXRhYmxlSW5mbyhm dW5jdGlvbi0+dXNlc0V2YWwoKSwga2luZCA9PSBDb2RlRm9yQ29uc3RydWN0LCBmdW5jdGlvbktp bmQgPT0gVW5saW5rZWRCdWlsdGluRnVuY3Rpb24sIGV4ZWN1dGFibGUtPmNvbnN0cnVjdG9yS2lu ZCgpLCBzY3JpcHRNb2RlLCBleGVjdXRhYmxlLT5zdXBlckJpbmRpbmcoKSwgcGFyc2VNb2RlLCBl eGVjdXRhYmxlLT5kZXJpdmVkQ29udGV4dFR5cGUoKSwgZXhlY3V0YWJsZS0+bmVlZHNDbGFzc0Zp ZWxkSW5pdGlhbGl6ZXIoKSwgZmFsc2UsIGlzQ2xhc3NDb250ZXh0LCBFdmFsQ29udGV4dFR5cGU6 OkZ1bmN0aW9uRXZhbENvbnRleHQpLCBjb2RlR2VuZXJhdGlvbk1vZGUpOwogCmRpZmYgLS1naXQg YS9KU1Rlc3RzL0NoYW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDczY2E5NDAxZTc2 N2Y1OWVmZjZhMThiZjYwNWIyODBlNmQwMTU2MDEuLmMyZjRkZWE5M2E5MjJmYjhjMDZhODBkYTkz YzRiYjFhNjg3MzAxY2YgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVz dHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMjEtMDEtMTIgIENhaW8gTGltYSAgPHRp Y2Fpb2xpbWFAZ21haWwuY29tPgorCisgICAgICAgIFtFU05leHRdIHN1cGVyIGFjY2Vzc2VzIGJy b2tlbiBvbiBhcnJvdyBmdW5jdGlvbnMgZGVmaW5lZCBhcyBjbGFzcyBmaWVsZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNTU4CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvY2xhc3MtZmll bGQtYXJyb3ctZnVuY3Rpb24tdXNpbmctc3VwZXIuanM6IEFkZGVkLgorCiAyMDIxLTAxLTA4ICBB bGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBJbXBsZW1l bnQgQGNvcHlEYXRhUHJvcGVydGllcyBpbiBDKysgdG8gb3B0aW1pemUgb2JqZWN0IHJlc3QgLyBz cHJlYWQKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL2NsYXNzLWZpZWxkLWFycm93LWZ1bmN0 aW9uLXVzaW5nLXN1cGVyLmpzIGIvSlNUZXN0cy9zdHJlc3MvY2xhc3MtZmllbGQtYXJyb3ctZnVu Y3Rpb24tdXNpbmctc3VwZXIuanMKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNWEzOTc3YmU4ZDA2Y2ZjZWVmMWJhODg4 MDQxYTFhYmE4ZTQyZDM4YgotLS0gL2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2NsYXNz LWZpZWxkLWFycm93LWZ1bmN0aW9uLXVzaW5nLXN1cGVyLmpzCkBAIC0wLDAgKzEsMTUgQEAKK2Z1 bmN0aW9uIGFzc2VydChhY3R1YWwsIGV4cGVjdGVkKSB7CisgICAgaWYgKGFjdHVhbCAhPT0gZXhw ZWN0ZWQpCisgICAgICAgIHRocm93IEVycm9yKCJFeHBlY3RlZDogIiArIGV4cGVjdGVkICsgIiBB Y3R1YWw6ICIgKyBhY3R1YWwpOworfQorCitjbGFzcyBDIHsKKyAgICBmdW5jID0gKCkgPT4gewor ICAgICAgICBzdXBlci5wcm9wID0gImZvbyI7CisgICAgICAgIHJldHVybiB0aGlzLnByb3A7Cisg ICAgfTsKK30KKworbGV0IGMgPSBuZXcgQzsKK2Fzc2VydChjLmZ1bmMoKSwgImZvbyIpOworCg==