220544 2021-01-12 08:44:07 -0800 [build.webkit.org] Update force schedulers as per new buildbot 2021-02-08 07:37:49 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 175056 1 aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1719001 0 aakash_jain 2021-01-12 08:44:07 -0800 [build.webkit.org] Update force schedulers as per new buildbot. Force schedulers class parameters have changed in newer Buildbot versions. We should change the code accordingly to support the new parameters. 1719002 1 aakash_jain 2021-01-12 08:46:47 -0800 ForceScheduler class in newer buildbot doesn't accept parameters like: branch, repository, project. 1719003 2 417458 aakash_jain 2021-01-12 08:46:53 -0800 Created attachment 417458 Patch 1719004 3 aakash_jain 2021-01-12 08:47:42 -0800 Tested on dev instance. 1719005 4 417458 jbedard 2021-01-12 08:57:44 -0800 Comment on attachment 417458 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417458&action=review > Tools/CISupport/build-webkit-org/loadConfig.py:91 > + revision=StringParameter(name="revision", default="", regex=re.compile(r'^(\d*)$')), What are the implications for this argument in a Git world? 1719009 5 aakash_jain 2021-01-12 09:01:45 -0800 (In reply to Jonathan Bedard from comment #4) > What are the implications for this argument in a Git world? Good thing is that we won't be using it in new buildbot anymore. In old buildbot, it is restricting that specified revision should be in svn revision format while doing a force build. 1719024 6 ews-feeder 2021-01-12 09:30:59 -0800 Committed r271406: <https://trac.webkit.org/changeset/271406> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417458. 1719025 7 webkit-bug-importer 2021-01-12 09:31:14 -0800 <rdar://problem/73044118> 417458 2021-01-12 08:46:53 -0800 2021-01-12 09:30:59 -0800 Patch bug-220544-20210112114652.patch text/plain 3094 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MTQwMykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTAxLTEyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbYnVpbGQud2Via2l0Lm9yZ10gVXBkYXRlIGZvcmNlIHNjaGVkdWxlcnMg YXMgcGVyIG5ldyBidWlsZGJvdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjIwNTQ0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBDSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9sb2FkQ29uZmlnLnB5Ogor ICAgICAgICAobG9hZEJ1aWxkZXJDb25maWcpOgorCiAyMDIxLTAxLTExICBMYXVybyBNb3VyYSAg PGxtb3VyYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdIEdhcmRlbmluZyBBUEkgdGVzdCBj cmFzaApJbmRleDogVG9vbHMvQ0lTdXBwb3J0L2J1aWxkLXdlYmtpdC1vcmcvbG9hZENvbmZpZy5w eQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0LW9yZy9sb2FkQ29u ZmlnLnB5CShyZXZpc2lvbiAyNzE0MDMpCisrKyBUb29scy9DSVN1cHBvcnQvYnVpbGQtd2Via2l0 LW9yZy9sb2FkQ29uZmlnLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotIyBDb3B5 cmlnaHQgKEMpIDIwMTctMjAyMCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENv cHlyaWdodCAoQykgMjAxNy0yMDIxIEFwcGxlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMK ICMgUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0 aCBvciB3aXRob3V0CiAjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0 IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwpAQCAtNzUsMjAgKzc1LDI3IEBAIGRlZiBsb2FkQnVp bGRlckNvbmZpZyhjLCBpc190ZXN0X21vZGVfZW4KICAgICAgICAgc2NoZWR1bGVyQ2xhc3MgPSBn bG9iYWxzKClbc2NoZWR1bGVyQ2xhc3NOYW1lXQogICAgICAgICBjWydzY2hlZHVsZXJzJ10uYXBw ZW5kKHNjaGVkdWxlckNsYXNzKCoqc2NoZWR1bGVyKSkKIAotICAgIGZvcmNlU2NoZWR1bGVyID0g Rm9yY2VTY2hlZHVsZXIoCi0gICAgICAgIG5hbWU9ImZvcmNlIiwKLSAgICAgICAgYnVpbGRlck5h bWVzPVtzdHIoYnVpbGRlclsnbmFtZSddKSBmb3IgYnVpbGRlciBpbiBjb25maWdbJ2J1aWxkZXJz J11dLAotICAgICAgICByZWFzb249U3RyaW5nUGFyYW1ldGVyKG5hbWU9InJlYXNvbiIsIGRlZmF1 bHQ9IiIsIHNpemU9NDApLAotCi0gICAgICAgICMgVmFsaWRhdGUgU1ZOIHJldmlzaW9uOiBudW1i ZXIgb3IgZW1wdHkgc3RyaW5nCi0gICAgICAgIHJldmlzaW9uPVN0cmluZ1BhcmFtZXRlcihuYW1l PSJyZXZpc2lvbiIsIGRlZmF1bHQ9IiIsIHJlZ2V4PXJlLmNvbXBpbGUocideKFxkKikkJykpLAot Ci0gICAgICAgICMgRGlzYWJsZSBkZWZhdWx0IGVuYWJsZWQgaW5wdXQgZmllbGRzOiBicmFuY2gs IHJlcG9zaXRvcnksIHByb2plY3QsIGFkZGl0aW9uYWwgcHJvcGVydGllcwotICAgICAgICBicmFu Y2g9Rml4ZWRQYXJhbWV0ZXIobmFtZT0iYnJhbmNoIiksCi0gICAgICAgIHJlcG9zaXRvcnk9Rml4 ZWRQYXJhbWV0ZXIobmFtZT0icmVwb3NpdG9yeSIpLAotICAgICAgICBwcm9qZWN0PUZpeGVkUGFy YW1ldGVyKG5hbWU9InByb2plY3QiKSwKLSAgICAgICAgcHJvcGVydGllcz1bQm9vbGVhblBhcmFt ZXRlcihuYW1lPSJpc19jbGVhbiIsIGxhYmVsPSJGb3JjZSBDbGVhbiBidWlsZCIpXQotICAgICkK KyAgICAjIFNldHVwIGZvcmNlIHNjaGVkdWxlcnMKKyAgICBidWlsZGVyTmFtZXMgPSBbc3RyKGJ1 aWxkZXJbJ25hbWUnXSkgZm9yIGJ1aWxkZXIgaW4gY29uZmlnWydidWlsZGVycyddXQorICAgIHJl YXNvbiA9IFN0cmluZ1BhcmFtZXRlcihuYW1lPSdyZWFzb24nLCBkZWZhdWx0PScnLCBzaXplPTQw KQorICAgIHByb3BlcnRpZXMgPSBbQm9vbGVhblBhcmFtZXRlcihuYW1lPSdpc19jbGVhbicsIGxh YmVsPSdGb3JjZSBDbGVhbiBidWlsZCcpXQorICAgIGlmIFVTRV9CVUlMREJPVF9WRVJTSU9OMjoK KyAgICAgICAgZm9yY2VTY2hlZHVsZXIgPSBGb3JjZVNjaGVkdWxlcihuYW1lPSdmb3JjZScsIGJ1 aWxkZXJOYW1lcz1idWlsZGVyTmFtZXMsIHJlYXNvbj1yZWFzb24sIHByb3BlcnRpZXM9cHJvcGVy dGllcykKKyAgICBlbHNlOgorICAgICAgICBmb3JjZVNjaGVkdWxlciA9IEZvcmNlU2NoZWR1bGVy KAorICAgICAgICAgICAgbmFtZT0nZm9yY2UnLAorICAgICAgICAgICAgYnVpbGRlck5hbWVzPWJ1 aWxkZXJOYW1lcywKKyAgICAgICAgICAgIHJlYXNvbj1yZWFzb24sCisKKyAgICAgICAgICAgICMg VmFsaWRhdGUgU1ZOIHJldmlzaW9uOiBudW1iZXIgb3IgZW1wdHkgc3RyaW5nCisgICAgICAgICAg ICByZXZpc2lvbj1TdHJpbmdQYXJhbWV0ZXIobmFtZT0icmV2aXNpb24iLCBkZWZhdWx0PSIiLCBy ZWdleD1yZS5jb21waWxlKHInXihcZCopJCcpKSwKKworICAgICAgICAgICAgIyBEaXNhYmxlIGRl ZmF1bHQgZW5hYmxlZCBpbnB1dCBmaWVsZHM6IGJyYW5jaCwgcmVwb3NpdG9yeSwgcHJvamVjdCwg YWRkaXRpb25hbCBwcm9wZXJ0aWVzCisgICAgICAgICAgICBicmFuY2g9Rml4ZWRQYXJhbWV0ZXIo bmFtZT0iYnJhbmNoIiksCisgICAgICAgICAgICByZXBvc2l0b3J5PUZpeGVkUGFyYW1ldGVyKG5h bWU9InJlcG9zaXRvcnkiKSwKKyAgICAgICAgICAgIHByb2plY3Q9Rml4ZWRQYXJhbWV0ZXIobmFt ZT0icHJvamVjdCIpLAorICAgICAgICAgICAgcHJvcGVydGllcz1wcm9wZXJ0aWVzCisgICAgICAg ICkKICAgICBjWydzY2hlZHVsZXJzJ10uYXBwZW5kKGZvcmNlU2NoZWR1bGVyKQogCiAgICAgY1sn YnVpbGRlcnMnXSA9IFtdCg==