22054 2008-11-03 14:00:54 -0800 DRT does not properly reset scrollbar arrows to default 2008-11-03 18:33:07 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 pol webkit-unassigned mitz simon.fraser oldest_to_newest 97495 0 pol 2008-11-03 14:00:54 -0800 This code in DRT has actually no effect for the scrollbars drawn by WebKit as it uses HI toolbox which reads the default _only_ from kCFPreferencesAnyApplication / kCFPreferencesCurrentUser / kCFPreferencesAnyHost. [defaults setObject:@"DoubleMax" forKey:@"AppleScrollBarVariant"]; This makes pixel tests fail for test cases that display scrollbars if the user has chosen to place scroll arrows at top and bottom in system preferences. 97520 1 pol 2008-11-03 17:33:17 -0800 Here's a test case that fails for instance: LayoutTests/svg/custom/invisible-text-after-scrolling.xhtml But actually, for this one, the scrollbars do not appear to be drawn by HIToolbox. 97522 2 pol 2008-11-03 17:49:33 -0800 > But actually, for this one, the scrollbars do not appear to be drawn by > HIToolbox. Ignore this comment as it is incorrect: HIToolbox is indeed drawing these scrollbars! 97523 3 24874 pol 2008-11-03 18:01:44 -0800 Created attachment 24874 Tentative patch 97525 4 24874 mitz 2008-11-03 18:08:40 -0800 Comment on attachment 24874 Tentative patch > + CFTypeRef oldValue = CFPreferencesCopyValue(CFSTR("AppleScrollBarVariant"), kCFPreferencesAnyApplication, kCFPreferencesCurrentUser, kCFPreferencesAnyHost); You can use a RetainPtr for that and create create a local variable to hold CFSTR("AppleScrollBarVariant"). It would also be nice to move this closer to where you set the default in NSUserDefaults. r=me 97528 5 24877 pol 2008-11-03 18:30:01 -0800 Created attachment 24877 Second revision 97529 6 24877 mitz 2008-11-03 18:32:05 -0800 Comment on attachment 24877 Second revision r=me 97530 7 mitz 2008-11-03 18:33:07 -0800 Fixed in <http://trac.webkit.org/changeset/38082>. 24874 2008-11-03 18:01:44 -0800 2008-11-03 18:30:01 -0800 Tentative patch Patch.txt text/plain 2253 pol SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM4MDgxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMDMgIFBpZXJyZS1PbGl2aWVyIExh dG91ciAgPHBvbEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4ZWQgdGhlIG92ZXJyaWRlIG9mIHRoZSAiQXBwbGVTY3JvbGxCYXJW YXJpYW50IiBzeXN0ZW0gc2V0dGluZyB0byBhbHNvIHdvcmsgd2l0aCBISVRvb2xib3guCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDU0CisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChz ZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlc0ZvclRlc3RpbmcpOgorCiAyMDA4LTEwLTMxICBD YW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3 ZWQuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5k ZXJUcmVlLm1tCShyZXZpc2lvbiAzODA3NykKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L21hYy9EdW1wUmVuZGVyVHJlZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQAog I2ltcG9ydCAiVUlEZWxlZ2F0ZS5oIgogI2ltcG9ydCAiV29ya1F1ZXVlLmgiCiAjaW1wb3J0ICJX b3JrUXVldWVJdGVtLmgiCisjaW1wb3J0IDxDYXJib24vQ2FyYm9uLmg+CiAjaW1wb3J0IDxDb3Jl Rm91bmRhdGlvbi9Db3JlRm91bmRhdGlvbi5oPgogI2ltcG9ydCA8V2ViS2l0L0RPTUVsZW1lbnRQ cml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvRE9NRXh0ZW5zaW9ucy5oPgpAQCAtMzA1LDYgKzMw NiwxNiBAQCB2b2lkIHRlc3RTdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0RnJvCiAKIHN0YXRp YyB2b2lkIHNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWVzRm9yVGVzdGluZygpCiB7CisgICAg Ly8gU2Nyb2xsYmFycyBhcmUgZHJhd24gdXNpbmcgSElUb29sYm94IGluIFdlYkNvcmUgd2hpY2gg ZG9lc24ndCByZWFkIGZyb20gTlNVc2VyRGVmYXVsdHMgYnV0IENGUHJlZmVyZW5jZXMgLyBrQ0ZQ cmVmZXJlbmNlc0FueUFwcGxpY2F0aW9uIC8ga0NGUHJlZmVyZW5jZXNDdXJyZW50VXNlciAvIGtD RlByZWZlcmVuY2VzQW55SG9zdAorICAgIENGVHlwZVJlZiBvbGRWYWx1ZSA9IENGUHJlZmVyZW5j ZXNDb3B5VmFsdWUoQ0ZTVFIoIkFwcGxlU2Nyb2xsQmFyVmFyaWFudCIpLCBrQ0ZQcmVmZXJlbmNl c0FueUFwcGxpY2F0aW9uLCBrQ0ZQcmVmZXJlbmNlc0N1cnJlbnRVc2VyLCBrQ0ZQcmVmZXJlbmNl c0FueUhvc3QpOworICAgIENGUHJlZmVyZW5jZXNTZXRWYWx1ZShDRlNUUigiQXBwbGVTY3JvbGxC YXJWYXJpYW50IiksIENGU1RSKCJEb3VibGVNYXgiKSwga0NGUHJlZmVyZW5jZXNBbnlBcHBsaWNh dGlvbiwga0NGUHJlZmVyZW5jZXNDdXJyZW50VXNlciwga0NGUHJlZmVyZW5jZXNBbnlIb3N0KTsK KyAgICBUaGVtZVNjcm9sbEJhckFycm93U3R5bGUgc3R5bGU7CisgICAgR2V0VGhlbWVTY3JvbGxC YXJBcnJvd1N0eWxlKCZzdHlsZSk7IC8vIEZvcmNlIEhJVG9vbGJveCB0byByZWFkIGZyb20gdGhl IHByZWZzCisgICAgaWYgKG9sZFZhbHVlKSB7CisgICAgICAgIENGUHJlZmVyZW5jZXNTZXRWYWx1 ZShDRlNUUigiQXBwbGVTY3JvbGxCYXJWYXJpYW50IiksIG9sZFZhbHVlLCBrQ0ZQcmVmZXJlbmNl c0FueUFwcGxpY2F0aW9uLCBrQ0ZQcmVmZXJlbmNlc0N1cnJlbnRVc2VyLCBrQ0ZQcmVmZXJlbmNl c0FueUhvc3QpOworICAgICAgICBDRlJlbGVhc2Uob2xkVmFsdWUpOworICAgIH0KKyAgICAKICAg ICAvLyBHaXZlIHNvbWUgY2xlYXIgdG8gdW5kb2N1bWVudGVkIGRlZmF1bHRzIHZhbHVlcwogICAg IHN0YXRpYyBjb25zdCBpbnQgTm9Gb250U21vb3RoaW5nID0gMDsKICAgICBzdGF0aWMgY29uc3Qg aW50IEJsdWVUaW50ZWRBcHBlYXJhbmNlID0gMTsK 24877 2008-11-03 18:30:01 -0800 2008-11-03 18:32:05 -0800 Second revision Patch.txt text/plain 3069 pol SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDM4MDgxKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDgtMTEtMDMgIFBpZXJyZS1PbGl2aWVyIExh dG91ciAgPHBvbEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4ZWQgdGhlIG92ZXJyaWRlIG9mIHRoZSAiQXBwbGVTY3JvbGxCYXJW YXJpYW50IiBzeXN0ZW0gc2V0dGluZyB0byBhbHNvIHdvcmsgd2l0aCBISVRvb2xib3guCisKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDU0CisKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUubW06CisgICAgICAgIChz ZXREZWZhdWx0c1RvQ29uc2lzdGVudFZhbHVlc0ZvclRlc3RpbmcpOgorCiAyMDA4LTEwLTMxICBD YW1lcm9uIFp3YXJpY2ggIDx6d2FyaWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBOb3QgcmV2aWV3 ZWQuCkluZGV4OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvRHVtcFJlbmRlclRyZWUu bW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvbWFjL0R1bXBSZW5k ZXJUcmVlLm1tCShyZXZpc2lvbiAzODA3NykKKysrIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVl L21hYy9EdW1wUmVuZGVyVHJlZS5tbQkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQAog I2ltcG9ydCAiVUlEZWxlZ2F0ZS5oIgogI2ltcG9ydCAiV29ya1F1ZXVlLmgiCiAjaW1wb3J0ICJX b3JrUXVldWVJdGVtLmgiCisjaW1wb3J0IDxDYXJib24vQ2FyYm9uLmg+CiAjaW1wb3J0IDxDb3Jl Rm91bmRhdGlvbi9Db3JlRm91bmRhdGlvbi5oPgogI2ltcG9ydCA8V2ViS2l0L0RPTUVsZW1lbnRQ cml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvRE9NRXh0ZW5zaW9ucy5oPgpAQCAtMzEwLDcgKzMx MSw2IEBAIHN0YXRpYyB2b2lkIHNldERlZmF1bHRzVG9Db25zaXN0ZW50VmFsdWUKICAgICBzdGF0 aWMgY29uc3QgaW50IEJsdWVUaW50ZWRBcHBlYXJhbmNlID0gMTsKIAogICAgIE5TVXNlckRlZmF1 bHRzICpkZWZhdWx0cyA9IFtOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c107Ci0g ICAgW2RlZmF1bHRzIHNldE9iamVjdDpAIkRvdWJsZU1heCIgZm9yS2V5OkAiQXBwbGVTY3JvbGxC YXJWYXJpYW50Il07CiAgICAgW2RlZmF1bHRzIHNldEludGVnZXI6NCBmb3JLZXk6QCJBcHBsZUFu dGlBbGlhc2luZ1RocmVzaG9sZCJdOyAvLyBzbWFsbGVzdCBmb250IHNpemUgdG8gQ0cgc2hvdWxk IHBlcmZvcm0gYW50aWFsaWFzaW5nIG9uCiAgICAgW2RlZmF1bHRzIHNldEludGVnZXI6Tm9Gb250 U21vb3RoaW5nIGZvcktleTpAIkFwcGxlRm9udFNtb290aGluZyJdOwogICAgIFtkZWZhdWx0cyBz ZXRJbnRlZ2VyOkJsdWVUaW50ZWRBcHBlYXJhbmNlIGZvcktleTpAIkFwcGxlQXF1YUNvbG9yVmFy aWFudCJdOwpAQCAtMzE4LDYgKzMxOCwxNSBAQCBzdGF0aWMgdm9pZCBzZXREZWZhdWx0c1RvQ29u c2lzdGVudFZhbHVlCiAgICAgW2RlZmF1bHRzIHNldE9iamVjdDpAIjAuNTAwMDAwIDAuNTAwMDAw IDAuNTAwMDAwIiBmb3JLZXk6QCJBcHBsZU90aGVySGlnaGxpZ2h0Q29sb3IiXTsKICAgICBbZGVm YXVsdHMgc2V0T2JqZWN0OltOU0FycmF5IGFycmF5V2l0aE9iamVjdDpAImVuIl0gZm9yS2V5OkAi QXBwbGVMYW5ndWFnZXMiXTsKIAorICAgIC8vIFNjcm9sbGJhcnMgYXJlIGRyYXduIGVpdGhlciB1 c2luZyBBcHBLaXQgKHdoaWNoIHVzZXMgTlNVc2VyRGVmYXVsdHMpIG9yIHVzaW5nIEhJVG9vbGJv eCAod2hpY2ggdXNlcyBDRlByZWZlcmVuY2VzIC8ga0NGUHJlZmVyZW5jZXNBbnlBcHBsaWNhdGlv biAvIGtDRlByZWZlcmVuY2VzQ3VycmVudFVzZXIgLyBrQ0ZQcmVmZXJlbmNlc0FueUhvc3QpCisg ICAgW2RlZmF1bHRzIHNldE9iamVjdDpAIkRvdWJsZU1heCIgZm9yS2V5OkAiQXBwbGVTY3JvbGxC YXJWYXJpYW50Il07CisgICAgUmV0YWluUHRyPENGVHlwZVJlZj4gaW5pdGlhbFZhbHVlID0gQ0ZQ cmVmZXJlbmNlc0NvcHlWYWx1ZShDRlNUUigiQXBwbGVTY3JvbGxCYXJWYXJpYW50IiksIGtDRlBy ZWZlcmVuY2VzQW55QXBwbGljYXRpb24sIGtDRlByZWZlcmVuY2VzQ3VycmVudFVzZXIsIGtDRlBy ZWZlcmVuY2VzQW55SG9zdCk7CisgICAgQ0ZQcmVmZXJlbmNlc1NldFZhbHVlKENGU1RSKCJBcHBs ZVNjcm9sbEJhclZhcmlhbnQiKSwgQ0ZTVFIoIkRvdWJsZU1heCIpLCBrQ0ZQcmVmZXJlbmNlc0Fu eUFwcGxpY2F0aW9uLCBrQ0ZQcmVmZXJlbmNlc0N1cnJlbnRVc2VyLCBrQ0ZQcmVmZXJlbmNlc0Fu eUhvc3QpOworICAgIFRoZW1lU2Nyb2xsQmFyQXJyb3dTdHlsZSBzdHlsZTsKKyAgICBHZXRUaGVt ZVNjcm9sbEJhckFycm93U3R5bGUoJnN0eWxlKTsgLy8gRm9yY2UgSElUb29sYm94IHRvIHJlYWQg ZnJvbSBDRlByZWZlcmVuY2VzCisgICAgaWYgKGluaXRpYWxWYWx1ZSkKKyAgICAgICAgQ0ZQcmVm ZXJlbmNlc1NldFZhbHVlKENGU1RSKCJBcHBsZVNjcm9sbEJhclZhcmlhbnQiKSwgaW5pdGlhbFZh bHVlLmdldCgpLCBrQ0ZQcmVmZXJlbmNlc0FueUFwcGxpY2F0aW9uLCBrQ0ZQcmVmZXJlbmNlc0N1 cnJlbnRVc2VyLCBrQ0ZQcmVmZXJlbmNlc0FueUhvc3QpOworCiAgICAgTlNTdHJpbmcgKmxpYnJh cnlQYXRoID0gW0Aifi9MaWJyYXJ5L0FwcGxpY2F0aW9uIFN1cHBvcnQvRHVtcFJlbmRlclRyZWUi IHN0cmluZ0J5RXhwYW5kaW5nVGlsZGVJblBhdGhdOwogICAgIFtkZWZhdWx0cyBzZXRPYmplY3Q6 W2xpYnJhcnlQYXRoIHN0cmluZ0J5QXBwZW5kaW5nUGF0aENvbXBvbmVudDpAIkRhdGFiYXNlcyJd IGZvcktleTpXZWJEYXRhYmFzZURpcmVjdG9yeURlZmF1bHRzS2V5XTsKICAgICAK