220536 2021-01-12 01:01:05 -0800 Multi-codepoint CJK grapheme clusters are not oriented correctly in vertical writing mode 2021-01-15 18:50:19 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=220680 InRadar P2 Normal --- 1 mmaxfield mmaxfield lmoura webkit-bug-importer zalan oldest_to_newest 1718916 0 mmaxfield 2021-01-12 01:01:05 -0800 Multi-codepoint CJK grapheme clusters are not oriented correctly in vertical writing mode 1718918 1 417438 mmaxfield 2021-01-12 01:03:01 -0800 Created attachment 417438 Patch 1718919 2 mmaxfield 2021-01-12 01:03:04 -0800 <rdar://problem/70633887> 1719144 3 mmaxfield 2021-01-12 14:58:04 -0800 Investigating the Windows failure now. 1719176 4 mmaxfield 2021-01-12 16:55:14 -0800 Committed r271425: <https://trac.webkit.org/changeset/271425> 1719882 5 lmoura 2021-01-15 08:27:51 -0800 GTK/WPE renders the glyph correctly but with a slightly different positioning, ditto for Firefox 85 and Chromium 87. The same occurs for single codepoints. Does the spec require them to to be layout exactly the same (i.e. single grapheme in vertical and horizontal modes) or it's something open and the test could be tweaked to work in GTK/WPE? 1719919 6 mmaxfield 2021-01-15 10:20:36 -0800 (In reply to Lauro Moura from comment #5) > GTK/WPE renders the glyph correctly but with a slightly different > positioning, ditto for Firefox 85 and Chromium 87. The same occurs for > single codepoints. > > Does the spec require them to to be layout exactly the same (i.e. single > grapheme in vertical and horizontal modes) or it's something open and the > test could be tweaked to work in GTK/WPE? They don’t *have* to be exactly the same. However, the em box is usually a perfect square, so it would be good to at least determine where the offset comes from in GTK/WPE. One would expect that rotating a perfect square by 90deg would lead to an identical rendering. 1720103 7 lmoura 2021-01-15 18:50:19 -0800 (In reply to Myles C. Maxfield from comment #6) > (In reply to Lauro Moura from comment #5) > > GTK/WPE renders the glyph correctly but with a slightly different > > positioning, ditto for Firefox 85 and Chromium 87. The same occurs for > > single codepoints. > > > > Does the spec require them to to be layout exactly the same (i.e. single > > grapheme in vertical and horizontal modes) or it's something open and the > > test could be tweaked to work in GTK/WPE? > > They don’t *have* to be exactly the same. However, the em box is usually a > perfect square, so it would be good to at least determine where the offset > comes from in GTK/WPE. One would expect that rotating a perfect square by > 90deg would lead to an identical rendering. For GTK/WPE in this test the box seems to be slightly rectangular (111x100) and slightly offset (-6,0 and 0,-6, depending on the orientation). I've opened bug220680 to track it. 417438 2021-01-12 01:03:01 -0800 2021-01-12 07:09:40 -0800 Patch bug-220536-20210112010301.patch text/plain 4743 mmaxfield U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMzM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDhhYTU2YzU1MTZlZmE4 MjI4OGYxYmFhYzU2YTE2MDkzYWY1NDgwMS4uODQ1YjVhMjZlOTFlYjYyYTgxNDViYWVkODkyOGI4 YjJlNjZlOTdmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAxLTEyICBNeWxl cyBDLiBNYXhmaWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CisKKyAgICAgICAgTXVsdGktY29k ZXBvaW50IENKSyBncmFwaGVtZSBjbHVzdGVycyBhcmUgbm90IG9yaWVudGVkIGNvcnJlY3RseSBp biB2ZXJ0aWNhbCB3cml0aW5nIG1vZGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMDUzNgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzA2MzM4ODc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgaGF2 ZSB0d28gY29kZWJsb2NrcyBpbiB0aGlzIHNlY3Rpb24gdGhhdCBhcmUgbWVhbnQgdG8gYmUgdXNl ZAorICAgICAgICBmb3Igbm9uLUNKSyB0ZXh0LCBidXQgdGhlIGNvbXBvdW5kICJpZiIgc3RhdGVt ZW50IHdhcyBjYXVzaW5nIHVzIHRvIGhpdAorICAgICAgICBvbmUgb2YgdGhlbSBldmVuIGZvciBD SksgdGV4dC4KKworICAgICAgICBUZXN0OiBmYXN0L3RleHQvY2prLW11bHRpLWNvZGVwb2ludC1j bHVzdGVyLXZlcnRpY2FsLmh0bWwKKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NvcmV0 ZXh0L0ZvbnRDYXNjYWRlQ29yZVRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udENhc2Nh ZGU6OmZvbnRGb3JDb21iaW5pbmdDaGFyYWN0ZXJTZXF1ZW5jZSBjb25zdCk6CisKIDIwMjEtMDEt MDggIFBlbmcgTGl1ICA8cGVuZy5saXU2QGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O IChyMjcxMjczKTogQ3Jhc2ggaW4gV2ViQ29yZTo6SFRNTE1lZGlhRWxlbWVudDo6c2V0VmlkZW9G dWxsc2NyZWVuR3Jhdml0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvY29yZXRleHQvRm9udENhc2NhZGVDb3JlVGV4dC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jb3JldGV4dC9Gb250Q2FzY2FkZUNvcmVUZXh0LmNwcAppbmRleCBl OTViYjM0MDhmNTIwNzE3MjFkZTNkMTAzNDMxZDRhZjk1OWU0NGM2Li44ZjFmYmYyOTk0ZTNmZWEy OTVlZmE5ZmZhNmJjOTFiMzJiMDNiMzI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9jb3JldGV4dC9Gb250Q2FzY2FkZUNvcmVUZXh0LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jb3JldGV4dC9Gb250Q2FzY2FkZUNvcmVUZXh0 LmNwcApAQCAtMzIyLDkgKzMyMiwxMCBAQCBjb25zdCBGb250KiBGb250Q2FzY2FkZTo6Zm9udEZv ckNvbWJpbmluZ0NoYXJhY3RlclNlcXVlbmNlKGNvbnN0IFVDaGFyKiBjaGFyYWN0ZQogICAgICAg ICAgICAgY29udGludWU7CiAjZW5kaWYKICAgICAgICAgaWYgKGZvbnQtPnBsYXRmb3JtRGF0YSgp Lm9yaWVudGF0aW9uKCkgPT0gRm9udE9yaWVudGF0aW9uOjpWZXJ0aWNhbCkgewotICAgICAgICAg ICAgaWYgKGlzQ0pLSWRlb2dyYXBoT3JTeW1ib2woYmFzZUNoYXJhY3RlcikgJiYgIWZvbnQtPmhh c1ZlcnRpY2FsR2x5cGhzKCkpCi0gICAgICAgICAgICAgICAgZm9udCA9ICZmb250LT5icm9rZW5J ZGVvZ3JhcGhGb250KCk7Ci0gICAgICAgICAgICBlbHNlIGlmIChtX2ZvbnREZXNjcmlwdGlvbi5u b25DSktHbHlwaE9yaWVudGF0aW9uKCkgPT0gTm9uQ0pLR2x5cGhPcmllbnRhdGlvbjo6TWl4ZWQp IHsKKyAgICAgICAgICAgIGlmIChpc0NKS0lkZW9ncmFwaE9yU3ltYm9sKGJhc2VDaGFyYWN0ZXIp KSB7CisgICAgICAgICAgICAgICAgaWYgKCFmb250LT5oYXNWZXJ0aWNhbEdseXBocygpKQorICAg ICAgICAgICAgICAgICAgICBmb250ID0gJmZvbnQtPmJyb2tlbklkZW9ncmFwaEZvbnQoKTsKKyAg ICAgICAgICAgIH0gZWxzZSBpZiAobV9mb250RGVzY3JpcHRpb24ubm9uQ0pLR2x5cGhPcmllbnRh dGlvbigpID09IE5vbkNKS0dseXBoT3JpZW50YXRpb246Ok1peGVkKSB7CiAgICAgICAgICAgICAg ICAgY29uc3QgRm9udCYgdmVydGljYWxSaWdodEZvbnQgPSBmb250LT52ZXJ0aWNhbFJpZ2h0T3Jp ZW50YXRpb25Gb250KCk7CiAgICAgICAgICAgICAgICAgR2x5cGggdmVydGljYWxSaWdodEdseXBo ID0gdmVydGljYWxSaWdodEZvbnQuZ2x5cGhGb3JDaGFyYWN0ZXIoYmFzZUNoYXJhY3Rlcik7CiAg ICAgICAgICAgICAgICAgaWYgKHZlcnRpY2FsUmlnaHRHbHlwaCA9PSBiYXNlQ2hhcmFjdGVyR2x5 cGhEYXRhLmdseXBoKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGYxNTI5Mjg2NGNiOTY1ZGMxNWNkMzFhZmM2YTJjY2IwNDBi ZmVjY2MuLjhmZGVkODA4MjJkYjA5NjIzODlhNjgzZjNjOGZkNDEyNDcxZDJjN2UgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNCBAQAorMjAyMS0wMS0xMiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRA YXBwbGUuY29tPgorCisgICAgICAgIE11bHRpLWNvZGVwb2ludCBDSksgZ3JhcGhlbWUgY2x1c3Rl cnMgYXJlIG5vdCBvcmllbnRlZCBjb3JyZWN0bHkgaW4gdmVydGljYWwgd3JpdGluZyBtb2RlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA1MzYKKyAg ICAgICAgPHJkYXI6Ly9wcm9ibGVtLzcwNjMzODg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogZmFzdC90ZXh0L2Nqay1tdWx0aS1jb2RlcG9pbnQt Y2x1c3Rlci12ZXJ0aWNhbC1leHBlY3RlZC5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L3Rl eHQvY2prLW11bHRpLWNvZGVwb2ludC1jbHVzdGVyLXZlcnRpY2FsLmh0bWw6IEFkZGVkLgorCiAy MDIxLTAxLTA4ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAg IFsgQmlnIFN1ciBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvbWltZXNuaWZmL21p bWUtdHlwZXMvY2hhcnNldC1wYXJhbWV0ZXIud2luZG93Lmh0bWwgaWYgZmFpbGluZwpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2Nqay1tdWx0aS1jb2RlcG9pbnQtY2x1c3Rlci12 ZXJ0aWNhbC1leHBlY3RlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC90ZXh0L2Nqay1tdWx0aS1j b2RlcG9pbnQtY2x1c3Rlci12ZXJ0aWNhbC1leHBlY3RlZC5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBjMTc0 OTM5NGNjZGY1ZjJjZGE4Y2U3MzM1MDMyZjEzYzRiNDM0YTMKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9mYXN0L3RleHQvY2prLW11bHRpLWNvZGVwb2ludC1jbHVzdGVyLXZlcnRpY2Fs LWV4cGVjdGVkLmh0bWwKQEAgLTAsMCArMSw5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgor PGhlYWQ+Cis8L2hlYWQ+Cis8Ym9keT4KK1RoaXMgdGVzdCBtYWtlcyBzdXJlIHRoYXQgYSBDSksg bXVsdGktY29kZXBvaW50IGdyYXBoZW1lIGNsdXN0ZXIgaXMgb3JpZW50ZWQgY29ycmVjdGx5ICh1 cHJpZ2h0KSBpbiB2ZXJ0aWNhbCB3cml0aW5nIG1vZGUuIFRoZSB0ZXN0IHBhc3NlcyBpZiB0aGUg Y2hhcmFjdGVyIGJlbG93IGxvb2tzIGxpa2UgJiN4MzBkNTsmI3gzMDlhOy4KKzxkaXYgc3R5bGU9 ImZvbnQ6IDEwMHB4ICdIaXJhTWluUHJvLVczJzsgbGluZS1oZWlnaHQ6IDE7Ij4mI3gzMGQ1OyYj eDMwOWE7PC9kaXY+Cis8L2JvZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9m YXN0L3RleHQvY2prLW11bHRpLWNvZGVwb2ludC1jbHVzdGVyLXZlcnRpY2FsLmh0bWwgYi9MYXlv dXRUZXN0cy9mYXN0L3RleHQvY2prLW11bHRpLWNvZGVwb2ludC1jbHVzdGVyLXZlcnRpY2FsLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uMjdlZDIwOTY4ZDljOTdiY2EwYzRkMmUwNmFiYTJlMDY1NzcxYTY3MAot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvdGV4dC9jamstbXVsdGktY29kZXBv aW50LWNsdXN0ZXItdmVydGljYWwuaHRtbApAQCAtMCwwICsxLDkgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8aGVhZD4KKzwvaGVhZD4KKzxib2R5PgorVGhpcyB0ZXN0IG1ha2VzIHN1cmUg dGhhdCBhIENKSyBtdWx0aS1jb2RlcG9pbnQgZ3JhcGhlbWUgY2x1c3RlciBpcyBvcmllbnRlZCBj b3JyZWN0bHkgKHVwcmlnaHQpIGluIHZlcnRpY2FsIHdyaXRpbmcgbW9kZS4gVGhlIHRlc3QgcGFz c2VzIGlmIHRoZSBjaGFyYWN0ZXIgYmVsb3cgbG9va3MgbGlrZSAmI3gzMGQ1OyYjeDMwOWE7Lgor PGRpdiBzdHlsZT0iZm9udDogMTAwcHggJ0hpcmFNaW5Qcm8tVzMnOyB3cml0aW5nLW1vZGU6IHZl cnRpY2FsLXJsOyBsaW5lLWhlaWdodDogMTsiPiYjeDMwZDU7JiN4MzA5YTs8L2Rpdj4KKzwvYm9k eT4KKzwvaHRtbD4K