220524 2021-01-11 13:16:53 -0800 REGRESSION(r268666) Incorrect vertical position inside grid items with padding 2021-01-13 03:54:09 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=217479 InRadar P2 Normal --- 1 zalan svillar bfulgham changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr rego simon.fraser webkit-bug-importer zalan oldest_to_newest 1718795 0 417407 zalan 2021-01-11 13:16:53 -0800 Created attachment 417407 test reduction ssia 1718796 1 webkit-bug-importer 2021-01-11 13:18:29 -0800 <rdar://problem/73010949> 1719238 2 417518 svillar 2021-01-13 02:44:58 -0800 Created attachment 417518 Patch 1719239 3 417518 rego 2021-01-13 03:04:30 -0800 Comment on attachment 417518 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417518&action=review r=me > Source/WebCore/ChangeLog:3 > + REGRESSION(r268666) Incorrect vertical position inside grid/flex with padding Shouldn't we rename the bug so we don't mention "flex"? It seems unrelated to flexbox and specific to grid layout. 1719245 4 svillar 2021-01-13 03:54:09 -0800 Committed r271436: <https://trac.webkit.org/changeset/271436> 417407 2021-01-11 13:16:53 -0800 2021-01-11 13:16:53 -0800 test reduction incorrrect-vertical-position.html text/html 391 zalan PCFET0NUWVBFIGh0bWw+CjxzdHlsZT4KLmdyaWRfY29udGFpbmVyIHsKICBiYWNrZ3JvdW5kLWNv bG9yOiBncmVlbjsKICBkaXNwbGF5OiBncmlkOwogIGdyaWQtYXV0by1yb3dzOiAzMHB4Owp9Cgou ZmxleF9wYXJlbnQgewogIHBhZGRpbmctdG9wOiAxMHB4Owp9CgouZmxleF9pdGVtIHsKICBkaXNw bGF5OiBmbGV4OwogIGZsZXgtZGlyZWN0aW9uOiBjb2x1bW47CiAgaGVpZ2h0OiAxMDAlOwogIGp1 c3RpZnktY29udGVudDogZmxleC1lbmQ7Cn0KPC9zdHlsZT4KPGRpdiBjbGFzcz1ncmlkX2NvbnRh aW5lcj48ZGl2IGNsYXNzPWZsZXhfcGFyZW50PjxkaXYgY2xhc3M9ZmxleF9pdGVtPnRoaXMgc2hv dWxkIG5vdCBvdmVyZmxvdyB0aGUgZ3JlZW4gYm94PC9kaXY+PC9kaXY+PC9kaXY+Cg== 417518 2021-01-13 02:44:58 -0800 2021-01-13 03:04:30 -0800 Patch bug-220524-20210113114456.patch text/plain 4448 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxNDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmZjZmEzZWJiYWNlNTE3 OGY5YWY5NjZkZTYyZDg0N2Q1YTA2MmI3NS4uMjU1NjAxOTg1NDRhNDFjYjhiOTgxNzRkNDhjNTZk YWYyYzNkZmZiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDIxLTAxLTEzICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFJFR1JFU1NJ T04ocjI2ODY2NikgSW5jb3JyZWN0IHZlcnRpY2FsIHBvc2l0aW9uIGluc2lkZSBncmlkL2ZsZXgg d2l0aCBwYWRkaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjA1MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJbiByMjY4NjY2IHdlIHNhbml0aXplZCBhbmQgcmVuYW1lZCB0aGUgb2xkIG92ZXJyaWRl TG9naWNhbFhYWCBzaXplcyBzbyB0aGF0IHRoZXkgc3RvcmUgd2hhdCB0aGV5IHNheS4KKyAgICAg ICAgVGhlcmUgd2FzIGEgbWlzdGFrZSBpbiBvbmUgb2YgdGhvc2UgcmVuYW1lcywgaW4gYXZhaWxh YmxlTG9naWNhbEhlaWdodEZvclBlcmNlbnRhZ2VDb21wdXRhdGlvbigpIHdlIHdlcmUKKyAgICAg ICAgcmV0dXJuaW5nIHRoZSBib3JkZXIgYm94IHNpemUgZm9yIHRoZSBjYXNlIG9mIGdyaWQgaXRl bXMuIFRoYXQncyBjbGVhcmx5IHdyb25nIGFzIHdlIHNob3VsZCByZXR1cm4gdGhlCisgICAgICAg IGNvbnRlbnQgYm94IHNpemUuIFRoYXQncyB3aHkgYWRkaW5nIGEgcGFkZGluZyB0byBhIGdyaWQg aXRlbSB3YXMgY2F1c2luZyB0aGVpciBjaGlsZHJlbiB0byB3cm9uZ2x5CisgICAgICAgIGV2YWx1 YXRlIHRoZSBhdmFpbGFibGUgbG9naWNhbCBoZWlnaHQuCisKKyAgICAgICAgVGhpcyBmaXhlcyBh IFdQVCB0aGF0IHdhcyBtYXJrZWQgYXMgZmFpbHVyZS4KKworICAgICAgICAqIHJlbmRlcmluZy9S ZW5kZXJCbG9jay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6YXZhaWxhYmxl TG9naWNhbEhlaWdodEZvclBlcmNlbnRhZ2VDb21wdXRhdGlvbiBjb25zdCk6IFJldHVybiB0aGUK KyAgICAgICAgb3ZlcnJpZGluZ0NvbnRlbnRMb2dpY2FsSGVpZ2h0IGluc3RlYWQgb2YgdGhlIG92 ZXJyaWRpbmdMb2dpY2FsSGVpZ2h0LgorCiAyMDIxLTAxLTEyICBBbnRvaW5lIFF1aW50ICA8Z3Jh b3V0c0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNjc1NzEpOiBibGFjayBs aW5lIGFwcGVhcnMgdXBvbiBuYXZpZ2F0aW5nIGJhY2sgZnJvbSBhcHBsZS5jb20gc2hvcHBpbmcg YmFnCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3Bw IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAppbmRleCBlYTBjMGRh MGZjMWNjNTU2OWYxY2VhM2FlYjFiNjZhMWNmMGMwMjY1Li5mYWUzYmExZWExOGQzZDYzYzA0ZmQ2 OTU0ZDQ4ODI4YmJlOGIzZmExIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyQmxvY2suY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9j ay5jcHAKQEAgLTMyMDMsNyArMzIwMyw3IEBAIE9wdGlvbmFsPExheW91dFVuaXQ+IFJlbmRlckJs b2NrOjphdmFpbGFibGVMb2dpY2FsSGVpZ2h0Rm9yUGVyY2VudGFnZUNvbXB1dGF0aW9uCiAgICAg aWYgKHN0cmV0Y2hlZEZsZXhIZWlnaHQpCiAgICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IHN0cmV0 Y2hlZEZsZXhIZWlnaHQ7CiAgICAgZWxzZSBpZiAoaXNHcmlkSXRlbSgpICYmIGhhc092ZXJyaWRp bmdMb2dpY2FsSGVpZ2h0KCkpCi0gICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IG92ZXJyaWRpbmdM b2dpY2FsSGVpZ2h0KCk7CisgICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IG92ZXJyaWRpbmdDb250 ZW50TG9naWNhbEhlaWdodCgpOwogICAgIGVsc2UgaWYgKHN0eWxlVG9Vc2UubG9naWNhbEhlaWdo dCgpLmlzRml4ZWQoKSkgewogICAgICAgICBMYXlvdXRVbml0IGNvbnRlbnRCb3hIZWlnaHQgPSBh ZGp1c3RDb250ZW50Qm94TG9naWNhbEhlaWdodEZvckJveFNpemluZygoTGF5b3V0VW5pdClzdHls ZVRvVXNlLmxvZ2ljYWxIZWlnaHQoKS52YWx1ZSgpKTsKICAgICAgICAgYXZhaWxhYmxlSGVpZ2h0 ID0gc3RkOjptYXgoMF9sdSwgY29uc3RyYWluQ29udGVudEJveExvZ2ljYWxIZWlnaHRCeU1pbk1h eChjb250ZW50Qm94SGVpZ2h0IC0gc2Nyb2xsYmFyTG9naWNhbEhlaWdodCgpLCBXVEY6Om51bGxv cHQpKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0No YW5nZUxvZwppbmRleCAzNTFlNGNhMDc5MTYzYzRhMGZhNTVjMmUwNTdmNjg0YjZmYmUxZDlhLi4z MTRhYTQ1ZjkzM2Y0MTRlN2M5MTY1ODFmNTM0OGU3YjU5M2JiNTY0IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMjEtMDEtMTMgIFNlcmdpbyBWaWxsYXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5j b20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjY4NjY2KSBJbmNvcnJlY3QgdmVydGljYWwgcG9z aXRpb24gaW5zaWRlIGdyaWQvZmxleCB3aXRoIHBhZGRpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMDUyNAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogcmVtb3ZlIHdl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9wZXJjZW50YWdlLXNpemUt c3ViaXRlbXMtMDAxLmh0bWwKKyAgICAgICAgZnJvbSB0aGUgbGlzdCBvZiBpbWFnZSBmYWlsdXJl cy4KKwogMjAyMS0wMS0xMiAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSRUdSRVNTSU9OIChyMjY3NTcxKTogYmxhY2sgbGluZSBhcHBlYXJzIHVwb24gbmF2 aWdhdGluZyBiYWNrIGZyb20gYXBwbGUuY29tIHNob3BwaW5nIGJhZwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK aW5kZXggYTNlYzkwMTY4Yjk0NzI5ZjFjZmRmZDVmZGUzYTkyNjY4MTYzMzRkNS4uNjhiZDYyMjc5 NjI1YjE5YzQ4NTk1YWY3YTA1OGNjNDhhMDEyMGRkNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv VGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC0x MjA2LDcgKzEyMDYsNiBAQCB3ZWJraXQub3JnL2IvMjE2MTQ1IGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2FsaWdubWVudC9ncmlkLQogd2Via2l0Lm9yZy9iLzIx NjE0NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1l bnQvZ3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTguaHRtbCBbIEltYWdlT25seUZh aWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRl c3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1pdGVtLW5vLWFzcGVjdC1yYXRpby1zdHJl dGNoLTkuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzIxNjE0NSBpbXBv cnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2Nzcy9jc3MtZ3JpZC9hbGlnbm1lbnQvZ3JpZC1p dGVtLW5vLWFzcGVjdC1yYXRpby1zdHJldGNoLTEwLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K LXdlYmtpdC5vcmcvYi8xOTE0NjEgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9jc3Mv Y3NzLWdyaWQvZ3JpZC1pdGVtcy9wZXJjZW50YWdlLXNpemUtc3ViaXRlbXMtMDAxLmh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xOTE0NjMgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWdyaWQvZ3JpZC1pdGVtcy9leHBsaWNpdGx5LXNpemVkLWdy aWQtaXRlbS1hcy10YWJsZS5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2Iv MTkxNjI3IGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1ncmlkL2FsaWdu bWVudC9ncmlkLXNlbGYtYmFzZWxpbmUtbm90LWFwcGxpZWQtaWYtc2l6aW5nLWN5Y2xpYy1kZXBl bmRlbmN5LTAwMS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTQ5ODkwIGZhc3QvY3Nz LWdyaWQtbGF5b3V0L2dyaWQtc2hvcnRoYW5kcy1zdHlsZS1mb3JtYXQuaHRtbCBbIEZhaWx1cmUg XQo=