<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>220508</bug_id>
          <alias>libsoup3</alias>
          <creation_ts>2021-01-11 06:27:27 -0800</creation_ts>
          <short_desc>[META][SOUP] Support libsoup3</short_desc>
          <delta_ts>2021-05-07 05:25:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>220509</dependson>
    
    <dependson>220764</dependson>
    
    <dependson>221034</dependson>
    
    <dependson>221206</dependson>
    
    <dependson>221251</dependson>
    
    <dependson>221543</dependson>
    
    <dependson>221963</dependson>
    
    <dependson>222093</dependson>
    
    <dependson>222309</dependson>
    
    <dependson>222413</dependson>
    
    <dependson>223067</dependson>
    
    <dependson>223236</dependson>
    
    <dependson>223237</dependson>
    
    <dependson>223437</dependson>
    
    <dependson>224362</dependson>
    
    <dependson>224741</dependson>
    
    <dependson>224802</dependson>
    
    <dependson>224925</dependson>
    
    <dependson>225510</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>aperez</cc>
    
    <cc>balducci</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pgriffis</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1718670</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2021-01-11 06:27:27 -0800</bug_when>
    <thetext>Libsoup3 will be the new API version of libsoup.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1734281</commentid>
    <comment_count>1</comment_count>
    <who name="gabriele balducci">balducci</who>
    <bug_when>2021-02-28 06:10:33 -0800</bug_when>
    <thetext>building 2.31.90 with -DUSE_SOUP2=OFF fails for me because soup
version 2.4 is still hardcoded in the following files:

    ----8&lt;----
    Tools/gtkdoc/generate-gtkdoc
    Source/WebKit/PlatformGTK.cmake
    Source/WebKit/gtk/webkit2gtk.pc.in
    Source/WebKit/gtk/webkit2gtk-web-extension.pc.in
    ----&gt;8----

brute force fix of those definitions makes my build succeed; eg:


    ----8&lt;----
    diff -c ./Source/WebKit/PlatformGTK.cmake.REALLY_SOUP_3 ./Source/WebKit/PlatformGTK.cmake
    *** ./Source/WebKit/PlatformGTK.cmake.REALLY_SOUP_3	2021-02-28 10:15:27.680399591 +0100
    --- ./Source/WebKit/PlatformGTK.cmake	2021-02-28 10:15:27.684399609 +0100
    ***************
    *** 684,690 ****
                  --nsversion=${WEBKITGTK_API_VERSION}
                  --include=GObject-2.0
                  --include=Gtk-${GTK_API_VERSION}.0
    !             --include=Soup-2.4
                  --include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
                  --library=webkit2gtk-${WEBKITGTK_API_VERSION}
                  --library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
    --- 684,690 ----
                  --nsversion=${WEBKITGTK_API_VERSION}
                  --include=GObject-2.0
                  --include=Gtk-${GTK_API_VERSION}.0
    !             --include=Soup-3.0
                  --include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
                  --library=webkit2gtk-${WEBKITGTK_API_VERSION}
                  --library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
    ***************
    *** 693,699 ****
                  --no-libtool
                  --pkg=gobject-2.0
                  --pkg=${GTK_PKGCONFIG_PACKAGE}
    !             --pkg=libsoup-2.4
                  --pkg-export=webkit2gtk-${WEBKITGTK_API_VERSION}
                  --output=${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
                  ${GIR_SOURCES_TOP_DIRS}
    --- 693,699 ----
                  --no-libtool
                  --pkg=gobject-2.0
                  --pkg=${GTK_PKGCONFIG_PACKAGE}
    !             --pkg=libsoup-3.0
                  --pkg-export=webkit2gtk-${WEBKITGTK_API_VERSION}
                  --output=${CMAKE_BINARY_DIR}/WebKit2-${WEBKITGTK_API_VERSION}.gir
                  ${GIR_SOURCES_TOP_DIRS}
    ***************
    *** 731,737 ****
                  --nsversion=${WEBKITGTK_API_VERSION}
                  --include=GObject-2.0
                  --include=Gtk-${GTK_API_VERSION}.0
    !             --include=Soup-2.4
                  --include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
                  --library=webkit2gtk-${WEBKITGTK_API_VERSION}
                  --library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
    --- 731,737 ----
                  --nsversion=${WEBKITGTK_API_VERSION}
                  --include=GObject-2.0
                  --include=Gtk-${GTK_API_VERSION}.0
    !             --include=Soup-3.0
                  --include-uninstalled=${CMAKE_BINARY_DIR}/JavaScriptCore-${WEBKITGTK_API_VERSION}.gir
                  --library=webkit2gtk-${WEBKITGTK_API_VERSION}
                  --library=javascriptcoregtk-${WEBKITGTK_API_VERSION}
    ***************
    *** 741,747 ****
                  --no-libtool
                  --pkg=gobject-2.0
                  --pkg=${GTK_PKGCONFIG_PACKAGE}
    !             --pkg=libsoup-2.4
                  --pkg-export=webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}
                  --output=${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
                  ${GIR_SOURCES_TOP_DIRS}
    --- 741,747 ----
                  --no-libtool
                  --pkg=gobject-2.0
                  --pkg=${GTK_PKGCONFIG_PACKAGE}
    !             --pkg=libsoup-3.0
                  --pkg-export=webkit2gtk-web-extension-${WEBKITGTK_API_VERSION}
                  --output=${CMAKE_BINARY_DIR}/WebKit2WebExtension-${WEBKITGTK_API_VERSION}.gir
                  ${GIR_SOURCES_TOP_DIRS}
    ----&gt;8----

and so on.

Building on linux with:

    ----8&lt;----
    -DCMAKE_CXX_FLAGS=&quot;-fpermissive&quot;
    -DPORT=GTK
    -DCMAKE_BUILD_TYPE=Release
    -DENABLE_CREDENTIAL_STORAGE=OFF
    -DENABLE_GEOLOCATION=OFF
    -DUSE_LIBNOTIFY=OFF
    -DUSE_LIBHYPHEN=OFF
    -DENABLE_FTL_JIT=ON
    -DUSE_WOFF2=OFF
    -DENABLE_JIT=ON
    -DUSE_OPENJPEG=OFF
    -DUSE_WPE_RENDERER=OFF
    -DENABLE_BUBBLEWRAP_SANDBOX=OFF
    -DUSE_SYSTEMD=OFF
    -DENABLE_GAMEPAD=OFF
    -DUSE_LD_GOLD=OFF
    -DUSE_SOUP2=OFF
    ----&gt;8----


thanks
ciao
-gabriele</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>