220462 2021-01-08 07:35:34 -0800 [GStreamer] Player audio sink needs to be initialized earlier 2021-01-08 10:02:19 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia eric.carlson ews-watchlist glenn gustavo jer.noble menard philipj sergio vjaquez webkit-bug-importer oldest_to_newest 1718293 0 pnormand 2021-01-08 07:35:34 -0800 Currently we do it in the load method but that's not enough in situations where the player has an audiosourceprovider: Thread 1 (Thread 0x7ff5389609c0 (LWP 35298)): #0 g_logv (log_domain=0x7ff53a14c240 <g_log_domain_gstreamer> "GStreamer", log_level=G_LOG_LEVEL_CRITICAL, format=<optimized out>, args=<optimized out>) at ../glib/gmessages.c:1377 #1 0x00007ff53ae9ec23 in g_log (log_domain=<optimized out>, log_level=log_level@entry=G_LOG_LEVEL_CRITICAL, format=format@entry=0x7ff53aef495f "%s: assertion '%s' failed") at ../glib/gmessages.c:1415 #2 0x00007ff53ae9f41d in g_return_if_fail_warning (log_domain=<optimized out>, pretty_function=pretty_function@entry=0x7ff53a14e8b0 <__func__.4> "gst_bin_get_by_name", expression=expression@entry=0x7ff53a14d3ac "GST_IS_BIN (bin)") at ../glib/gmessages.c:2771 #3 0x00007ff53a0a7cad in gst_bin_get_by_name (bin=0x0, name=0x7ff54493dbba "volume") at ../gst/gstbin.c:4413 #4 0x00007ff544011505 in WebCore::AudioSourceProviderGStreamer::setClient(WebCore::AudioSourceProviderClient*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #5 0x00007ff543289522 in non-virtual thunk to WebCore::HTMLMediaElement::mediaPlayerEngineUpdated() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #6 0x00007ff54384cfe7 in WebCore::MediaPlayer::loadWithNextMediaEngine(WebCore::MediaPlayerFactory const*) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #7 0x00007ff543851d01 in WebCore::MediaPlayer::load(WTF::URL const&, WebCore::ContentType const&, WTF::String const&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #8 0x00007ff5432a2fc3 in WebCore::HTMLMediaElement::loadResource(WTF::URL const&, WebCore::ContentType&, WTF::String const&) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #9 0x00007ff5432a4582 in WTF::Detail::CallableWrapper<WebCore::HTMLMediaElement::selectMediaResource()::{lambda()#1}, void>::call() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #10 0x00007ff5437786ad in WebCore::TaskDispatcher<WebCore::Timer>::dispatchOneTask() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #11 0x00007ff543778776 in WebCore::TaskDispatcher<WebCore::Timer>::sharedTimerFired() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #12 0x00007ff5437ae7d4 in WebCore::ThreadTimers::sharedTimerFiredInternal() () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #13 0x00007ff53e841fa5 in WTF::RunLoop::TimerBase::TimerBase(WTF::RunLoop&)::{lambda(void*)#1}::_FUN(void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #14 0x00007ff53e84221f in WTF::RunLoop::{lambda(_GSource*, int (*)(void*), void*)#1}::_FUN(_GSource*, int (*)(void*), void*) () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #15 0x00007ff53ae9718f in g_main_dispatch (context=0x557f42bae150) at ../glib/gmain.c:3325 #16 g_main_context_dispatch (context=0x557f42bae150) at ../glib/gmain.c:4043 #17 0x00007ff53ae97538 in g_main_context_iterate (context=0x557f42bae150, block=block@entry=1, dispatch=dispatch@entry=1, self=<optimized out>) at ../glib/gmain.c:4119 #18 0x00007ff53ae97853 in g_main_loop_run (loop=0x557f42bdce70) at ../glib/gmain.c:4317 #19 0x00007ff53e842368 in WTF::RunLoop::run() () at /app/webkit/WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18 #20 0x00007ff5420d77ff in WebKit::WebProcessMain(int, char**) () at /app/webkit/WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37 #21 0x00007ff53a83d022 in __libc_start_main (main=0x557f42951840 <main>, argc=4, argv=0x7ffe040edfa8, init=<optimized out>, fini=<optimized out>, rtld_fini=<optimized out>, stack_end=0x7ffe040edf98) at ../csu/libc-start.c:308 #22 0x0000557f4295187e in _start () at ../sysdeps/x86_64/start.S:120 STDERR: (WebKitWebProcess:35298): GStreamer-CRITICAL **: 06:37:19.886: gst_bin_get_by_name: assertion 'GST_IS_BIN (bin)' failed 1718294 1 417267 pnormand 2021-01-08 07:38:45 -0800 Created attachment 417267 Patch 1718329 2 ews-feeder 2021-01-08 10:01:20 -0800 Committed r271302: <https://trac.webkit.org/changeset/271302> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417267. 1718330 3 webkit-bug-importer 2021-01-08 10:02:19 -0800 <rdar://problem/72934262> 417267 2021-01-08 07:38:45 -0800 2021-01-08 10:01:22 -0800 Patch bug-220462-20210108073843.patch text/plain 3445 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMjkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTM2MTBjMTAyN2FlNjRk ZjY3YzUyMzg5YTE5ZGJjMDU1MDcyNWRhZC4uYTA5ODhkZGFhNmUwNWRkODVjYmUxYmFlZjU0OGYw Y2UxN2MyODEyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAxLTA4ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBQbGF5ZXIgYXVkaW8gc2luayBuZWVkcyB0byBiZSBpbml0aWFsaXplZCBlYXJsaWVyCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjA0NjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDdXJyZW50bHkgdGhl IHBsYXllciBpbml0aWFsaXplcyB0aGUgYXVkaW8gc2luayBpbiB0aGUgbG9hZCBtZXRob2QgYnV0 IHRoYXQncyBub3QgZW5vdWdoIGluCisgICAgICAgIHNpdHVhdGlvbnMgd2hlcmUgdGhlIHBsYXll ciBoYXMgYW4gYXVkaW9zb3VyY2Vwcm92aWRlci4gU28gaW5pdGlhbGl6ZSBpdCBmcm9tIHRoZQor ICAgICAgICBjb25zdHJ1Y3RvciBlYXJseSBvbiwgdG8gZW5zdXJlIHRoYXQgdGhlIGF1ZGlvIHBy b3ZpZGVyIHNpbmsgYmluIGlzIHZhbGlkLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lcik6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNy ZWF0ZUdTVFBsYXlCaW4pOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaDoKKwogMjAyMS0wMS0wOCAgUm9iIEJ1aXMgIDxy YnVpc0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFRha2UgYXNwZWN0LXJhdGlvIGludG8gYWNjb3Vu dCBmb3IgcGVyY2VudGFnZSByZXNvbHV0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDBmNmM2NmQyMDc1ZDU3YzVjNzc0MzZjMWRkMDk0 ZDQ0MWU3ZWU1ODcuLmFjNzQ0MmFjMjIyMDUxYjI4N2FhYjMxYmZkMjI3ZjQxZTcwNTRmYWUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC0y MDAsNiArMjAwLDggQEAgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpNZWRpYVBsYXllclBy aXZhdGVHU3RyZWFtZXIoTWVkaWFQbGF5ZXIqIHBsYXllcikKICNlbmRpZgogICAgIG1faXNQbGF5 ZXJTaHV0dGluZ0Rvd24uc3RvcmUoZmFsc2UpOwogCisgICAgbV9hdWRpb1NpbmsgPSBjcmVhdGVB dWRpb1NpbmsoKTsKKwogI2lmIFVTRShXUEVfVklERU9fUExBTkVfRElTUExBWV9ETUFCVUYpCiAg ICAgYXV0byYgc2hhcmVkRGlzcGxheSA9IFBsYXRmb3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgp OwogICAgIGlmIChpczxQbGF0Zm9ybURpc3BsYXlMaWJXUEU+KHNoYXJlZERpc3BsYXkpKQpAQCAt MjcwNiw2ICsyNzA4LDcgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNyZWF0 ZUdTVFBsYXlCaW4oY29uc3QgVVJMJiB1cmwsIGNvbnN0IFN0cmluZyYKICAgICAgICAgR1NUX0lO Rk9fT0JKRUNUKHBpcGVsaW5lKCksICJUZWFyaW5nIGRvd24gYXMgd2UgbmVlZCB0byB1c2UgJXMg bm93LiIsIHBsYXliaW5OYW1lKTsKICAgICAgICAgY2hhbmdlUGlwZWxpbmVTdGF0ZShHU1RfU1RB VEVfTlVMTCk7CiAgICAgICAgIG1fcGlwZWxpbmUgPSBudWxscHRyOworICAgICAgICBtX2F1ZGlv U2luayA9IG51bGxwdHI7CiAgICAgfQogCiAgICAgQVNTRVJUKCFtX3BpcGVsaW5lKTsKQEAgLTI3 NzMsNyArMjc3NiwxMCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRl R1NUUGxheUJpbihjb25zdCBVUkwmIHVybCwgY29uc3QgU3RyaW5nJgogCiAgICAgZ19vYmplY3Rf c2V0KG1fcGlwZWxpbmUuZ2V0KCksICJ0ZXh0LXNpbmsiLCBtX3RleHRBcHBTaW5rLmdldCgpLCBu dWxscHRyKTsKIAotICAgIGdfb2JqZWN0X3NldChtX3BpcGVsaW5lLmdldCgpLCAiYXVkaW8tc2lu ayIsIGNyZWF0ZUF1ZGlvU2luaygpLCBudWxscHRyKTsKKyAgICBpZiAoIW1fYXVkaW9TaW5rKQor ICAgICAgICBtX2F1ZGlvU2luayA9IGNyZWF0ZUF1ZGlvU2luaygpOworCisgICAgZ19vYmplY3Rf c2V0KG1fcGlwZWxpbmUuZ2V0KCksICJhdWRpby1zaW5rIiwgbV9hdWRpb1NpbmsuZ2V0KCksIG51 bGxwdHIpOwogICAgIGlmIChtX3BsYXllci0+aXNWaWRlb1BsYXllcigpKQogICAgICAgICBnX29i amVjdF9zZXQobV9waXBlbGluZS5nZXQoKSwgInZpZGVvLXNpbmsiLCBjcmVhdGVWaWRlb1Npbmso KSwgbnVsbHB0cik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuaCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFt ZXIuaAppbmRleCA3YWNiNjYxMTkyOTg0YTcyOTQ4ZWJjNDJjYjU2MmJhM2EzMDYzZTc0Li43N2I5 YzcxMTZiZWQ2MDI3MDE1MmNhZmEzMzI2NmNmZDU0NzMwMDM1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5oCkBAIC0zNTUsNiArMzU1LDcgQEAgcHJvdGVj dGVkOgogI2VuZGlmCiAKICAgICBHUmVmUHRyPEdzdFN0cmVhbVZvbHVtZT4gbV92b2x1bWVFbGVt ZW50OworICAgIEdSZWZQdHI8R3N0RWxlbWVudD4gbV9hdWRpb1Npbms7CiAgICAgR1JlZlB0cjxH c3RFbGVtZW50PiBtX3ZpZGVvU2luazsKICAgICBHUmVmUHRyPEdzdEVsZW1lbnQ+IG1fcGlwZWxp bmU7CiAgICAgSW50U2l6ZSBtX3NpemU7Cg==