220451 2021-01-07 18:23:31 -0800 [JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge 2021-01-08 08:30:43 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer oldest_to_newest 1718177 0 ysuzuki 2021-01-07 18:23:31 -0800 [JSC] DFG/FTL Atomics should assume non-typed-array input with storage-edge 1718178 1 417235 ysuzuki 2021-01-07 18:33:43 -0800 Created attachment 417235 Patch 1718179 2 ysuzuki 2021-01-07 18:34:01 -0800 <rdar://problem/71237065> 1718184 3 417235 mark.lam 2021-01-07 19:07:25 -0800 Comment on attachment 417235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review r=me with ChangeLog fix. > Source/JavaScriptCore/ChangeLog:11 > + and if it is, we should make it generic one instead of using fast TypedArray path. I think you meant to say "if it is not" instead here. 1718185 4 417235 ysuzuki 2021-01-07 19:08:02 -0800 Comment on attachment 417235 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=417235&action=review >> Source/JavaScriptCore/ChangeLog:11 >> + and if it is, we should make it generic one instead of using fast TypedArray path. > > I think you meant to say "if it is not" instead here. Thanks! Fixed. 1718302 5 ysuzuki 2021-01-08 08:30:43 -0800 Committed r271297: <https://trac.webkit.org/changeset/271297> 417235 2021-01-07 18:33:43 -0800 2021-01-07 19:07:25 -0800 Patch bug-220451-20210107183342.patch text/plain 4542 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjcxMjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA1 YjU2M2NjYWRlYjhkMWI4MjhjZDg1MTAyYTIyODczMzFjODVmZWFhLi40ODUyZGI0ZWVmNWU0YmVh YmE5MjgyNjcxYzhmMzUxN2EzNDUxMjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAyMS0wMS0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIERGRy9GVEwgQXRvbWljcyBzaG91bGQgYXNzdW1lIG5vbi10eXBl ZC1hcnJheSBpbnB1dCB3aXRoIHN0b3JhZ2UtZWRnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNDUxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83 MTIzNzA2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBdG9taWNzIGltcGxlbWVudGF0aW9uIGFzc3VtZWQgdGhhdCBpdCBvbmx5IGdldHMgVHlwZWRB cnJheSB2aWEgY2hlY2tBcnJheSBmaWx0ZXIgaWYgc3RvcmFnZS1lZGdlIGV4aXN0cy4gQnV0IHRo aXMgaXMgd3JvbmcuCisgICAgICAgIFN0cmluZyBhbmQgdGhlIG90aGVyIGNhc2VzIGNhbiBwdXQg c3RvcmFnZS1lZGdlIHdoaWxlIGl0IGlzIG5vdCBUeXBlZEFycmF5LiBXZSBzaG91bGQgY2hlY2sg d2hldGhlciB0aGlzIGlzIG9uZSBvZiBUeXBlZEFycmF5LAorICAgICAgICBhbmQgaWYgaXQgaXMs IHdlIHNob3VsZCBtYWtlIGl0IGdlbmVyaWMgb25lIGluc3RlYWQgb2YgdXNpbmcgZmFzdCBUeXBl ZEFycmF5IHBhdGguCisKKyAgICAgICAgKiBkZmcvREZHQXJyYXlNb2RlLmg6CisgICAgICAgIChK U0M6OkRGRzo6QXJyYXlNb2RlOjppc09uZU9mVHlwZWRBcnJheVZpZXcgY29uc3QpOgorICAgICAg ICAqIGRmZy9ERkdGaXh1cFBoYXNlLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpGaXh1cFBoYXNl OjpmaXh1cE5vZGUpOgorCiAyMDIxLTAxLTA3ICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNo QGdtYWlsLmNvbT4KIAogICAgICAgICBbSlNDXSBTaW1wbGlmeSBnZXQqUHJvcGVydHlOYW1lcygp IG1ldGhvZHMgYW5kIEVudW1lcmF0aW9uTW9kZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3Jp cHRDb3JlL2RmZy9ERkdBcnJheU1vZGUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZH QXJyYXlNb2RlLmgKaW5kZXggY2NkYTg2OTNkNTkxZDM0ZDg3OGFlOTc5ODQ0YTUwOGNhZDk3Mzg0 My4uMmI5ZDg1NTc0MDY2Y2RjNmI0MjFhYjM1ZjZhMDBmNWM0NTRkNTkwMyAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1vZGUuaAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0FycmF5TW9kZS5oCkBAIC01MDcsNiArNTA3LDEzIEBAIGNsYXNz IEFycmF5TW9kZSB7CiAgICAgewogICAgICAgICByZXR1cm4gdHlwZSgpID09IEFycmF5OjpBbnlU eXBlZEFycmF5IHx8IGlzVHlwZWRWaWV3KHR5cGVkQXJyYXlUeXBlKCkpOwogICAgIH0KKworICAg IGJvb2wgaXNPbmVPZlR5cGVkQXJyYXlWaWV3KCkgY29uc3QKKyAgICB7CisgICAgICAgIGlmICh0 eXBlKCkgPT0gQXJyYXk6OkFueVR5cGVkQXJyYXkpCisgICAgICAgICAgICByZXR1cm4gZmFsc2U7 CisgICAgICAgIHJldHVybiBpc1R5cGVkVmlldyh0eXBlZEFycmF5VHlwZSgpKTsKKyAgICB9CiAg ICAgCiAgICAgYm9vbCBvcGVyYXRvcj09KGNvbnN0IEFycmF5TW9kZSYgb3RoZXIpIGNvbnN0CiAg ICAgewpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdGaXh1cFBoYXNl LmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRml4dXBQaGFzZS5jcHAKaW5kZXgg MmJmYzIxMDJiNDc0MGI3ZGJlMTRhNjVjZDQ4NzNiNzU2ZDNiMzJjNC4uOWViZmU0NWI4NzAzMDNl ZmM2ZGI2ODA0ZTA2N2E5MDNlYjU2NTU0YiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRD b3JlL2RmZy9ERkdGaXh1cFBoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0ZpeHVwUGhhc2UuY3BwCkBAIC0xMzM1LDggKzEzMzUsMTAgQEAgY2xhc3MgRml4dXBQaGFz ZSA6IHB1YmxpYyBQaGFzZSB7CiAgICAgICAgICAgICAgICAgbm9kZS0+YXJyYXlNb2RlKCkucmVm aW5lKAogICAgICAgICAgICAgICAgICAgICBtX2dyYXBoLCBub2RlLCBiYXNlLT5wcmVkaWN0aW9u KCksIGluZGV4LT5wcmVkaWN0aW9uKCkpKTsKICAgICAgICAgICAgIAotICAgICAgICAgICAgaWYg KG5vZGUtPmFycmF5TW9kZSgpLnR5cGUoKSA9PSBBcnJheTo6R2VuZXJpYykKKyAgICAgICAgICAg IGlmICghbm9kZS0+YXJyYXlNb2RlKCkuaXNPbmVPZlR5cGVkQXJyYXlWaWV3KCkpIHsKKyAgICAg ICAgICAgICAgICBub2RlLT5zZXRBcnJheU1vZGUoQXJyYXlNb2RlKEFycmF5OjpHZW5lcmljLCBu b2RlLT5hcnJheU1vZGUoKS5hY3Rpb24oKSkpOwogICAgICAgICAgICAgICAgIGJyZWFrOworICAg ICAgICAgICAgfQogICAgICAgICAgICAgCiAgICAgICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSBu dW1FeHRyYUF0b21pY3NBcmdzKG5vZGUtPm9wKCkpOyBpLS07KSB7CiAgICAgICAgICAgICAgICAg RWRnZSYgY2hpbGQgPSBtX2dyYXBoLmNoaWxkKG5vZGUsIDIgKyBpKTsKZGlmZiAtLWdpdCBhL0pT VGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNjNhZDYxYmU3MGMwY2I2 NzU1ZTY5NmM2ODA5YTdkZDM4MzEzOWEzOS4uMjA1MzFjN2YxNjJlMWM0MzIxY2JlZThiNmU1OGQ1 ZDU0MTA2M2ZlYyAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMS0wMS0wNyAgWXVzdWtlIFN1enVraSAgPHlz dXp1a2lAYXBwbGUuY29tPgorCisgICAgICAgIFtKU0NdIERGRy9GVEwgQXRvbWljcyBzaG91bGQg YXNzdW1lIG5vbi10eXBlZC1hcnJheSBpbnB1dCB3aXRoIHN0b3JhZ2UtZWRnZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIwNDUxCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MTIzNzA2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIHN0cmVzcy9hdG9taWNzLWFuZC1tdWx0aXBsZS10eXBlZC1hcnJh eXMuanM6IEFkZGVkLgorICAgICAgICAoZm9vKToKKyAgICAgICAgKiBzdHJlc3MvYXRvbWljcy1h bmQtc3RyaW5nLmpzOiBBZGRlZC4KKyAgICAgICAgKGZvbyk6CisKIDIwMjEtMDEtMDcgIEFsZXhl eSBTaHZheWthICA8c2h2YWlrYWxlc2hAZ21haWwuY29tPgogCiAgICAgICAgIFtKU0NdIFNpbXBs aWZ5IGdldCpQcm9wZXJ0eU5hbWVzKCkgbWV0aG9kcyBhbmQgRW51bWVyYXRpb25Nb2RlCmRpZmYg LS1naXQgYS9KU1Rlc3RzL3N0cmVzcy9hdG9taWNzLWFuZC1tdWx0aXBsZS10eXBlZC1hcnJheXMu anMgYi9KU1Rlc3RzL3N0cmVzcy9hdG9taWNzLWFuZC1tdWx0aXBsZS10eXBlZC1hcnJheXMuanMK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uZGUwZWM1MGY1ZGVmNWVhYWI4NjVlN2YyYmVjNWU2N2U3M2I0YWJlNQotLS0g L2Rldi9udWxsCisrKyBiL0pTVGVzdHMvc3RyZXNzL2F0b21pY3MtYW5kLW11bHRpcGxlLXR5cGVk LWFycmF5cy5qcwpAQCAtMCwwICsxLDEyIEBACitmdW5jdGlvbiBmb28oaW5wdXQpIHsKKyAgICBy ZXR1cm4gQXRvbWljcy5sb2FkKGlucHV0LCAwKTsKK30KK25vSW5saW5lKGZvbyk7CisKKwordmFy IGEgPSBuZXcgVWludDhBcnJheSgxMCk7Cit2YXIgYiA9IG5ldyBVaW50MzJBcnJheSgxMCk7Citm b3IgKGxldCBpPTA7IGk8MWU0OyBpKyspIHsKKyAgICBmb28oYSk7CisgICAgZm9vKGIpOworfQpk aWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvYXRvbWljcy1hbmQtc3RyaW5nLmpzIGIvSlNUZXN0 cy9zdHJlc3MvYXRvbWljcy1hbmQtc3RyaW5nLmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjRhNTliZDU3MmNhYWE0 MjkyMWEyYjJmZDI0YTYzOTBkN2ViZjNmZDIKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0 cmVzcy9hdG9taWNzLWFuZC1zdHJpbmcuanMKQEAgLTAsMCArMSwxMiBAQAorLy9AIHJ1bkRlZmF1 bHQoIi0tdXNlUmFuZG9taXppbmdGdXp6ZXJBZ2VudD0xIiwgIi0tdXNlQ29uY3VycmVudEpJVD0w IikKKworZnVuY3Rpb24gZm9vKCkgeworICAgIHJldHVybiBBdG9taWNzLmxvYWQoJycsIDApOwor fQorbm9JbmxpbmUoZm9vKTsKKworZm9yIChsZXQgaT0wOyBpPDFlNDsgaSsrKSB7CisgICAgdHJ5 IHsKKyAgICAgICAgZm9vKCk7CisgICAgfSBjYXRjaCB7IH0KK30K