220449 2021-01-07 17:39:48 -0800 JavaScriptCore API headers contain project style includes 2021-01-08 12:23:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ap ap ews-watchlist keith_miller mark.lam msaboff rmorisset saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1718172 0 ap 2021-01-07 17:39:48 -0800 Maybe I'm missing some reason for it, but it seems wrong for framework headers to use project style includes. rdar://problem/71493605 1718175 1 417234 ap 2021-01-07 17:45:56 -0800 Created attachment 417234 proposed patch 1718176 2 ap 2021-01-07 17:47:35 -0800 There are also lots of SPI headers, where the include style is wrong too, but that's a cleanup for another day. 1718337 3 417234 ysuzuki 2021-01-08 10:39:05 -0800 Comment on attachment 417234 proposed patch r=me 1718394 4 ews-feeder 2021-01-08 12:23:12 -0800 Committed r271317: <https://trac.webkit.org/changeset/271317> All reviewed patches have been landed. Closing bug and clearing flags on attachment 417234. 417234 2021-01-07 17:45:56 -0800 2021-01-08 12:23:14 -0800 proposed patch ProjectIncludes.txt text/plain 1752 ap SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjcxMjc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDIxLTAxLTA3ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAg ICAgIEphdmFTY3JpcHRDb3JlIEFQSSBoZWFkZXJzIGNvbnRhaW4gcHJvamVjdCBzdHlsZSBpbmNs dWRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIw NDQ5CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzcxNDkzNjA1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBBUEkvSlNTdHJpbmdSZWZDRi5oOgorICAg ICAgICAqIEFQSS9KYXZhU2NyaXB0Q29yZS5oOgorCiAyMDIxLTAxLTA3ICBNYXJrIExhbSAgPG1h cmsubGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBXb3JrIGFyb3VuZCBDbGFuZyBidWcgaW4gX19i dWlsdGluX3JldHVybl9hZGRyZXNzKCkuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTU3RyaW5nUmVmQ0YuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTU3RyaW5nUmVmQ0YuaAkocmV2aXNpb24gMjcxMjIxKQorKysgU291cmNlL0phdmFTY3JpcHRD b3JlL0FQSS9KU1N0cmluZ1JlZkNGLmgJKHdvcmtpbmcgY29weSkKQEAgLTI2LDggKzI2LDggQEAK ICNpZm5kZWYgSlNTdHJpbmdSZWZDRl9oCiAjZGVmaW5lIEpTU3RyaW5nUmVmQ0ZfaAogCi0jaW5j bHVkZSAiSlNCYXNlLmgiCiAjaW5jbHVkZSA8Q29yZUZvdW5kYXRpb24vQ29yZUZvdW5kYXRpb24u aD4KKyNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU0Jhc2UuaD4KIAogI2lmZGVmIF9fY3BsdXNw bHVzCiBleHRlcm4gIkMiIHsKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSmF2YVNj cmlwdENvcmUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0phdmFT Y3JpcHRDb3JlLmgJKHJldmlzaW9uIDI3MTIyMSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9B UEkvSmF2YVNjcmlwdENvcmUuaAkod29ya2luZyBjb3B5KQpAQCAtMzEsMTEgKzMxLDExIEBACiAK ICNpZiBkZWZpbmVkKF9fT0JKQ19fKSAmJiBKU0NfT0JKQ19BUElfRU5BQkxFRAogCi0jaW1wb3J0 ICJKU0NvbnRleHQuaCIKLSNpbXBvcnQgIkpTVmFsdWUuaCIKLSNpbXBvcnQgIkpTTWFuYWdlZFZh bHVlLmgiCi0jaW1wb3J0ICJKU1ZpcnR1YWxNYWNoaW5lLmgiCi0jaW1wb3J0ICJKU0V4cG9ydC5o IgorI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSlNDb250ZXh0Lmg+CisjaW1wb3J0IDxKYXZhU2Ny aXB0Q29yZS9KU1ZhbHVlLmg+CisjaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9KU01hbmFnZWRWYWx1 ZS5oPgorI2ltcG9ydCA8SmF2YVNjcmlwdENvcmUvSlNWaXJ0dWFsTWFjaGluZS5oPgorI2ltcG9y dCA8SmF2YVNjcmlwdENvcmUvSlNFeHBvcnQuaD4KIAogI2VuZGlmCiAK